[PATCH net] net: mscc: ocelot: fix broken IP multicast flooding

[PATCH net] net: mscc: ocelot: fix broken IP multicast flooding

[Vladimir Oltean]

When the user runs:
bridge link set dev $br_port mcast_flood on

this command should affect not only L2 multicast, but also IPv4 and IPv6
multicast.

In the Ocelot switch, unknown multicast gets flooded according to
different PGIDs according to its type, and PGID_MC only handles L2
multicast. Therefore, by leaving PGID_MCIPV4 and PGID_MCIPV6 at their
default value of 0, unknown IP multicast traffic is never flooded.

Fixes: 421741ea5672 ("net: mscc: ocelot: offload bridge port flags to device")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/mscc/ocelot.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/net/ethernet/mscc/ocelot.c b/drivers/net/ethernet/mscc/ocelot.c
index e443bd8b2d09..ee9c607d62a7 100644
--- a/drivers/net/ethernet/mscc/ocelot.c
+++ b/drivers/net/ethernet/mscc/ocelot.c
@@ -2859,6 +2859,8 @@ static void ocelot_port_set_mcast_flood(struct ocelot *ocelot, int port,
 		val = BIT(port);
 
 	ocelot_rmw_rix(ocelot, val, BIT(port), ANA_PGID_PGID, PGID_MC);
+	ocelot_rmw_rix(ocelot, val, BIT(port), ANA_PGID_PGID, PGID_MCIPV4);
+	ocelot_rmw_rix(ocelot, val, BIT(port), ANA_PGID_PGID, PGID_MCIPV6);
 }
 
 static void ocelot_port_set_bcast_flood(struct ocelot *ocelot, int port,
-- 
2.25.1

Re: [PATCH net] net: mscc: ocelot: fix broken IP multicast flooding

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net.git (master)
by Paolo Abeni <pabeni@redhat.com>:

On Fri, 15 Apr 2022 18:19:50 +0300 you wrote:
> When the user runs:
> bridge link set dev $br_port mcast_flood on
> 
> this command should affect not only L2 multicast, but also IPv4 and IPv6
> multicast.
> 
> In the Ocelot switch, unknown multicast gets flooded according to
> different PGIDs according to its type, and PGID_MC only handles L2
> multicast. Therefore, by leaving PGID_MCIPV4 and PGID_MCIPV6 at their
> default value of 0, unknown IP multicast traffic is never flooded.
> 
> [...]

Here is the summary with links:
  - [net] net: mscc: ocelot: fix broken IP multicast flooding
    https://git.kernel.org/netdev/net/c/4cf35a2b627a

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html