All of lore.kernel.org
 help / color / mirror / Atom feed
* block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter]
@ 2022-04-15 15:23 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-04-15 15:23 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2375 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Christoph Hellwig <hch@lst.de>
CC: Jens Axboe <axboe@kernel.dk>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   028192fea1de083f4f12bfb1eb7c4d7beb5c8ecd
commit: 0dbcfe247f22a6d73302dfa691c48b3c14d31c4c block: look up holders by bdev
date:   8 months ago
:::::: branch date: 16 hours ago
:::::: commit date: 8 months ago
compiler: powerpc-linux-gcc (GCC) 11.2.0
reproduce (cppcheck warning):
        # apt-get install cppcheck
        git checkout 0dbcfe247f22a6d73302dfa691c48b3c14d31c4c
        cppcheck --quiet --enable=style,performance,portability --template=gcc FILE

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter]
   static struct bd_holder_disk *bd_find_holder_disk(struct block_device *bdev,
                                                                          ^

vim +/bdev +10 block/holder.c

c66fd019713e9cf Christoph Hellwig 2021-08-04   9  
c66fd019713e9cf Christoph Hellwig 2021-08-04 @10  static struct bd_holder_disk *bd_find_holder_disk(struct block_device *bdev,
c66fd019713e9cf Christoph Hellwig 2021-08-04  11  						  struct gendisk *disk)
c66fd019713e9cf Christoph Hellwig 2021-08-04  12  {
c66fd019713e9cf Christoph Hellwig 2021-08-04  13  	struct bd_holder_disk *holder;
c66fd019713e9cf Christoph Hellwig 2021-08-04  14  
0dbcfe247f22a6d Christoph Hellwig 2021-08-04  15  	list_for_each_entry(holder, &disk->slave_bdevs, list)
0dbcfe247f22a6d Christoph Hellwig 2021-08-04  16  		if (holder->bdev == bdev)
c66fd019713e9cf Christoph Hellwig 2021-08-04  17  			return holder;
c66fd019713e9cf Christoph Hellwig 2021-08-04  18  	return NULL;
c66fd019713e9cf Christoph Hellwig 2021-08-04  19  }
c66fd019713e9cf Christoph Hellwig 2021-08-04  20  

:::::: The code at line 10 was first introduced by commit
:::::: c66fd019713e9cf7d6f1243c378cd177d01fe18a block: make the block holder code optional

:::::: TO: Christoph Hellwig <hch@lst.de>
:::::: CC: Jens Axboe <axboe@kernel.dk>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 4+ messages in thread
* block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter]
@ 2022-07-13 18:30 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-07-13 18:30 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2543 bytes --]

:::::: 
:::::: Manual check reason: "low confidence static check warning: block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter]"
:::::: 

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Christoph Hellwig <hch@lst.de>
CC: Jens Axboe <axboe@kernel.dk>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b047602d579b4fb028128a525f056bbdc890e7f0
commit: 0dbcfe247f22a6d73302dfa691c48b3c14d31c4c block: look up holders by bdev
date:   11 months ago
:::::: branch date: 19 hours ago
:::::: commit date: 11 months ago
compiler: arceb-elf-gcc (GCC) 11.3.0
reproduce (cppcheck warning):
        # apt-get install cppcheck
        git checkout 0dbcfe247f22a6d73302dfa691c48b3c14d31c4c
        cppcheck --quiet --enable=style,performance,portability --template=gcc FILE

If you fix the issue, kindly add following tag where applicable
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter]
   static struct bd_holder_disk *bd_find_holder_disk(struct block_device *bdev,
                                                                          ^

vim +/bdev +10 block/holder.c

c66fd019713e9c Christoph Hellwig 2021-08-04   9  
c66fd019713e9c Christoph Hellwig 2021-08-04 @10  static struct bd_holder_disk *bd_find_holder_disk(struct block_device *bdev,
c66fd019713e9c Christoph Hellwig 2021-08-04  11  						  struct gendisk *disk)
c66fd019713e9c Christoph Hellwig 2021-08-04  12  {
c66fd019713e9c Christoph Hellwig 2021-08-04  13  	struct bd_holder_disk *holder;
c66fd019713e9c Christoph Hellwig 2021-08-04  14  
0dbcfe247f22a6 Christoph Hellwig 2021-08-04  15  	list_for_each_entry(holder, &disk->slave_bdevs, list)
0dbcfe247f22a6 Christoph Hellwig 2021-08-04  16  		if (holder->bdev == bdev)
c66fd019713e9c Christoph Hellwig 2021-08-04  17  			return holder;
c66fd019713e9c Christoph Hellwig 2021-08-04  18  	return NULL;
c66fd019713e9c Christoph Hellwig 2021-08-04  19  }
c66fd019713e9c Christoph Hellwig 2021-08-04  20  

:::::: The code at line 10 was first introduced by commit
:::::: c66fd019713e9cf7d6f1243c378cd177d01fe18a block: make the block holder code optional

:::::: TO: Christoph Hellwig <hch@lst.de>
:::::: CC: Jens Axboe <axboe@kernel.dk>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 4+ messages in thread
* block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter]
@ 2022-04-02 19:44 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-04-02 19:44 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2146 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Christoph Hellwig <hch@lst.de>
CC: Jens Axboe <axboe@kernel.dk>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   88e6c0207623874922712e162e25d9dafd39661e
commit: 0dbcfe247f22a6d73302dfa691c48b3c14d31c4c block: look up holders by bdev
date:   8 months ago
:::::: branch date: 17 hours ago
:::::: commit date: 8 months ago
compiler: nios2-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter]
   static struct bd_holder_disk *bd_find_holder_disk(struct block_device *bdev,
                                                                          ^

vim +/bdev +10 block/holder.c

c66fd019713e9c Christoph Hellwig 2021-08-04   9  
c66fd019713e9c Christoph Hellwig 2021-08-04 @10  static struct bd_holder_disk *bd_find_holder_disk(struct block_device *bdev,
c66fd019713e9c Christoph Hellwig 2021-08-04  11  						  struct gendisk *disk)
c66fd019713e9c Christoph Hellwig 2021-08-04  12  {
c66fd019713e9c Christoph Hellwig 2021-08-04  13  	struct bd_holder_disk *holder;
c66fd019713e9c Christoph Hellwig 2021-08-04  14  
0dbcfe247f22a6 Christoph Hellwig 2021-08-04  15  	list_for_each_entry(holder, &disk->slave_bdevs, list)
0dbcfe247f22a6 Christoph Hellwig 2021-08-04  16  		if (holder->bdev == bdev)
c66fd019713e9c Christoph Hellwig 2021-08-04  17  			return holder;
c66fd019713e9c Christoph Hellwig 2021-08-04  18  	return NULL;
c66fd019713e9c Christoph Hellwig 2021-08-04  19  }
c66fd019713e9c Christoph Hellwig 2021-08-04  20  

:::::: The code at line 10 was first introduced by commit
:::::: c66fd019713e9cf7d6f1243c378cd177d01fe18a block: make the block holder code optional

:::::: TO: Christoph Hellwig <hch@lst.de>
:::::: CC: Jens Axboe <axboe@kernel.dk>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 4+ messages in thread
* block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter]
@ 2022-04-02 14:40 kernel test robot
  0 siblings, 0 replies; 4+ messages in thread
From: kernel test robot @ 2022-04-02 14:40 UTC (permalink / raw)
  To: kbuild

[-- Attachment #1: Type: text/plain, Size: 2146 bytes --]

CC: kbuild-all(a)lists.01.org
BCC: lkp(a)intel.com
CC: linux-kernel(a)vger.kernel.org
TO: Christoph Hellwig <hch@lst.de>
CC: Jens Axboe <axboe@kernel.dk>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   88e6c0207623874922712e162e25d9dafd39661e
commit: 0dbcfe247f22a6d73302dfa691c48b3c14d31c4c block: look up holders by bdev
date:   8 months ago
:::::: branch date: 12 hours ago
:::::: commit date: 8 months ago
compiler: nios2-linux-gcc (GCC) 11.2.0

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>


cppcheck possible warnings: (new ones prefixed by >>, may not real problems)

>> block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter]
   static struct bd_holder_disk *bd_find_holder_disk(struct block_device *bdev,
                                                                          ^

vim +/bdev +10 block/holder.c

c66fd019713e9c Christoph Hellwig 2021-08-04   9  
c66fd019713e9c Christoph Hellwig 2021-08-04 @10  static struct bd_holder_disk *bd_find_holder_disk(struct block_device *bdev,
c66fd019713e9c Christoph Hellwig 2021-08-04  11  						  struct gendisk *disk)
c66fd019713e9c Christoph Hellwig 2021-08-04  12  {
c66fd019713e9c Christoph Hellwig 2021-08-04  13  	struct bd_holder_disk *holder;
c66fd019713e9c Christoph Hellwig 2021-08-04  14  
0dbcfe247f22a6 Christoph Hellwig 2021-08-04  15  	list_for_each_entry(holder, &disk->slave_bdevs, list)
0dbcfe247f22a6 Christoph Hellwig 2021-08-04  16  		if (holder->bdev == bdev)
c66fd019713e9c Christoph Hellwig 2021-08-04  17  			return holder;
c66fd019713e9c Christoph Hellwig 2021-08-04  18  	return NULL;
c66fd019713e9c Christoph Hellwig 2021-08-04  19  }
c66fd019713e9c Christoph Hellwig 2021-08-04  20  

:::::: The code at line 10 was first introduced by commit
:::::: c66fd019713e9cf7d6f1243c378cd177d01fe18a block: make the block holder code optional

:::::: TO: Christoph Hellwig <hch@lst.de>
:::::: CC: Jens Axboe <axboe@kernel.dk>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-07-13 18:30 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-15 15:23 block/holder.c:10:72: warning: Parameter 'bdev' can be declared with const [constParameter] kernel test robot
  -- strict thread matches above, loose matches on Subject: below --
2022-07-13 18:30 kernel test robot
2022-04-02 19:44 kernel test robot
2022-04-02 14:40 kernel test robot

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.