* [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties
@ 2022-04-13 18:53 Andy Shevchenko
2022-04-16 10:48 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2022-04-13 18:53 UTC (permalink / raw)
To: Navin Sankar Velliangiri, linux-iio, linux-kernel
Cc: Jonathan Cameron, Lars-Peter Clausen, Andy Shevchenko
Convert the module to be property provider agnostic and allow
it to be used on non-OF platforms.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/iio/temperature/max31865.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/iio/temperature/max31865.c b/drivers/iio/temperature/max31865.c
index 86c3f3509a26..e3bb78184c6e 100644
--- a/drivers/iio/temperature/max31865.c
+++ b/drivers/iio/temperature/max31865.c
@@ -12,9 +12,11 @@
#include <linux/delay.h>
#include <linux/err.h>
#include <linux/init.h>
+#include <linux/mod_devicetable.h>
#include <linux/module.h>
#include <linux/iio/iio.h>
#include <linux/iio/sysfs.h>
+#include <linux/property.h>
#include <linux/spi/spi.h>
#include <asm/unaligned.h>
@@ -305,7 +307,7 @@ static int max31865_probe(struct spi_device *spi)
indio_dev->channels = max31865_channels;
indio_dev->num_channels = ARRAY_SIZE(max31865_channels);
- if (of_property_read_bool(spi->dev.of_node, "maxim,3-wire")) {
+ if (device_property_read_bool(&spi->dev, "maxim,3-wire")) {
/* select 3 wire */
data->three_wire = 1;
} else {
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties
2022-04-13 18:53 [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties Andy Shevchenko
@ 2022-04-16 10:48 ` Jonathan Cameron
2022-04-26 14:47 ` navin
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2022-04-16 10:48 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Navin Sankar Velliangiri, linux-iio, linux-kernel, Lars-Peter Clausen
On Wed, 13 Apr 2022 21:53:35 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Convert the module to be property provider agnostic and allow
> it to be used on non-OF platforms.
This one should call out the addition of missing mod_devicetable.h
If nothing else comes up I can add that whilst applying.
Looks fine to me but I'd like to give a little time for
Navin to comment if they wish.
Jonathan
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/iio/temperature/max31865.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/temperature/max31865.c b/drivers/iio/temperature/max31865.c
> index 86c3f3509a26..e3bb78184c6e 100644
> --- a/drivers/iio/temperature/max31865.c
> +++ b/drivers/iio/temperature/max31865.c
> @@ -12,9 +12,11 @@
> #include <linux/delay.h>
> #include <linux/err.h>
> #include <linux/init.h>
> +#include <linux/mod_devicetable.h>
> #include <linux/module.h>
> #include <linux/iio/iio.h>
> #include <linux/iio/sysfs.h>
> +#include <linux/property.h>
> #include <linux/spi/spi.h>
> #include <asm/unaligned.h>
>
> @@ -305,7 +307,7 @@ static int max31865_probe(struct spi_device *spi)
> indio_dev->channels = max31865_channels;
> indio_dev->num_channels = ARRAY_SIZE(max31865_channels);
>
> - if (of_property_read_bool(spi->dev.of_node, "maxim,3-wire")) {
> + if (device_property_read_bool(&spi->dev, "maxim,3-wire")) {
> /* select 3 wire */
> data->three_wire = 1;
> } else {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties
2022-04-16 10:48 ` Jonathan Cameron
@ 2022-04-26 14:47 ` navin
2022-04-28 18:30 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: navin @ 2022-04-26 14:47 UTC (permalink / raw)
To: Jonathan Cameron, Andy Shevchenko
Cc: linux-iio, linux-kernel, Lars-Peter Clausen
On 16.04.22 12:48, Jonathan Cameron wrote:
> On Wed, 13 Apr 2022 21:53:35 +0300
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
>
>> Convert the module to be property provider agnostic and allow
>> it to be used on non-OF platforms.
> This one should call out the addition of missing mod_devicetable.h
> If nothing else comes up I can add that whilst applying.
> Looks fine to me but I'd like to give a little time for
> Navin to comment if they wish.
>
> Jonathan
Looks fine for me. Thanks
Navin
>
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> ---
>> drivers/iio/temperature/max31865.c | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/iio/temperature/max31865.c b/drivers/iio/temperature/max31865.c
>> index 86c3f3509a26..e3bb78184c6e 100644
>> --- a/drivers/iio/temperature/max31865.c
>> +++ b/drivers/iio/temperature/max31865.c
>> @@ -12,9 +12,11 @@
>> #include <linux/delay.h>
>> #include <linux/err.h>
>> #include <linux/init.h>
>> +#include <linux/mod_devicetable.h>
>> #include <linux/module.h>
>> #include <linux/iio/iio.h>
>> #include <linux/iio/sysfs.h>
>> +#include <linux/property.h>
>> #include <linux/spi/spi.h>
>> #include <asm/unaligned.h>
>>
>> @@ -305,7 +307,7 @@ static int max31865_probe(struct spi_device *spi)
>> indio_dev->channels = max31865_channels;
>> indio_dev->num_channels = ARRAY_SIZE(max31865_channels);
>>
>> - if (of_property_read_bool(spi->dev.of_node, "maxim,3-wire")) {
>> + if (device_property_read_bool(&spi->dev, "maxim,3-wire")) {
>> /* select 3 wire */
>> data->three_wire = 1;
>> } else {
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties
2022-04-26 14:47 ` navin
@ 2022-04-28 18:30 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2022-04-28 18:30 UTC (permalink / raw)
To: navin; +Cc: Andy Shevchenko, linux-iio, linux-kernel, Lars-Peter Clausen
On Tue, 26 Apr 2022 16:47:20 +0200
navin <navin@linumiz.com> wrote:
> On 16.04.22 12:48, Jonathan Cameron wrote:
> > On Wed, 13 Apr 2022 21:53:35 +0300
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> >
> >> Convert the module to be property provider agnostic and allow
> >> it to be used on non-OF platforms.
> > This one should call out the addition of missing mod_devicetable.h
> > If nothing else comes up I can add that whilst applying.
> > Looks fine to me but I'd like to give a little time for
> > Navin to comment if they wish.
> >
> > Jonathan
>
> Looks fine for me. Thanks
Thanks,
Applied to the togreg branch of iio.git and pushed out as testing
for 0-day to poke at it.
Thanks,
Jonathan
>
> Navin
>
> >
> >> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> >> ---
> >> drivers/iio/temperature/max31865.c | 4 +++-
> >> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/iio/temperature/max31865.c b/drivers/iio/temperature/max31865.c
> >> index 86c3f3509a26..e3bb78184c6e 100644
> >> --- a/drivers/iio/temperature/max31865.c
> >> +++ b/drivers/iio/temperature/max31865.c
> >> @@ -12,9 +12,11 @@
> >> #include <linux/delay.h>
> >> #include <linux/err.h>
> >> #include <linux/init.h>
> >> +#include <linux/mod_devicetable.h>
> >> #include <linux/module.h>
> >> #include <linux/iio/iio.h>
> >> #include <linux/iio/sysfs.h>
> >> +#include <linux/property.h>
> >> #include <linux/spi/spi.h>
> >> #include <asm/unaligned.h>
> >>
> >> @@ -305,7 +307,7 @@ static int max31865_probe(struct spi_device *spi)
> >> indio_dev->channels = max31865_channels;
> >> indio_dev->num_channels = ARRAY_SIZE(max31865_channels);
> >>
> >> - if (of_property_read_bool(spi->dev.of_node, "maxim,3-wire")) {
> >> + if (device_property_read_bool(&spi->dev, "maxim,3-wire")) {
> >> /* select 3 wire */
> >> data->three_wire = 1;
> >> } else {
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-28 18:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-13 18:53 [PATCH v1 1/1] iio: temperature: max31865: Make use of device properties Andy Shevchenko
2022-04-16 10:48 ` Jonathan Cameron
2022-04-26 14:47 ` navin
2022-04-28 18:30 ` Jonathan Cameron
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.