* [PATCH] usb: gadget: tegra-xudc: clean up comments
@ 2022-04-16 22:39 Tom Rix
2022-04-17 0:36 ` Joe Perches
2022-04-17 17:45 ` Sergey Shtylyov
0 siblings, 2 replies; 4+ messages in thread
From: Tom Rix @ 2022-04-16 22:39 UTC (permalink / raw)
To: balbi, gregkh, thierry.reding, jonathanh, waynec,
rikard.falkeborn, zhangqilong3, jakobkoschel
Cc: linux-usb, linux-tegra, linux-kernel, Tom Rix
Spelling replacements
cancelled to canceled
endpiont to endpoint
Compliance to Compliance
Signed-off-by: Tom Rix <trix@redhat.com>
---
drivers/usb/gadget/udc/tegra-xudc.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
index d9c406bdb680..0aaf01e1551f 100644
--- a/drivers/usb/gadget/udc/tegra-xudc.c
+++ b/drivers/usb/gadget/udc/tegra-xudc.c
@@ -1330,7 +1330,7 @@ static void squeeze_transfer_ring(struct tegra_xudc_ep *ep,
bool pcs;
/*
- * Clear out all the TRBs part of or after the cancelled request,
+ * Clear out all the TRBs part of or after the canceled request,
* and must correct trb cycle bit to the last un-enqueued state.
*/
while (trb != &ep->transfer_ring[ep->enq_ptr]) {
@@ -1343,11 +1343,11 @@ static void squeeze_transfer_ring(struct tegra_xudc_ep *ep,
trb = ep->transfer_ring;
}
- /* Requests will be re-queued at the start of the cancelled request. */
+ /* Requests will be re-queued at the start of the canceled request. */
ep->enq_ptr = req->first_trb - ep->transfer_ring;
/*
* Retrieve the correct cycle bit state from the first trb of
- * the cancelled request.
+ * the canceled request.
*/
ep->pcs = pcs_enq;
ep->ring_full = false;
@@ -1434,7 +1434,7 @@ __tegra_xudc_ep_dequeue(struct tegra_xudc_ep *ep,
return 0;
}
- /* Halt DMA for this endpiont. */
+ /* Halt DMA for this endpoint. */
if (ep_ctx_read_state(ep->context) == EP_STATE_RUNNING) {
ep_pause(xudc, ep->index);
ep_wait_for_inactive(xudc, ep->index);
@@ -3423,7 +3423,7 @@ static void tegra_xudc_device_params_init(struct tegra_xudc *xudc)
}
/*
- * Compliacne suite appears to be violating polling LFPS tBurst max
+ * Compliance suite appears to be violating polling LFPS tBurst max
* of 1.4us. Send 1.45us instead.
*/
val = xudc_readl(xudc, SSPX_CORE_CNT32);
--
2.27.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: gadget: tegra-xudc: clean up comments
2022-04-16 22:39 [PATCH] usb: gadget: tegra-xudc: clean up comments Tom Rix
@ 2022-04-17 0:36 ` Joe Perches
2022-04-17 12:57 ` Tom Rix
2022-04-17 17:45 ` Sergey Shtylyov
1 sibling, 1 reply; 4+ messages in thread
From: Joe Perches @ 2022-04-17 0:36 UTC (permalink / raw)
To: Tom Rix, balbi, gregkh, thierry.reding, jonathanh, waynec,
rikard.falkeborn, zhangqilong3, jakobkoschel
Cc: linux-usb, linux-tegra, linux-kernel
On Sat, 2022-04-16 at 18:39 -0400, Tom Rix wrote:
> Spelling replacements
> cancelled to canceled
cancelled is a generally accepted variant.
https://www.dictionary.com/browse/cancelled
> endpiont to endpoint
ok.
> Compliance to Compliance
huh? a == a
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
> index d9c406bdb680..0aaf01e1551f 100644
> --- a/drivers/usb/gadget/udc/tegra-xudc.c
> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
> @@ -1330,7 +1330,7 @@ static void squeeze_transfer_ring(struct tegra_xudc_ep *ep,
> bool pcs;
>
> /*
> - * Clear out all the TRBs part of or after the cancelled request,
> + * Clear out all the TRBs part of or after the canceled request,
> * and must correct trb cycle bit to the last un-enqueued state.
> */
> while (trb != &ep->transfer_ring[ep->enq_ptr]) {
> @@ -1343,11 +1343,11 @@ static void squeeze_transfer_ring(struct tegra_xudc_ep *ep,
> trb = ep->transfer_ring;
> }
>
> - /* Requests will be re-queued at the start of the cancelled request. */
> + /* Requests will be re-queued at the start of the canceled request. */
> ep->enq_ptr = req->first_trb - ep->transfer_ring;
> /*
> * Retrieve the correct cycle bit state from the first trb of
> - * the cancelled request.
> + * the canceled request.
> */
> ep->pcs = pcs_enq;
> ep->ring_full = false;
> @@ -1434,7 +1434,7 @@ __tegra_xudc_ep_dequeue(struct tegra_xudc_ep *ep,
> return 0;
> }
>
> - /* Halt DMA for this endpiont. */
> + /* Halt DMA for this endpoint. */
> if (ep_ctx_read_state(ep->context) == EP_STATE_RUNNING) {
> ep_pause(xudc, ep->index);
> ep_wait_for_inactive(xudc, ep->index);
> @@ -3423,7 +3423,7 @@ static void tegra_xudc_device_params_init(struct tegra_xudc *xudc)
> }
>
> /*
> - * Compliacne suite appears to be violating polling LFPS tBurst max
> + * Compliance suite appears to be violating polling LFPS tBurst max
> * of 1.4us. Send 1.45us instead.
> */
> val = xudc_readl(xudc, SSPX_CORE_CNT32);
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: gadget: tegra-xudc: clean up comments
2022-04-17 0:36 ` Joe Perches
@ 2022-04-17 12:57 ` Tom Rix
0 siblings, 0 replies; 4+ messages in thread
From: Tom Rix @ 2022-04-17 12:57 UTC (permalink / raw)
To: Joe Perches, balbi, gregkh, thierry.reding, jonathanh, waynec,
rikard.falkeborn, zhangqilong3, jakobkoschel
Cc: linux-usb, linux-tegra, linux-kernel
On 4/16/22 5:36 PM, Joe Perches wrote:
> On Sat, 2022-04-16 at 18:39 -0400, Tom Rix wrote:
>> Spelling replacements
>> cancelled to canceled
> cancelled is a generally accepted variant.
>
> https://www.dictionary.com/browse/cancelled
>
>> endpiont to endpoint
> ok.
>
>> Compliance to Compliance
> huh? a == a
I missspelled.. from below it is
Compliacne
>
>
>> Signed-off-by: Tom Rix <trix@redhat.com>
>> ---
>> drivers/usb/gadget/udc/tegra-xudc.c | 10 +++++-----
>> 1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
>> index d9c406bdb680..0aaf01e1551f 100644
>> --- a/drivers/usb/gadget/udc/tegra-xudc.c
>> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
>> @@ -1330,7 +1330,7 @@ static void squeeze_transfer_ring(struct tegra_xudc_ep *ep,
>> bool pcs;
>>
>> /*
>> - * Clear out all the TRBs part of or after the cancelled request,
>> + * Clear out all the TRBs part of or after the canceled request,
>> * and must correct trb cycle bit to the last un-enqueued state.
>> */
>> while (trb != &ep->transfer_ring[ep->enq_ptr]) {
>> @@ -1343,11 +1343,11 @@ static void squeeze_transfer_ring(struct tegra_xudc_ep *ep,
>> trb = ep->transfer_ring;
>> }
>>
>> - /* Requests will be re-queued at the start of the cancelled request. */
>> + /* Requests will be re-queued at the start of the canceled request. */
>> ep->enq_ptr = req->first_trb - ep->transfer_ring;
>> /*
>> * Retrieve the correct cycle bit state from the first trb of
>> - * the cancelled request.
>> + * the canceled request.
>> */
>> ep->pcs = pcs_enq;
>> ep->ring_full = false;
>> @@ -1434,7 +1434,7 @@ __tegra_xudc_ep_dequeue(struct tegra_xudc_ep *ep,
>> return 0;
>> }
>>
>> - /* Halt DMA for this endpiont. */
>> + /* Halt DMA for this endpoint. */
>> if (ep_ctx_read_state(ep->context) == EP_STATE_RUNNING) {
>> ep_pause(xudc, ep->index);
>> ep_wait_for_inactive(xudc, ep->index);
>> @@ -3423,7 +3423,7 @@ static void tegra_xudc_device_params_init(struct tegra_xudc *xudc)
>> }
>>
>> /*
>> - * Compliacne suite appears to be violating polling LFPS tBurst max
>> + * Compliance suite appears to be violating polling LFPS tBurst max
>> * of 1.4us. Send 1.45us instead.
>> */
>> val = xudc_readl(xudc, SSPX_CORE_CNT32);
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] usb: gadget: tegra-xudc: clean up comments
2022-04-16 22:39 [PATCH] usb: gadget: tegra-xudc: clean up comments Tom Rix
2022-04-17 0:36 ` Joe Perches
@ 2022-04-17 17:45 ` Sergey Shtylyov
1 sibling, 0 replies; 4+ messages in thread
From: Sergey Shtylyov @ 2022-04-17 17:45 UTC (permalink / raw)
To: Tom Rix, balbi, gregkh, thierry.reding, jonathanh, waynec,
rikard.falkeborn, zhangqilong3, jakobkoschel
Cc: linux-usb, linux-tegra, linux-kernel
Hello!
On 4/17/22 1:39 AM, Tom Rix wrote:
> Spelling replacements
> cancelled to canceled
This one was actually correct! :-)
> endpiont to endpoint
> Compliance to Compliance
You meant "Compliacne to Compliance"?
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---
> drivers/usb/gadget/udc/tegra-xudc.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/gadget/udc/tegra-xudc.c b/drivers/usb/gadget/udc/tegra-xudc.c
> index d9c406bdb680..0aaf01e1551f 100644
> --- a/drivers/usb/gadget/udc/tegra-xudc.c
> +++ b/drivers/usb/gadget/udc/tegra-xudc.c
[...]
> @@ -3423,7 +3423,7 @@ static void tegra_xudc_device_params_init(struct tegra_xudc *xudc)
> }
>
> /*
> - * Compliacne suite appears to be violating polling LFPS tBurst max
> + * Compliance suite appears to be violating polling LFPS tBurst max
> * of 1.4us. Send 1.45us instead.
> */
> val = xudc_readl(xudc, SSPX_CORE_CNT32);
>
MBR, Sergey
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-17 17:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-16 22:39 [PATCH] usb: gadget: tegra-xudc: clean up comments Tom Rix
2022-04-17 0:36 ` Joe Perches
2022-04-17 12:57 ` Tom Rix
2022-04-17 17:45 ` Sergey Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.