* [Buildroot] [PATCH 1/1] package/php-apcu: needs threads
@ 2022-04-14 20:30 Fabrice Fontaine
2022-04-15 6:36 ` Herve Codina via buildroot
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Fabrice Fontaine @ 2022-04-14 20:30 UTC (permalink / raw)
To: buildroot; +Cc: Hervé Codina, Fabrice Fontaine
php-apcu needs threads since its addition in commit
8ddeeffa186d8bce875ac713c1e71483c618842a:
In file included from /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.c:20:
/home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.h:41:11: fatal error: pthread.h: No such file or directory
41 | # include "pthread.h"
| ^~~~~~~~~~~
Fixes:
- http://autobuild.buildroot.org/results/314405423aeece5ee55d76ec5c4fa1919e7ee853
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/php-apcu/Config.in | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/php-apcu/Config.in b/package/php-apcu/Config.in
index 6338980222..f8e1eb17bb 100644
--- a/package/php-apcu/Config.in
+++ b/package/php-apcu/Config.in
@@ -1,6 +1,10 @@
config BR2_PACKAGE_PHP_APCU
bool "php-apcu"
+ depends on BR2_TOOLCHAIN_HAS_THREADS
help
APCu is an in-memory key-value store for PHP.
https://pecl.php.net/package/APCu
+
+comment "php-apcu needs a toolchain w/ threads"
+ depends on !BR2_TOOLCHAIN_HAS_THREADS
--
2.35.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads
2022-04-14 20:30 [Buildroot] [PATCH 1/1] package/php-apcu: needs threads Fabrice Fontaine
@ 2022-04-15 6:36 ` Herve Codina via buildroot
2022-04-17 19:36 ` Thomas Petazzoni via buildroot
2022-04-19 20:40 ` Arnout Vandecappelle
2022-05-22 20:19 ` Peter Korsgaard
2 siblings, 1 reply; 6+ messages in thread
From: Herve Codina via buildroot @ 2022-04-15 6:36 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: buildroot
Hi Fabrice,
On Thu, 14 Apr 2022 22:30:59 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> php-apcu needs threads since its addition in commit
> 8ddeeffa186d8bce875ac713c1e71483c618842a:
>
> In file included from /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.c:20:
> /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.h:41:11: fatal error: pthread.h: No such file or directory
> 41 | # include "pthread.h"
> | ^~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/314405423aeece5ee55d76ec5c4fa1919e7ee853
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/php-apcu/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/php-apcu/Config.in b/package/php-apcu/Config.in
> index 6338980222..f8e1eb17bb 100644
> --- a/package/php-apcu/Config.in
> +++ b/package/php-apcu/Config.in
> @@ -1,6 +1,10 @@
> config BR2_PACKAGE_PHP_APCU
> bool "php-apcu"
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> help
> APCu is an in-memory key-value store for PHP.
>
> https://pecl.php.net/package/APCu
> +
> +comment "php-apcu needs a toolchain w/ threads"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
Acked.
Thanks,
Hervé
--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads
2022-04-15 6:36 ` Herve Codina via buildroot
@ 2022-04-17 19:36 ` Thomas Petazzoni via buildroot
2022-04-18 15:20 ` Herve Codina via buildroot
0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-04-17 19:36 UTC (permalink / raw)
To: Herve Codina; +Cc: Fabrice Fontaine, Herve Codina via buildroot
Hello Hervé,
On Fri, 15 Apr 2022 08:36:57 +0200
Herve Codina via buildroot <buildroot@buildroot.org> wrote:
> Acked.
If you want your Acked-by to be recorded by patchwork, it needs to be a
full Acked-by:, followed by your name and e-mail.
Thomas
--
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads
2022-04-17 19:36 ` Thomas Petazzoni via buildroot
@ 2022-04-18 15:20 ` Herve Codina via buildroot
0 siblings, 0 replies; 6+ messages in thread
From: Herve Codina via buildroot @ 2022-04-18 15:20 UTC (permalink / raw)
To: Thomas Petazzoni; +Cc: Fabrice Fontaine, Herve Codina via buildroot
Hi Thomas, Fabrice,
On Sun, 17 Apr 2022 21:36:01 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello Hervé,
>
> On Fri, 15 Apr 2022 08:36:57 +0200
> Herve Codina via buildroot <buildroot@buildroot.org> wrote:
>
> > Acked.
>
> If you want your Acked-by to be recorded by patchwork, it needs to be a
> full Acked-by:, followed by your name and e-mail.
>
> Thomas
Acked-by: Herve Codina <herve.codina@bootlin.com>
Hervé
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads
2022-04-14 20:30 [Buildroot] [PATCH 1/1] package/php-apcu: needs threads Fabrice Fontaine
2022-04-15 6:36 ` Herve Codina via buildroot
@ 2022-04-19 20:40 ` Arnout Vandecappelle
2022-05-22 20:19 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Arnout Vandecappelle @ 2022-04-19 20:40 UTC (permalink / raw)
To: Fabrice Fontaine, buildroot; +Cc: Hervé Codina
On 14/04/2022 22:30, Fabrice Fontaine wrote:
> php-apcu needs threads since its addition in commit
> 8ddeeffa186d8bce875ac713c1e71483c618842a:
>
> In file included from /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.c:20:
> /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.h:41:11: fatal error: pthread.h: No such file or directory
> 41 | # include "pthread.h"
> | ^~~~~~~~~~~
>
> Fixes:
> - http://autobuild.buildroot.org/results/314405423aeece5ee55d76ec5c4fa1919e7ee853
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Applied to master, thanks.
Regards,
Arnout
> ---
> package/php-apcu/Config.in | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/php-apcu/Config.in b/package/php-apcu/Config.in
> index 6338980222..f8e1eb17bb 100644
> --- a/package/php-apcu/Config.in
> +++ b/package/php-apcu/Config.in
> @@ -1,6 +1,10 @@
> config BR2_PACKAGE_PHP_APCU
> bool "php-apcu"
> + depends on BR2_TOOLCHAIN_HAS_THREADS
> help
> APCu is an in-memory key-value store for PHP.
>
> https://pecl.php.net/package/APCu
> +
> +comment "php-apcu needs a toolchain w/ threads"
> + depends on !BR2_TOOLCHAIN_HAS_THREADS
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Buildroot] [PATCH 1/1] package/php-apcu: needs threads
2022-04-14 20:30 [Buildroot] [PATCH 1/1] package/php-apcu: needs threads Fabrice Fontaine
2022-04-15 6:36 ` Herve Codina via buildroot
2022-04-19 20:40 ` Arnout Vandecappelle
@ 2022-05-22 20:19 ` Peter Korsgaard
2 siblings, 0 replies; 6+ messages in thread
From: Peter Korsgaard @ 2022-05-22 20:19 UTC (permalink / raw)
To: Fabrice Fontaine; +Cc: Hervé Codina, buildroot
>>>>> "Fabrice" == Fabrice Fontaine <fontaine.fabrice@gmail.com> writes:
> php-apcu needs threads since its addition in commit
> 8ddeeffa186d8bce875ac713c1e71483c618842a:
> In file included from /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.c:20:
> /home/buildroot/autobuild/instance-3/output-1/build/php-apcu-5.1.20/apc_lock.h:41:11: fatal error: pthread.h: No such file or directory
> 41 | # include "pthread.h"
> | ^~~~~~~~~~~
> Fixes:
> - http://autobuild.buildroot.org/results/314405423aeece5ee55d76ec5c4fa1919e7ee853
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
Committed to 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-22 20:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-14 20:30 [Buildroot] [PATCH 1/1] package/php-apcu: needs threads Fabrice Fontaine
2022-04-15 6:36 ` Herve Codina via buildroot
2022-04-17 19:36 ` Thomas Petazzoni via buildroot
2022-04-18 15:20 ` Herve Codina via buildroot
2022-04-19 20:40 ` Arnout Vandecappelle
2022-05-22 20:19 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.