From: Dmitry Osipenko <dmitry.osipenko@collabora.com> To: David Airlie <airlied@linux.ie>, Gerd Hoffmann <kraxel@redhat.com>, Gurchetan Singh <gurchetansingh@chromium.org>, Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Daniel Almeida <daniel.almeida@collabora.com>, Gert Wollny <gert.wollny@collabora.com>, Gustavo Padovan <gustavo.padovan@collabora.com>, Daniel Stone <daniel@fooishbar.org>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Rob Herring <robh@kernel.org>, Steven Price <steven.price@arm.com>, Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>, Rob Clark <robdclark@gmail.com>, Emil Velikov <emil.l.velikov@gmail.com>, Robin Murphy <robin.murphy@arm.com> Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, Dmitry Osipenko <digetx@gmail.com>, Dmitry Osipenko <dmitry.osipenko@collabora.com> Subject: [PATCH v4 08/15] drm/virtio: Use dev_is_pci() Date: Mon, 18 Apr 2022 01:37:00 +0300 [thread overview] Message-ID: <20220417223707.157113-9-dmitry.osipenko@collabora.com> (raw) In-Reply-To: <20220417223707.157113-1-dmitry.osipenko@collabora.com> Use common dev_is_pci() helper to replace the strcmp("pci") used by driver. Suggested-by: Robin Murphy <robin.murphy@arm.com> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> --- drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c index 0141b7df97ec..0035affc3e59 100644 --- a/drivers/gpu/drm/virtio/virtgpu_drv.c +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c @@ -87,7 +87,7 @@ static int virtio_gpu_probe(struct virtio_device *vdev) return PTR_ERR(dev); vdev->priv = dev; - if (!strcmp(vdev->dev.parent->bus->name, "pci")) { + if (dev_is_pci(vdev->dev.parent)) { ret = virtio_gpu_pci_quirk(dev); if (ret) goto err_free; -- 2.35.1
WARNING: multiple messages have this Message-ID (diff)
From: Dmitry Osipenko <dmitry.osipenko@collabora.com> To: David Airlie <airlied@linux.ie>, Gerd Hoffmann <kraxel@redhat.com>, Gurchetan Singh <gurchetansingh@chromium.org>, Chia-I Wu <olvaffe@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Daniel Almeida <daniel.almeida@collabora.com>, Gert Wollny <gert.wollny@collabora.com>, Gustavo Padovan <gustavo.padovan@collabora.com>, Daniel Stone <daniel@fooishbar.org>, Tomeu Vizoso <tomeu.vizoso@collabora.com>, Maarten Lankhorst <maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>, Thomas Zimmermann <tzimmermann@suse.de>, Rob Herring <robh@kernel.org>, Steven Price <steven.price@arm.com>, Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>, Rob Clark <robdclark@gmail.com>, Emil Velikov <emil.l.velikov@gmail.com>, Robin Murphy <robin.murphy@arm.com> Cc: Dmitry Osipenko <digetx@gmail.com>, Dmitry Osipenko <dmitry.osipenko@collabora.com>, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, virtualization@lists.linux-foundation.org Subject: [PATCH v4 08/15] drm/virtio: Use dev_is_pci() Date: Mon, 18 Apr 2022 01:37:00 +0300 [thread overview] Message-ID: <20220417223707.157113-9-dmitry.osipenko@collabora.com> (raw) In-Reply-To: <20220417223707.157113-1-dmitry.osipenko@collabora.com> Use common dev_is_pci() helper to replace the strcmp("pci") used by driver. Suggested-by: Robin Murphy <robin.murphy@arm.com> Signed-off-by: Dmitry Osipenko <dmitry.osipenko@collabora.com> --- drivers/gpu/drm/virtio/virtgpu_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_drv.c b/drivers/gpu/drm/virtio/virtgpu_drv.c index 0141b7df97ec..0035affc3e59 100644 --- a/drivers/gpu/drm/virtio/virtgpu_drv.c +++ b/drivers/gpu/drm/virtio/virtgpu_drv.c @@ -87,7 +87,7 @@ static int virtio_gpu_probe(struct virtio_device *vdev) return PTR_ERR(dev); vdev->priv = dev; - if (!strcmp(vdev->dev.parent->bus->name, "pci")) { + if (dev_is_pci(vdev->dev.parent)) { ret = virtio_gpu_pci_quirk(dev); if (ret) goto err_free; -- 2.35.1
next prev parent reply other threads:[~2022-04-17 22:38 UTC|newest] Thread overview: 123+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-17 22:36 [PATCH v4 00/15] Add generic memory shrinker to VirtIO-GPU and Panfrost DRM drivers Dmitry Osipenko 2022-04-17 22:36 ` Dmitry Osipenko 2022-04-17 22:36 ` [PATCH v4 01/15] drm/virtio: Correct drm_gem_shmem_get_sg_table() error handling Dmitry Osipenko 2022-04-17 22:36 ` Dmitry Osipenko 2022-04-17 22:36 ` [PATCH v4 02/15] drm/virtio: Check whether transferred 2D BO is shmem Dmitry Osipenko 2022-04-17 22:36 ` Dmitry Osipenko 2022-04-17 22:36 ` [PATCH v4 03/15] drm/virtio: Unlock GEM reservations on virtio_gpu_object_shmem_init() error Dmitry Osipenko 2022-04-17 22:36 ` Dmitry Osipenko 2022-04-17 22:36 ` [PATCH v4 04/15] drm/virtio: Unlock reservations on dma_resv_reserve_fences() error Dmitry Osipenko 2022-04-17 22:36 ` Dmitry Osipenko 2022-04-17 22:36 ` [PATCH v4 05/15] drm/virtio: Use appropriate atomic state in virtio_gpu_plane_cleanup_fb() Dmitry Osipenko 2022-04-17 22:36 ` Dmitry Osipenko 2022-04-17 22:36 ` [PATCH v4 06/15] drm/virtio: Simplify error handling of virtio_gpu_object_create() Dmitry Osipenko 2022-04-17 22:36 ` Dmitry Osipenko 2022-04-17 22:36 ` [PATCH v4 07/15] drm/virtio: Improve DMA API usage for shmem BOs Dmitry Osipenko 2022-04-17 22:36 ` Dmitry Osipenko 2022-04-17 22:37 ` Dmitry Osipenko [this message] 2022-04-17 22:37 ` [PATCH v4 08/15] drm/virtio: Use dev_is_pci() Dmitry Osipenko 2022-04-17 22:37 ` [PATCH v4 09/15] drm/shmem-helper: Correct doc-comment of drm_gem_shmem_get_sg_table() Dmitry Osipenko 2022-04-17 22:37 ` Dmitry Osipenko 2022-04-18 18:25 ` Thomas Zimmermann 2022-04-18 18:25 ` Thomas Zimmermann 2022-04-18 18:25 ` Thomas Zimmermann 2022-04-18 19:43 ` Dmitry Osipenko 2022-04-18 19:43 ` Dmitry Osipenko 2022-04-17 22:37 ` [PATCH v4 10/15] drm/shmem-helper: Take reservation lock instead of drm_gem_shmem locks Dmitry Osipenko 2022-04-17 22:37 ` Dmitry Osipenko 2022-04-18 18:38 ` Thomas Zimmermann 2022-04-18 18:38 ` Thomas Zimmermann 2022-04-18 19:18 ` Dmitry Osipenko 2022-04-27 14:50 ` Daniel Vetter 2022-04-27 14:50 ` Daniel Vetter 2022-04-27 14:50 ` Daniel Vetter 2022-04-28 18:31 ` Dmitry Osipenko 2022-05-04 8:21 ` Daniel Vetter 2022-05-04 8:21 ` Daniel Vetter 2022-05-04 8:21 ` Daniel Vetter 2022-05-04 15:56 ` Dmitry Osipenko 2022-05-05 8:12 ` Daniel Vetter 2022-05-05 8:12 ` Daniel Vetter 2022-05-05 8:12 ` Daniel Vetter 2022-05-05 22:49 ` Dmitry Osipenko 2022-05-09 13:42 ` Daniel Vetter 2022-05-09 13:42 ` Daniel Vetter 2022-05-09 13:42 ` Daniel Vetter 2022-05-10 13:39 ` Dmitry Osipenko 2022-05-10 13:39 ` Dmitry Osipenko 2022-05-11 13:00 ` Daniel Vetter 2022-05-11 13:00 ` Daniel Vetter 2022-05-11 13:00 ` Daniel Vetter 2022-05-11 14:24 ` Christian König 2022-05-11 14:24 ` Christian König 2022-05-11 15:07 ` Daniel Vetter 2022-05-11 15:07 ` Daniel Vetter 2022-05-11 15:07 ` Daniel Vetter 2022-05-11 15:14 ` Dmitry Osipenko 2022-05-11 15:14 ` Dmitry Osipenko 2022-05-11 15:29 ` Daniel Vetter 2022-05-11 15:29 ` Daniel Vetter 2022-05-11 15:29 ` Daniel Vetter 2022-05-11 15:40 ` Dmitry Osipenko 2022-05-11 15:40 ` Dmitry Osipenko 2022-05-11 19:05 ` Daniel Vetter 2022-05-11 19:05 ` Daniel Vetter 2022-05-11 19:05 ` Daniel Vetter 2022-05-12 7:29 ` Christian König 2022-05-12 7:29 ` Christian König 2022-05-12 14:15 ` Daniel Vetter 2022-05-12 14:15 ` Daniel Vetter 2022-05-12 14:15 ` Daniel Vetter 2022-04-17 22:37 ` [PATCH v4 11/15] drm/shmem-helper: Add generic memory shrinker Dmitry Osipenko 2022-04-17 22:37 ` Dmitry Osipenko 2022-04-19 7:22 ` Thomas Zimmermann 2022-04-19 7:22 ` Thomas Zimmermann 2022-04-19 20:40 ` Dmitry Osipenko 2022-04-27 15:03 ` Daniel Vetter 2022-04-27 15:03 ` Daniel Vetter 2022-04-27 15:03 ` Daniel Vetter 2022-04-28 18:20 ` Dmitry Osipenko 2022-05-04 8:24 ` Daniel Vetter 2022-05-04 8:24 ` Daniel Vetter 2022-05-04 8:24 ` Daniel Vetter 2022-06-19 16:54 ` Rob Clark 2022-06-19 16:54 ` Rob Clark 2022-06-19 16:54 ` Rob Clark 2022-05-05 8:34 ` Thomas Zimmermann 2022-05-05 8:34 ` Thomas Zimmermann 2022-05-05 11:59 ` Daniel Vetter 2022-05-05 11:59 ` Daniel Vetter 2022-05-05 11:59 ` Daniel Vetter 2022-05-06 0:10 ` Dmitry Osipenko 2022-05-09 13:49 ` Daniel Vetter 2022-05-09 13:49 ` Daniel Vetter 2022-05-09 13:49 ` Daniel Vetter 2022-05-10 13:47 ` Dmitry Osipenko 2022-05-10 13:47 ` Dmitry Osipenko 2022-05-11 13:09 ` Daniel Vetter 2022-05-11 13:09 ` Daniel Vetter 2022-05-11 13:09 ` Daniel Vetter 2022-05-11 16:06 ` Dmitry Osipenko 2022-05-11 16:06 ` Dmitry Osipenko 2022-05-11 19:09 ` Daniel Vetter 2022-05-11 19:09 ` Daniel Vetter 2022-05-11 19:09 ` Daniel Vetter 2022-05-12 11:36 ` Dmitry Osipenko 2022-05-12 11:36 ` Dmitry Osipenko 2022-05-12 17:04 ` Daniel Vetter 2022-05-12 17:04 ` Daniel Vetter 2022-05-12 17:04 ` Daniel Vetter 2022-05-12 19:04 ` Dmitry Osipenko 2022-05-12 19:04 ` Dmitry Osipenko 2022-05-19 14:13 ` Daniel Vetter 2022-05-19 14:13 ` Daniel Vetter 2022-05-19 14:13 ` Daniel Vetter 2022-05-19 14:29 ` Dmitry Osipenko 2022-04-17 22:37 ` [PATCH v4 12/15] drm/virtio: Support memory shrinking Dmitry Osipenko 2022-04-17 22:37 ` Dmitry Osipenko 2022-04-17 22:37 ` [PATCH v4 13/15] drm/panfrost: Switch to generic memory shrinker Dmitry Osipenko 2022-04-17 22:37 ` Dmitry Osipenko 2022-04-17 22:37 ` [PATCH v4 14/15] drm/shmem-helper: Make drm_gem_shmem_get_pages() private Dmitry Osipenko 2022-04-17 22:37 ` Dmitry Osipenko 2022-04-17 22:37 ` [PATCH v4 15/15] drm/shmem-helper: Remove drm_gem_shmem_purge() Dmitry Osipenko 2022-04-17 22:37 ` Dmitry Osipenko
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220417223707.157113-9-dmitry.osipenko@collabora.com \ --to=dmitry.osipenko@collabora.com \ --cc=airlied@linux.ie \ --cc=alyssa.rosenzweig@collabora.com \ --cc=daniel.almeida@collabora.com \ --cc=daniel@ffwll.ch \ --cc=daniel@fooishbar.org \ --cc=digetx@gmail.com \ --cc=dri-devel@lists.freedesktop.org \ --cc=emil.l.velikov@gmail.com \ --cc=gert.wollny@collabora.com \ --cc=gurchetansingh@chromium.org \ --cc=gustavo.padovan@collabora.com \ --cc=kraxel@redhat.com \ --cc=linux-kernel@vger.kernel.org \ --cc=maarten.lankhorst@linux.intel.com \ --cc=mripard@kernel.org \ --cc=olvaffe@gmail.com \ --cc=robdclark@gmail.com \ --cc=robh@kernel.org \ --cc=robin.murphy@arm.com \ --cc=steven.price@arm.com \ --cc=tomeu.vizoso@collabora.com \ --cc=tzimmermann@suse.de \ --cc=virtualization@lists.linux-foundation.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.