[Fuego] [PATCH] Dhrystone: Add 'one run through Dhrystone' value in the report

[Fuego] [PATCH] Dhrystone: Add 'one run through Dhrystone' value in the report

[sireesha.nakkala]

From: sireesha <sireesha.nakkala@toshiba-tsip.com>

parser.py: update parser file to parse 'Microseconds of one run through Dhrystone'

reference.json: Add reference for 'Microseconds of one run through Dhrystone'

Signed-off-by: sireesha <sireesha.nakkala@toshiba-tsip.com>
---
 tests/Benchmark.Dhrystone/parser.py      | 6 +++---
 tests/Benchmark.Dhrystone/reference.json | 5 +++++
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git a/tests/Benchmark.Dhrystone/parser.py b/tests/Benchmark.Dhrystone/parser.py
index 261d661..62447e9 100755
--- a/tests/Benchmark.Dhrystone/parser.py
+++ b/tests/Benchmark.Dhrystone/parser.py
@@ -3,12 +3,12 @@
 import os, re, sys
 import common as plib
 
-regex_string = "^(Dhrystones.per.Second:)(\ *)([\d]{1,8}.?[\d]{1,3})(.*)$"
-
+regex_string = "^(Microseconds.for.one.run.through.Dhrystone:|Dhrystones.per.Second:)(\ *)([\d]{1,8}.?[\d]{1,3})(.*)$"
 measurements = {}
+
 matches = plib.parse_log(regex_string)
 
 if matches:
-    measurements['default.Dhrystone'] = [{"name": "Score", "measure" : float(matches[0][2])}]
+    measurements['default.Dhrystone'] = [{"name": "microseconds_onerun", "measure" : float(matches[0][2])},{"name": "Score", "measure" : float(matches[1][2])}]
 
 sys.exit(plib.process(measurements))
diff --git a/tests/Benchmark.Dhrystone/reference.json b/tests/Benchmark.Dhrystone/reference.json
index 532ac16..443ebcf 100644
--- a/tests/Benchmark.Dhrystone/reference.json
+++ b/tests/Benchmark.Dhrystone/reference.json
@@ -9,7 +9,12 @@
                         {
                             "name":"Score",
                             "unit":"Dhrystones/s"
+                        },
+			{
+                            "name":"microseconds_onerun",
+                            "unit":"us"
                         }
+
                     ]
                 }
             ]
-- 
2.20.1

Re: [Fuego] [PATCH] Dhrystone: Add 'one run through Dhrystone' value in the report

[Bird, Tim]

See comments inline below.

> -----Original Message-----
> From: sireesha.nakkala@toshiba-tsip.com <sireesha.nakkala@toshiba-tsip.com>
> 
> From: sireesha <sireesha.nakkala@toshiba-tsip.com>
> 
> parser.py: update parser file to parse 'Microseconds of one run through Dhrystone'
Please keep lines in the commit message less than 80 chars long.  The one above is
a bit too long.

> 
> reference.json: Add reference for 'Microseconds of one run through Dhrystone'
> 
> Signed-off-by: sireesha <sireesha.nakkala@toshiba-tsip.com>
> ---
>  tests/Benchmark.Dhrystone/parser.py      | 6 +++---
>  tests/Benchmark.Dhrystone/reference.json | 5 +++++
>  2 files changed, 8 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/Benchmark.Dhrystone/parser.py b/tests/Benchmark.Dhrystone/parser.py
> index 261d661..62447e9 100755
> --- a/tests/Benchmark.Dhrystone/parser.py
> +++ b/tests/Benchmark.Dhrystone/parser.py
> @@ -3,12 +3,12 @@
>  import os, re, sys
>  import common as plib
> 
> -regex_string = "^(Dhrystones.per.Second:)(\ *)([\d]{1,8}.?[\d]{1,3})(.*)$"
> -
> +regex_string = "^(Microseconds.for.one.run.through.Dhrystone:|Dhrystones.per.Second:)(\ *)([\d]{1,8}.?[\d]{1,3})(.*)$"

I'm don't like using periods where spaces are trying to be matched, but
your addition is no worse than what was here before.

>  measurements = {}
> +
>  matches = plib.parse_log(regex_string)
> 
>  if matches:
> -    measurements['default.Dhrystone'] = [{"name": "Score", "measure" : float(matches[0][2])}]
> +    measurements['default.Dhrystone'] = [{"name": "microseconds_onerun", "measure" : float(matches[0][2])},{"name": "Score",

I kind of prefer 'onerun_microseconds', but that's just me.  I can live with this, since it matches
the order of the words in the testlog.txt file.  You might want to consider 'microseconds_for_one_run'.
It's just aesthetics, though.

> "measure" : float(matches[1][2])}]
> 
>  sys.exit(plib.process(measurements))
> diff --git a/tests/Benchmark.Dhrystone/reference.json b/tests/Benchmark.Dhrystone/reference.json
> index 532ac16..443ebcf 100644
> --- a/tests/Benchmark.Dhrystone/reference.json
> +++ b/tests/Benchmark.Dhrystone/reference.json
> @@ -9,7 +9,12 @@
>                          {
>                              "name":"Score",
>                              "unit":"Dhrystones/s"
> +                        },
> +			{
> +                            "name":"microseconds_onerun",
> +                            "unit":"us"
>                          }
> +
>                      ]
>                  }
>              ]
> --
> 2.20.1
> 

Looks good.  You haven't updated chart_config.json to show this new measure.
Did you want to do that?

I've applied and pushed this.  Please send any new patches based on this
one being already applied.

Thanks,
 -- Tim

[Fuego] [PATCH 0/2] Updated as per feedback

[sireesha.nakkala]

From: sireesha <sireesha.nakkala@toshiba-tsip.com>

Dear Tim,

I have updated patches as per your suggestion.

Kindly review


sireesha (2):
  Dhrystone: Update measure name  to 'microseconds_for_one_run'
  Dhrystone/chart_config.json: Add new measure for
    'microseconds_for_one_run'

 tests/Benchmark.Dhrystone/chart_config.json | 2 +-
 tests/Benchmark.Dhrystone/parser.py         | 2 +-
 tests/Benchmark.Dhrystone/reference.json    | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

-- 
2.20.1

[Fuego] [PATCH 1/2] Dhrystone: Update measure name to 'microseconds_for_one_run'

[sireesha.nakkala]

From: sireesha <sireesha.nakkala@toshiba-tsip.com>

Signed-off-by: sireesha <sireesha.nakkala@toshiba-tsip.com>
---
 tests/Benchmark.Dhrystone/parser.py      | 2 +-
 tests/Benchmark.Dhrystone/reference.json | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/Benchmark.Dhrystone/parser.py b/tests/Benchmark.Dhrystone/parser.py
index 62447e9..fd07cff 100755
--- a/tests/Benchmark.Dhrystone/parser.py
+++ b/tests/Benchmark.Dhrystone/parser.py
@@ -9,6 +9,6 @@ measurements = {}
 matches = plib.parse_log(regex_string)
 
 if matches:
-    measurements['default.Dhrystone'] = [{"name": "microseconds_onerun", "measure" : float(matches[0][2])},{"name": "Score", "measure" : float(matches[1][2])}]
+    measurements['default.Dhrystone'] = [{"name": "microseconds_for_one_run", "measure" : float(matches[0][2])},{"name": "Score", "measure" : float(matches[1][2])}]
 
 sys.exit(plib.process(measurements))
diff --git a/tests/Benchmark.Dhrystone/reference.json b/tests/Benchmark.Dhrystone/reference.json
index 443ebcf..1551504 100644
--- a/tests/Benchmark.Dhrystone/reference.json
+++ b/tests/Benchmark.Dhrystone/reference.json
@@ -11,7 +11,7 @@
                             "unit":"Dhrystones/s"
                         },
 			{
-                            "name":"microseconds_onerun",
+                            "name":"microseconds_for_one_run",
                             "unit":"us"
                         }
 
-- 
2.20.1

[Fuego] [PATCH 2/2] Dhrystone/chart_config.json: Add new measure for 'microseconds_for_one_run'

[sireesha.nakkala]

From: sireesha <sireesha.nakkala@toshiba-tsip.com>

Signed-off-by: sireesha <sireesha.nakkala@toshiba-tsip.com>
---
 tests/Benchmark.Dhrystone/chart_config.json | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/Benchmark.Dhrystone/chart_config.json b/tests/Benchmark.Dhrystone/chart_config.json
index f27da55..b6c1b48 100644
--- a/tests/Benchmark.Dhrystone/chart_config.json
+++ b/tests/Benchmark.Dhrystone/chart_config.json
@@ -1,4 +1,4 @@
 {
     "chart_type": "measure_plot",
-    "measures": ["default.Dhrystone.Score"]
+    "measures": ["default.Dhrystone.microseconds_for_one_run", "default.Dhrystone.Score"]
 }
-- 
2.20.1

Re: [Fuego] [PATCH 2/2] Dhrystone/chart_config.json: Add new measure for 'microseconds_for_one_run'

[Bird, Tim]

Looks good.  Applied and pushed.
 -- Tim

> -----Original Message-----
> From: sireesha.nakkala@toshiba-tsip.com <sireesha.nakkala@toshiba-tsip.com>
> Sent: Monday, April 18, 2022 5:35 AM
> To: Bird, Tim <Tim.Bird@sony.com>
> Cc: sireesha <sireesha.nakkala@toshiba-tsip.com>; fuego@lists.linuxfoundation.org; dinesh.kumar@toshiba-tsip.com;
> kazuhiro3.hayashi@toshiba.co.jp
> Subject: [PATCH 2/2] Dhrystone/chart_config.json: Add new measure for 'microseconds_for_one_run'
> 
> From: sireesha <sireesha.nakkala@toshiba-tsip.com>
> 
> Signed-off-by: sireesha <sireesha.nakkala@toshiba-tsip.com>
> ---
>  tests/Benchmark.Dhrystone/chart_config.json | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/Benchmark.Dhrystone/chart_config.json b/tests/Benchmark.Dhrystone/chart_config.json
> index f27da55..b6c1b48 100644
> --- a/tests/Benchmark.Dhrystone/chart_config.json
> +++ b/tests/Benchmark.Dhrystone/chart_config.json
> @@ -1,4 +1,4 @@
>  {
>      "chart_type": "measure_plot",
> -    "measures": ["default.Dhrystone.Score"]
> +    "measures": ["default.Dhrystone.microseconds_for_one_run", "default.Dhrystone.Score"]
>  }
> --
> 2.20.1
> 

Re: [Fuego] [PATCH 1/2] Dhrystone: Update measure name to 'microseconds_for_one_run'

[Bird, Tim]

Looks good. Applied and pushed.
 -- Tim


> -----Original Message-----
> From: sireesha.nakkala@toshiba-tsip.com <sireesha.nakkala@toshiba-tsip.com>
> Sent: Monday, April 18, 2022 5:35 AM
> To: Bird, Tim <Tim.Bird@sony.com>
> Cc: sireesha <sireesha.nakkala@toshiba-tsip.com>; fuego@lists.linuxfoundation.org; dinesh.kumar@toshiba-tsip.com;
> kazuhiro3.hayashi@toshiba.co.jp
> Subject: [PATCH 1/2] Dhrystone: Update measure name to 'microseconds_for_one_run'
> 
> From: sireesha <sireesha.nakkala@toshiba-tsip.com>
> 
> Signed-off-by: sireesha <sireesha.nakkala@toshiba-tsip.com>
> ---
>  tests/Benchmark.Dhrystone/parser.py      | 2 +-
>  tests/Benchmark.Dhrystone/reference.json | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/Benchmark.Dhrystone/parser.py b/tests/Benchmark.Dhrystone/parser.py
> index 62447e9..fd07cff 100755
> --- a/tests/Benchmark.Dhrystone/parser.py
> +++ b/tests/Benchmark.Dhrystone/parser.py
> @@ -9,6 +9,6 @@ measurements = {}
>  matches = plib.parse_log(regex_string)
> 
>  if matches:
> -    measurements['default.Dhrystone'] = [{"name": "microseconds_onerun", "measure" : float(matches[0][2])},{"name": "Score",
> "measure" : float(matches[1][2])}]
> +    measurements['default.Dhrystone'] = [{"name": "microseconds_for_one_run", "measure" : float(matches[0][2])},{"name": "Score",
> "measure" : float(matches[1][2])}]
> 
>  sys.exit(plib.process(measurements))
> diff --git a/tests/Benchmark.Dhrystone/reference.json b/tests/Benchmark.Dhrystone/reference.json
> index 443ebcf..1551504 100644
> --- a/tests/Benchmark.Dhrystone/reference.json
> +++ b/tests/Benchmark.Dhrystone/reference.json
> @@ -11,7 +11,7 @@
>                              "unit":"Dhrystones/s"
>                          },
>  			{
> -                            "name":"microseconds_onerun",
> +                            "name":"microseconds_for_one_run",
>                              "unit":"us"
>                          }
> 
> --
> 2.20.1
>