* [PATCH] ASoC: wm8958: Fix change notifications for DSP controls
@ 2022-04-16 12:54 Mark Brown
2022-04-18 12:58 ` Charles Keepax
2022-04-19 15:29 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2022-04-16 12:54 UTC (permalink / raw)
To: Liam Girdwood, patches; +Cc: alsa-devel, Mark Brown
The WM8958 DSP controls all return 0 on successful write, not a boolean
value indicating if the write changed the value of the control. Fix this
by returning 1 after a change, there is already a check at the start of
each put() that skips the function in the case that there is no change.
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/wm8958-dsp2.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/sound/soc/codecs/wm8958-dsp2.c b/sound/soc/codecs/wm8958-dsp2.c
index e4018ba3b19a..7878c7a58ff1 100644
--- a/sound/soc/codecs/wm8958-dsp2.c
+++ b/sound/soc/codecs/wm8958-dsp2.c
@@ -530,7 +530,7 @@ static int wm8958_mbc_put(struct snd_kcontrol *kcontrol,
wm8958_dsp_apply(component, mbc, wm8994->mbc_ena[mbc]);
- return 0;
+ return 1;
}
#define WM8958_MBC_SWITCH(xname, xval) {\
@@ -656,7 +656,7 @@ static int wm8958_vss_put(struct snd_kcontrol *kcontrol,
wm8958_dsp_apply(component, vss, wm8994->vss_ena[vss]);
- return 0;
+ return 1;
}
@@ -730,7 +730,7 @@ static int wm8958_hpf_put(struct snd_kcontrol *kcontrol,
wm8958_dsp_apply(component, hpf % 3, ucontrol->value.integer.value[0]);
- return 0;
+ return 1;
}
#define WM8958_HPF_SWITCH(xname, xval) {\
@@ -824,7 +824,7 @@ static int wm8958_enh_eq_put(struct snd_kcontrol *kcontrol,
wm8958_dsp_apply(component, eq, ucontrol->value.integer.value[0]);
- return 0;
+ return 1;
}
#define WM8958_ENH_EQ_SWITCH(xname, xval) {\
--
2.30.2
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: wm8958: Fix change notifications for DSP controls
2022-04-16 12:54 [PATCH] ASoC: wm8958: Fix change notifications for DSP controls Mark Brown
@ 2022-04-18 12:58 ` Charles Keepax
2022-04-19 15:29 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Charles Keepax @ 2022-04-18 12:58 UTC (permalink / raw)
To: Mark Brown; +Cc: patches, alsa-devel, Liam Girdwood
On Sat, Apr 16, 2022 at 01:54:08PM +0100, Mark Brown wrote:
> The WM8958 DSP controls all return 0 on successful write, not a boolean
> value indicating if the write changed the value of the control. Fix this
> by returning 1 after a change, there is already a check at the start of
> each put() that skips the function in the case that there is no change.
>
> Signed-off-by: Mark Brown <broonie@kernel.org>
> ---
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: wm8958: Fix change notifications for DSP controls
2022-04-16 12:54 [PATCH] ASoC: wm8958: Fix change notifications for DSP controls Mark Brown
2022-04-18 12:58 ` Charles Keepax
@ 2022-04-19 15:29 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2022-04-19 15:29 UTC (permalink / raw)
To: patches, broonie, Liam Girdwood; +Cc: alsa-devel
On Sat, 16 Apr 2022 13:54:08 +0100, Mark Brown wrote:
> The WM8958 DSP controls all return 0 on successful write, not a boolean
> value indicating if the write changed the value of the control. Fix this
> by returning 1 after a change, there is already a check at the start of
> each put() that skips the function in the case that there is no change.
>
>
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: wm8958: Fix change notifications for DSP controls
commit: b4f5c6b2e52b27462c0599e64e96e53b58438de1
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-19 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-16 12:54 [PATCH] ASoC: wm8958: Fix change notifications for DSP controls Mark Brown
2022-04-18 12:58 ` Charles Keepax
2022-04-19 15:29 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.