All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kees Cook <keescook@chromium.org>
To: kernel test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, linux-kernel@vger.kernel.org
Subject: Re: include/linux/fortify-string.h:267:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()?
Date: Mon, 18 Apr 2022 21:19:09 -0700	[thread overview]
Message-ID: <202204182118.5EB742C6@keescook> (raw)
In-Reply-To: <202204142318.vDqjjSFn-lkp@intel.com>

On Thu, Apr 14, 2022 at 11:54:03PM +0800, kernel test robot wrote:
>    In function 'fortify_memcpy_chk',
>        inlined from 'firm_send_command' at drivers/usb/serial/whiteheat.c:587:4:
> >> include/linux/fortify-string.h:267:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning]
>      267 |                         __write_overflow_field(p_size_field, size);
>          |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks! Proposed patch:
https://lore.kernel.org/linux-hardening/20220419041742.4117026-1-keescook@chromium.org/

-- 
Kees Cook

WARNING: multiple messages have this Message-ID (diff)
From: Kees Cook <keescook@chromium.org>
To: kbuild-all@lists.01.org
Subject: Re: include/linux/fortify-string.h:267:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()?
Date: Mon, 18 Apr 2022 21:19:09 -0700	[thread overview]
Message-ID: <202204182118.5EB742C6@keescook> (raw)
In-Reply-To: <202204142318.vDqjjSFn-lkp@intel.com>

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

On Thu, Apr 14, 2022 at 11:54:03PM +0800, kernel test robot wrote:
>    In function 'fortify_memcpy_chk',
>        inlined from 'firm_send_command' at drivers/usb/serial/whiteheat.c:587:4:
> >> include/linux/fortify-string.h:267:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Wattribute-warning]
>      267 |                         __write_overflow_field(p_size_field, size);
>          |                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks! Proposed patch:
https://lore.kernel.org/linux-hardening/20220419041742.4117026-1-keescook(a)chromium.org/

-- 
Kees Cook

  reply	other threads:[~2022-04-19  4:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-14 15:54 include/linux/fortify-string.h:267:25: warning: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? kernel test robot
2022-04-19  4:19 ` Kees Cook [this message]
2022-04-19  4:19   ` Kees Cook

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202204182118.5EB742C6@keescook \
    --to=keescook@chromium.org \
    --cc=kbuild-all@lists.01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.