[PATCH] USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static

[PATCH] USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static

[Tom Rix]

Smatch reports this issue
sr9800.h:166:53: warning: symbol 'SR9800_BULKIN_SIZE' was not declared. Should it be static?

Global variables should not be defined in header files.
This only works because sr9800.h in only included by sr9800.c
Change the storage-class specifier to static.
And since it does not change add type qualifier const.

Signed-off-by: Tom Rix <trix@redhat.com>
---
 drivers/net/usb/sr9800.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/usb/sr9800.h b/drivers/net/usb/sr9800.h
index 18f670251275..952e6f7c0321 100644
--- a/drivers/net/usb/sr9800.h
+++ b/drivers/net/usb/sr9800.h
@@ -163,7 +163,7 @@
 #define SR9800_MAX_BULKIN_24K		6
 #define SR9800_MAX_BULKIN_32K		7
 
-struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = {
+static const struct {unsigned short size, byte_cnt, threshold; } SR9800_BULKIN_SIZE[] = {
 	/* 2k */
 	{2048, 0x8000, 0x8001},
 	/* 4k */
-- 
2.27.0

Re: [PATCH] USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 19 Apr 2022 10:06:25 -0400 you wrote:
> Smatch reports this issue
> sr9800.h:166:53: warning: symbol 'SR9800_BULKIN_SIZE' was not declared. Should it be static?
> 
> Global variables should not be defined in header files.
> This only works because sr9800.h in only included by sr9800.c
> Change the storage-class specifier to static.
> And since it does not change add type qualifier const.
> 
> [...]

Here is the summary with links:
  - USB2NET : SR9800 : change SR9800_BULKIN_SIZE from global to static
    https://git.kernel.org/netdev/net-next/c/0844d36f771d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html