[meta-oe][PATCH 1/2] libcereal: Link libatomics with gcc as well

[meta-oe][PATCH 1/2] libcereal: Link libatomics with gcc as well

[Khem Raj]

Since gcc-12, gcc is also emitting calls to 64bit atomics

Fixes
unittests/CMakeFiles/test_atomic.dir/atomic.cpp.o:/usr/include/c++/12.0.1/atomic:285: more undefined references to `__atomic_load_8' follow
collect2: error: ld returned 1 exit status
Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-oe/recipes-support/libcereal/libcereal_1.3.2.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/meta-oe/recipes-support/libcereal/libcereal_1.3.2.bb b/meta-oe/recipes-support/libcereal/libcereal_1.3.2.bb
index 0bb06c1d1f..fc4fad708a 100644
--- a/meta-oe/recipes-support/libcereal/libcereal_1.3.2.bb
+++ b/meta-oe/recipes-support/libcereal/libcereal_1.3.2.bb
@@ -26,8 +26,8 @@ S = "${WORKDIR}/git"
 
 inherit cmake pkgconfig ptest
 
-LIBATOMIC:mips:toolchain-clang = "${@bb.utils.contains('PTEST_ENABLED', '1', '-DCEREAL_THREAD_LIBS="-latomic"', '', d)}"
-LIBATOMIC:riscv32:toolchain-clang = "${@bb.utils.contains('PTEST_ENABLED', '1', '-DCEREAL_THREAD_LIBS="-latomic"', '', d)}"
+LIBATOMIC:mips = "${@bb.utils.contains('PTEST_ENABLED', '1', '-DCEREAL_THREAD_LIBS="-latomic"', '', d)}"
+LIBATOMIC:riscv32 = "${@bb.utils.contains('PTEST_ENABLED', '1', '-DCEREAL_THREAD_LIBS="-latomic"', '', d)}"
 
 PACKAGECONFIG ??= "${@bb.utils.contains('PTEST_ENABLED', '1', 'with-tests', '', d)}"
 PACKAGECONFIG[with-tests] = "-DWITH_WERROR=OFF -DBUILD_TESTS=ON ${LIBATOMIC},,"
-- 
2.35.3

[meta-networking][PATCH 2/2] wpantund: Add missing dependency on boost

[Khem Raj]

Fixes
checking for boost/signals2/signal.hpp... no
configure: error: Unable to find a usable implementation of boost::signals2 (not even our internal copy)

Signed-off-by: Khem Raj <raj.khem@gmail.com>
---
 meta-networking/recipes-connectivity/openthread/wpantund_git.bb | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/meta-networking/recipes-connectivity/openthread/wpantund_git.bb b/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
index bb444d04f5..a7fcc202a4 100644
--- a/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
+++ b/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
@@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=e7820bc7f7d1638a6b54fc2e8d7fb103 \
                     file://third_party/openthread/LICENSE;md5=543b6fe90ec5901a683320a36390c65f \
                     file://third_party/pt/LICENSE;md5=dcd598b69cad786beea33da7b1ae14b7 \
                     "
-DEPENDS = "autoconf-archive dbus readline"
+DEPENDS = "autoconf-archive dbus readline boost"
 SRCREV = "0fb1f57e4224e2df3e630e146702bfcf63fbf07a"
 PV = "0.07.01+git${SRCPV}"
 
-- 
2.35.3

Re: [oe] [meta-networking][PATCH 2/2] wpantund: Add missing dependency on boost

[Stefan Schmidt]

Hello Khem.

On 19.04.22 17:22, Khem Raj wrote:
> Fixes
> checking for boost/signals2/signal.hpp... no
> configure: error: Unable to find a usable implementation of boost::signals2 (not even our internal copy)
> 
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
>   meta-networking/recipes-connectivity/openthread/wpantund_git.bb | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/meta-networking/recipes-connectivity/openthread/wpantund_git.bb b/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
> index bb444d04f5..a7fcc202a4 100644
> --- a/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
> +++ b/meta-networking/recipes-connectivity/openthread/wpantund_git.bb
> @@ -11,7 +11,7 @@ LIC_FILES_CHKSUM = "file://LICENSE;md5=e7820bc7f7d1638a6b54fc2e8d7fb103 \
>                       file://third_party/openthread/LICENSE;md5=543b6fe90ec5901a683320a36390c65f \
>                       file://third_party/pt/LICENSE;md5=dcd598b69cad786beea33da7b1ae14b7 \
>                       "
> -DEPENDS = "autoconf-archive dbus readline"
> +DEPENDS = "autoconf-archive dbus readline boost"
>   SRCREV = "0fb1f57e4224e2df3e630e146702bfcf63fbf07a"
>   PV = "0.07.01+git${SRCPV}"

LGTM

JFYI the project does have an internal copy of boost in the 
third_party/boost sub-folder (can be enabled by --with-boost=internal), 
but given its age I agree that we should rely on newer boost versions 
coming through OE.

regards
Stefan Schmidt