[PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h

[PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h

[Yinjun Zhang]

Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: linux-pci@vger.kernel.org
Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
Signed-off-by: Simon Horman <simon.horman@corigine.com>
---
 include/linux/pci_ids.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
index 0178823ce8c2..6d12b6d71c61 100644
--- a/include/linux/pci_ids.h
+++ b/include/linux/pci_ids.h
@@ -2568,6 +2568,8 @@
 
 #define PCI_VENDOR_ID_HYGON		0x1d94
 
+#define PCI_VENDOR_ID_CORIGINE		0x1da8
+
 #define PCI_VENDOR_ID_FUNGIBLE		0x1dad
 
 #define PCI_VENDOR_ID_HXT		0x1dbf
-- 
1.8.3.1

Re: [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h

[Bjorn Helgaas]

On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote:
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>

Acked-by: Bjorn Helgaas <bhelgaas@google.com>

I'd be happy to apply this, but since I'm in the cc: line, I assume it
will be applied with other patches that use this.  Let me know if
otherwise.

I see that you also added the ID at
https://pci-ids.ucw.cz/read/PC/1da8; thank you for that!  

But it looks like the "name" part isn't quite correct -- at
https://pci-ids.ucw.cz/read/PC?restrict=1, "Corigine" isn't shown, so
I think lspci won't show the right thing yet.

> ---
>  include/linux/pci_ids.h | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> index 0178823ce8c2..6d12b6d71c61 100644
> --- a/include/linux/pci_ids.h
> +++ b/include/linux/pci_ids.h
> @@ -2568,6 +2568,8 @@
>  
>  #define PCI_VENDOR_ID_HYGON		0x1d94
>  
> +#define PCI_VENDOR_ID_CORIGINE		0x1da8
> +
>  #define PCI_VENDOR_ID_FUNGIBLE		0x1dad
>  
>  #define PCI_VENDOR_ID_HXT		0x1dbf
> -- 
> 1.8.3.1
> 

Re: [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h

[Andrew Lunn]

On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote:
> Cc: Bjorn Helgaas <bhelgaas@google.com>
> Cc: linux-pci@vger.kernel.org
> Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
> Signed-off-by: Simon Horman <simon.horman@corigine.com>
> ---
>  include/linux/pci_ids.h | 2 ++

The very top of this file says:

 *      Do not add new entries to this file unless the definitions
 *      are shared between multiple drivers.

Please add to the commit messages the two or more drivers which share
this definition.

Thanks

     Andrew

Re: [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h

[Yinjun Zhang]

On Tue, Apr 19, 2022 at 09:23:10AM -0500, Bjorn Helgaas wrote:
> On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote:
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: linux-pci@vger.kernel.org
> > Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
> > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> 
> Acked-by: Bjorn Helgaas <bhelgaas@google.com>
> 
> I'd be happy to apply this, but since I'm in the cc: line, I assume it
> will be applied with other patches that use this.  Let me know if
> otherwise.

Yes, it will be used by coming-up patches which will be submitted to
net-next tree, so I'll appreciate that if it can be applied to net-next
tree first.

> 
> I see that you also added the ID at
> https://pci-ids.ucw.cz/read/PC/1da8; thank you for that!  
> 
> But it looks like the "name" part isn't quite correct -- at
> https://pci-ids.ucw.cz/read/PC?restrict=1, "Corigine" isn't shown, so
> I think lspci won't show the right thing yet.

Yeah, I presume that it's not approved yet by the administrator.

> 
> > ---
> >  include/linux/pci_ids.h | 2 ++
> >  1 file changed, 2 insertions(+)
> > 
> > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > index 0178823ce8c2..6d12b6d71c61 100644
> > --- a/include/linux/pci_ids.h
> > +++ b/include/linux/pci_ids.h
> > @@ -2568,6 +2568,8 @@
> >  
> >  #define PCI_VENDOR_ID_HYGON		0x1d94
> >  
> > +#define PCI_VENDOR_ID_CORIGINE		0x1da8
> > +
> >  #define PCI_VENDOR_ID_FUNGIBLE		0x1dad
> >  
> >  #define PCI_VENDOR_ID_HXT		0x1dbf
> > -- 
> > 1.8.3.1
> > 

Re: [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h

[Yinjun Zhang]

On Wed, Apr 20, 2022 at 12:00:05AM +0200, Andrew Lunn wrote:
> On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote:
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: linux-pci@vger.kernel.org
> > Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
> > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > ---
> >  include/linux/pci_ids.h | 2 ++
> 
> The very top of this file says:
> 
>  *      Do not add new entries to this file unless the definitions
>  *      are shared between multiple drivers.
> 
> Please add to the commit messages the two or more drivers which share
> this definition.

It will be used by ethernet and infiniband driver as we can see now,
I'll update the commit message if you think it's a good practice.

> 
> Thanks
> 
>      Andrew

Re: [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h

[Leon Romanovsky]

On Wed, Apr 20, 2022 at 09:59:52AM +0800, Yinjun Zhang wrote:
> On Wed, Apr 20, 2022 at 12:00:05AM +0200, Andrew Lunn wrote:
> > On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote:
> > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > Cc: linux-pci@vger.kernel.org
> > > Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
> > > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > > ---
> > >  include/linux/pci_ids.h | 2 ++
> > 
> > The very top of this file says:
> > 
> >  *      Do not add new entries to this file unless the definitions
> >  *      are shared between multiple drivers.
> > 
> > Please add to the commit messages the two or more drivers which share
> > this definition.
> 
> It will be used by ethernet and infiniband driver as we can see now,
> I'll update the commit message if you think it's a good practice.

Are you going to submit completely separated infiniband driver that has
PCI logic in drivers/infiniband without connection todrivers/net/ethernet ...?

If yes, it is very uncommon in infiniband world.

I would like to see this PCI patch submitted when it is actually used.

Thanks

> 
> > 
> > Thanks
> > 
> >      Andrew

Re: [PATCH net-next] PCI: add Corigine vendor ID into pci_ids.h

[Yinjun Zhang]

On Wed, Apr 20, 2022 at 09:12:34AM +0300, Leon Romanovsky wrote:
> On Wed, Apr 20, 2022 at 09:59:52AM +0800, Yinjun Zhang wrote:
> > On Wed, Apr 20, 2022 at 12:00:05AM +0200, Andrew Lunn wrote:
> > > On Tue, Apr 19, 2022 at 06:02:48PM +0800, Yinjun Zhang wrote:
> > > > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > > > Cc: linux-pci@vger.kernel.org
> > > > Signed-off-by: Yinjun Zhang <yinjun.zhang@corigine.com>
> > > > Signed-off-by: Simon Horman <simon.horman@corigine.com>
> > > > ---
> > > >  include/linux/pci_ids.h | 2 ++
> > > 
> > > The very top of this file says:
> > > 
> > >  *      Do not add new entries to this file unless the definitions
> > >  *      are shared between multiple drivers.
> > > 
> > > Please add to the commit messages the two or more drivers which share
> > > this definition.
> > 
> > It will be used by ethernet and infiniband driver as we can see now,
> > I'll update the commit message if you think it's a good practice.
> 
> Are you going to submit completely separated infiniband driver that has
> PCI logic in drivers/infiniband without connection todrivers/net/ethernet ...?
> 
> If yes, it is very uncommon in infiniband world.

No, we'll follow the convention, the connection with driver/net/ethernet
is necessary. We've discussed internally that direct ref to VID/DID is not
a good way.

I'll move the VID macro into driver header files for now.
Also thanks for pointing this out, Andrew. 

Cc: Bjorn Helgaas

> 
> I would like to see this PCI patch submitted when it is actually used.
> 
> Thanks
> 
> > 
> > > 
> > > Thanks
> > > 
> > >      Andrew