* [PATCH 01/11] server/process: Drop unused import
@ 2022-04-20 13:21 Richard Purdie
2022-04-20 13:21 ` [PATCH 02/11] ui/buildinfohelper: " Richard Purdie
` (9 more replies)
0 siblings, 10 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:21 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/server/process.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/bb/server/process.py b/lib/bb/server/process.py
index 19ef83980f..613956f30f 100644
--- a/lib/bb/server/process.py
+++ b/lib/bb/server/process.py
@@ -20,7 +20,6 @@ import os
import sys
import time
import select
-import signal
import socket
import subprocess
import errno
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 02/11] ui/buildinfohelper: Drop unused import
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
@ 2022-04-20 13:21 ` Richard Purdie
2022-04-20 13:21 ` [PATCH 03/11] cooker: Drop unused loop Richard Purdie
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:21 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/ui/buildinfohelper.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/bb/ui/buildinfohelper.py b/lib/bb/ui/buildinfohelper.py
index 0761f73b3b..9c4215f9a2 100644
--- a/lib/bb/ui/buildinfohelper.py
+++ b/lib/bb/ui/buildinfohelper.py
@@ -45,7 +45,7 @@ from pprint import pformat
import logging
from datetime import datetime, timedelta
-from django.db import transaction, connection
+from django.db import transaction
# pylint: disable=invalid-name
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 03/11] cooker: Drop unused loop
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
2022-04-20 13:21 ` [PATCH 02/11] ui/buildinfohelper: " Richard Purdie
@ 2022-04-20 13:21 ` Richard Purdie
2022-04-20 13:21 ` [PATCH 04/11] msg: Drop unused local variable Richard Purdie
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:21 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/cooker.py | 25 ++++++++++++-------------
1 file changed, 12 insertions(+), 13 deletions(-)
diff --git a/lib/bb/cooker.py b/lib/bb/cooker.py
index 7685db11f3..701e49339a 100644
--- a/lib/bb/cooker.py
+++ b/lib/bb/cooker.py
@@ -763,19 +763,18 @@ class BBCooker:
taskdata[mc].add_unresolved(localdata[mc], self.recipecaches[mc])
mcdeps |= set(taskdata[mc].get_mcdepends())
new = False
- for mc in self.multiconfigs:
- for k in mcdeps:
- if k in seen:
- continue
- l = k.split(':')
- depmc = l[2]
- if depmc not in self.multiconfigs:
- bb.fatal("Multiconfig dependency %s depends on nonexistent multiconfig configuration named configuration %s" % (k,depmc))
- else:
- logger.debug("Adding providers for multiconfig dependency %s" % l[3])
- taskdata[depmc].add_provider(localdata[depmc], self.recipecaches[depmc], l[3])
- seen.add(k)
- new = True
+ for k in mcdeps:
+ if k in seen:
+ continue
+ l = k.split(':')
+ depmc = l[2]
+ if depmc not in self.multiconfigs:
+ bb.fatal("Multiconfig dependency %s depends on nonexistent multiconfig configuration named configuration %s" % (k,depmc))
+ else:
+ logger.debug("Adding providers for multiconfig dependency %s" % l[3])
+ taskdata[depmc].add_provider(localdata[depmc], self.recipecaches[depmc], l[3])
+ seen.add(k)
+ new = True
for mc in self.multiconfigs:
taskdata[mc].add_unresolved(localdata[mc], self.recipecaches[mc])
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 04/11] msg: Drop unused local variable
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
2022-04-20 13:21 ` [PATCH 02/11] ui/buildinfohelper: " Richard Purdie
2022-04-20 13:21 ` [PATCH 03/11] cooker: Drop unused loop Richard Purdie
@ 2022-04-20 13:21 ` Richard Purdie
2022-04-20 13:21 ` [PATCH 05/11] buildinfohelper: Drop unused function Richard Purdie
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:21 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/msg.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/bb/msg.py b/lib/bb/msg.py
index c95a874beb..93575d89c4 100644
--- a/lib/bb/msg.py
+++ b/lib/bb/msg.py
@@ -133,7 +133,6 @@ class LogFilterShowOnce(logging.Filter):
self.seen_errors = set()
def filter(self, record):
- msg = record.msg
if record.levelno == bb.msg.BBLogFormatter.WARNONCE:
if record.msg in self.seen_warnings:
return False
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 05/11] buildinfohelper: Drop unused function
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
` (2 preceding siblings ...)
2022-04-20 13:21 ` [PATCH 04/11] msg: Drop unused local variable Richard Purdie
@ 2022-04-20 13:21 ` Richard Purdie
2022-04-20 13:22 ` [PATCH 06/11] fetch2/crate: Drop unused import Richard Purdie
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:21 UTC (permalink / raw)
To: bitbake-devel
The function has a loop where the variable is never used which I was going
to fix but the entire function never seems to be called so remove it entirely.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/ui/buildinfohelper.py | 21 ---------------------
1 file changed, 21 deletions(-)
diff --git a/lib/bb/ui/buildinfohelper.py b/lib/bb/ui/buildinfohelper.py
index 9c4215f9a2..c4ca267783 100644
--- a/lib/bb/ui/buildinfohelper.py
+++ b/lib/bb/ui/buildinfohelper.py
@@ -1062,27 +1062,6 @@ class BuildInfoHelper(object):
return recipe_info
- def _get_path_information(self, task_object):
- self._ensure_build()
-
- assert isinstance(task_object, Task)
- build_stats_format = "{tmpdir}/buildstats/{buildname}/{package}/"
- build_stats_path = []
-
- for t in self.internal_state['targets']:
- buildname = self.internal_state['build'].build_name
- pe, pv = task_object.recipe.version.split(":",1)
- if pe:
- package = task_object.recipe.name + "-" + pe + "_" + pv
- else:
- package = task_object.recipe.name + "-" + pv
-
- build_stats_path.append(build_stats_format.format(tmpdir=self.tmp_dir,
- buildname=buildname,
- package=package))
-
- return build_stats_path
-
################################
## external available methods to store information
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 06/11] fetch2/crate: Drop unused import
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
` (3 preceding siblings ...)
2022-04-20 13:21 ` [PATCH 05/11] buildinfohelper: Drop unused function Richard Purdie
@ 2022-04-20 13:22 ` Richard Purdie
2022-04-20 13:22 ` [PATCH 07/11] siggen: Drop pointless break statement Richard Purdie
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:22 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/fetch2/crate.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/bb/fetch2/crate.py b/lib/bb/fetch2/crate.py
index aac1221c87..f4ddc782a9 100644
--- a/lib/bb/fetch2/crate.py
+++ b/lib/bb/fetch2/crate.py
@@ -13,7 +13,6 @@ BitBake 'Fetch' implementation for crates.io
import hashlib
import json
import os
-import shutil
import subprocess
import bb
from bb.fetch2 import logger, subprocess_setup, UnpackError
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 07/11] siggen: Drop pointless break statement
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
` (4 preceding siblings ...)
2022-04-20 13:22 ` [PATCH 06/11] fetch2/crate: Drop unused import Richard Purdie
@ 2022-04-20 13:22 ` Richard Purdie
2022-04-20 13:22 ` [PATCH 08/11] ui/knotty: Drop pointless pass statement Richard Purdie
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:22 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/siggen.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/bb/siggen.py b/lib/bb/siggen.py
index 130b38d8a7..9fa568f614 100644
--- a/lib/bb/siggen.py
+++ b/lib/bb/siggen.py
@@ -40,7 +40,6 @@ def init(d):
for sg in siggens:
if desired == sg.name:
return sg(d)
- break
else:
logger.error("Invalid signature generator '%s', using default 'noop'\n"
"Available generators: %s", desired,
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 08/11] ui/knotty: Drop pointless pass statement
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
` (5 preceding siblings ...)
2022-04-20 13:22 ` [PATCH 07/11] siggen: Drop pointless break statement Richard Purdie
@ 2022-04-20 13:22 ` Richard Purdie
2022-04-20 13:22 ` [PATCH 09/11] persist_data: Use a valid exception for missing implementation Richard Purdie
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:22 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/ui/knotty.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/bb/ui/knotty.py b/lib/bb/ui/knotty.py
index 3f410fd525..61cf0a37f4 100644
--- a/lib/bb/ui/knotty.py
+++ b/lib/bb/ui/knotty.py
@@ -877,7 +877,6 @@ def main(server, eventHandler, params, tf = TerminalFilter):
state_force_shutdown()
main.shutdown = main.shutdown + 1
- pass
except Exception as e:
import traceback
sys.stderr.write(traceback.format_exc())
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 09/11] persist_data: Use a valid exception for missing implementation
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
` (6 preceding siblings ...)
2022-04-20 13:22 ` [PATCH 08/11] ui/knotty: Drop pointless pass statement Richard Purdie
@ 2022-04-20 13:22 ` Richard Purdie
2022-04-20 13:22 ` [PATCH 10/11] runqueue: Drop pointless variable assignment Richard Purdie
2022-04-20 13:22 ` [PATCH 11/11] buildinfohelper: Drop unused variables Richard Purdie
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:22 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/persist_data.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/bb/persist_data.py b/lib/bb/persist_data.py
index 9e20a837a4..ce84a15825 100644
--- a/lib/bb/persist_data.py
+++ b/lib/bb/persist_data.py
@@ -208,7 +208,7 @@ class SQLTable(collections.abc.MutableMapping):
def __lt__(self, other):
if not isinstance(other, Mapping):
- raise NotImplemented
+ raise NotImplementedError()
return len(self) < len(other)
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 10/11] runqueue: Drop pointless variable assignment
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
` (7 preceding siblings ...)
2022-04-20 13:22 ` [PATCH 09/11] persist_data: Use a valid exception for missing implementation Richard Purdie
@ 2022-04-20 13:22 ` Richard Purdie
2022-04-20 13:22 ` [PATCH 11/11] buildinfohelper: Drop unused variables Richard Purdie
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:22 UTC (permalink / raw)
To: bitbake-devel
This is set at the start of the loop anyway so it does nothing. Drop
the pointless code.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/runqueue.py | 1 -
1 file changed, 1 deletion(-)
diff --git a/lib/bb/runqueue.py b/lib/bb/runqueue.py
index a7a84630d7..a4e82f375c 100644
--- a/lib/bb/runqueue.py
+++ b/lib/bb/runqueue.py
@@ -2664,7 +2664,6 @@ def build_scenequeue_data(sqdata, rqdata, rq, cooker, stampcache, sqrq):
sq_revdeps_squash[point] = set()
if point in rqdata.runq_setscene_tids:
sq_revdeps_squash[point] = tasks
- tasks = set()
continue
for dep in rqdata.runtaskentries[point].depends:
if point in sq_revdeps[dep]:
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH 11/11] buildinfohelper: Drop unused variables
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
` (8 preceding siblings ...)
2022-04-20 13:22 ` [PATCH 10/11] runqueue: Drop pointless variable assignment Richard Purdie
@ 2022-04-20 13:22 ` Richard Purdie
9 siblings, 0 replies; 11+ messages in thread
From: Richard Purdie @ 2022-04-20 13:22 UTC (permalink / raw)
To: bitbake-devel
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
---
lib/bb/ui/buildinfohelper.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/bb/ui/buildinfohelper.py b/lib/bb/ui/buildinfohelper.py
index c4ca267783..129bb329c3 100644
--- a/lib/bb/ui/buildinfohelper.py
+++ b/lib/bb/ui/buildinfohelper.py
@@ -496,7 +496,7 @@ class ORMWrapper(object):
if not parent_path:
parent_path = "/"
parent_obj = self._cached_get(Target_File, target = target_obj, path = parent_path, inodetype = Target_File.ITYPE_DIRECTORY)
- tf_obj = Target_File.objects.create(
+ Target_File.objects.create(
target = target_obj,
path = path,
size = size,
@@ -561,7 +561,7 @@ class ORMWrapper(object):
parent_obj = Target_File.objects.get(target = target_obj, path = parent_path, inodetype = Target_File.ITYPE_DIRECTORY)
- tf_obj = Target_File.objects.create(
+ Target_File.objects.create(
target = target_obj,
path = path,
size = size,
--
2.32.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-04-21 16:46 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-20 13:21 [PATCH 01/11] server/process: Drop unused import Richard Purdie
2022-04-20 13:21 ` [PATCH 02/11] ui/buildinfohelper: " Richard Purdie
2022-04-20 13:21 ` [PATCH 03/11] cooker: Drop unused loop Richard Purdie
2022-04-20 13:21 ` [PATCH 04/11] msg: Drop unused local variable Richard Purdie
2022-04-20 13:21 ` [PATCH 05/11] buildinfohelper: Drop unused function Richard Purdie
2022-04-20 13:22 ` [PATCH 06/11] fetch2/crate: Drop unused import Richard Purdie
2022-04-20 13:22 ` [PATCH 07/11] siggen: Drop pointless break statement Richard Purdie
2022-04-20 13:22 ` [PATCH 08/11] ui/knotty: Drop pointless pass statement Richard Purdie
2022-04-20 13:22 ` [PATCH 09/11] persist_data: Use a valid exception for missing implementation Richard Purdie
2022-04-20 13:22 ` [PATCH 10/11] runqueue: Drop pointless variable assignment Richard Purdie
2022-04-20 13:22 ` [PATCH 11/11] buildinfohelper: Drop unused variables Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.