[PATCH BlueZ] btmon: Fix decoding of Enhanced Credit Connection Request

[PATCH BlueZ] btmon: Fix decoding of Enhanced Credit Connection Request

[Luiz Augusto von Dentz]

From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>

This fixes the decoding of Enhanced Credit Connection Request which was
not accounting the fields correctly causing 2 extra Source CID to be
printed.
---
 monitor/l2cap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/l2cap.c b/monitor/l2cap.c
index 4e449854a..01825ce0a 100644
--- a/monitor/l2cap.c
+++ b/monitor/l2cap.c
@@ -1331,7 +1331,7 @@ static void sig_ecred_conn_req(const struct l2cap_frame *frame)
 	const struct bt_l2cap_pdu_ecred_conn_req *pdu = frame->data;
 	uint16_t scid;
 
-	l2cap_frame_pull((void *)frame, frame, sizeof(pdu));
+	l2cap_frame_pull((void *)frame, frame, sizeof(*pdu));
 
 	print_psm(pdu->psm);
 	print_field("MTU: %u", le16_to_cpu(pdu->mtu));
-- 
2.35.1

RE: [BlueZ] btmon: Fix decoding of Enhanced Credit Connection Request

[bluez.test.bot]

[-- Attachment #1: Type: text/plain, Size: 995 bytes --]

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=633945

---Test result---

Test Summary:
CheckPatch                    PASS      1.44 seconds
GitLint                       PASS      0.98 seconds
Prep - Setup ELL              PASS      42.20 seconds
Build - Prep                  PASS      0.71 seconds
Build - Configure             PASS      8.42 seconds
Build - Make                  PASS      1245.43 seconds
Make Check                    PASS      12.15 seconds
Make Check w/Valgrind         PASS      437.69 seconds
Make Distcheck                PASS      225.55 seconds
Build w/ext ELL - Configure   PASS      8.50 seconds
Build w/ext ELL - Make        PASS      1234.97 seconds
Incremental Build with patchesPASS      0.00 seconds



---
Regards,
Linux Bluetooth

Re: [PATCH BlueZ] btmon: Fix decoding of Enhanced Credit Connection Request

[patchwork-bot+bluetooth]

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <luiz.von.dentz@intel.com>:

On Wed, 20 Apr 2022 16:46:09 -0700 you wrote:
> From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
> 
> This fixes the decoding of Enhanced Credit Connection Request which was
> not accounting the fields correctly causing 2 extra Source CID to be
> printed.
> ---
>  monitor/l2cap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
  - [BlueZ] btmon: Fix decoding of Enhanced Credit Connection Request
    https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=3e2ad5009c0f

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html