* [PATCH] dmaengine: ptdma: statify pt_tx_status
@ 2022-04-21 5:24 Vinod Koul
2022-04-22 5:59 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: Vinod Koul @ 2022-04-21 5:24 UTC (permalink / raw)
To: dmaengine, Sanjay R Mehta; +Cc: Vinod Koul, Ilya Novikov, kernel test robot
LKP bot reports a new warning:
Warning:
drivers/dma/ptdma/ptdma-dmaengine.c:262:1: warning: no previous prototype for 'pt_tx_status' [-Wmissing-prototypes]
pt_tx_status() should be static, so declare as such.
Reported-by: kernel test robot <lkp@intel.com>
Fixes: d965068259d1 ("dmaengine: PTDMA: support polled mode")
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/dma/ptdma/ptdma-dmaengine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ptdma/ptdma-dmaengine.c b/drivers/dma/ptdma/ptdma-dmaengine.c
index ea07cc42f4d0..cc22d162ce25 100644
--- a/drivers/dma/ptdma/ptdma-dmaengine.c
+++ b/drivers/dma/ptdma/ptdma-dmaengine.c
@@ -258,7 +258,7 @@ static void pt_issue_pending(struct dma_chan *dma_chan)
pt_cmd_callback(desc, 0);
}
-enum dma_status
+static enum dma_status
pt_tx_status(struct dma_chan *c, dma_cookie_t cookie,
struct dma_tx_state *txstate)
{
--
2.34.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: ptdma: statify pt_tx_status
2022-04-21 5:24 [PATCH] dmaengine: ptdma: statify pt_tx_status Vinod Koul
@ 2022-04-22 5:59 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2022-04-22 5:59 UTC (permalink / raw)
To: dmaengine, Sanjay R Mehta; +Cc: Ilya Novikov, kernel test robot
On 21-04-22, 10:54, Vinod Koul wrote:
> LKP bot reports a new warning:
> Warning:
> drivers/dma/ptdma/ptdma-dmaengine.c:262:1: warning: no previous prototype for 'pt_tx_status' [-Wmissing-prototypes]
>
> pt_tx_status() should be static, so declare as such.
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] dmaengine: PTDMA: statify pt_tx_status
2022-04-21 9:21 [PATCH] dmaengine: PTDMA: " i.m.novikov
@ 2022-04-22 6:00 ` Vinod Koul
0 siblings, 0 replies; 4+ messages in thread
From: Vinod Koul @ 2022-04-22 6:00 UTC (permalink / raw)
To: i.m.novikov
Cc: sanju.mehta, dmaengine, linux-kernel, linux, kernel test robot
On 21-04-22, 12:21, i.m.novikov@yadro.com wrote:
> From: Ilya Novikov <i.m.novikov@yadro.com>
>
> LKP bot reports a new warning:
> Warning:
> drivers/dma/ptdma/ptdma-dmaengine.c:262:1: warning: no previous
> prototype for 'pt_tx_status' [-Wmissing-prototypes]
I have applied 20220421052407.745637-1-vkoul@kernel.org which was sent
before this
--
~Vinod
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] dmaengine: PTDMA: statify pt_tx_status
@ 2022-04-21 9:21 i.m.novikov
2022-04-22 6:00 ` Vinod Koul
0 siblings, 1 reply; 4+ messages in thread
From: i.m.novikov @ 2022-04-21 9:21 UTC (permalink / raw)
To: vkoul
Cc: i.m.novikov, sanju.mehta, dmaengine, linux-kernel, linux,
kernel test robot
From: Ilya Novikov <i.m.novikov@yadro.com>
LKP bot reports a new warning:
Warning:
drivers/dma/ptdma/ptdma-dmaengine.c:262:1: warning: no previous
prototype for 'pt_tx_status' [-Wmissing-prototypes]
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Ilya Novikov <i.m.novikov@yadro.com>
---
drivers/dma/ptdma/ptdma-dmaengine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/dma/ptdma/ptdma-dmaengine.c b/drivers/dma/ptdma/ptdma-dmaengine.c
index ea07cc42f4d0..cc22d162ce25 100644
--- a/drivers/dma/ptdma/ptdma-dmaengine.c
+++ b/drivers/dma/ptdma/ptdma-dmaengine.c
@@ -258,7 +258,7 @@ static void pt_issue_pending(struct dma_chan *dma_chan)
pt_cmd_callback(desc, 0);
}
-enum dma_status
+static enum dma_status
pt_tx_status(struct dma_chan *c, dma_cookie_t cookie,
struct dma_tx_state *txstate)
{
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-22 6:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 5:24 [PATCH] dmaengine: ptdma: statify pt_tx_status Vinod Koul
2022-04-22 5:59 ` Vinod Koul
2022-04-21 9:21 [PATCH] dmaengine: PTDMA: " i.m.novikov
2022-04-22 6:00 ` Vinod Koul
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.