[PATCH v2] treewide: Enable SPL_SEPARATE_BSS if SPL_BSS_START_ADDR is used

[PATCH v2] treewide: Enable SPL_SEPARATE_BSS if SPL_BSS_START_ADDR is used

[Sean Anderson]

If .bss does not immediately follow the end of the image, then
CONFIG_SPL_SEPARATE_BSS must be selected. Typically, the location of bss
is specified by using CONFIG_SPL_BSS_START_ADDR in a linker script. On
these arches, CONFIG_SPL_SEPARATE_BSS should be enabled. If there is an
option to use an alternate boot script (e.g. CONFIG_SPL_LDSCRIPT is just
a default), just imply. If there is not, select.

Signed-off-by: Sean Anderson <sean.anderson@seco.com>
---

Changes in v2:
- Add "if SPL" to selects to avoid config error

 arch/Kconfig     | 2 ++
 arch/arm/Kconfig | 6 ++++++
 2 files changed, 8 insertions(+)

diff --git a/arch/Kconfig b/arch/Kconfig
index bc31e5ad50..8a63adcfd8 100644
--- a/arch/Kconfig
+++ b/arch/Kconfig
@@ -85,6 +85,7 @@ config MIPS
 	select HAVE_ARCH_IOREMAP
 	select HAVE_PRIVATE_LIBGCC
 	select SUPPORT_OF_CONTROL
+	select SPL_SEPARATE_BSS if SPL
 
 config NDS32
 	bool "NDS32 architecture"
@@ -112,6 +113,7 @@ config RISCV
 	select SUPPORT_OF_CONTROL
 	select OF_CONTROL
 	select DM
+	select SPL_SEPARATE_BSS if SPL
 	imply DM_SERIAL
 	imply DM_ETH
 	imply DM_EVENT
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index f277929c99..92bd189c95 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -8,6 +8,7 @@ config ARM64
 	bool
 	select PHYS_64BIT
 	select SYS_CACHE_SHIFT_6
+	imply SPL_SEPARATE_BSS
 
 config ARM64_CRC32
 	bool "Enable support for CRC32 instruction"
@@ -267,6 +268,7 @@ config CPU_ARM926EJS
 	bool
 	select SYS_CACHE_SHIFT_5
 	imply SYS_ARM_MMU
+	imply SPL_SEPARATE_BSS
 
 config CPU_ARM946ES
 	bool
@@ -277,6 +279,7 @@ config CPU_ARM1136
 	bool
 	select SYS_CACHE_SHIFT_5
 	imply SYS_ARM_MMU
+	imply SPL_SEPARATE_BSS
 
 config CPU_ARM1176
 	bool
@@ -624,6 +627,7 @@ config ARCH_ORION5X
 	bool "Marvell Orion"
 	select CPU_ARM926EJS
 	select GPIO_EXTRA_HEADER
+	select SPL_SEPARATE_BSS if SPL
 
 config TARGET_STV0991
 	bool "Support stv0991"
@@ -814,6 +818,7 @@ config ARCH_OMAP2PLUS
 	imply TI_SYSC if DM && OF_CONTROL
 	imply FIT
 	imply DM_EVENT
+	imply SPL_SEPARATE_BSS
 
 config ARCH_MESON
 	bool "Amlogic Meson"
@@ -954,6 +959,7 @@ config ARCH_MX6
 	select SYS_FSL_SEC_LE
 	imply MXC_GPIO
 	imply SYS_THUMB_BUILD
+	imply SPL_SEPARATE_BSS
 
 if ARCH_MX6
 config SPL_LDSCRIPT
-- 
2.35.1.1320.gc452695387.dirty

Re: [PATCH v2] treewide: Enable SPL_SEPARATE_BSS if SPL_BSS_START_ADDR is used

[Tom Rini]

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

On Tue, Apr 12, 2022 at 10:59:04AM -0400, Sean Anderson wrote:

> If .bss does not immediately follow the end of the image, then
> CONFIG_SPL_SEPARATE_BSS must be selected. Typically, the location of bss
> is specified by using CONFIG_SPL_BSS_START_ADDR in a linker script. On
> these arches, CONFIG_SPL_SEPARATE_BSS should be enabled. If there is an
> option to use an alternate boot script (e.g. CONFIG_SPL_LDSCRIPT is just
> a default), just imply. If there is not, select.
> 
> Signed-off-by: Sean Anderson <sean.anderson@seco.com>

Applied to u-boot/master, thanks!

-- 
Tom

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]