* [PATCH] ASoC: soc-ops: fix error handling
@ 2022-04-21 16:23 Pierre-Louis Bossart
2022-04-21 19:18 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Pierre-Louis Bossart @ 2022-04-21 16:23 UTC (permalink / raw)
To: alsa-devel
Cc: tiwai, Bard Liao, Pierre-Louis Bossart, Rander Wang, broonie,
Péter Ujfalusi
cppcheck throws the following warning:
sound/soc/soc-ops.c:461:8: style: Variable 'ret' is assigned a value
that is never used. [unreadVariable]
ret = err;
^
This seems to be a missing change in the return value.
Fixes: 7f3d90a351968 ("ASoC: ops: Fix stereo change notifications in snd_soc_put_volsw_sx()")
Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Péter Ujfalusi <peter.ujfalusi@linux.intel.com>
---
sound/soc/soc-ops.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/soc-ops.c b/sound/soc/soc-ops.c
index a0ca58ba16273..58347eadd219b 100644
--- a/sound/soc/soc-ops.c
+++ b/sound/soc/soc-ops.c
@@ -461,7 +461,7 @@ int snd_soc_put_volsw_sx(struct snd_kcontrol *kcontrol,
ret = err;
}
}
- return err;
+ return ret;
}
EXPORT_SYMBOL_GPL(snd_soc_put_volsw_sx);
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ASoC: soc-ops: fix error handling
2022-04-21 16:23 [PATCH] ASoC: soc-ops: fix error handling Pierre-Louis Bossart
@ 2022-04-21 19:18 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2022-04-21 19:18 UTC (permalink / raw)
To: pierre-louis.bossart, alsa-devel
Cc: tiwai, peter.ujfalusi, yung-chuan.liao, rander.wang
On Thu, 21 Apr 2022 11:23:28 -0500, Pierre-Louis Bossart wrote:
> cppcheck throws the following warning:
>
> sound/soc/soc-ops.c:461:8: style: Variable 'ret' is assigned a value
> that is never used. [unreadVariable]
> ret = err;
> ^
>
> [...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: soc-ops: fix error handling
commit: eb5773201b1c5d603424bd21f161c8c2d1075b42
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-21 19:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 16:23 [PATCH] ASoC: soc-ops: fix error handling Pierre-Louis Bossart
2022-04-21 19:18 ` Mark Brown
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.