* [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
@ 2022-04-21 13:22 kernel test robot
2022-04-21 13:48 ` Miquel Raynal
0 siblings, 1 reply; 11+ messages in thread
From: kernel test robot @ 2022-04-21 13:22 UTC (permalink / raw)
To: Jean-Marc Eurin; +Cc: llvm, kbuild-all, linux-kernel, Miquel Raynal
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
head: f812679fab605b3d5b853ed24a81dabb222ea23a
commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
git fetch --no-tags mtd mtd/next
git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
>> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
page * record_size, retlen, sizeof(hdr), ret);
^~~~~~~~~~~
include/linux/printk.h:446:60: note: expanded from macro 'printk'
#define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
~~~ ^~~~~~~~~~~
include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
_p_func(_fmt, ##__VA_ARGS__); \
~~~~ ^~~~~~~~~~~
1 warning generated.
vim +244 drivers/mtd/mtdoops.c
225
226 static void find_next_position(struct mtdoops_context *cxt)
227 {
228 struct mtd_info *mtd = cxt->mtd;
229 struct mtdoops_hdr hdr;
230 int ret, page, maxpos = 0;
231 u32 maxcount = 0xffffffff;
232 size_t retlen;
233
234 for (page = 0; page < cxt->oops_pages; page++) {
235 if (mtd_block_isbad(mtd, page * record_size))
236 continue;
237 /* Assume the page is used */
238 mark_page_used(cxt, page);
239 ret = mtd_read(mtd, page * record_size, sizeof(hdr),
240 &retlen, (u_char *)&hdr);
241 if (retlen != sizeof(hdr) ||
242 (ret < 0 && !mtd_is_bitflip(ret))) {
243 printk(KERN_ERR "mtdoops: read failure at %ld (%td of %ld read), err %d\n",
> 244 page * record_size, retlen, sizeof(hdr), ret);
245 continue;
246 }
247
248 if (hdr.seq == 0xffffffff && hdr.magic == 0xffffffff)
249 mark_page_unused(cxt, page);
250 if (hdr.seq == 0xffffffff || hdr.magic != MTDOOPS_KERNMSG_MAGIC)
251 continue;
252 if (maxcount == 0xffffffff) {
253 maxcount = hdr.seq;
254 maxpos = page;
255 } else if (hdr.seq < 0x40000000 && maxcount > 0xc0000000) {
256 maxcount = hdr.seq;
257 maxpos = page;
258 } else if (hdr.seq > maxcount && hdr.seq < 0xc0000000) {
259 maxcount = hdr.seq;
260 maxpos = page;
261 } else if (hdr.seq > maxcount && hdr.seq > 0xc0000000
262 && maxcount > 0x80000000) {
263 maxcount = hdr.seq;
264 maxpos = page;
265 }
266 }
267 if (maxcount == 0xffffffff) {
268 cxt->nextpage = cxt->oops_pages - 1;
269 cxt->nextcount = 0;
270 }
271 else {
272 cxt->nextpage = maxpos;
273 cxt->nextcount = maxcount;
274 }
275
276 mtdoops_inc_counter(cxt);
277 }
278
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
2022-04-21 13:22 [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' kernel test robot
@ 2022-04-21 13:48 ` Miquel Raynal
0 siblings, 0 replies; 11+ messages in thread
From: Miquel Raynal @ 2022-04-21 13:48 UTC (permalink / raw)
To: kernel test robot; +Cc: Jean-Marc Eurin, llvm, kbuild-all, linux-kernel
Hi Jean-Marc,
lkp@intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> head: f812679fab605b3d5b853ed24a81dabb222ea23a
> commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp@intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> git fetch --no-tags mtd mtd/next
> git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> page * record_size, retlen, sizeof(hdr), ret);
> ^~~~~~~~~~~
> include/linux/printk.h:446:60: note: expanded from macro 'printk'
> #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> ~~~ ^~~~~~~~~~~
> include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> _p_func(_fmt, ##__VA_ARGS__); \
> ~~~~ ^~~~~~~~~~~
> 1 warning generated.
I've dropped the series for now. Please have a look at the reports and
propose a new version when this is fixed?
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
@ 2022-04-21 13:48 ` Miquel Raynal
0 siblings, 0 replies; 11+ messages in thread
From: Miquel Raynal @ 2022-04-21 13:48 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2380 bytes --]
Hi Jean-Marc,
lkp(a)intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> head: f812679fab605b3d5b853ed24a81dabb222ea23a
> commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp(a)intel.com/config)
> compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> reproduce (this is a W=1 build):
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> git fetch --no-tags mtd mtd/next
> git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> # save the config file
> mkdir build_dir && cp config build_dir/.config
> COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
>
> If you fix the issue, kindly add following tag as appropriate
> Reported-by: kernel test robot <lkp@intel.com>
>
> All warnings (new ones prefixed by >>):
>
> >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> page * record_size, retlen, sizeof(hdr), ret);
> ^~~~~~~~~~~
> include/linux/printk.h:446:60: note: expanded from macro 'printk'
> #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> ~~~ ^~~~~~~~~~~
> include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> _p_func(_fmt, ##__VA_ARGS__); \
> ~~~~ ^~~~~~~~~~~
> 1 warning generated.
I've dropped the series for now. Please have a look at the reports and
propose a new version when this is fixed?
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
2022-04-21 13:48 ` Miquel Raynal
@ 2022-04-21 22:22 ` Jean-Marc Eurin
-1 siblings, 0 replies; 11+ messages in thread
From: Jean-Marc Eurin @ 2022-04-21 22:22 UTC (permalink / raw)
To: Miquel Raynal; +Cc: kernel test robot, llvm, kbuild-all, linux-kernel
On Thu, Apr 21, 2022 at 6:48 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Jean-Marc,
>
> lkp@intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> > head: f812679fab605b3d5b853ed24a81dabb222ea23a
> > commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> > config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp@intel.com/config)
> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> > git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> > git fetch --no-tags mtd mtd/next
> > git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> > page * record_size, retlen, sizeof(hdr), ret);
> > ^~~~~~~~~~~
> > include/linux/printk.h:446:60: note: expanded from macro 'printk'
> > #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> > ~~~ ^~~~~~~~~~~
> > include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> > _p_func(_fmt, ##__VA_ARGS__); \
> > ~~~~ ^~~~~~~~~~~
> > 1 warning generated.
>
> I've dropped the series for now. Please have a look at the reports and
> propose a new version when this is fixed?
Sorry about that, I had made that change based on this suggestion
https://lore.kernel.org/all/202203310648.it4f2xXD-lkp@intel.com/ :-)
I'll send another set.
Thanks,
Jean-Marc
>
> Thanks,
> Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
@ 2022-04-21 22:22 ` Jean-Marc Eurin
0 siblings, 0 replies; 11+ messages in thread
From: Jean-Marc Eurin @ 2022-04-21 22:22 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 2731 bytes --]
On Thu, Apr 21, 2022 at 6:48 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Jean-Marc,
>
> lkp(a)intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
>
> > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> > head: f812679fab605b3d5b853ed24a81dabb222ea23a
> > commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> > config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp(a)intel.com/config)
> > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> > reproduce (this is a W=1 build):
> > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > chmod +x ~/bin/make.cross
> > # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> > git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> > git fetch --no-tags mtd mtd/next
> > git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> > # save the config file
> > mkdir build_dir && cp config build_dir/.config
> > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> >
> > If you fix the issue, kindly add following tag as appropriate
> > Reported-by: kernel test robot <lkp@intel.com>
> >
> > All warnings (new ones prefixed by >>):
> >
> > >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> > page * record_size, retlen, sizeof(hdr), ret);
> > ^~~~~~~~~~~
> > include/linux/printk.h:446:60: note: expanded from macro 'printk'
> > #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> > ~~~ ^~~~~~~~~~~
> > include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> > _p_func(_fmt, ##__VA_ARGS__); \
> > ~~~~ ^~~~~~~~~~~
> > 1 warning generated.
>
> I've dropped the series for now. Please have a look at the reports and
> propose a new version when this is fixed?
Sorry about that, I had made that change based on this suggestion
https://lore.kernel.org/all/202203310648.it4f2xXD-lkp(a)intel.com/ :-)
I'll send another set.
Thanks,
Jean-Marc
>
> Thanks,
> Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
2022-04-21 22:22 ` Jean-Marc Eurin
@ 2022-04-22 9:17 ` Miquel Raynal
-1 siblings, 0 replies; 11+ messages in thread
From: Miquel Raynal @ 2022-04-22 9:17 UTC (permalink / raw)
To: Jean-Marc Eurin; +Cc: kernel test robot, llvm, kbuild-all, linux-kernel
Hi Jean-Marc,
jmeurin@google.com wrote on Thu, 21 Apr 2022 15:22:26 -0700:
> On Thu, Apr 21, 2022 at 6:48 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Jean-Marc,
> >
> > lkp@intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
> >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> > > head: f812679fab605b3d5b853ed24a81dabb222ea23a
> > > commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> > > config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp@intel.com/config)
> > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> > > git fetch --no-tags mtd mtd/next
> > > git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > # save the config file
> > > mkdir build_dir && cp config build_dir/.config
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> > > page * record_size, retlen, sizeof(hdr), ret);
> > > ^~~~~~~~~~~
> > > include/linux/printk.h:446:60: note: expanded from macro 'printk'
> > > #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> > > ~~~ ^~~~~~~~~~~
> > > include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> > > _p_func(_fmt, ##__VA_ARGS__); \
> > > ~~~~ ^~~~~~~~~~~
> > > 1 warning generated.
> >
> > I've dropped the series for now. Please have a look at the reports and
> > propose a new version when this is fixed?
>
> Sorry about that, I had made that change based on this suggestion
> https://lore.kernel.org/all/202203310648.it4f2xXD-lkp@intel.com/ :-)
Did you verify with
> > > # save the config file
> > > mkdir build_dir && cp config build_dir/.config
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
That the errors were actually gone? You seem to suggest that you didn't
:)
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
@ 2022-04-22 9:17 ` Miquel Raynal
0 siblings, 0 replies; 11+ messages in thread
From: Miquel Raynal @ 2022-04-22 9:17 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3189 bytes --]
Hi Jean-Marc,
jmeurin(a)google.com wrote on Thu, 21 Apr 2022 15:22:26 -0700:
> On Thu, Apr 21, 2022 at 6:48 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Jean-Marc,
> >
> > lkp(a)intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
> >
> > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> > > head: f812679fab605b3d5b853ed24a81dabb222ea23a
> > > commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> > > config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp(a)intel.com/config)
> > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> > > reproduce (this is a W=1 build):
> > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > chmod +x ~/bin/make.cross
> > > # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> > > git fetch --no-tags mtd mtd/next
> > > git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > # save the config file
> > > mkdir build_dir && cp config build_dir/.config
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> > >
> > > If you fix the issue, kindly add following tag as appropriate
> > > Reported-by: kernel test robot <lkp@intel.com>
> > >
> > > All warnings (new ones prefixed by >>):
> > >
> > > >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> > > page * record_size, retlen, sizeof(hdr), ret);
> > > ^~~~~~~~~~~
> > > include/linux/printk.h:446:60: note: expanded from macro 'printk'
> > > #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> > > ~~~ ^~~~~~~~~~~
> > > include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> > > _p_func(_fmt, ##__VA_ARGS__); \
> > > ~~~~ ^~~~~~~~~~~
> > > 1 warning generated.
> >
> > I've dropped the series for now. Please have a look at the reports and
> > propose a new version when this is fixed?
>
> Sorry about that, I had made that change based on this suggestion
> https://lore.kernel.org/all/202203310648.it4f2xXD-lkp(a)intel.com/ :-)
Did you verify with
> > > # save the config file
> > > mkdir build_dir && cp config build_dir/.config
> > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
That the errors were actually gone? You seem to suggest that you didn't
:)
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
2022-04-22 9:17 ` Miquel Raynal
@ 2022-04-22 19:10 ` Jean-Marc Eurin
-1 siblings, 0 replies; 11+ messages in thread
From: Jean-Marc Eurin @ 2022-04-22 19:10 UTC (permalink / raw)
To: Miquel Raynal; +Cc: kernel test robot, llvm, kbuild-all, linux-kernel
Hi Miquel,
On Fri, Apr 22, 2022 at 2:17 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Jean-Marc,
>
> jmeurin@google.com wrote on Thu, 21 Apr 2022 15:22:26 -0700:
>
> > On Thu, Apr 21, 2022 at 6:48 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > > Hi Jean-Marc,
> > >
> > > lkp@intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
> > >
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> > > > head: f812679fab605b3d5b853ed24a81dabb222ea23a
> > > > commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> > > > config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp@intel.com/config)
> > > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> > > > reproduce (this is a W=1 build):
> > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > chmod +x ~/bin/make.cross
> > > > # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > > git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> > > > git fetch --no-tags mtd mtd/next
> > > > git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > > # save the config file
> > > > mkdir build_dir && cp config build_dir/.config
> > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All warnings (new ones prefixed by >>):
> > > >
> > > > >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> > > > page * record_size, retlen, sizeof(hdr), ret);
> > > > ^~~~~~~~~~~
> > > > include/linux/printk.h:446:60: note: expanded from macro 'printk'
> > > > #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> > > > ~~~ ^~~~~~~~~~~
> > > > include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> > > > _p_func(_fmt, ##__VA_ARGS__); \
> > > > ~~~~ ^~~~~~~~~~~
> > > > 1 warning generated.
> > >
> > > I've dropped the series for now. Please have a look at the reports and
> > > propose a new version when this is fixed?
> >
> > Sorry about that, I had made that change based on this suggestion
> > https://lore.kernel.org/all/202203310648.it4f2xXD-lkp@intel.com/ :-)
>
> Did you verify with
>
> > > > # save the config file
> > > > mkdir build_dir && cp config build_dir/.config
> > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
>
> That the errors were actually gone? You seem to suggest that you didn't
> :)
I did run it. I believe the issue is because the field is a size_t so
when building 64 bits like the first bot on v2, the %ld suggestion
compiled but then it failed the hexagon build (which I'm guessing is
32 bit). Using %zu in v4 builds both versions (ARCH=x86_64 and
hexagon). I should have double checked the bot suggestion and noticed
this was a sizeof / size_t field, sorry about that.
Thanks,
Jean-Marc
>
> Thanks,
> Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
@ 2022-04-22 19:10 ` Jean-Marc Eurin
0 siblings, 0 replies; 11+ messages in thread
From: Jean-Marc Eurin @ 2022-04-22 19:10 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 3818 bytes --]
Hi Miquel,
On Fri, Apr 22, 2022 at 2:17 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
>
> Hi Jean-Marc,
>
> jmeurin(a)google.com wrote on Thu, 21 Apr 2022 15:22:26 -0700:
>
> > On Thu, Apr 21, 2022 at 6:48 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > >
> > > Hi Jean-Marc,
> > >
> > > lkp(a)intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
> > >
> > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> > > > head: f812679fab605b3d5b853ed24a81dabb222ea23a
> > > > commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> > > > config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp(a)intel.com/config)
> > > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> > > > reproduce (this is a W=1 build):
> > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > chmod +x ~/bin/make.cross
> > > > # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > > git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> > > > git fetch --no-tags mtd mtd/next
> > > > git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > > # save the config file
> > > > mkdir build_dir && cp config build_dir/.config
> > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> > > >
> > > > If you fix the issue, kindly add following tag as appropriate
> > > > Reported-by: kernel test robot <lkp@intel.com>
> > > >
> > > > All warnings (new ones prefixed by >>):
> > > >
> > > > >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> > > > page * record_size, retlen, sizeof(hdr), ret);
> > > > ^~~~~~~~~~~
> > > > include/linux/printk.h:446:60: note: expanded from macro 'printk'
> > > > #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> > > > ~~~ ^~~~~~~~~~~
> > > > include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> > > > _p_func(_fmt, ##__VA_ARGS__); \
> > > > ~~~~ ^~~~~~~~~~~
> > > > 1 warning generated.
> > >
> > > I've dropped the series for now. Please have a look at the reports and
> > > propose a new version when this is fixed?
> >
> > Sorry about that, I had made that change based on this suggestion
> > https://lore.kernel.org/all/202203310648.it4f2xXD-lkp(a)intel.com/ :-)
>
> Did you verify with
>
> > > > # save the config file
> > > > mkdir build_dir && cp config build_dir/.config
> > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
>
> That the errors were actually gone? You seem to suggest that you didn't
> :)
I did run it. I believe the issue is because the field is a size_t so
when building 64 bits like the first bot on v2, the %ld suggestion
compiled but then it failed the hexagon build (which I'm guessing is
32 bit). Using %zu in v4 builds both versions (ARCH=x86_64 and
hexagon). I should have double checked the bot suggestion and noticed
this was a sizeof / size_t field, sorry about that.
Thanks,
Jean-Marc
>
> Thanks,
> Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
2022-04-22 19:10 ` Jean-Marc Eurin
@ 2022-04-25 8:18 ` Miquel Raynal
-1 siblings, 0 replies; 11+ messages in thread
From: Miquel Raynal @ 2022-04-25 8:18 UTC (permalink / raw)
To: Jean-Marc Eurin; +Cc: kernel test robot, llvm, kbuild-all, linux-kernel
Hi Jean-Marc,
jmeurin@google.com wrote on Fri, 22 Apr 2022 12:10:13 -0700:
> Hi Miquel,
>
> On Fri, Apr 22, 2022 at 2:17 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Jean-Marc,
> >
> > jmeurin@google.com wrote on Thu, 21 Apr 2022 15:22:26 -0700:
> >
> > > On Thu, Apr 21, 2022 at 6:48 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > >
> > > > Hi Jean-Marc,
> > > >
> > > > lkp@intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
> > > >
> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> > > > > head: f812679fab605b3d5b853ed24a81dabb222ea23a
> > > > > commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> > > > > config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp@intel.com/config)
> > > > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> > > > > reproduce (this is a W=1 build):
> > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > > chmod +x ~/bin/make.cross
> > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > > > git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> > > > > git fetch --no-tags mtd mtd/next
> > > > > git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > > > # save the config file
> > > > > mkdir build_dir && cp config build_dir/.config
> > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> > > > >
> > > > > If you fix the issue, kindly add following tag as appropriate
> > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > >
> > > > > All warnings (new ones prefixed by >>):
> > > > >
> > > > > >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> > > > > page * record_size, retlen, sizeof(hdr), ret);
> > > > > ^~~~~~~~~~~
> > > > > include/linux/printk.h:446:60: note: expanded from macro 'printk'
> > > > > #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> > > > > ~~~ ^~~~~~~~~~~
> > > > > include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> > > > > _p_func(_fmt, ##__VA_ARGS__); \
> > > > > ~~~~ ^~~~~~~~~~~
> > > > > 1 warning generated.
> > > >
> > > > I've dropped the series for now. Please have a look at the reports and
> > > > propose a new version when this is fixed?
> > >
> > > Sorry about that, I had made that change based on this suggestion
> > > https://lore.kernel.org/all/202203310648.it4f2xXD-lkp@intel.com/ :-)
> >
> > Did you verify with
> >
> > > > > # save the config file
> > > > > mkdir build_dir && cp config build_dir/.config
> > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> >
> > That the errors were actually gone? You seem to suggest that you didn't
> > :)
>
> I did run it. I believe the issue is because the field is a size_t so
> when building 64 bits like the first bot on v2, the %ld suggestion
> compiled but then it failed the hexagon build (which I'm guessing is
> 32 bit). Using %zu in v4 builds both versions (ARCH=x86_64 and
> hexagon). I should have double checked the bot suggestion and noticed
> this was a sizeof / size_t field, sorry about that.
No problem at all, it often happens to me as well.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int'
@ 2022-04-25 8:18 ` Miquel Raynal
0 siblings, 0 replies; 11+ messages in thread
From: Miquel Raynal @ 2022-04-25 8:18 UTC (permalink / raw)
To: kbuild-all
[-- Attachment #1: Type: text/plain, Size: 4078 bytes --]
Hi Jean-Marc,
jmeurin(a)google.com wrote on Fri, 22 Apr 2022 12:10:13 -0700:
> Hi Miquel,
>
> On Fri, Apr 22, 2022 at 2:17 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> >
> > Hi Jean-Marc,
> >
> > jmeurin(a)google.com wrote on Thu, 21 Apr 2022 15:22:26 -0700:
> >
> > > On Thu, Apr 21, 2022 at 6:48 AM Miquel Raynal <miquel.raynal@bootlin.com> wrote:
> > > >
> > > > Hi Jean-Marc,
> > > >
> > > > lkp(a)intel.com wrote on Thu, 21 Apr 2022 21:22:47 +0800:
> > > >
> > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/next
> > > > > head: f812679fab605b3d5b853ed24a81dabb222ea23a
> > > > > commit: 0629fcef16d703d384f76cb2c2c3a119a9149a34 [10/11] mtd: mtdoops: Create a header structure for the saved mtdoops.
> > > > > config: hexagon-randconfig-r045-20220420 (https://download.01.org/0day-ci/archive/20220421/202204212106.9R1ylUB7-lkp(a)intel.com/config)
> > > > > compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project bac6cd5bf85669e3376610cfc4c4f9ca015e7b9b)
> > > > > reproduce (this is a W=1 build):
> > > > > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> > > > > chmod +x ~/bin/make.cross
> > > > > # https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git/commit/?id=0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > > > git remote add mtd https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git
> > > > > git fetch --no-tags mtd mtd/next
> > > > > git checkout 0629fcef16d703d384f76cb2c2c3a119a9149a34
> > > > > # save the config file
> > > > > mkdir build_dir && cp config build_dir/.config
> > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> > > > >
> > > > > If you fix the issue, kindly add following tag as appropriate
> > > > > Reported-by: kernel test robot <lkp@intel.com>
> > > > >
> > > > > All warnings (new ones prefixed by >>):
> > > > >
> > > > > >> drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' [-Wformat]
> > > > > page * record_size, retlen, sizeof(hdr), ret);
> > > > > ^~~~~~~~~~~
> > > > > include/linux/printk.h:446:60: note: expanded from macro 'printk'
> > > > > #define printk(fmt, ...) printk_index_wrap(_printk, fmt, ##__VA_ARGS__)
> > > > > ~~~ ^~~~~~~~~~~
> > > > > include/linux/printk.h:418:19: note: expanded from macro 'printk_index_wrap'
> > > > > _p_func(_fmt, ##__VA_ARGS__); \
> > > > > ~~~~ ^~~~~~~~~~~
> > > > > 1 warning generated.
> > > >
> > > > I've dropped the series for now. Please have a look at the reports and
> > > > propose a new version when this is fixed?
> > >
> > > Sorry about that, I had made that change based on this suggestion
> > > https://lore.kernel.org/all/202203310648.it4f2xXD-lkp(a)intel.com/ :-)
> >
> > Did you verify with
> >
> > > > > # save the config file
> > > > > mkdir build_dir && cp config build_dir/.config
> > > > > COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash drivers/mtd/
> >
> > That the errors were actually gone? You seem to suggest that you didn't
> > :)
>
> I did run it. I believe the issue is because the field is a size_t so
> when building 64 bits like the first bot on v2, the %ld suggestion
> compiled but then it failed the hexagon build (which I'm guessing is
> 32 bit). Using %zu in v4 builds both versions (ARCH=x86_64 and
> hexagon). I should have double checked the bot suggestion and noticed
> this was a sizeof / size_t field, sorry about that.
No problem at all, it often happens to me as well.
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2022-04-25 8:18 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-21 13:22 [mtd:mtd/next 10/11] drivers/mtd/mtdoops.c:244:39: warning: format specifies type 'long' but the argument has type 'unsigned int' kernel test robot
2022-04-21 13:48 ` Miquel Raynal
2022-04-21 13:48 ` Miquel Raynal
2022-04-21 22:22 ` Jean-Marc Eurin
2022-04-21 22:22 ` Jean-Marc Eurin
2022-04-22 9:17 ` Miquel Raynal
2022-04-22 9:17 ` Miquel Raynal
2022-04-22 19:10 ` Jean-Marc Eurin
2022-04-22 19:10 ` Jean-Marc Eurin
2022-04-25 8:18 ` Miquel Raynal
2022-04-25 8:18 ` Miquel Raynal
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.