* [PATCH 0/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-22 12:10 ` Allen-KH Cheng
0 siblings, 0 replies; 23+ messages in thread
From: Allen-KH Cheng @ 2022-04-22 12:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee, Allen-KH Cheng
Based on kernel/git/groeck/linux-staging.git, watchdog-next
Add align watchdog node name with dtschema PATCH to fix dtbs_check warnings.
Allen-KH Cheng (2):
arm64: dts: mt8516: align watchdog node name with dtschema
dt-bindings: watchdog: mediatek: Convert binding to YAML
.../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
.../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
3 files changed, 77 insertions(+), 43 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
--
2.18.0
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 0/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-22 12:10 ` Allen-KH Cheng
0 siblings, 0 replies; 23+ messages in thread
From: Allen-KH Cheng @ 2022-04-22 12:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee, Allen-KH Cheng
Based on kernel/git/groeck/linux-staging.git, watchdog-next
Add align watchdog node name with dtschema PATCH to fix dtbs_check warnings.
Allen-KH Cheng (2):
arm64: dts: mt8516: align watchdog node name with dtschema
dt-bindings: watchdog: mediatek: Convert binding to YAML
.../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
.../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
3 files changed, 77 insertions(+), 43 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 0/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-22 12:10 ` Allen-KH Cheng
0 siblings, 0 replies; 23+ messages in thread
From: Allen-KH Cheng @ 2022-04-22 12:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee, Allen-KH Cheng
Based on kernel/git/groeck/linux-staging.git, watchdog-next
Add align watchdog node name with dtschema PATCH to fix dtbs_check warnings.
Allen-KH Cheng (2):
arm64: dts: mt8516: align watchdog node name with dtschema
dt-bindings: watchdog: mediatek: Convert binding to YAML
.../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
.../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
3 files changed, 77 insertions(+), 43 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread
* [PATCH 1/2] arm64: dts: mt8516: align watchdog node name with dtschema
2022-04-22 12:10 ` Allen-KH Cheng
(?)
@ 2022-04-22 12:10 ` Allen-KH Cheng
-1 siblings, 0 replies; 23+ messages in thread
From: Allen-KH Cheng @ 2022-04-22 12:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee, Allen-KH Cheng
Based on watchdog.yaml, the node names should be "watchdog".
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
index d1b67c82d761..fff59dc1b4d7 100644
--- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
@@ -202,7 +202,7 @@
#clock-cells = <1>;
};
- toprgu: toprgu@10007000 {
+ toprgu: watchdog@10007000 {
compatible = "mediatek,mt8516-wdt",
"mediatek,mt6589-wdt";
reg = <0 0x10007000 0 0x1000>;
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 1/2] arm64: dts: mt8516: align watchdog node name with dtschema
@ 2022-04-22 12:10 ` Allen-KH Cheng
0 siblings, 0 replies; 23+ messages in thread
From: Allen-KH Cheng @ 2022-04-22 12:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee, Allen-KH Cheng
Based on watchdog.yaml, the node names should be "watchdog".
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
index d1b67c82d761..fff59dc1b4d7 100644
--- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
@@ -202,7 +202,7 @@
#clock-cells = <1>;
};
- toprgu: toprgu@10007000 {
+ toprgu: watchdog@10007000 {
compatible = "mediatek,mt8516-wdt",
"mediatek,mt6589-wdt";
reg = <0 0x10007000 0 0x1000>;
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 1/2] arm64: dts: mt8516: align watchdog node name with dtschema
@ 2022-04-22 12:10 ` Allen-KH Cheng
0 siblings, 0 replies; 23+ messages in thread
From: Allen-KH Cheng @ 2022-04-22 12:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee, Allen-KH Cheng
Based on watchdog.yaml, the node names should be "watchdog".
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
arch/arm64/boot/dts/mediatek/mt8516.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/mediatek/mt8516.dtsi b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
index d1b67c82d761..fff59dc1b4d7 100644
--- a/arch/arm64/boot/dts/mediatek/mt8516.dtsi
+++ b/arch/arm64/boot/dts/mediatek/mt8516.dtsi
@@ -202,7 +202,7 @@
#clock-cells = <1>;
};
- toprgu: toprgu@10007000 {
+ toprgu: watchdog@10007000 {
compatible = "mediatek,mt8516-wdt",
"mediatek,mt6589-wdt";
reg = <0 0x10007000 0 0x1000>;
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
2022-04-22 12:10 ` Allen-KH Cheng
(?)
@ 2022-04-22 12:10 ` Allen-KH Cheng
-1 siblings, 0 replies; 23+ messages in thread
From: Allen-KH Cheng @ 2022-04-22 12:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee, Allen-KH Cheng
Convert Mediatek watchdog devicetree binding to YAML.
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
.../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
.../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
2 files changed, 76 insertions(+), 42 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
deleted file mode 100644
index 762c62e428ef..000000000000
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ /dev/null
@@ -1,42 +0,0 @@
-Mediatek SoCs Watchdog timer
-
-The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
-before the expiry.
-
-Required properties:
-
-- compatible should contain:
- "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
- "mediatek,mt2712-wdt": for MT2712
- "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
- "mediatek,mt6589-wdt": for MT6589
- "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
- "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
- "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
- "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
- "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
- "mediatek,mt8183-wdt": for MT8183
- "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
- "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
- "mediatek,mt8192-wdt": for MT8192
- "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
-
-- reg : Specifies base physical address and size of the registers.
-
-Optional properties:
-- mediatek,disable-extrst: disable send output reset signal
-- interrupts: Watchdog pre-timeout (bark) interrupt.
-- timeout-sec: contains the watchdog timeout in seconds.
-- #reset-cells: Should be 1.
-
-Example:
-
-watchdog: watchdog@10007000 {
- compatible = "mediatek,mt8183-wdt",
- "mediatek,mt6589-wdt";
- mediatek,disable-extrst;
- reg = <0 0x10007000 0 0x100>;
- interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
- timeout-sec = <10>;
- #reset-cells = <1>;
-};
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
new file mode 100644
index 000000000000..5788617027c8
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/mtk-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek SoCs Watchdog timer
+
+maintainers:
+ - Runyang Chen <runyang.chen@mediatek.com>
+ - Allen-KH Cheng <allen-kh.cheng@mediatek.com>
+
+description: |+
+ The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
+ before the expiry.
+
+allOf:
+ - $ref: "watchdog.yaml#"
+
+properties:
+ compatible:
+ oneOf:
+ - const: mediatek,mt2712-wdt
+ - const: mediatek,mt6589-wdt
+ - const: mediatek,mt8183-wdt
+ - const: mediatek,mt8192-wdt
+
+ - items:
+ - enum:
+ - mediatek,mt2701-wdt
+ - mediatek,mt6582-wdt
+ - mediatek,mt6797-wdt
+ - mediatek,mt7622-wdt
+ - mediatek,mt7623-wdt
+ - mediatek,mt7629-wdt
+ - mediatek,mt7986-wdt
+ - mediatek,mt8173-wdt
+ - mediatek,mt8183-wdt
+ - mediatek,mt8186-wdt
+ - mediatek,mt8192-wdt
+ - mediatek,mt8195-wdt
+ - mediatek,mt8516-wdt
+ - const: mediatek,mt6589-wdt
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ '#reset-cells':
+ const: 1
+
+ timeout-sec: true
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ watchdog@10007000 {
+ compatible = "mediatek,mt8183-wdt",
+ "mediatek,mt6589-wdt";
+ mediatek,disable-extrst;
+ reg = <0x10007000 0x100>;
+ interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
+ timeout-sec = <10>;
+ #reset-cells = <1>;
+ };
+
+...
--
2.18.0
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-22 12:10 ` Allen-KH Cheng
0 siblings, 0 replies; 23+ messages in thread
From: Allen-KH Cheng @ 2022-04-22 12:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee, Allen-KH Cheng
Convert Mediatek watchdog devicetree binding to YAML.
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
.../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
.../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
2 files changed, 76 insertions(+), 42 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
deleted file mode 100644
index 762c62e428ef..000000000000
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ /dev/null
@@ -1,42 +0,0 @@
-Mediatek SoCs Watchdog timer
-
-The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
-before the expiry.
-
-Required properties:
-
-- compatible should contain:
- "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
- "mediatek,mt2712-wdt": for MT2712
- "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
- "mediatek,mt6589-wdt": for MT6589
- "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
- "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
- "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
- "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
- "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
- "mediatek,mt8183-wdt": for MT8183
- "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
- "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
- "mediatek,mt8192-wdt": for MT8192
- "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
-
-- reg : Specifies base physical address and size of the registers.
-
-Optional properties:
-- mediatek,disable-extrst: disable send output reset signal
-- interrupts: Watchdog pre-timeout (bark) interrupt.
-- timeout-sec: contains the watchdog timeout in seconds.
-- #reset-cells: Should be 1.
-
-Example:
-
-watchdog: watchdog@10007000 {
- compatible = "mediatek,mt8183-wdt",
- "mediatek,mt6589-wdt";
- mediatek,disable-extrst;
- reg = <0 0x10007000 0 0x100>;
- interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
- timeout-sec = <10>;
- #reset-cells = <1>;
-};
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
new file mode 100644
index 000000000000..5788617027c8
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/mtk-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek SoCs Watchdog timer
+
+maintainers:
+ - Runyang Chen <runyang.chen@mediatek.com>
+ - Allen-KH Cheng <allen-kh.cheng@mediatek.com>
+
+description: |+
+ The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
+ before the expiry.
+
+allOf:
+ - $ref: "watchdog.yaml#"
+
+properties:
+ compatible:
+ oneOf:
+ - const: mediatek,mt2712-wdt
+ - const: mediatek,mt6589-wdt
+ - const: mediatek,mt8183-wdt
+ - const: mediatek,mt8192-wdt
+
+ - items:
+ - enum:
+ - mediatek,mt2701-wdt
+ - mediatek,mt6582-wdt
+ - mediatek,mt6797-wdt
+ - mediatek,mt7622-wdt
+ - mediatek,mt7623-wdt
+ - mediatek,mt7629-wdt
+ - mediatek,mt7986-wdt
+ - mediatek,mt8173-wdt
+ - mediatek,mt8183-wdt
+ - mediatek,mt8186-wdt
+ - mediatek,mt8192-wdt
+ - mediatek,mt8195-wdt
+ - mediatek,mt8516-wdt
+ - const: mediatek,mt6589-wdt
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ '#reset-cells':
+ const: 1
+
+ timeout-sec: true
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ watchdog@10007000 {
+ compatible = "mediatek,mt8183-wdt",
+ "mediatek,mt6589-wdt";
+ mediatek,disable-extrst;
+ reg = <0x10007000 0x100>;
+ interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
+ timeout-sec = <10>;
+ #reset-cells = <1>;
+ };
+
+...
--
2.18.0
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply related [flat|nested] 23+ messages in thread
* [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-22 12:10 ` Allen-KH Cheng
0 siblings, 0 replies; 23+ messages in thread
From: Allen-KH Cheng @ 2022-04-22 12:10 UTC (permalink / raw)
To: Wim Van Sebroeck, Guenter Roeck, Krzysztof Kozlowski,
Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee, Allen-KH Cheng
Convert Mediatek watchdog devicetree binding to YAML.
Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
---
.../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
.../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
2 files changed, 76 insertions(+), 42 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
deleted file mode 100644
index 762c62e428ef..000000000000
--- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
+++ /dev/null
@@ -1,42 +0,0 @@
-Mediatek SoCs Watchdog timer
-
-The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
-before the expiry.
-
-Required properties:
-
-- compatible should contain:
- "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
- "mediatek,mt2712-wdt": for MT2712
- "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
- "mediatek,mt6589-wdt": for MT6589
- "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
- "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
- "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
- "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
- "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
- "mediatek,mt8183-wdt": for MT8183
- "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
- "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
- "mediatek,mt8192-wdt": for MT8192
- "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
-
-- reg : Specifies base physical address and size of the registers.
-
-Optional properties:
-- mediatek,disable-extrst: disable send output reset signal
-- interrupts: Watchdog pre-timeout (bark) interrupt.
-- timeout-sec: contains the watchdog timeout in seconds.
-- #reset-cells: Should be 1.
-
-Example:
-
-watchdog: watchdog@10007000 {
- compatible = "mediatek,mt8183-wdt",
- "mediatek,mt6589-wdt";
- mediatek,disable-extrst;
- reg = <0 0x10007000 0 0x100>;
- interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
- timeout-sec = <10>;
- #reset-cells = <1>;
-};
diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
new file mode 100644
index 000000000000..5788617027c8
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
@@ -0,0 +1,76 @@
+# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/mtk-wdt.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Mediatek SoCs Watchdog timer
+
+maintainers:
+ - Runyang Chen <runyang.chen@mediatek.com>
+ - Allen-KH Cheng <allen-kh.cheng@mediatek.com>
+
+description: |+
+ The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
+ before the expiry.
+
+allOf:
+ - $ref: "watchdog.yaml#"
+
+properties:
+ compatible:
+ oneOf:
+ - const: mediatek,mt2712-wdt
+ - const: mediatek,mt6589-wdt
+ - const: mediatek,mt8183-wdt
+ - const: mediatek,mt8192-wdt
+
+ - items:
+ - enum:
+ - mediatek,mt2701-wdt
+ - mediatek,mt6582-wdt
+ - mediatek,mt6797-wdt
+ - mediatek,mt7622-wdt
+ - mediatek,mt7623-wdt
+ - mediatek,mt7629-wdt
+ - mediatek,mt7986-wdt
+ - mediatek,mt8173-wdt
+ - mediatek,mt8183-wdt
+ - mediatek,mt8186-wdt
+ - mediatek,mt8192-wdt
+ - mediatek,mt8195-wdt
+ - mediatek,mt8516-wdt
+ - const: mediatek,mt6589-wdt
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ '#reset-cells':
+ const: 1
+
+ timeout-sec: true
+
+required:
+ - compatible
+ - reg
+
+unevaluatedProperties: false
+
+examples:
+ - |
+ #include <dt-bindings/interrupt-controller/arm-gic.h>
+
+ watchdog@10007000 {
+ compatible = "mediatek,mt8183-wdt",
+ "mediatek,mt6589-wdt";
+ mediatek,disable-extrst;
+ reg = <0x10007000 0x100>;
+ interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
+ timeout-sec = <10>;
+ #reset-cells = <1>;
+ };
+
+...
--
2.18.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
2022-04-22 12:10 ` Allen-KH Cheng
(?)
@ 2022-04-22 15:44 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-22 15:44 UTC (permalink / raw)
To: Allen-KH Cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On 22/04/2022 14:10, Allen-KH Cheng wrote:
> Convert Mediatek watchdog devicetree binding to YAML.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
> .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
> .../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
> 2 files changed, 76 insertions(+), 42 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> deleted file mode 100644
> index 762c62e428ef..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -Mediatek SoCs Watchdog timer
> -
> -The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> -before the expiry.
> -
> -Required properties:
> -
> -- compatible should contain:
> - "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> - "mediatek,mt2712-wdt": for MT2712
> - "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
> - "mediatek,mt6589-wdt": for MT6589
> - "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> - "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> - "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> - "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> - "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
> - "mediatek,mt8183-wdt": for MT8183
> - "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> - "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
> - "mediatek,mt8192-wdt": for MT8192
> - "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
> -
> -- reg : Specifies base physical address and size of the registers.
> -
> -Optional properties:
> -- mediatek,disable-extrst: disable send output reset signal
> -- interrupts: Watchdog pre-timeout (bark) interrupt.
> -- timeout-sec: contains the watchdog timeout in seconds.
> -- #reset-cells: Should be 1.
> -
> -Example:
> -
> -watchdog: watchdog@10007000 {
> - compatible = "mediatek,mt8183-wdt",
> - "mediatek,mt6589-wdt";
> - mediatek,disable-extrst;
> - reg = <0 0x10007000 0 0x100>;
> - interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
> - timeout-sec = <10>;
> - #reset-cells = <1>;
> -};
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> new file mode 100644
> index 000000000000..5788617027c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/mtk-wdt.yaml#
File name: mtk,wdt.yaml
I assume all future MediaTek watchdogs (even these unpublished and
developed in some years) will fit into this schema. :) If not, then
maybe better to name the file by the compatible... but it's not a must.
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek SoCs Watchdog timer
> +
> +maintainers:
> + - Runyang Chen <runyang.chen@mediatek.com>
> + - Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> +
> +description: |+
> + The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> + before the expiry.
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: mediatek,mt2712-wdt
> + - const: mediatek,mt6589-wdt
> + - const: mediatek,mt8183-wdt
> + - const: mediatek,mt8192-wdt
All these four entries should be an enum.
> +
> + - items:
> + - enum:
> + - mediatek,mt2701-wdt
> + - mediatek,mt6582-wdt
> + - mediatek,mt6797-wdt
> + - mediatek,mt7622-wdt
> + - mediatek,mt7623-wdt
> + - mediatek,mt7629-wdt
> + - mediatek,mt7986-wdt
> + - mediatek,mt8173-wdt
> + - mediatek,mt8183-wdt
> + - mediatek,mt8186-wdt
> + - mediatek,mt8192-wdt
> + - mediatek,mt8195-wdt
> + - mediatek,mt8516-wdt
> + - const: mediatek,mt6589-wdt
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + timeout-sec: true
You do not need this, it's coming from watchdog schema.
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + watchdog@10007000 {
> + compatible = "mediatek,mt8183-wdt",
> + "mediatek,mt6589-wdt";
> + mediatek,disable-extrst;
Did you test your bindings? Does not look like. Please run
dt_binding_check (see writing-schema for instructions).
> + reg = <0x10007000 0x100>;
> + interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
Wrong interrupt flag.
> + timeout-sec = <10>;
> + #reset-cells = <1>;
> + };
> +
> +...
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-22 15:44 ` Krzysztof Kozlowski
0 siblings, 0 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-22 15:44 UTC (permalink / raw)
To: Allen-KH Cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On 22/04/2022 14:10, Allen-KH Cheng wrote:
> Convert Mediatek watchdog devicetree binding to YAML.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
> .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
> .../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
> 2 files changed, 76 insertions(+), 42 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> deleted file mode 100644
> index 762c62e428ef..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -Mediatek SoCs Watchdog timer
> -
> -The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> -before the expiry.
> -
> -Required properties:
> -
> -- compatible should contain:
> - "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> - "mediatek,mt2712-wdt": for MT2712
> - "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
> - "mediatek,mt6589-wdt": for MT6589
> - "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> - "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> - "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> - "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> - "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
> - "mediatek,mt8183-wdt": for MT8183
> - "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> - "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
> - "mediatek,mt8192-wdt": for MT8192
> - "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
> -
> -- reg : Specifies base physical address and size of the registers.
> -
> -Optional properties:
> -- mediatek,disable-extrst: disable send output reset signal
> -- interrupts: Watchdog pre-timeout (bark) interrupt.
> -- timeout-sec: contains the watchdog timeout in seconds.
> -- #reset-cells: Should be 1.
> -
> -Example:
> -
> -watchdog: watchdog@10007000 {
> - compatible = "mediatek,mt8183-wdt",
> - "mediatek,mt6589-wdt";
> - mediatek,disable-extrst;
> - reg = <0 0x10007000 0 0x100>;
> - interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
> - timeout-sec = <10>;
> - #reset-cells = <1>;
> -};
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> new file mode 100644
> index 000000000000..5788617027c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/mtk-wdt.yaml#
File name: mtk,wdt.yaml
I assume all future MediaTek watchdogs (even these unpublished and
developed in some years) will fit into this schema. :) If not, then
maybe better to name the file by the compatible... but it's not a must.
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek SoCs Watchdog timer
> +
> +maintainers:
> + - Runyang Chen <runyang.chen@mediatek.com>
> + - Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> +
> +description: |+
> + The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> + before the expiry.
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: mediatek,mt2712-wdt
> + - const: mediatek,mt6589-wdt
> + - const: mediatek,mt8183-wdt
> + - const: mediatek,mt8192-wdt
All these four entries should be an enum.
> +
> + - items:
> + - enum:
> + - mediatek,mt2701-wdt
> + - mediatek,mt6582-wdt
> + - mediatek,mt6797-wdt
> + - mediatek,mt7622-wdt
> + - mediatek,mt7623-wdt
> + - mediatek,mt7629-wdt
> + - mediatek,mt7986-wdt
> + - mediatek,mt8173-wdt
> + - mediatek,mt8183-wdt
> + - mediatek,mt8186-wdt
> + - mediatek,mt8192-wdt
> + - mediatek,mt8195-wdt
> + - mediatek,mt8516-wdt
> + - const: mediatek,mt6589-wdt
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + timeout-sec: true
You do not need this, it's coming from watchdog schema.
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + watchdog@10007000 {
> + compatible = "mediatek,mt8183-wdt",
> + "mediatek,mt6589-wdt";
> + mediatek,disable-extrst;
Did you test your bindings? Does not look like. Please run
dt_binding_check (see writing-schema for instructions).
> + reg = <0x10007000 0x100>;
> + interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
Wrong interrupt flag.
> + timeout-sec = <10>;
> + #reset-cells = <1>;
> + };
> +
> +...
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-22 15:44 ` Krzysztof Kozlowski
0 siblings, 0 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-22 15:44 UTC (permalink / raw)
To: Allen-KH Cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On 22/04/2022 14:10, Allen-KH Cheng wrote:
> Convert Mediatek watchdog devicetree binding to YAML.
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
> .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
> .../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
> 2 files changed, 76 insertions(+), 42 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
>
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> deleted file mode 100644
> index 762c62e428ef..000000000000
> --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> +++ /dev/null
> @@ -1,42 +0,0 @@
> -Mediatek SoCs Watchdog timer
> -
> -The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> -before the expiry.
> -
> -Required properties:
> -
> -- compatible should contain:
> - "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> - "mediatek,mt2712-wdt": for MT2712
> - "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
> - "mediatek,mt6589-wdt": for MT6589
> - "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> - "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> - "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> - "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> - "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
> - "mediatek,mt8183-wdt": for MT8183
> - "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> - "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
> - "mediatek,mt8192-wdt": for MT8192
> - "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
> -
> -- reg : Specifies base physical address and size of the registers.
> -
> -Optional properties:
> -- mediatek,disable-extrst: disable send output reset signal
> -- interrupts: Watchdog pre-timeout (bark) interrupt.
> -- timeout-sec: contains the watchdog timeout in seconds.
> -- #reset-cells: Should be 1.
> -
> -Example:
> -
> -watchdog: watchdog@10007000 {
> - compatible = "mediatek,mt8183-wdt",
> - "mediatek,mt6589-wdt";
> - mediatek,disable-extrst;
> - reg = <0 0x10007000 0 0x100>;
> - interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
> - timeout-sec = <10>;
> - #reset-cells = <1>;
> -};
> diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> new file mode 100644
> index 000000000000..5788617027c8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> @@ -0,0 +1,76 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/watchdog/mtk-wdt.yaml#
File name: mtk,wdt.yaml
I assume all future MediaTek watchdogs (even these unpublished and
developed in some years) will fit into this schema. :) If not, then
maybe better to name the file by the compatible... but it's not a must.
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Mediatek SoCs Watchdog timer
> +
> +maintainers:
> + - Runyang Chen <runyang.chen@mediatek.com>
> + - Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> +
> +description: |+
> + The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> + before the expiry.
> +
> +allOf:
> + - $ref: "watchdog.yaml#"
> +
> +properties:
> + compatible:
> + oneOf:
> + - const: mediatek,mt2712-wdt
> + - const: mediatek,mt6589-wdt
> + - const: mediatek,mt8183-wdt
> + - const: mediatek,mt8192-wdt
All these four entries should be an enum.
> +
> + - items:
> + - enum:
> + - mediatek,mt2701-wdt
> + - mediatek,mt6582-wdt
> + - mediatek,mt6797-wdt
> + - mediatek,mt7622-wdt
> + - mediatek,mt7623-wdt
> + - mediatek,mt7629-wdt
> + - mediatek,mt7986-wdt
> + - mediatek,mt8173-wdt
> + - mediatek,mt8183-wdt
> + - mediatek,mt8186-wdt
> + - mediatek,mt8192-wdt
> + - mediatek,mt8195-wdt
> + - mediatek,mt8516-wdt
> + - const: mediatek,mt6589-wdt
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + '#reset-cells':
> + const: 1
> +
> + timeout-sec: true
You do not need this, it's coming from watchdog schema.
> +
> +required:
> + - compatible
> + - reg
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/interrupt-controller/arm-gic.h>
> +
> + watchdog@10007000 {
> + compatible = "mediatek,mt8183-wdt",
> + "mediatek,mt6589-wdt";
> + mediatek,disable-extrst;
Did you test your bindings? Does not look like. Please run
dt_binding_check (see writing-schema for instructions).
> + reg = <0x10007000 0x100>;
> + interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
Wrong interrupt flag.
> + timeout-sec = <10>;
> + #reset-cells = <1>;
> + };
> +
> +...
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mt8516: align watchdog node name with dtschema
2022-04-22 12:10 ` Allen-KH Cheng
(?)
@ 2022-04-22 15:45 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-22 15:45 UTC (permalink / raw)
To: Allen-KH Cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On 22/04/2022 14:10, Allen-KH Cheng wrote:
> Based on watchdog.yaml, the node names should be "watchdog".
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mt8516: align watchdog node name with dtschema
@ 2022-04-22 15:45 ` Krzysztof Kozlowski
0 siblings, 0 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-22 15:45 UTC (permalink / raw)
To: Allen-KH Cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On 22/04/2022 14:10, Allen-KH Cheng wrote:
> Based on watchdog.yaml, the node names should be "watchdog".
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 1/2] arm64: dts: mt8516: align watchdog node name with dtschema
@ 2022-04-22 15:45 ` Krzysztof Kozlowski
0 siblings, 0 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-22 15:45 UTC (permalink / raw)
To: Allen-KH Cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On 22/04/2022 14:10, Allen-KH Cheng wrote:
> Based on watchdog.yaml, the node names should be "watchdog".
>
> Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> ---
Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
2022-04-22 15:44 ` Krzysztof Kozlowski
@ 2022-04-25 7:37 ` allen-kh.cheng
-1 siblings, 0 replies; 23+ messages in thread
From: allen-kh.cheng @ 2022-04-25 7:37 UTC (permalink / raw)
To: Krzysztof Kozlowski, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
Hi Krzysztof,
Thanks for your suggestion
On Fri, 2022-04-22 at 17:44 +0200, Krzysztof Kozlowski wrote:
> On 22/04/2022 14:10, Allen-KH Cheng wrote:
> > Convert Mediatek watchdog devicetree binding to YAML.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > ---
> > .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
> > .../devicetree/bindings/watchdog/mtk-wdt.yaml | 76
> > +++++++++++++++++++
> > 2 files changed, 76 insertions(+), 42 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-
> > wdt.txt
> > create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-
> > wdt.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > deleted file mode 100644
> > index 762c62e428ef..000000000000
> > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > +++ /dev/null
> > @@ -1,42 +0,0 @@
> > -Mediatek SoCs Watchdog timer
> > -
> > -The watchdog supports a pre-timeout interrupt that fires timeout-
> > sec/2
> > -before the expiry.
> > -
> > -Required properties:
> > -
> > -- compatible should contain:
> > - "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> > - "mediatek,mt2712-wdt": for MT2712
> > - "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
> > - "mediatek,mt6589-wdt": for MT6589
> > - "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> > - "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> > - "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> > - "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> > - "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
> > - "mediatek,mt8183-wdt": for MT8183
> > - "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> > - "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
> > - "mediatek,mt8192-wdt": for MT8192
> > - "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
> > -
> > -- reg : Specifies base physical address and size of the registers.
> > -
> > -Optional properties:
> > -- mediatek,disable-extrst: disable send output reset signal
> > -- interrupts: Watchdog pre-timeout (bark) interrupt.
> > -- timeout-sec: contains the watchdog timeout in seconds.
> > -- #reset-cells: Should be 1.
> > -
> > -Example:
> > -
> > -watchdog: watchdog@10007000 {
> > - compatible = "mediatek,mt8183-wdt",
> > - "mediatek,mt6589-wdt";
> > - mediatek,disable-extrst;
> > - reg = <0 0x10007000 0 0x100>;
> > - interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
> > - timeout-sec = <10>;
> > - #reset-cells = <1>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-
> > wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > new file mode 100644
> > index 000000000000..5788617027c8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/watchdog/mtk-wdt.yaml*__;Iw!!CTRNKA9wMg0ARbw!xERWr2MUvqHyyGH9pqm2mwLVX2kDQAF0wr8QJrl5tQnRanjP0cFLXaLZ4-lCdeJ2erdbFvS3b8m5CyqauSNxK-PDlQ$
> >
>
> File name: mtk,wdt.yaml
>
> I assume all future MediaTek watchdogs (even these unpublished and
> developed in some years) will fit into this schema. :) If not, then
> maybe better to name the file by the compatible... but it's not a
> must.
>
Will correct file name.
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!xERWr2MUvqHyyGH9pqm2mwLVX2kDQAF0wr8QJrl5tQnRanjP0cFLXaLZ4-lCdeJ2erdbFvS3b8m5CyqauSOMMN0Duw$
> >
> > +
> > +title: Mediatek SoCs Watchdog timer
> > +
> > +maintainers:
> > + - Runyang Chen <runyang.chen@mediatek.com>
> > + - Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > +
> > +description: |+
> > + The watchdog supports a pre-timeout interrupt that fires
> > timeout-sec/2
> > + before the expiry.
> > +
> > +allOf:
> > + - $ref: "watchdog.yaml#"
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - const: mediatek,mt2712-wdt
> > + - const: mediatek,mt6589-wdt
> > + - const: mediatek,mt8183-wdt
> > + - const: mediatek,mt8192-wdt
>
> All these four entries should be an enum.
>
ok.
> > +
> > + - items:
> > + - enum:
> > + - mediatek,mt2701-wdt
> > + - mediatek,mt6582-wdt
> > + - mediatek,mt6797-wdt
> > + - mediatek,mt7622-wdt
> > + - mediatek,mt7623-wdt
> > + - mediatek,mt7629-wdt
> > + - mediatek,mt7986-wdt
> > + - mediatek,mt8173-wdt
> > + - mediatek,mt8183-wdt
> > + - mediatek,mt8186-wdt
> > + - mediatek,mt8192-wdt
> > + - mediatek,mt8195-wdt
> > + - mediatek,mt8516-wdt
> > + - const: mediatek,mt6589-wdt
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + '#reset-cells':
> > + const: 1
> > +
> > + timeout-sec: true
>
> You do not need this, it's coming from watchdog schema.
>
ok.
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + watchdog@10007000 {
> > + compatible = "mediatek,mt8183-wdt",
> > + "mediatek,mt6589-wdt";
> > + mediatek,disable-extrst;
>
> Did you test your bindings? Does not look like. Please run
> dt_binding_check (see writing-schema for instructions).
>
Yes, I have run dt_binding_check.
But example is from original binding txt file.
Is it ok I can write a new expample?
> > + reg = <0x10007000 0x100>;
> > + interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
>
> Wrong interrupt flag.
I wil check this.
Thanks,
Allen
>
> > + timeout-sec = <10>;
> > + #reset-cells = <1>;
> > + };
> > +
> > +...
>
>
> Best regards,
> Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-25 7:37 ` allen-kh.cheng
0 siblings, 0 replies; 23+ messages in thread
From: allen-kh.cheng @ 2022-04-25 7:37 UTC (permalink / raw)
To: Krzysztof Kozlowski, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
Hi Krzysztof,
Thanks for your suggestion
On Fri, 2022-04-22 at 17:44 +0200, Krzysztof Kozlowski wrote:
> On 22/04/2022 14:10, Allen-KH Cheng wrote:
> > Convert Mediatek watchdog devicetree binding to YAML.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > ---
> > .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
> > .../devicetree/bindings/watchdog/mtk-wdt.yaml | 76
> > +++++++++++++++++++
> > 2 files changed, 76 insertions(+), 42 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-
> > wdt.txt
> > create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-
> > wdt.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > deleted file mode 100644
> > index 762c62e428ef..000000000000
> > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > +++ /dev/null
> > @@ -1,42 +0,0 @@
> > -Mediatek SoCs Watchdog timer
> > -
> > -The watchdog supports a pre-timeout interrupt that fires timeout-
> > sec/2
> > -before the expiry.
> > -
> > -Required properties:
> > -
> > -- compatible should contain:
> > - "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> > - "mediatek,mt2712-wdt": for MT2712
> > - "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
> > - "mediatek,mt6589-wdt": for MT6589
> > - "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> > - "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> > - "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> > - "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> > - "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
> > - "mediatek,mt8183-wdt": for MT8183
> > - "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> > - "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
> > - "mediatek,mt8192-wdt": for MT8192
> > - "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
> > -
> > -- reg : Specifies base physical address and size of the registers.
> > -
> > -Optional properties:
> > -- mediatek,disable-extrst: disable send output reset signal
> > -- interrupts: Watchdog pre-timeout (bark) interrupt.
> > -- timeout-sec: contains the watchdog timeout in seconds.
> > -- #reset-cells: Should be 1.
> > -
> > -Example:
> > -
> > -watchdog: watchdog@10007000 {
> > - compatible = "mediatek,mt8183-wdt",
> > - "mediatek,mt6589-wdt";
> > - mediatek,disable-extrst;
> > - reg = <0 0x10007000 0 0x100>;
> > - interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
> > - timeout-sec = <10>;
> > - #reset-cells = <1>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-
> > wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > new file mode 100644
> > index 000000000000..5788617027c8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/watchdog/mtk-wdt.yaml*__;Iw!!CTRNKA9wMg0ARbw!xERWr2MUvqHyyGH9pqm2mwLVX2kDQAF0wr8QJrl5tQnRanjP0cFLXaLZ4-lCdeJ2erdbFvS3b8m5CyqauSNxK-PDlQ$
> >
>
> File name: mtk,wdt.yaml
>
> I assume all future MediaTek watchdogs (even these unpublished and
> developed in some years) will fit into this schema. :) If not, then
> maybe better to name the file by the compatible... but it's not a
> must.
>
Will correct file name.
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!xERWr2MUvqHyyGH9pqm2mwLVX2kDQAF0wr8QJrl5tQnRanjP0cFLXaLZ4-lCdeJ2erdbFvS3b8m5CyqauSOMMN0Duw$
> >
> > +
> > +title: Mediatek SoCs Watchdog timer
> > +
> > +maintainers:
> > + - Runyang Chen <runyang.chen@mediatek.com>
> > + - Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > +
> > +description: |+
> > + The watchdog supports a pre-timeout interrupt that fires
> > timeout-sec/2
> > + before the expiry.
> > +
> > +allOf:
> > + - $ref: "watchdog.yaml#"
> > +
> > +properties:
> > + compatible:
> > + oneOf:
> > + - const: mediatek,mt2712-wdt
> > + - const: mediatek,mt6589-wdt
> > + - const: mediatek,mt8183-wdt
> > + - const: mediatek,mt8192-wdt
>
> All these four entries should be an enum.
>
ok.
> > +
> > + - items:
> > + - enum:
> > + - mediatek,mt2701-wdt
> > + - mediatek,mt6582-wdt
> > + - mediatek,mt6797-wdt
> > + - mediatek,mt7622-wdt
> > + - mediatek,mt7623-wdt
> > + - mediatek,mt7629-wdt
> > + - mediatek,mt7986-wdt
> > + - mediatek,mt8173-wdt
> > + - mediatek,mt8183-wdt
> > + - mediatek,mt8186-wdt
> > + - mediatek,mt8192-wdt
> > + - mediatek,mt8195-wdt
> > + - mediatek,mt8516-wdt
> > + - const: mediatek,mt6589-wdt
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + interrupts:
> > + maxItems: 1
> > +
> > + '#reset-cells':
> > + const: 1
> > +
> > + timeout-sec: true
>
> You do not need this, it's coming from watchdog schema.
>
ok.
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/interrupt-controller/arm-gic.h>
> > +
> > + watchdog@10007000 {
> > + compatible = "mediatek,mt8183-wdt",
> > + "mediatek,mt6589-wdt";
> > + mediatek,disable-extrst;
>
> Did you test your bindings? Does not look like. Please run
> dt_binding_check (see writing-schema for instructions).
>
Yes, I have run dt_binding_check.
But example is from original binding txt file.
Is it ok I can write a new expample?
> > + reg = <0x10007000 0x100>;
> > + interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
>
> Wrong interrupt flag.
I wil check this.
Thanks,
Allen
>
> > + timeout-sec = <10>;
> > + #reset-cells = <1>;
> > + };
> > +
> > +...
>
>
> Best regards,
> Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
2022-04-25 7:37 ` allen-kh.cheng
(?)
@ 2022-04-25 7:53 ` Krzysztof Kozlowski
-1 siblings, 0 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 7:53 UTC (permalink / raw)
To: allen-kh.cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On 25/04/2022 09:37, allen-kh.cheng wrote:
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> + watchdog@10007000 {
>>> + compatible = "mediatek,mt8183-wdt",
>>> + "mediatek,mt6589-wdt";
>>> + mediatek,disable-extrst;
>>
>> Did you test your bindings? Does not look like. Please run
>> dt_binding_check (see writing-schema for instructions).
>>
>
> Yes, I have run dt_binding_check.
>
> But example is from original binding txt file.
>
> Is it ok I can write a new expample?
Yes, please. Correct the example in the conversion so it is
reasonable/proper.
Best regards,
Krzysztof
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-25 7:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 7:53 UTC (permalink / raw)
To: allen-kh.cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On 25/04/2022 09:37, allen-kh.cheng wrote:
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> + watchdog@10007000 {
>>> + compatible = "mediatek,mt8183-wdt",
>>> + "mediatek,mt6589-wdt";
>>> + mediatek,disable-extrst;
>>
>> Did you test your bindings? Does not look like. Please run
>> dt_binding_check (see writing-schema for instructions).
>>
>
> Yes, I have run dt_binding_check.
>
> But example is from original binding txt file.
>
> Is it ok I can write a new expample?
Yes, please. Correct the example in the conversion so it is
reasonable/proper.
Best regards,
Krzysztof
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-25 7:53 ` Krzysztof Kozlowski
0 siblings, 0 replies; 23+ messages in thread
From: Krzysztof Kozlowski @ 2022-04-25 7:53 UTC (permalink / raw)
To: allen-kh.cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger, Rob Herring, nfraprado
Cc: Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel, linux-mediatek, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On 25/04/2022 09:37, allen-kh.cheng wrote:
>>> +examples:
>>> + - |
>>> + #include <dt-bindings/interrupt-controller/arm-gic.h>
>>> +
>>> + watchdog@10007000 {
>>> + compatible = "mediatek,mt8183-wdt",
>>> + "mediatek,mt6589-wdt";
>>> + mediatek,disable-extrst;
>>
>> Did you test your bindings? Does not look like. Please run
>> dt_binding_check (see writing-schema for instructions).
>>
>
> Yes, I have run dt_binding_check.
>
> But example is from original binding txt file.
>
> Is it ok I can write a new expample?
Yes, please. Correct the example in the conversion so it is
reasonable/proper.
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
2022-04-22 15:44 ` Krzysztof Kozlowski
(?)
@ 2022-04-25 16:02 ` Rob Herring
-1 siblings, 0 replies; 23+ messages in thread
From: Rob Herring @ 2022-04-25 16:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Allen-KH Cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger,
Nícolas F. R. A. Prado,
Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel,
moderated list:ARM/Mediatek SoC support, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On Fri, Apr 22, 2022 at 10:44 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 22/04/2022 14:10, Allen-KH Cheng wrote:
> > Convert Mediatek watchdog devicetree binding to YAML.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > ---
> > .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
> > .../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
> > 2 files changed, 76 insertions(+), 42 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > deleted file mode 100644
> > index 762c62e428ef..000000000000
> > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > +++ /dev/null
> > @@ -1,42 +0,0 @@
> > -Mediatek SoCs Watchdog timer
> > -
> > -The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> > -before the expiry.
> > -
> > -Required properties:
> > -
> > -- compatible should contain:
> > - "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> > - "mediatek,mt2712-wdt": for MT2712
> > - "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
> > - "mediatek,mt6589-wdt": for MT6589
> > - "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> > - "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> > - "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> > - "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> > - "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
> > - "mediatek,mt8183-wdt": for MT8183
> > - "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> > - "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
> > - "mediatek,mt8192-wdt": for MT8192
> > - "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
> > -
> > -- reg : Specifies base physical address and size of the registers.
> > -
> > -Optional properties:
> > -- mediatek,disable-extrst: disable send output reset signal
> > -- interrupts: Watchdog pre-timeout (bark) interrupt.
> > -- timeout-sec: contains the watchdog timeout in seconds.
> > -- #reset-cells: Should be 1.
> > -
> > -Example:
> > -
> > -watchdog: watchdog@10007000 {
> > - compatible = "mediatek,mt8183-wdt",
> > - "mediatek,mt6589-wdt";
> > - mediatek,disable-extrst;
> > - reg = <0 0x10007000 0 0x100>;
> > - interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
> > - timeout-sec = <10>;
> > - #reset-cells = <1>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > new file mode 100644
> > index 000000000000..5788617027c8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/mtk-wdt.yaml#
>
> File name: mtk,wdt.yaml
mediatek,wdt.yaml
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-25 16:02 ` Rob Herring
0 siblings, 0 replies; 23+ messages in thread
From: Rob Herring @ 2022-04-25 16:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Allen-KH Cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger,
Nícolas F. R. A. Prado,
Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel,
moderated list:ARM/Mediatek SoC support, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On Fri, Apr 22, 2022 at 10:44 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 22/04/2022 14:10, Allen-KH Cheng wrote:
> > Convert Mediatek watchdog devicetree binding to YAML.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > ---
> > .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
> > .../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
> > 2 files changed, 76 insertions(+), 42 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > deleted file mode 100644
> > index 762c62e428ef..000000000000
> > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > +++ /dev/null
> > @@ -1,42 +0,0 @@
> > -Mediatek SoCs Watchdog timer
> > -
> > -The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> > -before the expiry.
> > -
> > -Required properties:
> > -
> > -- compatible should contain:
> > - "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> > - "mediatek,mt2712-wdt": for MT2712
> > - "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
> > - "mediatek,mt6589-wdt": for MT6589
> > - "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> > - "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> > - "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> > - "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> > - "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
> > - "mediatek,mt8183-wdt": for MT8183
> > - "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> > - "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
> > - "mediatek,mt8192-wdt": for MT8192
> > - "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
> > -
> > -- reg : Specifies base physical address and size of the registers.
> > -
> > -Optional properties:
> > -- mediatek,disable-extrst: disable send output reset signal
> > -- interrupts: Watchdog pre-timeout (bark) interrupt.
> > -- timeout-sec: contains the watchdog timeout in seconds.
> > -- #reset-cells: Should be 1.
> > -
> > -Example:
> > -
> > -watchdog: watchdog@10007000 {
> > - compatible = "mediatek,mt8183-wdt",
> > - "mediatek,mt6589-wdt";
> > - mediatek,disable-extrst;
> > - reg = <0 0x10007000 0 0x100>;
> > - interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
> > - timeout-sec = <10>;
> > - #reset-cells = <1>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > new file mode 100644
> > index 000000000000..5788617027c8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/mtk-wdt.yaml#
>
> File name: mtk,wdt.yaml
mediatek,wdt.yaml
_______________________________________________
Linux-mediatek mailing list
Linux-mediatek@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-mediatek
^ permalink raw reply [flat|nested] 23+ messages in thread
* Re: [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML
@ 2022-04-25 16:02 ` Rob Herring
0 siblings, 0 replies; 23+ messages in thread
From: Rob Herring @ 2022-04-25 16:02 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: Allen-KH Cheng, Wim Van Sebroeck, Guenter Roeck,
Krzysztof Kozlowski, Matthias Brugger,
Nícolas F. R. A. Prado,
Project_Global_Chrome_Upstream_Group, devicetree,
linux-arm-kernel, linux-kernel,
moderated list:ARM/Mediatek SoC support, srv_heupstream,
Chen-Yu Tsai, Ryder Lee
On Fri, Apr 22, 2022 at 10:44 AM Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 22/04/2022 14:10, Allen-KH Cheng wrote:
> > Convert Mediatek watchdog devicetree binding to YAML.
> >
> > Signed-off-by: Allen-KH Cheng <allen-kh.cheng@mediatek.com>
> > ---
> > .../devicetree/bindings/watchdog/mtk-wdt.txt | 42 ----------
> > .../devicetree/bindings/watchdog/mtk-wdt.yaml | 76 +++++++++++++++++++
> > 2 files changed, 76 insertions(+), 42 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > create mode 100644 Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt b/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > deleted file mode 100644
> > index 762c62e428ef..000000000000
> > --- a/Documentation/devicetree/bindings/watchdog/mtk-wdt.txt
> > +++ /dev/null
> > @@ -1,42 +0,0 @@
> > -Mediatek SoCs Watchdog timer
> > -
> > -The watchdog supports a pre-timeout interrupt that fires timeout-sec/2
> > -before the expiry.
> > -
> > -Required properties:
> > -
> > -- compatible should contain:
> > - "mediatek,mt2701-wdt", "mediatek,mt6589-wdt": for MT2701
> > - "mediatek,mt2712-wdt": for MT2712
> > - "mediatek,mt6582-wdt", "mediatek,mt6589-wdt": for MT6582
> > - "mediatek,mt6589-wdt": for MT6589
> > - "mediatek,mt6797-wdt", "mediatek,mt6589-wdt": for MT6797
> > - "mediatek,mt7622-wdt", "mediatek,mt6589-wdt": for MT7622
> > - "mediatek,mt7623-wdt", "mediatek,mt6589-wdt": for MT7623
> > - "mediatek,mt7629-wdt", "mediatek,mt6589-wdt": for MT7629
> > - "mediatek,mt7986-wdt", "mediatek,mt6589-wdt": for MT7986
> > - "mediatek,mt8183-wdt": for MT8183
> > - "mediatek,mt8186-wdt", "mediatek,mt6589-wdt": for MT8186
> > - "mediatek,mt8516-wdt", "mediatek,mt6589-wdt": for MT8516
> > - "mediatek,mt8192-wdt": for MT8192
> > - "mediatek,mt8195-wdt", "mediatek,mt6589-wdt": for MT8195
> > -
> > -- reg : Specifies base physical address and size of the registers.
> > -
> > -Optional properties:
> > -- mediatek,disable-extrst: disable send output reset signal
> > -- interrupts: Watchdog pre-timeout (bark) interrupt.
> > -- timeout-sec: contains the watchdog timeout in seconds.
> > -- #reset-cells: Should be 1.
> > -
> > -Example:
> > -
> > -watchdog: watchdog@10007000 {
> > - compatible = "mediatek,mt8183-wdt",
> > - "mediatek,mt6589-wdt";
> > - mediatek,disable-extrst;
> > - reg = <0 0x10007000 0 0x100>;
> > - interrupts = <GIC_SPI 139 IRQ_TYPE_NONE>;
> > - timeout-sec = <10>;
> > - #reset-cells = <1>;
> > -};
> > diff --git a/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > new file mode 100644
> > index 000000000000..5788617027c8
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/mtk-wdt.yaml
> > @@ -0,0 +1,76 @@
> > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/watchdog/mtk-wdt.yaml#
>
> File name: mtk,wdt.yaml
mediatek,wdt.yaml
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 23+ messages in thread
end of thread, other threads:[~2022-04-25 16:03 UTC | newest]
Thread overview: 23+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-22 12:10 [PATCH 0/2] dt-bindings: watchdog: mediatek: Convert binding to YAML Allen-KH Cheng
2022-04-22 12:10 ` Allen-KH Cheng
2022-04-22 12:10 ` Allen-KH Cheng
2022-04-22 12:10 ` [PATCH 1/2] arm64: dts: mt8516: align watchdog node name with dtschema Allen-KH Cheng
2022-04-22 12:10 ` Allen-KH Cheng
2022-04-22 12:10 ` Allen-KH Cheng
2022-04-22 15:45 ` Krzysztof Kozlowski
2022-04-22 15:45 ` Krzysztof Kozlowski
2022-04-22 15:45 ` Krzysztof Kozlowski
2022-04-22 12:10 ` [PATCH 2/2] dt-bindings: watchdog: mediatek: Convert binding to YAML Allen-KH Cheng
2022-04-22 12:10 ` Allen-KH Cheng
2022-04-22 12:10 ` Allen-KH Cheng
2022-04-22 15:44 ` Krzysztof Kozlowski
2022-04-22 15:44 ` Krzysztof Kozlowski
2022-04-22 15:44 ` Krzysztof Kozlowski
2022-04-25 7:37 ` allen-kh.cheng
2022-04-25 7:37 ` allen-kh.cheng
2022-04-25 7:53 ` Krzysztof Kozlowski
2022-04-25 7:53 ` Krzysztof Kozlowski
2022-04-25 7:53 ` Krzysztof Kozlowski
2022-04-25 16:02 ` Rob Herring
2022-04-25 16:02 ` Rob Herring
2022-04-25 16:02 ` Rob Herring
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.