From: cgel.zte@gmail.com To: dmitry.baryshkov@linaro.org Cc: airlied@linux.ie, angelogioacchino.delregno@collabora.com, cgel.zte@gmail.com, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, lv.ruyi@zte.com.cn, quic_abhinavk@quicinc.com, quic_mkrishn@quicinc.com, sean@poorly.run, swboyd@chromium.org, vulab@iscas.ac.cn, Zeal Robot <zealci@zte.com.cn> Subject: [PATCH v2] drm: msm: fix error check return value of irq_of_parse_and_map() Date: Sun, 24 Apr 2022 03:19:59 +0000 [thread overview] Message-ID: <20220424031959.3172406-1-lv.ruyi@zte.com.cn> (raw) In-Reply-To: <39b3828e-064c-6aa4-de77-35b201b1b40f@linaro.org> From: Lv Ruyi <lv.ruyi@zte.com.cn> The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> --- v2: don't print irq, and return ERR_PTR(-EINVAL) --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c index 3b92372e7bdf..44e395e59df9 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c @@ -570,9 +570,9 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) } irq = irq_of_parse_and_map(pdev->dev.of_node, 0); - if (irq < 0) { - ret = irq; - DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret); + if (!irq) { + ret = -EINVAL; + DRM_DEV_ERROR(&pdev->dev, "failed to get irq\n"); goto fail; } -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: cgel.zte@gmail.com To: dmitry.baryshkov@linaro.org Cc: sean@poorly.run, airlied@linux.ie, cgel.zte@gmail.com, lv.ruyi@zte.com.cn, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, quic_abhinavk@quicinc.com, quic_mkrishn@quicinc.com, vulab@iscas.ac.cn, linux-arm-msm@vger.kernel.org, swboyd@chromium.org, freedreno@lists.freedesktop.org, Zeal Robot <zealci@zte.com.cn>, angelogioacchino.delregno@collabora.com Subject: [PATCH v2] drm: msm: fix error check return value of irq_of_parse_and_map() Date: Sun, 24 Apr 2022 03:19:59 +0000 [thread overview] Message-ID: <20220424031959.3172406-1-lv.ruyi@zte.com.cn> (raw) In-Reply-To: <39b3828e-064c-6aa4-de77-35b201b1b40f@linaro.org> From: Lv Ruyi <lv.ruyi@zte.com.cn> The irq_of_parse_and_map() function returns 0 on failure, and does not return an negative value. Reported-by: Zeal Robot <zealci@zte.com.cn> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn> --- v2: don't print irq, and return ERR_PTR(-EINVAL) --- drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c index 3b92372e7bdf..44e395e59df9 100644 --- a/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c +++ b/drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c @@ -570,9 +570,9 @@ struct msm_kms *mdp5_kms_init(struct drm_device *dev) } irq = irq_of_parse_and_map(pdev->dev.of_node, 0); - if (irq < 0) { - ret = irq; - DRM_DEV_ERROR(&pdev->dev, "failed to get irq: %d\n", ret); + if (!irq) { + ret = -EINVAL; + DRM_DEV_ERROR(&pdev->dev, "failed to get irq\n"); goto fail; } -- 2.25.1
next prev parent reply other threads:[~2022-04-24 3:20 UTC|newest] Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-22 8:52 [PATCH] drm: msm: fix error check return value of irq_of_parse_and_map() cgel.zte 2022-04-22 8:52 ` cgel.zte 2022-04-22 10:42 ` Dmitry Baryshkov 2022-04-22 10:42 ` Dmitry Baryshkov 2022-04-22 22:40 ` Dmitry Baryshkov 2022-04-22 22:40 ` Dmitry Baryshkov 2022-04-24 3:19 ` cgel.zte [this message] 2022-04-24 3:19 ` [PATCH v2] " cgel.zte 2022-04-25 22:23 ` Dmitry Baryshkov 2022-04-25 22:23 ` Dmitry Baryshkov 2022-04-22 12:40 ` [PATCH] " AngeloGioacchino Del Regno 2022-04-22 12:40 ` AngeloGioacchino Del Regno
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220424031959.3172406-1-lv.ruyi@zte.com.cn \ --to=cgel.zte@gmail.com \ --cc=airlied@linux.ie \ --cc=angelogioacchino.delregno@collabora.com \ --cc=dmitry.baryshkov@linaro.org \ --cc=dri-devel@lists.freedesktop.org \ --cc=freedreno@lists.freedesktop.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=lv.ruyi@zte.com.cn \ --cc=quic_abhinavk@quicinc.com \ --cc=quic_mkrishn@quicinc.com \ --cc=sean@poorly.run \ --cc=swboyd@chromium.org \ --cc=vulab@iscas.ac.cn \ --cc=zealci@zte.com.cn \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.