* [PATCH] clk: sunxi-ng: ccu-sun6i-rtc: set rtc-32k to critical
@ 2022-04-24 5:59 ` Icenowy Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Icenowy Zheng @ 2022-04-24 5:59 UTC (permalink / raw)
To: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland
Cc: linux-clk, linux-arm-kernel, linux-sunxi, linux-kernel, Icenowy Zheng
RTC itself is the one and only consumer of rtc-32k clock. As the rtc
should be always running, set rtc-32k clock to critical, to prevent it
from being gated by the kernel.
Fixes: d91612d7f01a ("clk: sunxi-ng: Add support for the sun6i RTC clocks")
Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
---
drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
index 8a10bade7e0d..3d9c9ce5a3db 100644
--- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
+++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
@@ -241,6 +241,7 @@ static struct clk_init_data rtc_32k_init_data = {
.ops = &ccu_mux_ops,
.parent_hws = rtc_32k_parents,
.num_parents = ARRAY_SIZE(rtc_32k_parents), /* updated during probe */
+ .flags = CLK_IS_CRITICAL,
};
static struct ccu_mux rtc_32k_clk = {
--
2.35.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] clk: sunxi-ng: ccu-sun6i-rtc: set rtc-32k to critical
@ 2022-04-24 5:59 ` Icenowy Zheng
0 siblings, 0 replies; 4+ messages in thread
From: Icenowy Zheng @ 2022-04-24 5:59 UTC (permalink / raw)
To: Chen-Yu Tsai, Jernej Skrabec, Samuel Holland
Cc: linux-clk, linux-arm-kernel, linux-sunxi, linux-kernel, Icenowy Zheng
RTC itself is the one and only consumer of rtc-32k clock. As the rtc
should be always running, set rtc-32k clock to critical, to prevent it
from being gated by the kernel.
Fixes: d91612d7f01a ("clk: sunxi-ng: Add support for the sun6i RTC clocks")
Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
---
drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
index 8a10bade7e0d..3d9c9ce5a3db 100644
--- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
+++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
@@ -241,6 +241,7 @@ static struct clk_init_data rtc_32k_init_data = {
.ops = &ccu_mux_ops,
.parent_hws = rtc_32k_parents,
.num_parents = ARRAY_SIZE(rtc_32k_parents), /* updated during probe */
+ .flags = CLK_IS_CRITICAL,
};
static struct ccu_mux rtc_32k_clk = {
--
2.35.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] clk: sunxi-ng: ccu-sun6i-rtc: set rtc-32k to critical
2022-04-24 5:59 ` Icenowy Zheng
@ 2022-04-24 19:55 ` Jernej Škrabec
-1 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2022-04-24 19:55 UTC (permalink / raw)
To: Chen-Yu Tsai, Samuel Holland, Icenowy Zheng
Cc: linux-clk, linux-arm-kernel, linux-sunxi, linux-kernel, Icenowy Zheng
Dne nedelja, 24. april 2022 ob 07:59:59 CEST je Icenowy Zheng napisal(a):
> RTC itself is the one and only consumer of rtc-32k clock. As the rtc
> should be always running, set rtc-32k clock to critical, to prevent it
> from being gated by the kernel.
>
> Fixes: d91612d7f01a ("clk: sunxi-ng: Add support for the sun6i RTC clocks")
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
This one was already submitted here:
https://lore.kernel.org/linux-sunxi/20220411050100.40964-1-samuel@sholland.org/
Best regards,
Jernej
> ---
> drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-
sun6i-rtc.c
> index 8a10bade7e0d..3d9c9ce5a3db 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> @@ -241,6 +241,7 @@ static struct clk_init_data rtc_32k_init_data = {
> .ops = &ccu_mux_ops,
> .parent_hws = rtc_32k_parents,
> .num_parents = ARRAY_SIZE(rtc_32k_parents), /* updated
during probe */
> + .flags = CLK_IS_CRITICAL,
> };
>
> static struct ccu_mux rtc_32k_clk = {
> --
> 2.35.1
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] clk: sunxi-ng: ccu-sun6i-rtc: set rtc-32k to critical
@ 2022-04-24 19:55 ` Jernej Škrabec
0 siblings, 0 replies; 4+ messages in thread
From: Jernej Škrabec @ 2022-04-24 19:55 UTC (permalink / raw)
To: Chen-Yu Tsai, Samuel Holland, Icenowy Zheng
Cc: linux-clk, linux-arm-kernel, linux-sunxi, linux-kernel, Icenowy Zheng
Dne nedelja, 24. april 2022 ob 07:59:59 CEST je Icenowy Zheng napisal(a):
> RTC itself is the one and only consumer of rtc-32k clock. As the rtc
> should be always running, set rtc-32k clock to critical, to prevent it
> from being gated by the kernel.
>
> Fixes: d91612d7f01a ("clk: sunxi-ng: Add support for the sun6i RTC clocks")
> Signed-off-by: Icenowy Zheng <uwu@icenowy.me>
This one was already submitted here:
https://lore.kernel.org/linux-sunxi/20220411050100.40964-1-samuel@sholland.org/
Best regards,
Jernej
> ---
> drivers/clk/sunxi-ng/ccu-sun6i-rtc.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c b/drivers/clk/sunxi-ng/ccu-
sun6i-rtc.c
> index 8a10bade7e0d..3d9c9ce5a3db 100644
> --- a/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> +++ b/drivers/clk/sunxi-ng/ccu-sun6i-rtc.c
> @@ -241,6 +241,7 @@ static struct clk_init_data rtc_32k_init_data = {
> .ops = &ccu_mux_ops,
> .parent_hws = rtc_32k_parents,
> .num_parents = ARRAY_SIZE(rtc_32k_parents), /* updated
during probe */
> + .flags = CLK_IS_CRITICAL,
> };
>
> static struct ccu_mux rtc_32k_clk = {
> --
> 2.35.1
>
>
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-04-24 19:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24 5:59 [PATCH] clk: sunxi-ng: ccu-sun6i-rtc: set rtc-32k to critical Icenowy Zheng
2022-04-24 5:59 ` Icenowy Zheng
2022-04-24 19:55 ` Jernej Škrabec
2022-04-24 19:55 ` Jernej Škrabec
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.