* [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue
@ 2022-04-24 6:26 cgel.zte
2022-04-25 15:07 ` Ira Weiny
2022-04-26 5:01 ` Dan Williams
0 siblings, 2 replies; 3+ messages in thread
From: cgel.zte @ 2022-04-24 6:26 UTC (permalink / raw)
To: dan.j.williams
Cc: vishal.l.verma, dave.jiang, ira.weiny, ran.jianping, jane.chu,
rafael.j.wysocki, nvdimm, linux-kernel, Zeal Robot
From: ran jianping <ran.jianping@zte.com.cn>
All work currently pending will be done first by calling destroy_workqueue,
so there is no need to flush it explicitly.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
---
tools/testing/nvdimm/test/nfit.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
index 1da76ccde448..e7e1a640e482 100644
--- a/tools/testing/nvdimm/test/nfit.c
+++ b/tools/testing/nvdimm/test/nfit.c
@@ -3375,7 +3375,6 @@ static __exit void nfit_test_exit(void)
{
int i;
- flush_workqueue(nfit_wq);
destroy_workqueue(nfit_wq);
for (i = 0; i < NUM_NFITS; i++)
platform_device_unregister(&instances[i]->pdev);
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue
2022-04-24 6:26 [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue cgel.zte
@ 2022-04-25 15:07 ` Ira Weiny
2022-04-26 5:01 ` Dan Williams
1 sibling, 0 replies; 3+ messages in thread
From: Ira Weiny @ 2022-04-25 15:07 UTC (permalink / raw)
To: cgel.zte
Cc: dan.j.williams, vishal.l.verma, dave.jiang, ran.jianping,
jane.chu, rafael.j.wysocki, nvdimm, linux-kernel, Zeal Robot
On Sun, Apr 24, 2022 at 06:26:55AM +0000, cgel.zte@gmail.com wrote:
> From: ran jianping <ran.jianping@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: ran jianping <ran.jianping@zte.com.cn>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> tools/testing/nvdimm/test/nfit.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/tools/testing/nvdimm/test/nfit.c b/tools/testing/nvdimm/test/nfit.c
> index 1da76ccde448..e7e1a640e482 100644
> --- a/tools/testing/nvdimm/test/nfit.c
> +++ b/tools/testing/nvdimm/test/nfit.c
> @@ -3375,7 +3375,6 @@ static __exit void nfit_test_exit(void)
> {
> int i;
>
> - flush_workqueue(nfit_wq);
> destroy_workqueue(nfit_wq);
> for (i = 0; i < NUM_NFITS; i++)
> platform_device_unregister(&instances[i]->pdev);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue
2022-04-24 6:26 [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue cgel.zte
2022-04-25 15:07 ` Ira Weiny
@ 2022-04-26 5:01 ` Dan Williams
1 sibling, 0 replies; 3+ messages in thread
From: Dan Williams @ 2022-04-26 5:01 UTC (permalink / raw)
To: cgel.zte
Cc: Vishal L Verma, Dave Jiang, Weiny, Ira, ran.jianping, Jane Chu,
Rafael J Wysocki, Linux NVDIMM, Linux Kernel Mailing List,
Zeal Robot
On Sat, Apr 23, 2022 at 11:27 PM <cgel.zte@gmail.com> wrote:
>
> From: ran jianping <ran.jianping@zte.com.cn>
>
> All work currently pending will be done first by calling destroy_workqueue,
> so there is no need to flush it explicitly.
>
Looks good, applied.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-04-26 5:01 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24 6:26 [PATCH] tools/testing/nvdimm: remove unneeded flush_workqueue cgel.zte
2022-04-25 15:07 ` Ira Weiny
2022-04-26 5:01 ` Dan Williams
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.