* [PATCH] ARM: imx: imx8q: Use LPUART_BASE macro in config files
@ 2022-04-24 21:43 Marek Vasut
2022-04-25 12:56 ` Tom Rini
0 siblings, 1 reply; 2+ messages in thread
From: Marek Vasut @ 2022-04-24 21:43 UTC (permalink / raw)
To: u-boot; +Cc: Marek Vasut, Fabio Estevam, Peng Fan, Stefano Babic, Tom Rini
Replace ad-hoc value with LPUART_BASE macro, no functional change.
Signed-off-by: Marek Vasut <marex@denx.de>
Cc: Fabio Estevam <festevam@denx.de>
Cc: Peng Fan <peng.fan@nxp.com>
Cc: Stefano Babic <sbabic@denx.de>
Cc: Tom Rini <trini@konsulko.com>
---
include/configs/cgtqmx8.h | 2 +-
include/configs/imx8qm_mek.h | 4 ++--
include/configs/imx8qxp_mek.h | 2 +-
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/include/configs/cgtqmx8.h b/include/configs/cgtqmx8.h
index 6da0483ef09..db2555c23cc 100644
--- a/include/configs/cgtqmx8.h
+++ b/include/configs/cgtqmx8.h
@@ -20,7 +20,7 @@
#define CONFIG_SPL_BSS_MAX_SIZE 0x1000 /* 4 KB */
#define CONFIG_SYS_SPL_MALLOC_START 0x00120000
#define CONFIG_SYS_SPL_MALLOC_SIZE 0x3000 /* 12 KB */
-#define CONFIG_SERIAL_LPUART_BASE 0x5a060000
+#define CONFIG_SERIAL_LPUART_BASE LPUART_BASE
#define CONFIG_MALLOC_F_ADDR 0x00120000
#define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE
diff --git a/include/configs/imx8qm_mek.h b/include/configs/imx8qm_mek.h
index 61d56e269ac..b9ad61ce501 100644
--- a/include/configs/imx8qm_mek.h
+++ b/include/configs/imx8qm_mek.h
@@ -21,7 +21,7 @@
#define CONFIG_SPL_BSS_MAX_SIZE 0x1000 /* 4 KB */
#define CONFIG_SYS_SPL_MALLOC_START 0x00120000
#define CONFIG_SYS_SPL_MALLOC_SIZE 0x3000 /* 12 KB */
-#define CONFIG_SERIAL_LPUART_BASE 0x5a060000
+#define CONFIG_SERIAL_LPUART_BASE LPUART_BASE
#define CONFIG_MALLOC_F_ADDR 0x00120000
#define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE
@@ -41,7 +41,7 @@
"script=boot.scr\0" \
"image=Image\0" \
"panel=NULL\0" \
- "console=ttyLP0,${baudrate} earlycon=lpuart32,0x5a060000,${baudrate}\0" \
+ "console=ttyLP0,${baudrate} earlycon=lpuart32," __stringify(LPUART_BASE) ",${baudrate}\0" \
"fdt_addr=0x83000000\0" \
"fdt_high=0xffffffffffffffff\0" \
"boot_fdt=try\0" \
diff --git a/include/configs/imx8qxp_mek.h b/include/configs/imx8qxp_mek.h
index 26dc4ded030..11a8ac50691 100644
--- a/include/configs/imx8qxp_mek.h
+++ b/include/configs/imx8qxp_mek.h
@@ -19,7 +19,7 @@
#define CONFIG_SPL_BSS_MAX_SIZE 0x1000 /* 4 KB */
#define CONFIG_SYS_SPL_MALLOC_START 0x00120000
#define CONFIG_SYS_SPL_MALLOC_SIZE 0x3000 /* 12 KB */
-#define CONFIG_SERIAL_LPUART_BASE 0x5a060000
+#define CONFIG_SERIAL_LPUART_BASE LPUART_BASE
#define CONFIG_MALLOC_F_ADDR 0x00120000
#define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE
--
2.35.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] ARM: imx: imx8q: Use LPUART_BASE macro in config files
2022-04-24 21:43 [PATCH] ARM: imx: imx8q: Use LPUART_BASE macro in config files Marek Vasut
@ 2022-04-25 12:56 ` Tom Rini
0 siblings, 0 replies; 2+ messages in thread
From: Tom Rini @ 2022-04-25 12:56 UTC (permalink / raw)
To: Marek Vasut; +Cc: u-boot, Fabio Estevam, Peng Fan, Stefano Babic
[-- Attachment #1: Type: text/plain, Size: 3061 bytes --]
On Sun, Apr 24, 2022 at 11:43:10PM +0200, Marek Vasut wrote:
> Replace ad-hoc value with LPUART_BASE macro, no functional change.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Cc: Fabio Estevam <festevam@denx.de>
> Cc: Peng Fan <peng.fan@nxp.com>
> Cc: Stefano Babic <sbabic@denx.de>
> Cc: Tom Rini <trini@konsulko.com>
> ---
> include/configs/cgtqmx8.h | 2 +-
> include/configs/imx8qm_mek.h | 4 ++--
> include/configs/imx8qxp_mek.h | 2 +-
> 3 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/include/configs/cgtqmx8.h b/include/configs/cgtqmx8.h
> index 6da0483ef09..db2555c23cc 100644
> --- a/include/configs/cgtqmx8.h
> +++ b/include/configs/cgtqmx8.h
> @@ -20,7 +20,7 @@
> #define CONFIG_SPL_BSS_MAX_SIZE 0x1000 /* 4 KB */
> #define CONFIG_SYS_SPL_MALLOC_START 0x00120000
> #define CONFIG_SYS_SPL_MALLOC_SIZE 0x3000 /* 12 KB */
> -#define CONFIG_SERIAL_LPUART_BASE 0x5a060000
> +#define CONFIG_SERIAL_LPUART_BASE LPUART_BASE
> #define CONFIG_MALLOC_F_ADDR 0x00120000
>
> #define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE
> diff --git a/include/configs/imx8qm_mek.h b/include/configs/imx8qm_mek.h
> index 61d56e269ac..b9ad61ce501 100644
> --- a/include/configs/imx8qm_mek.h
> +++ b/include/configs/imx8qm_mek.h
> @@ -21,7 +21,7 @@
> #define CONFIG_SPL_BSS_MAX_SIZE 0x1000 /* 4 KB */
> #define CONFIG_SYS_SPL_MALLOC_START 0x00120000
> #define CONFIG_SYS_SPL_MALLOC_SIZE 0x3000 /* 12 KB */
> -#define CONFIG_SERIAL_LPUART_BASE 0x5a060000
> +#define CONFIG_SERIAL_LPUART_BASE LPUART_BASE
> #define CONFIG_MALLOC_F_ADDR 0x00120000
>
> #define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE
> @@ -41,7 +41,7 @@
> "script=boot.scr\0" \
> "image=Image\0" \
> "panel=NULL\0" \
> - "console=ttyLP0,${baudrate} earlycon=lpuart32,0x5a060000,${baudrate}\0" \
> + "console=ttyLP0,${baudrate} earlycon=lpuart32," __stringify(LPUART_BASE) ",${baudrate}\0" \
> "fdt_addr=0x83000000\0" \
> "fdt_high=0xffffffffffffffff\0" \
> "boot_fdt=try\0" \
> diff --git a/include/configs/imx8qxp_mek.h b/include/configs/imx8qxp_mek.h
> index 26dc4ded030..11a8ac50691 100644
> --- a/include/configs/imx8qxp_mek.h
> +++ b/include/configs/imx8qxp_mek.h
> @@ -19,7 +19,7 @@
> #define CONFIG_SPL_BSS_MAX_SIZE 0x1000 /* 4 KB */
> #define CONFIG_SYS_SPL_MALLOC_START 0x00120000
> #define CONFIG_SYS_SPL_MALLOC_SIZE 0x3000 /* 12 KB */
> -#define CONFIG_SERIAL_LPUART_BASE 0x5a060000
> +#define CONFIG_SERIAL_LPUART_BASE LPUART_BASE
> #define CONFIG_MALLOC_F_ADDR 0x00120000
>
> #define CONFIG_SPL_RAW_IMAGE_ARM_TRUSTED_FIRMWARE
This kind of change makes Kconfig migration harder for moveconfig.py to
handle. I don't see CONFIG_SERIAL_LPUART_BASE used in code, so we
should just drop it. And so far as we're consistent about how to pass
earlycon info, we just put the raw address, but I don't strongly object
to __stringify(LPUART_BASE) as it is clearer, and handling the default
env part of board config.h has its own challenges more broadly.
--
Tom
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 659 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-25 12:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-24 21:43 [PATCH] ARM: imx: imx8q: Use LPUART_BASE macro in config files Marek Vasut
2022-04-25 12:56 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.