[PATCH] drm/amd/pm: fix the compile warning

[PATCH] drm/amd/pm: fix the compile warning

[Evan Quan]

Fix the compile warning below:
drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641
kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)'

Reported-by: kernel test robot <lkp@intel.com>
CC: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Evan Quan <evan.quan@amd.com>
Change-Id: If4985252017023d6711b4d7eb1192a397baff813
---
 drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c b/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c
index 8b23cc9f098a..cab948118d4b 100644
--- a/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c
+++ b/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c
@@ -1623,6 +1623,7 @@ static int kv_update_samu_dpm(struct amdgpu_device *adev, bool gate)
 
 static u8 kv_get_acp_boot_level(struct amdgpu_device *adev)
 {
+#if 0
 	u8 i;
 	struct amdgpu_clock_voltage_dependency_table *table =
 		&adev->pm.dpm.dyn_state.acp_clock_voltage_dependency_table;
@@ -1636,6 +1637,8 @@ static u8 kv_get_acp_boot_level(struct amdgpu_device *adev)
 		i = table->count - 1;
 
 	return i;
+#endif
+	return 0;
 }
 
 static void kv_update_acp_boot_level(struct amdgpu_device *adev)
-- 
2.29.0

Re: [PATCH] drm/amd/pm: fix the compile warning

[Alex Deucher]

On Sun, Apr 24, 2022 at 10:25 PM Evan Quan <evan.quan@amd.com> wrote:
>
> Fix the compile warning below:
> drivers/gpu/drm/amd/amdgpu/../pm/legacy-dpm/kv_dpm.c:1641
> kv_get_acp_boot_level() warn: always true condition '(table->entries[i]->clk >= 0) => (0-u32max >= 0)'
>
> Reported-by: kernel test robot <lkp@intel.com>
> CC: Alex Deucher <alexander.deucher@amd.com>
> Signed-off-by: Evan Quan <evan.quan@amd.com>
> Change-Id: If4985252017023d6711b4d7eb1192a397baff813
> ---
>  drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c b/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c
> index 8b23cc9f098a..cab948118d4b 100644
> --- a/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c
> +++ b/drivers/gpu/drm/amd/pm/legacy-dpm/kv_dpm.c
> @@ -1623,6 +1623,7 @@ static int kv_update_samu_dpm(struct amdgpu_device *adev, bool gate)
>
>  static u8 kv_get_acp_boot_level(struct amdgpu_device *adev)
>  {
> +#if 0
>         u8 i;
>         struct amdgpu_clock_voltage_dependency_table *table =
>                 &adev->pm.dpm.dyn_state.acp_clock_voltage_dependency_table;
> @@ -1636,6 +1637,8 @@ static u8 kv_get_acp_boot_level(struct amdgpu_device *adev)
>                 i = table->count - 1;
>
>         return i;
> +#endif

Just drop the code at this point and return 0.

Alex


> +       return 0;
>  }
>
>  static void kv_update_acp_boot_level(struct amdgpu_device *adev)
> --
> 2.29.0
>