All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Xiaobing Luo <luoxiaobing0926@gmail.com>,
	tiny.windzz@gmail.com, rafael@kernel.org, wens@csie.org,
	jernej.skrabec@gmail.com, mripard@kernel.org,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cpufreq:fix memory leak in sun50i_cpufreq_nvmem_probe
Date: Mon, 25 Apr 2022 10:36:04 +0530	[thread overview]
Message-ID: <20220425050604.fv4f3s74jmvx6rlp@vireshk-i7> (raw)
In-Reply-To: <4ee2421f-79a8-7f4d-f7ef-33f0ccf49337@sholland.org>

On 23-04-22, 21:46, Samuel Holland wrote:
> On 4/23/22 10:12 AM, Xiaobing Luo wrote:
> > --------------------------------------------
> > unreferenced object 0xffff000010742a00 (size 128):
> >   comm "swapper/0", pid 1, jiffies 4294902015 (age 1187.652s)
> >   hex dump (first 32 bytes):
> >     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> >     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> >   backtrace:
> >     [<00000000b4dfebaa>] __kmalloc+0x338/0x474
> >     [<00000000d6e716db>] sun50i_cpufreq_nvmem_probe+0xc4/0x36c
> >     [<000000007d6082a0>] platform_probe+0x98/0x11c
> >     [<00000000c990f549>] really_probe+0x234/0x5a0
> >     [<000000002d9fecc6>] __driver_probe_device+0x194/0x224
> >     [<00000000cf0b94fa>] driver_probe_device+0x64/0x13c
> >     [<00000000f238e4cf>] __device_attach_driver+0xf8/0x180
> >     [<000000006720e418>] bus_for_each_drv+0xf8/0x160
> >     [<00000000df4f14f6>] __device_attach+0x174/0x29c
> >     [<00000000782002fb>] device_initial_probe+0x20/0x30
> >     [<00000000c2681b06>] bus_probe_device+0xfc/0x110
> >     [<00000000964cf3bd>] device_add+0x5f0/0xcd0
> >     [<000000004b9264e3>] platform_device_add+0x198/0x390
> >     [<00000000fa82a9d0>] platform_device_register_full+0x178/0x210
> >     [<000000009a5daf13>] sun50i_cpufreq_init+0xf8/0x168
> >     [<000000000377cc7c>] do_one_initcall+0xe4/0x570
> > --------------------------------------------
> > 
> > if sun50i_cpufreq_get_efuse failed, then opp_tables leak.
> > Fixes: f328584f7bff ("cpufreq: Add sun50i nvmem based CPU scaling driver")
> > 
> > Signed-off-by: Xiaobing Luo <luoxiaobing0926@gmail.com>
> 
> Two minor style issues: there should be a space after "cpufreq:" in the commit
> subject. And the blank line should come before the "Fixes:" tag, not after.
> Otherwise:
> 
> Reviewed-by: Samuel Holland <samuel@sholland.org>

Applied, thanks.

-- 
viresh

WARNING: multiple messages have this Message-ID (diff)
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Samuel Holland <samuel@sholland.org>
Cc: Xiaobing Luo <luoxiaobing0926@gmail.com>,
	tiny.windzz@gmail.com, rafael@kernel.org, wens@csie.org,
	jernej.skrabec@gmail.com, mripard@kernel.org,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] cpufreq:fix memory leak in sun50i_cpufreq_nvmem_probe
Date: Mon, 25 Apr 2022 10:36:04 +0530	[thread overview]
Message-ID: <20220425050604.fv4f3s74jmvx6rlp@vireshk-i7> (raw)
In-Reply-To: <4ee2421f-79a8-7f4d-f7ef-33f0ccf49337@sholland.org>

On 23-04-22, 21:46, Samuel Holland wrote:
> On 4/23/22 10:12 AM, Xiaobing Luo wrote:
> > --------------------------------------------
> > unreferenced object 0xffff000010742a00 (size 128):
> >   comm "swapper/0", pid 1, jiffies 4294902015 (age 1187.652s)
> >   hex dump (first 32 bytes):
> >     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> >     00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00  ................
> >   backtrace:
> >     [<00000000b4dfebaa>] __kmalloc+0x338/0x474
> >     [<00000000d6e716db>] sun50i_cpufreq_nvmem_probe+0xc4/0x36c
> >     [<000000007d6082a0>] platform_probe+0x98/0x11c
> >     [<00000000c990f549>] really_probe+0x234/0x5a0
> >     [<000000002d9fecc6>] __driver_probe_device+0x194/0x224
> >     [<00000000cf0b94fa>] driver_probe_device+0x64/0x13c
> >     [<00000000f238e4cf>] __device_attach_driver+0xf8/0x180
> >     [<000000006720e418>] bus_for_each_drv+0xf8/0x160
> >     [<00000000df4f14f6>] __device_attach+0x174/0x29c
> >     [<00000000782002fb>] device_initial_probe+0x20/0x30
> >     [<00000000c2681b06>] bus_probe_device+0xfc/0x110
> >     [<00000000964cf3bd>] device_add+0x5f0/0xcd0
> >     [<000000004b9264e3>] platform_device_add+0x198/0x390
> >     [<00000000fa82a9d0>] platform_device_register_full+0x178/0x210
> >     [<000000009a5daf13>] sun50i_cpufreq_init+0xf8/0x168
> >     [<000000000377cc7c>] do_one_initcall+0xe4/0x570
> > --------------------------------------------
> > 
> > if sun50i_cpufreq_get_efuse failed, then opp_tables leak.
> > Fixes: f328584f7bff ("cpufreq: Add sun50i nvmem based CPU scaling driver")
> > 
> > Signed-off-by: Xiaobing Luo <luoxiaobing0926@gmail.com>
> 
> Two minor style issues: there should be a space after "cpufreq:" in the commit
> subject. And the blank line should come before the "Fixes:" tag, not after.
> Otherwise:
> 
> Reviewed-by: Samuel Holland <samuel@sholland.org>

Applied, thanks.

-- 
viresh

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-04-25  5:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-23 15:12 [PATCH v2] cpufreq:fix memory leak in sun50i_cpufreq_nvmem_probe Xiaobing Luo
2022-04-23 15:12 ` Xiaobing Luo
2022-04-24  2:46 ` Samuel Holland
2022-04-24  2:46   ` Samuel Holland
2022-04-25  5:06   ` Viresh Kumar [this message]
2022-04-25  5:06     ` Viresh Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425050604.fv4f3s74jmvx6rlp@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=luoxiaobing0926@gmail.com \
    --cc=mripard@kernel.org \
    --cc=rafael@kernel.org \
    --cc=samuel@sholland.org \
    --cc=tiny.windzz@gmail.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.