From: Alexander Usyskin <alexander.usyskin@intel.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Cc: Tomas Winkler <tomas.winkler@intel.com>, Alexander Usyskin <alexander.usyskin@intel.com>, Vitaly Lubart <vitaly.lubart@intel.com>, intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Subject: [PATCH v2 02/14] drm/i915/gsc: skip irq initialization if using polling Date: Mon, 25 Apr 2022 10:48:49 +0300 [thread overview] Message-ID: <20220425074901.3991274-3-alexander.usyskin@intel.com> (raw) In-Reply-To: <20220425074901.3991274-1-alexander.usyskin@intel.com> From: Vitaly Lubart <vitaly.lubart@intel.com> Some platforms require the host to poll on the GSC registers instead of relaying on the interrupts. For those platforms, irq initialization should be skipped Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> --- drivers/gpu/drm/i915/gt/intel_gsc.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c b/drivers/gpu/drm/i915/gt/intel_gsc.c index 0e494028b81d..e0236ff1d072 100644 --- a/drivers/gpu/drm/i915/gt/intel_gsc.c +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c @@ -40,6 +40,7 @@ struct gsc_def { const char *name; unsigned long bar; size_t bar_size; + bool use_polling; }; /* gsc resources and definitions (HECI1 and HECI2) */ @@ -117,6 +118,10 @@ static void gsc_init_one(struct drm_i915_private *i915, return; } + /* skip irq initialization */ + if (def->use_polling) + goto add_device; + intf->irq = irq_alloc_desc(0); if (intf->irq < 0) { drm_err(&i915->drm, "gsc irq error %d\n", intf->irq); @@ -129,6 +134,7 @@ static void gsc_init_one(struct drm_i915_private *i915, goto fail; } +add_device: adev = kzalloc(sizeof(*adev), GFP_KERNEL); if (!adev) goto fail; @@ -182,10 +188,8 @@ static void gsc_irq_handler(struct intel_gt *gt, unsigned int intf_id) return; } - if (gt->gsc.intf[intf_id].irq < 0) { - drm_err_ratelimited(>->i915->drm, "GSC irq: irq not set"); + if (gt->gsc.intf[intf_id].irq < 0) return; - } ret = generic_handle_irq(gt->gsc.intf[intf_id].irq); if (ret) -- 2.32.0
WARNING: multiple messages have this Message-ID (diff)
From: Alexander Usyskin <alexander.usyskin@intel.com> To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, Jani Nikula <jani.nikula@linux.intel.com>, Joonas Lahtinen <joonas.lahtinen@linux.intel.com>, Rodrigo Vivi <rodrigo.vivi@intel.com>, David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> Cc: intel-gfx@lists.freedesktop.org, Alexander Usyskin <alexander.usyskin@intel.com>, linux-kernel@vger.kernel.org, Tomas Winkler <tomas.winkler@intel.com>, Vitaly Lubart <vitaly.lubart@intel.com> Subject: [Intel-gfx] [PATCH v2 02/14] drm/i915/gsc: skip irq initialization if using polling Date: Mon, 25 Apr 2022 10:48:49 +0300 [thread overview] Message-ID: <20220425074901.3991274-3-alexander.usyskin@intel.com> (raw) In-Reply-To: <20220425074901.3991274-1-alexander.usyskin@intel.com> From: Vitaly Lubart <vitaly.lubart@intel.com> Some platforms require the host to poll on the GSC registers instead of relaying on the interrupts. For those platforms, irq initialization should be skipped Signed-off-by: Vitaly Lubart <vitaly.lubart@intel.com> Signed-off-by: Tomas Winkler <tomas.winkler@intel.com> Signed-off-by: Alexander Usyskin <alexander.usyskin@intel.com> Reviewed-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> --- drivers/gpu/drm/i915/gt/intel_gsc.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gt/intel_gsc.c b/drivers/gpu/drm/i915/gt/intel_gsc.c index 0e494028b81d..e0236ff1d072 100644 --- a/drivers/gpu/drm/i915/gt/intel_gsc.c +++ b/drivers/gpu/drm/i915/gt/intel_gsc.c @@ -40,6 +40,7 @@ struct gsc_def { const char *name; unsigned long bar; size_t bar_size; + bool use_polling; }; /* gsc resources and definitions (HECI1 and HECI2) */ @@ -117,6 +118,10 @@ static void gsc_init_one(struct drm_i915_private *i915, return; } + /* skip irq initialization */ + if (def->use_polling) + goto add_device; + intf->irq = irq_alloc_desc(0); if (intf->irq < 0) { drm_err(&i915->drm, "gsc irq error %d\n", intf->irq); @@ -129,6 +134,7 @@ static void gsc_init_one(struct drm_i915_private *i915, goto fail; } +add_device: adev = kzalloc(sizeof(*adev), GFP_KERNEL); if (!adev) goto fail; @@ -182,10 +188,8 @@ static void gsc_irq_handler(struct intel_gt *gt, unsigned int intf_id) return; } - if (gt->gsc.intf[intf_id].irq < 0) { - drm_err_ratelimited(>->i915->drm, "GSC irq: irq not set"); + if (gt->gsc.intf[intf_id].irq < 0) return; - } ret = generic_handle_irq(gt->gsc.intf[intf_id].irq); if (ret) -- 2.32.0
next prev parent reply other threads:[~2022-04-25 7:49 UTC|newest] Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-25 7:48 [PATCH v2 00/14] GSC support for XeHP SDV and DG2 platforms Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] " Alexander Usyskin 2022-04-25 7:48 ` [PATCH v2 01/14] HAX: drm/i915: force INTEL_MEI_GSC on for CI Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] " Alexander Usyskin 2022-04-25 7:48 ` Alexander Usyskin [this message] 2022-04-25 7:48 ` [Intel-gfx] [PATCH v2 02/14] drm/i915/gsc: skip irq initialization if using polling Alexander Usyskin 2022-04-25 7:48 ` [PATCH v2 03/14] drm/i915/gsc: add slow_fw flag to the mei auxiliary device Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] " Alexander Usyskin 2022-04-25 7:48 ` [PATCH v2 04/14] drm/i915/gsc: add slow_fw flag to the gsc device definition Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] " Alexander Usyskin 2022-04-25 7:48 ` [PATCH v2 05/14] drm/i915/gsc: add GSC XeHP SDV platform definition Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] " Alexander Usyskin 2022-04-25 7:48 ` [PATCH v2 06/14] mei: gsc: use polling instead of interrupts Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] " Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] [PATCH v2 07/14] mei: gsc: wait for reset thread on stop Alexander Usyskin 2022-04-25 7:48 ` Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] [PATCH v2 08/14] mei: extend timeouts on slow devices Alexander Usyskin 2022-04-25 7:48 ` Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] [PATCH v2 09/14] mei: bus: export common mkhi definitions into a separate header Alexander Usyskin 2022-04-25 7:48 ` Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] [PATCH v2 10/14] mei: mkhi: add memory ready command Alexander Usyskin 2022-04-25 7:48 ` Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] [PATCH v2 11/14] mei: gsc: setup gsc extended operational memory Alexander Usyskin 2022-04-25 7:48 ` Alexander Usyskin 2022-04-25 7:48 ` [Intel-gfx] [PATCH v2 12/14] mei: gsc: add transition to PXP mode in resume flow Alexander Usyskin 2022-04-25 7:48 ` Alexander Usyskin 2022-04-25 7:49 ` [Intel-gfx] [PATCH v2 13/14] mei: debugfs: add pxp mode to devstate in debugfs Alexander Usyskin 2022-04-25 7:49 ` Alexander Usyskin 2022-04-25 7:49 ` [Intel-gfx] [PATCH v2 14/14] drm/i915/gsc: allocate extended operational memory in LMEM Alexander Usyskin 2022-04-25 7:49 ` Alexander Usyskin 2022-04-25 10:50 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for GSC support for XeHP SDV and DG2 platforms (rev2) Patchwork 2022-04-25 10:50 ` [Intel-gfx] ✗ Fi.CI.SPARSE: " Patchwork 2022-04-25 11:23 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork 2022-05-18 16:00 ` [PATCH v2 00/14] GSC support for XeHP SDV and DG2 platforms Usyskin, Alexander 2022-05-18 16:00 ` [Intel-gfx] " Usyskin, Alexander
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220425074901.3991274-3-alexander.usyskin@intel.com \ --to=alexander.usyskin@intel.com \ --cc=airlied@linux.ie \ --cc=daniel@ffwll.ch \ --cc=daniele.ceraolospurio@intel.com \ --cc=gregkh@linuxfoundation.org \ --cc=intel-gfx@lists.freedesktop.org \ --cc=jani.nikula@linux.intel.com \ --cc=joonas.lahtinen@linux.intel.com \ --cc=linux-kernel@vger.kernel.org \ --cc=rodrigo.vivi@intel.com \ --cc=tomas.winkler@intel.com \ --cc=tvrtko.ursulin@linux.intel.com \ --cc=vitaly.lubart@intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.