All of lore.kernel.org
 help / color / mirror / Atom feed
From: cgel.zte@gmail.com
To: daniel@thingy.jp
Cc: romain.perier@gmail.com, daniel.lezcano@linaro.org,
	tglx@linutronix.de, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Minghao Chi <chi.minghao@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>
Subject: [PATCH] clocksource/drivers: remove unnecessary return in switch statement
Date: Mon, 25 Apr 2022 08:46:44 +0000	[thread overview]
Message-ID: <20220425084644.3495153-1-chi.minghao@zte.com.cn> (raw)

From: Minghao Chi <chi.minghao@zte.com.cn>

Since there's a return immediately after the 'break', there's no need for
this extra 'return'.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 drivers/clocksource/timer-msc313e.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/clocksource/timer-msc313e.c b/drivers/clocksource/timer-msc313e.c
index 54c54ca7c786..fedcbcafd320 100644
--- a/drivers/clocksource/timer-msc313e.c
+++ b/drivers/clocksource/timer-msc313e.c
@@ -233,14 +233,10 @@ static int __init msc313e_timer_init(struct device_node *np)
 	switch (num_called) {
 	case 0:
 		ret = msc313e_clksrc_init(np);
-		if (ret)
-			return ret;
 		break;
 
 	default:
 		ret = msc313e_clkevt_init(np);
-		if (ret)
-			return ret;
 		break;
 	}
 
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: cgel.zte@gmail.com
To: daniel@thingy.jp
Cc: romain.perier@gmail.com, daniel.lezcano@linaro.org,
	tglx@linutronix.de, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Minghao Chi <chi.minghao@zte.com.cn>,
	Zeal Robot <zealci@zte.com.cn>
Subject: [PATCH] clocksource/drivers: remove unnecessary return in switch statement
Date: Mon, 25 Apr 2022 08:46:44 +0000	[thread overview]
Message-ID: <20220425084644.3495153-1-chi.minghao@zte.com.cn> (raw)

From: Minghao Chi <chi.minghao@zte.com.cn>

Since there's a return immediately after the 'break', there's no need for
this extra 'return'.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Minghao Chi <chi.minghao@zte.com.cn>
---
 drivers/clocksource/timer-msc313e.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/clocksource/timer-msc313e.c b/drivers/clocksource/timer-msc313e.c
index 54c54ca7c786..fedcbcafd320 100644
--- a/drivers/clocksource/timer-msc313e.c
+++ b/drivers/clocksource/timer-msc313e.c
@@ -233,14 +233,10 @@ static int __init msc313e_timer_init(struct device_node *np)
 	switch (num_called) {
 	case 0:
 		ret = msc313e_clksrc_init(np);
-		if (ret)
-			return ret;
 		break;
 
 	default:
 		ret = msc313e_clkevt_init(np);
-		if (ret)
-			return ret;
 		break;
 	}
 
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

             reply	other threads:[~2022-04-25  8:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-25  8:46 cgel.zte [this message]
2022-04-25  8:46 ` [PATCH] clocksource/drivers: remove unnecessary return in switch statement cgel.zte
2022-04-25 18:05 ` kernel test robot
2022-04-25 18:05   ` kernel test robot
2022-05-02  0:01 kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220425084644.3495153-1-chi.minghao@zte.com.cn \
    --to=cgel.zte@gmail.com \
    --cc=chi.minghao@zte.com.cn \
    --cc=daniel.lezcano@linaro.org \
    --cc=daniel@thingy.jp \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=romain.perier@gmail.com \
    --cc=tglx@linutronix.de \
    --cc=zealci@zte.com.cn \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.