From: kernel test robot <lkp@intel.com>
To: Peter Collingbourne <pcc@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Peter Collingbourne <pcc@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
vbabka@suse.cz, penberg@kernel.org, roman.gushchin@linux.dev,
iamjoonsoo.kim@lge.com, rientjes@google.com,
Herbert Xu <herbert@gondor.apana.org.au>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v3] mm: make minimum slab alignment a runtime property
Date: Mon, 25 Apr 2022 13:12:47 +0800 [thread overview]
Message-ID: <202204251346.WbwgrNZw-lkp@intel.com> (raw)
In-Reply-To: <20220422201830.288018-1-pcc@google.com>
Hi Peter,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on hnaz-mm/master]
url: https://github.com/intel-lab-lkp/linux/commits/Peter-Collingbourne/mm-make-minimum-slab-alignment-a-runtime-property/20220423-042024
base: https://github.com/hnaz/linux-mm master
config: arm64-buildonly-randconfig-r002-20220425 (https://download.01.org/0day-ci/archive/20220425/202204251346.WbwgrNZw-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/3aef97055dd4a480e05dff758164f153aaddbb49
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Peter-Collingbourne/mm-make-minimum-slab-alignment-a-runtime-property/20220423-042024
git checkout 3aef97055dd4a480e05dff758164f153aaddbb49
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 prepare
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/bounds.c:10:
In file included from include/linux/page-flags.h:10:
In file included from include/linux/bug.h:5:
In file included from arch/arm64/include/asm/bug.h:26:
In file included from include/asm-generic/bug.h:22:
In file included from include/linux/printk.h:9:
In file included from include/linux/cache.h:6:
In file included from arch/arm64/include/asm/cache.h:56:
In file included from include/linux/kasan-enabled.h:5:
In file included from include/linux/static_key.h:1:
>> include/linux/jump_label.h:285:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
STATIC_KEY_CHECK_USE(key);
^
include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE'
#define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \
^
include/linux/jump_label.h:291:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
STATIC_KEY_CHECK_USE(key);
^
include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE'
#define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \
^
include/linux/jump_label.h:313:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
STATIC_KEY_CHECK_USE(key);
^
include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE'
#define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \
^
>> include/linux/jump_label.h:316:3: error: call to undeclared function 'WARN_ON_ONCE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
WARN_ON_ONCE(atomic_read(&key->enabled) != 1);
^
include/linux/jump_label.h:324:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
STATIC_KEY_CHECK_USE(key);
^
include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE'
#define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \
^
include/linux/jump_label.h:327:3: error: call to undeclared function 'WARN_ON_ONCE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
WARN_ON_ONCE(atomic_read(&key->enabled) != 0);
^
6 errors generated.
make[2]: *** [scripts/Makefile.build:122: kernel/bounds.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1283: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:226: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/WARN +285 include/linux/jump_label.h
bf5438fca2950b Jason Baron 2010-09-17 282
c5905afb0ee655 Ingo Molnar 2012-02-24 283 static inline void static_key_slow_inc(struct static_key *key)
d430d3d7e646eb Jason Baron 2011-03-16 284 {
5cdda5117e125e Borislav Petkov 2017-10-18 @285 STATIC_KEY_CHECK_USE(key);
d430d3d7e646eb Jason Baron 2011-03-16 286 atomic_inc(&key->enabled);
d430d3d7e646eb Jason Baron 2011-03-16 287 }
bf5438fca2950b Jason Baron 2010-09-17 288
c5905afb0ee655 Ingo Molnar 2012-02-24 289 static inline void static_key_slow_dec(struct static_key *key)
bf5438fca2950b Jason Baron 2010-09-17 290 {
5cdda5117e125e Borislav Petkov 2017-10-18 291 STATIC_KEY_CHECK_USE(key);
d430d3d7e646eb Jason Baron 2011-03-16 292 atomic_dec(&key->enabled);
bf5438fca2950b Jason Baron 2010-09-17 293 }
bf5438fca2950b Jason Baron 2010-09-17 294
ce48c146495a1a Peter Zijlstra 2018-01-22 295 #define static_key_slow_inc_cpuslocked(key) static_key_slow_inc(key)
ce48c146495a1a Peter Zijlstra 2018-01-22 296 #define static_key_slow_dec_cpuslocked(key) static_key_slow_dec(key)
ce48c146495a1a Peter Zijlstra 2018-01-22 297
4c3ef6d79328c0 Jason Baron 2010-09-17 298 static inline int jump_label_text_reserved(void *start, void *end)
4c3ef6d79328c0 Jason Baron 2010-09-17 299 {
4c3ef6d79328c0 Jason Baron 2010-09-17 300 return 0;
4c3ef6d79328c0 Jason Baron 2010-09-17 301 }
4c3ef6d79328c0 Jason Baron 2010-09-17 302
91bad2f8d30574 Jason Baron 2010-10-01 303 static inline void jump_label_lock(void) {}
91bad2f8d30574 Jason Baron 2010-10-01 304 static inline void jump_label_unlock(void) {}
91bad2f8d30574 Jason Baron 2010-10-01 305
d430d3d7e646eb Jason Baron 2011-03-16 306 static inline int jump_label_apply_nops(struct module *mod)
d430d3d7e646eb Jason Baron 2011-03-16 307 {
d430d3d7e646eb Jason Baron 2011-03-16 308 return 0;
d430d3d7e646eb Jason Baron 2011-03-16 309 }
b202952075f626 Gleb Natapov 2011-11-27 310
e33886b38cc82a Peter Zijlstra 2015-07-24 311 static inline void static_key_enable(struct static_key *key)
e33886b38cc82a Peter Zijlstra 2015-07-24 312 {
5cdda5117e125e Borislav Petkov 2017-10-18 313 STATIC_KEY_CHECK_USE(key);
e33886b38cc82a Peter Zijlstra 2015-07-24 314
1dbb6704de91b1 Paolo Bonzini 2017-08-01 315 if (atomic_read(&key->enabled) != 0) {
1dbb6704de91b1 Paolo Bonzini 2017-08-01 @316 WARN_ON_ONCE(atomic_read(&key->enabled) != 1);
1dbb6704de91b1 Paolo Bonzini 2017-08-01 317 return;
1dbb6704de91b1 Paolo Bonzini 2017-08-01 318 }
1dbb6704de91b1 Paolo Bonzini 2017-08-01 319 atomic_set(&key->enabled, 1);
e33886b38cc82a Peter Zijlstra 2015-07-24 320 }
e33886b38cc82a Peter Zijlstra 2015-07-24 321
--
0-DAY CI Kernel Test Service
https://01.org/lkp
WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Peter Collingbourne <pcc@google.com>,
Andrey Konovalov <andreyknvl@gmail.com>,
Hyeonggon Yoo <42.hyeyoo@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Catalin Marinas <catalin.marinas@arm.com>
Cc: llvm@lists.linux.dev, kbuild-all@lists.01.org,
Linux Memory Management List <linux-mm@kvack.org>,
Peter Collingbourne <pcc@google.com>,
Linux ARM <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
vbabka@suse.cz, penberg@kernel.org, roman.gushchin@linux.dev,
iamjoonsoo.kim@lge.com, rientjes@google.com,
Herbert Xu <herbert@gondor.apana.org.au>,
Andrey Ryabinin <ryabinin.a.a@gmail.com>,
Alexander Potapenko <glider@google.com>,
Dmitry Vyukov <dvyukov@google.com>,
kasan-dev <kasan-dev@googlegroups.com>,
Eric Biederman <ebiederm@xmission.com>,
Kees Cook <keescook@chromium.org>
Subject: Re: [PATCH v3] mm: make minimum slab alignment a runtime property
Date: Mon, 25 Apr 2022 13:12:47 +0800 [thread overview]
Message-ID: <202204251346.WbwgrNZw-lkp@intel.com> (raw)
In-Reply-To: <20220422201830.288018-1-pcc@google.com>
Hi Peter,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on hnaz-mm/master]
url: https://github.com/intel-lab-lkp/linux/commits/Peter-Collingbourne/mm-make-minimum-slab-alignment-a-runtime-property/20220423-042024
base: https://github.com/hnaz/linux-mm master
config: arm64-buildonly-randconfig-r002-20220425 (https://download.01.org/0day-ci/archive/20220425/202204251346.WbwgrNZw-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 1cddcfdc3c683b393df1a5c9063252eb60e52818)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/intel-lab-lkp/linux/commit/3aef97055dd4a480e05dff758164f153aaddbb49
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Peter-Collingbourne/mm-make-minimum-slab-alignment-a-runtime-property/20220423-042024
git checkout 3aef97055dd4a480e05dff758164f153aaddbb49
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 prepare
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All errors (new ones prefixed by >>):
In file included from kernel/bounds.c:10:
In file included from include/linux/page-flags.h:10:
In file included from include/linux/bug.h:5:
In file included from arch/arm64/include/asm/bug.h:26:
In file included from include/asm-generic/bug.h:22:
In file included from include/linux/printk.h:9:
In file included from include/linux/cache.h:6:
In file included from arch/arm64/include/asm/cache.h:56:
In file included from include/linux/kasan-enabled.h:5:
In file included from include/linux/static_key.h:1:
>> include/linux/jump_label.h:285:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
STATIC_KEY_CHECK_USE(key);
^
include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE'
#define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \
^
include/linux/jump_label.h:291:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
STATIC_KEY_CHECK_USE(key);
^
include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE'
#define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \
^
include/linux/jump_label.h:313:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
STATIC_KEY_CHECK_USE(key);
^
include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE'
#define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \
^
>> include/linux/jump_label.h:316:3: error: call to undeclared function 'WARN_ON_ONCE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
WARN_ON_ONCE(atomic_read(&key->enabled) != 1);
^
include/linux/jump_label.h:324:2: error: call to undeclared function 'WARN'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
STATIC_KEY_CHECK_USE(key);
^
include/linux/jump_label.h:81:35: note: expanded from macro 'STATIC_KEY_CHECK_USE'
#define STATIC_KEY_CHECK_USE(key) WARN(!static_key_initialized, \
^
include/linux/jump_label.h:327:3: error: call to undeclared function 'WARN_ON_ONCE'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
WARN_ON_ONCE(atomic_read(&key->enabled) != 0);
^
6 errors generated.
make[2]: *** [scripts/Makefile.build:122: kernel/bounds.s] Error 1
make[2]: Target '__build' not remade because of errors.
make[1]: *** [Makefile:1283: prepare0] Error 2
make[1]: Target 'prepare' not remade because of errors.
make: *** [Makefile:226: __sub-make] Error 2
make: Target 'prepare' not remade because of errors.
vim +/WARN +285 include/linux/jump_label.h
bf5438fca2950b Jason Baron 2010-09-17 282
c5905afb0ee655 Ingo Molnar 2012-02-24 283 static inline void static_key_slow_inc(struct static_key *key)
d430d3d7e646eb Jason Baron 2011-03-16 284 {
5cdda5117e125e Borislav Petkov 2017-10-18 @285 STATIC_KEY_CHECK_USE(key);
d430d3d7e646eb Jason Baron 2011-03-16 286 atomic_inc(&key->enabled);
d430d3d7e646eb Jason Baron 2011-03-16 287 }
bf5438fca2950b Jason Baron 2010-09-17 288
c5905afb0ee655 Ingo Molnar 2012-02-24 289 static inline void static_key_slow_dec(struct static_key *key)
bf5438fca2950b Jason Baron 2010-09-17 290 {
5cdda5117e125e Borislav Petkov 2017-10-18 291 STATIC_KEY_CHECK_USE(key);
d430d3d7e646eb Jason Baron 2011-03-16 292 atomic_dec(&key->enabled);
bf5438fca2950b Jason Baron 2010-09-17 293 }
bf5438fca2950b Jason Baron 2010-09-17 294
ce48c146495a1a Peter Zijlstra 2018-01-22 295 #define static_key_slow_inc_cpuslocked(key) static_key_slow_inc(key)
ce48c146495a1a Peter Zijlstra 2018-01-22 296 #define static_key_slow_dec_cpuslocked(key) static_key_slow_dec(key)
ce48c146495a1a Peter Zijlstra 2018-01-22 297
4c3ef6d79328c0 Jason Baron 2010-09-17 298 static inline int jump_label_text_reserved(void *start, void *end)
4c3ef6d79328c0 Jason Baron 2010-09-17 299 {
4c3ef6d79328c0 Jason Baron 2010-09-17 300 return 0;
4c3ef6d79328c0 Jason Baron 2010-09-17 301 }
4c3ef6d79328c0 Jason Baron 2010-09-17 302
91bad2f8d30574 Jason Baron 2010-10-01 303 static inline void jump_label_lock(void) {}
91bad2f8d30574 Jason Baron 2010-10-01 304 static inline void jump_label_unlock(void) {}
91bad2f8d30574 Jason Baron 2010-10-01 305
d430d3d7e646eb Jason Baron 2011-03-16 306 static inline int jump_label_apply_nops(struct module *mod)
d430d3d7e646eb Jason Baron 2011-03-16 307 {
d430d3d7e646eb Jason Baron 2011-03-16 308 return 0;
d430d3d7e646eb Jason Baron 2011-03-16 309 }
b202952075f626 Gleb Natapov 2011-11-27 310
e33886b38cc82a Peter Zijlstra 2015-07-24 311 static inline void static_key_enable(struct static_key *key)
e33886b38cc82a Peter Zijlstra 2015-07-24 312 {
5cdda5117e125e Borislav Petkov 2017-10-18 313 STATIC_KEY_CHECK_USE(key);
e33886b38cc82a Peter Zijlstra 2015-07-24 314
1dbb6704de91b1 Paolo Bonzini 2017-08-01 315 if (atomic_read(&key->enabled) != 0) {
1dbb6704de91b1 Paolo Bonzini 2017-08-01 @316 WARN_ON_ONCE(atomic_read(&key->enabled) != 1);
1dbb6704de91b1 Paolo Bonzini 2017-08-01 317 return;
1dbb6704de91b1 Paolo Bonzini 2017-08-01 318 }
1dbb6704de91b1 Paolo Bonzini 2017-08-01 319 atomic_set(&key->enabled, 1);
e33886b38cc82a Peter Zijlstra 2015-07-24 320 }
e33886b38cc82a Peter Zijlstra 2015-07-24 321
--
0-DAY CI Kernel Test Service
https://01.org/lkp
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-25 5:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 20:18 [PATCH v3] mm: make minimum slab alignment a runtime property Peter Collingbourne
2022-04-22 20:18 ` Peter Collingbourne
2022-04-24 10:45 ` Hyeonggon Yoo
2022-04-24 10:45 ` Hyeonggon Yoo
2022-04-24 19:15 ` David Rientjes
2022-04-24 19:15 ` David Rientjes
2022-04-25 5:12 ` kernel test robot [this message]
2022-04-25 5:12 ` kernel test robot
2022-04-26 15:12 ` Vlastimil Babka
2022-04-26 15:12 ` Vlastimil Babka
2022-04-26 15:12 ` Vlastimil Babka
2022-04-26 18:15 ` Peter Collingbourne
2022-04-26 18:15 ` Peter Collingbourne
2022-04-26 18:15 ` Peter Collingbourne
2022-04-25 15:56 ` Catalin Marinas
2022-04-25 15:56 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202204251346.WbwgrNZw-lkp@intel.com \
--to=lkp@intel.com \
--cc=42.hyeyoo@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=andreyknvl@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=glider@google.com \
--cc=herbert@gondor.apana.org.au \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=kbuild-all@lists.01.org \
--cc=keescook@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=llvm@lists.linux.dev \
--cc=pcc@google.com \
--cc=penberg@kernel.org \
--cc=rientjes@google.com \
--cc=roman.gushchin@linux.dev \
--cc=ryabinin.a.a@gmail.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.