* [PATCH] Revert "block: release rq qos structures for queue without disk"
@ 2022-04-26 2:49 Ming Lei
2022-05-02 16:03 ` Ming Lei
2022-05-02 16:06 ` Jens Axboe
0 siblings, 2 replies; 3+ messages in thread
From: Ming Lei @ 2022-04-26 2:49 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, Ming Lei
This reverts commit daaca3522a8e67c46e39ef09c1d542e866f85f3b.
Commit daaca3522a8e ("block: release rq qos structures for queue without
disk") is only needed for v5.15~v5.17, and isn't needed for v5.18, so
revert it.
Signed-off-by: Ming Lei <ming.lei@redhat.com>
---
block/blk-core.c | 4 ----
1 file changed, 4 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 245ec664753d..d44a93ad8fcb 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -50,7 +50,6 @@
#include "blk-pm.h"
#include "blk-cgroup.h"
#include "blk-throttle.h"
-#include "blk-rq-qos.h"
struct dentry *blk_debugfs_root;
@@ -315,9 +314,6 @@ void blk_cleanup_queue(struct request_queue *q)
*/
blk_freeze_queue(q);
- /* cleanup rq qos structures for queue without disk */
- rq_qos_exit(q);
-
blk_queue_flag_set(QUEUE_FLAG_DEAD, q);
blk_sync_queue(q);
--
2.31.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "block: release rq qos structures for queue without disk"
2022-04-26 2:49 [PATCH] Revert "block: release rq qos structures for queue without disk" Ming Lei
@ 2022-05-02 16:03 ` Ming Lei
2022-05-02 16:06 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Ming Lei @ 2022-05-02 16:03 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block
On Tue, Apr 26, 2022 at 10:49:36AM +0800, Ming Lei wrote:
> This reverts commit daaca3522a8e67c46e39ef09c1d542e866f85f3b.
>
> Commit daaca3522a8e ("block: release rq qos structures for queue without
> disk") is only needed for v5.15~v5.17, and isn't needed for v5.18, so
> revert it.
>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
> ---
Hello Guys,
Ping...
Thanks,
Ming
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Revert "block: release rq qos structures for queue without disk"
2022-04-26 2:49 [PATCH] Revert "block: release rq qos structures for queue without disk" Ming Lei
2022-05-02 16:03 ` Ming Lei
@ 2022-05-02 16:06 ` Jens Axboe
1 sibling, 0 replies; 3+ messages in thread
From: Jens Axboe @ 2022-05-02 16:06 UTC (permalink / raw)
To: ming.lei; +Cc: linux-block
On Tue, 26 Apr 2022 10:49:36 +0800, Ming Lei wrote:
> This reverts commit daaca3522a8e67c46e39ef09c1d542e866f85f3b.
>
> Commit daaca3522a8e ("block: release rq qos structures for queue without
> disk") is only needed for v5.15~v5.17, and isn't needed for v5.18, so
> revert it.
>
>
> [...]
Applied, thanks!
[1/1] Revert "block: release rq qos structures for queue without disk"
commit: 285d5731a0cb2dd3a12ddf34d67be4e4965e64da
Best regards,
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-02 16:07 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 2:49 [PATCH] Revert "block: release rq qos structures for queue without disk" Ming Lei
2022-05-02 16:03 ` Ming Lei
2022-05-02 16:06 ` Jens Axboe
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.