* [PATCH -next 1/3] [media] dm355_ccdc: remove unnecessary check of res
@ 2022-04-26 3:05 Yang Yingliang
2022-04-26 3:05 ` [PATCH -next 2/3] [media] dm644x_ccdc: " Yang Yingliang
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Yang Yingliang @ 2022-04-26 3:05 UTC (permalink / raw)
To: linux-kernel, linux-media; +Cc: mchehab, laurent.pinchart, prabhakar.csengg
The resource is checked in probe function, so there is
no need do this check in remove function.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/platform/ti/davinci/dm355_ccdc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/ti/davinci/dm355_ccdc.c b/drivers/media/platform/ti/davinci/dm355_ccdc.c
index e06d113dfe96..8fe55d1b972c 100644
--- a/drivers/media/platform/ti/davinci/dm355_ccdc.c
+++ b/drivers/media/platform/ti/davinci/dm355_ccdc.c
@@ -918,8 +918,7 @@ static int dm355_ccdc_remove(struct platform_device *pdev)
iounmap(ccdc_cfg.base_addr);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (res)
- release_mem_region(res->start, resource_size(res));
+ release_mem_region(res->start, resource_size(res));
vpfe_unregister_ccdc_device(&ccdc_hw_dev);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next 2/3] [media] dm644x_ccdc: remove unnecessary check of res
2022-04-26 3:05 [PATCH -next 1/3] [media] dm355_ccdc: remove unnecessary check of res Yang Yingliang
@ 2022-04-26 3:05 ` Yang Yingliang
2022-05-18 19:42 ` Lad, Prabhakar
2022-04-26 3:05 ` [PATCH -next 3/3] media: isif: " Yang Yingliang
2022-05-18 19:41 ` [PATCH -next 1/3] [media] dm355_ccdc: " Lad, Prabhakar
2 siblings, 1 reply; 6+ messages in thread
From: Yang Yingliang @ 2022-04-26 3:05 UTC (permalink / raw)
To: linux-kernel, linux-media; +Cc: mchehab, laurent.pinchart, prabhakar.csengg
The resource is checked in probe function, so there is
no need do this check in remove function.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/platform/ti/davinci/dm644x_ccdc.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/ti/davinci/dm644x_ccdc.c b/drivers/media/platform/ti/davinci/dm644x_ccdc.c
index c6378c4e0074..e4073e99914c 100644
--- a/drivers/media/platform/ti/davinci/dm644x_ccdc.c
+++ b/drivers/media/platform/ti/davinci/dm644x_ccdc.c
@@ -839,8 +839,7 @@ static int dm644x_ccdc_remove(struct platform_device *pdev)
iounmap(ccdc_cfg.base_addr);
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (res)
- release_mem_region(res->start, resource_size(res));
+ release_mem_region(res->start, resource_size(res));
vpfe_unregister_ccdc_device(&ccdc_hw_dev);
return 0;
}
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH -next 3/3] media: isif: remove unnecessary check of res
2022-04-26 3:05 [PATCH -next 1/3] [media] dm355_ccdc: remove unnecessary check of res Yang Yingliang
2022-04-26 3:05 ` [PATCH -next 2/3] [media] dm644x_ccdc: " Yang Yingliang
@ 2022-04-26 3:05 ` Yang Yingliang
2022-05-18 19:46 ` Lad, Prabhakar
2022-05-18 19:41 ` [PATCH -next 1/3] [media] dm355_ccdc: " Lad, Prabhakar
2 siblings, 1 reply; 6+ messages in thread
From: Yang Yingliang @ 2022-04-26 3:05 UTC (permalink / raw)
To: linux-kernel, linux-media; +Cc: mchehab, laurent.pinchart, prabhakar.csengg
The resource is checked in probe function, so there is
no need do this check in remove function.
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
drivers/media/platform/ti/davinci/isif.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/media/platform/ti/davinci/isif.c b/drivers/media/platform/ti/davinci/isif.c
index c53cecd072b1..69e862de014f 100644
--- a/drivers/media/platform/ti/davinci/isif.c
+++ b/drivers/media/platform/ti/davinci/isif.c
@@ -1107,8 +1107,7 @@ static int isif_remove(struct platform_device *pdev)
isif_cfg.linear_tbl1_addr = NULL;
while (i < 3) {
res = platform_get_resource(pdev, IORESOURCE_MEM, i);
- if (res)
- release_mem_region(res->start, resource_size(res));
+ release_mem_region(res->start, resource_size(res));
i++;
}
vpfe_unregister_ccdc_device(&isif_hw_dev);
--
2.25.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH -next 1/3] [media] dm355_ccdc: remove unnecessary check of res
2022-04-26 3:05 [PATCH -next 1/3] [media] dm355_ccdc: remove unnecessary check of res Yang Yingliang
2022-04-26 3:05 ` [PATCH -next 2/3] [media] dm644x_ccdc: " Yang Yingliang
2022-04-26 3:05 ` [PATCH -next 3/3] media: isif: " Yang Yingliang
@ 2022-05-18 19:41 ` Lad, Prabhakar
2 siblings, 0 replies; 6+ messages in thread
From: Lad, Prabhakar @ 2022-05-18 19:41 UTC (permalink / raw)
To: Yang Yingliang; +Cc: LKML, linux-media, Mauro Carvalho Chehab, Laurent Pinchart
On Tue, Apr 26, 2022 at 3:53 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> The resource is checked in probe function, so there is
> no need do this check in remove function.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/platform/ti/davinci/dm355_ccdc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cheers,
Prabhakar
> diff --git a/drivers/media/platform/ti/davinci/dm355_ccdc.c b/drivers/media/platform/ti/davinci/dm355_ccdc.c
> index e06d113dfe96..8fe55d1b972c 100644
> --- a/drivers/media/platform/ti/davinci/dm355_ccdc.c
> +++ b/drivers/media/platform/ti/davinci/dm355_ccdc.c
> @@ -918,8 +918,7 @@ static int dm355_ccdc_remove(struct platform_device *pdev)
>
> iounmap(ccdc_cfg.base_addr);
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (res)
> - release_mem_region(res->start, resource_size(res));
> + release_mem_region(res->start, resource_size(res));
> vpfe_unregister_ccdc_device(&ccdc_hw_dev);
> return 0;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next 2/3] [media] dm644x_ccdc: remove unnecessary check of res
2022-04-26 3:05 ` [PATCH -next 2/3] [media] dm644x_ccdc: " Yang Yingliang
@ 2022-05-18 19:42 ` Lad, Prabhakar
0 siblings, 0 replies; 6+ messages in thread
From: Lad, Prabhakar @ 2022-05-18 19:42 UTC (permalink / raw)
To: Yang Yingliang; +Cc: LKML, linux-media, Mauro Carvalho Chehab, Laurent Pinchart
On Tue, Apr 26, 2022 at 3:53 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> The resource is checked in probe function, so there is
> no need do this check in remove function.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/platform/ti/davinci/dm644x_ccdc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cheers,
Prabhakar
> diff --git a/drivers/media/platform/ti/davinci/dm644x_ccdc.c b/drivers/media/platform/ti/davinci/dm644x_ccdc.c
> index c6378c4e0074..e4073e99914c 100644
> --- a/drivers/media/platform/ti/davinci/dm644x_ccdc.c
> +++ b/drivers/media/platform/ti/davinci/dm644x_ccdc.c
> @@ -839,8 +839,7 @@ static int dm644x_ccdc_remove(struct platform_device *pdev)
>
> iounmap(ccdc_cfg.base_addr);
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (res)
> - release_mem_region(res->start, resource_size(res));
> + release_mem_region(res->start, resource_size(res));
> vpfe_unregister_ccdc_device(&ccdc_hw_dev);
> return 0;
> }
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH -next 3/3] media: isif: remove unnecessary check of res
2022-04-26 3:05 ` [PATCH -next 3/3] media: isif: " Yang Yingliang
@ 2022-05-18 19:46 ` Lad, Prabhakar
0 siblings, 0 replies; 6+ messages in thread
From: Lad, Prabhakar @ 2022-05-18 19:46 UTC (permalink / raw)
To: Yang Yingliang; +Cc: LKML, linux-media, Mauro Carvalho Chehab, Laurent Pinchart
On Tue, Apr 26, 2022 at 3:53 AM Yang Yingliang <yangyingliang@huawei.com> wrote:
>
> The resource is checked in probe function, so there is
> no need do this check in remove function.
>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---
> drivers/media/platform/ti/davinci/isif.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@gmail.com>
Cheers,
Prabhakar
> diff --git a/drivers/media/platform/ti/davinci/isif.c b/drivers/media/platform/ti/davinci/isif.c
> index c53cecd072b1..69e862de014f 100644
> --- a/drivers/media/platform/ti/davinci/isif.c
> +++ b/drivers/media/platform/ti/davinci/isif.c
> @@ -1107,8 +1107,7 @@ static int isif_remove(struct platform_device *pdev)
> isif_cfg.linear_tbl1_addr = NULL;
> while (i < 3) {
> res = platform_get_resource(pdev, IORESOURCE_MEM, i);
> - if (res)
> - release_mem_region(res->start, resource_size(res));
> + release_mem_region(res->start, resource_size(res));
> i++;
> }
> vpfe_unregister_ccdc_device(&isif_hw_dev);
> --
> 2.25.1
>
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-05-18 19:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 3:05 [PATCH -next 1/3] [media] dm355_ccdc: remove unnecessary check of res Yang Yingliang
2022-04-26 3:05 ` [PATCH -next 2/3] [media] dm644x_ccdc: " Yang Yingliang
2022-05-18 19:42 ` Lad, Prabhakar
2022-04-26 3:05 ` [PATCH -next 3/3] media: isif: " Yang Yingliang
2022-05-18 19:46 ` Lad, Prabhakar
2022-05-18 19:41 ` [PATCH -next 1/3] [media] dm355_ccdc: " Lad, Prabhakar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.