* [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names
@ 2022-04-26 6:40 Biju Das
2022-04-26 6:40 ` [PATCH v3 2/2] arm64: dts: renesas: r9a07g054: " Biju Das
2022-04-28 12:35 ` [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: " Geert Uytterhoeven
0 siblings, 2 replies; 5+ messages in thread
From: Biju Das @ 2022-04-26 6:40 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
devicetree, Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Add suffix '-clk' for can and extal clk node names and replace the
clk node names audio_clk{1,2} with clk-{1,2} as per the device
tree specification.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v2->v3:
* Sorted clk node-names alphabetically
v1->v2:
* Replaced clk node names audio_clk{1,2} with clk-{1,2}.
---
arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
index 19287cccb1f0..03fbb77a9814 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
@@ -13,29 +13,29 @@ / {
#address-cells = <2>;
#size-cells = <2>;
- audio_clk1: audio_clk1 {
+ /* External CAN clock - to be overridden by boards that provide it */
+ can_clk: can-clk {
compatible = "fixed-clock";
#clock-cells = <0>;
- /* This value must be overridden by boards that provide it */
clock-frequency = <0>;
};
- audio_clk2: audio_clk2 {
+ audio_clk1: clk-1 {
compatible = "fixed-clock";
#clock-cells = <0>;
/* This value must be overridden by boards that provide it */
clock-frequency = <0>;
};
- /* External CAN clock - to be overridden by boards that provide it */
- can_clk: can {
+ audio_clk2: clk-2 {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value must be overridden by boards that provide it */
clock-frequency = <0>;
};
/* clock can be either from exclk or crystal oscillator (XIN/XOUT) */
- extal_clk: extal {
+ extal_clk: extal-clk {
compatible = "fixed-clock";
#clock-cells = <0>;
/* This value must be overridden by the board */
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v3 2/2] arm64: dts: renesas: r9a07g054: Fix external clk node names
2022-04-26 6:40 [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names Biju Das
@ 2022-04-26 6:40 ` Biju Das
2022-04-28 12:35 ` [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: " Geert Uytterhoeven
1 sibling, 0 replies; 5+ messages in thread
From: Biju Das @ 2022-04-26 6:40 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski
Cc: Biju Das, Geert Uytterhoeven, Magnus Damm, linux-renesas-soc,
devicetree, Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Add suffix '-clk' for can and extal clk node names and replace the
clk node names audio_clk{1,2} with clk-{1,2} as per the device
tree specification.
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
---
v2->v3:
* Sorted clk node-names alphabetically
v1->v2:
* Replaced clk node names audio_clk{1,2} with clk-{1,2}.
---
arch/arm64/boot/dts/renesas/r9a07g054.dtsi | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
index f35aa0311e9c..8bc164d7b61e 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g054.dtsi
@@ -13,29 +13,29 @@ / {
#address-cells = <2>;
#size-cells = <2>;
- audio_clk1: audio_clk1 {
+ /* External CAN clock - to be overridden by boards that provide it */
+ can_clk: can-clk {
compatible = "fixed-clock";
#clock-cells = <0>;
- /* This value must be overridden by boards that provide it */
clock-frequency = <0>;
};
- audio_clk2: audio_clk2 {
+ audio_clk1: clk-1 {
compatible = "fixed-clock";
#clock-cells = <0>;
/* This value must be overridden by boards that provide it */
clock-frequency = <0>;
};
- /* External CAN clock - to be overridden by boards that provide it */
- can_clk: can {
+ audio_clk2: clk-2 {
compatible = "fixed-clock";
#clock-cells = <0>;
+ /* This value must be overridden by boards that provide it */
clock-frequency = <0>;
};
/* clock can be either from exclk or crystal oscillator (XIN/XOUT) */
- extal_clk: extal {
+ extal_clk: extal-clk {
compatible = "fixed-clock";
#clock-cells = <0>;
/* This value must be overridden by the board */
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names
2022-04-26 6:40 [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names Biju Das
2022-04-26 6:40 ` [PATCH v3 2/2] arm64: dts: renesas: r9a07g054: " Biju Das
@ 2022-04-28 12:35 ` Geert Uytterhoeven
2022-04-28 13:02 ` Biju Das
1 sibling, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-04-28 12:35 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Krzysztof Kozlowski, Geert Uytterhoeven,
Magnus Damm, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Hi Biju,
On Tue, Apr 26, 2022 at 8:40 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Add suffix '-clk' for can and extal clk node names and replace the
> clk node names audio_clk{1,2} with clk-{1,2} as per the device
> tree specification.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> ---
> v2->v3:
> * Sorted clk node-names alphabetically
> v1->v2:
> * Replaced clk node names audio_clk{1,2} with clk-{1,2}.
Thanks for the update!
> --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> @@ -13,29 +13,29 @@ / {
> #address-cells = <2>;
> #size-cells = <2>;
>
> - audio_clk1: audio_clk1 {
> + /* External CAN clock - to be overridden by boards that provide it */
> + can_clk: can-clk {
OK.
> compatible = "fixed-clock";
> #clock-cells = <0>;
> - /* This value must be overridden by boards that provide it */
> clock-frequency = <0>;
> };
>
> - audio_clk2: audio_clk2 {
> + audio_clk1: clk-1 {
"clk-1" has a high risk of conflicts. "audio_clk1: audio1-clk"?
> compatible = "fixed-clock";
> #clock-cells = <0>;
> /* This value must be overridden by boards that provide it */
> clock-frequency = <0>;
> };
>
> - /* External CAN clock - to be overridden by boards that provide it */
> - can_clk: can {
> + audio_clk2: clk-2 {
audio_clk2: audio-2clk?
> compatible = "fixed-clock";
> #clock-cells = <0>;
> + /* This value must be overridden by boards that provide it */
> clock-frequency = <0>;
> };
>
> /* clock can be either from exclk or crystal oscillator (XIN/XOUT) */
> - extal_clk: extal {
> + extal_clk: extal-clk {
OK
> compatible = "fixed-clock";
> #clock-cells = <0>;
> /* This value must be overridden by the board */
Same comments for patch 2/2.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names
2022-04-28 12:35 ` [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: " Geert Uytterhoeven
@ 2022-04-28 13:02 ` Biju Das
2022-04-28 13:05 ` Geert Uytterhoeven
0 siblings, 1 reply; 5+ messages in thread
From: Biju Das @ 2022-04-28 13:02 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Rob Herring, Krzysztof Kozlowski, Geert Uytterhoeven,
Magnus Damm, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external
> clk node names
>
> Hi Biju,
>
> On Tue, Apr 26, 2022 at 8:40 AM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Add suffix '-clk' for can and extal clk node names and replace the clk
> > node names audio_clk{1,2} with clk-{1,2} as per the device tree
> > specification.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > ---
> > v2->v3:
> > * Sorted clk node-names alphabetically
> > v1->v2:
> > * Replaced clk node names audio_clk{1,2} with clk-{1,2}.
>
> Thanks for the update!
>
> > --- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
> > @@ -13,29 +13,29 @@ / {
> > #address-cells = <2>;
> > #size-cells = <2>;
> >
> > - audio_clk1: audio_clk1 {
> > + /* External CAN clock - to be overridden by boards that provide
> it */
> > + can_clk: can-clk {
>
> OK.
>
> > compatible = "fixed-clock";
> > #clock-cells = <0>;
> > - /* This value must be overridden by boards that provide
> it */
> > clock-frequency = <0>;
> > };
> >
> > - audio_clk2: audio_clk2 {
> > + audio_clk1: clk-1 {
>
> "clk-1" has a high risk of conflicts. "audio_clk1: audio1-clk"?
OK.
>
> > compatible = "fixed-clock";
> > #clock-cells = <0>;
> > /* This value must be overridden by boards that provide
> it */
> > clock-frequency = <0>;
> > };
> >
> > - /* External CAN clock - to be overridden by boards that provide
> it */
> > - can_clk: can {
> > + audio_clk2: clk-2 {
>
> audio_clk2: audio-2clk?
OK, you mean like audio_clk1, "audio_clk2: audio2-clk"
as "2clk" is not generic name for clk?
Regards,
Biju
>
> > compatible = "fixed-clock";
> > #clock-cells = <0>;
> > + /* This value must be overridden by boards that
> > + provide it */
> > clock-frequency = <0>;
> > };
> >
> > /* clock can be either from exclk or crystal oscillator
> (XIN/XOUT) */
> > - extal_clk: extal {
> > + extal_clk: extal-clk {
>
> OK
>
> > compatible = "fixed-clock";
> > #clock-cells = <0>;
> > /* This value must be overridden by the board */
>
> Same comments for patch 2/2.
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names
2022-04-28 13:02 ` Biju Das
@ 2022-04-28 13:05 ` Geert Uytterhoeven
0 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-04-28 13:05 UTC (permalink / raw)
To: Biju Das
Cc: Rob Herring, Krzysztof Kozlowski, Magnus Damm, Linux-Renesas,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Chris Paterson, Biju Das, Prabhakar Mahadev Lad
Hi Biju,
On Thu, Apr 28, 2022 at 3:03 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Subject: Re: [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external
> > clk node names
> > On Tue, Apr 26, 2022 at 8:40 AM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > > Add suffix '-clk' for can and extal clk node names and replace the clk
> > > node names audio_clk{1,2} with clk-{1,2} as per the device tree
> > > specification.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > compatible = "fixed-clock";
> > > #clock-cells = <0>;
> > > /* This value must be overridden by boards that provide
> > it */
> > > clock-frequency = <0>;
> > > };
> > >
> > > - /* External CAN clock - to be overridden by boards that provide
> > it */
> > > - can_clk: can {
> > > + audio_clk2: clk-2 {
> >
> > audio_clk2: audio-2clk?
>
> OK, you mean like audio_clk1, "audio_clk2: audio2-clk"
> as "2clk" is not generic name for clk?
Oops, indeed.
Sorry, my review fingers are becoming overloaded ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-28 13:05 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 6:40 [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: Fix external clk node names Biju Das
2022-04-26 6:40 ` [PATCH v3 2/2] arm64: dts: renesas: r9a07g054: " Biju Das
2022-04-28 12:35 ` [PATCH v3 1/2] arm64: dts: renesas: r9a07g044: " Geert Uytterhoeven
2022-04-28 13:02 ` Biju Das
2022-04-28 13:05 ` Geert Uytterhoeven
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.