[PATCH -next] clk: en7523: fix wrong pointer check in en7523_clk_probe()

[PATCH -next] clk: en7523: fix wrong pointer check in en7523_clk_probe()

[Yang Yingliang]

Check the real return value of devm_platform_ioremap_resource()
in en7523_clk_probe().

Fixes: 1e6273179190 ("clk: en7523: Add clock driver for Airoha EN7523 SoC")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
---
 drivers/clk/clk-en7523.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/clk/clk-en7523.c b/drivers/clk/clk-en7523.c
index 076a70c2e173..29f0126cbd05 100644
--- a/drivers/clk/clk-en7523.c
+++ b/drivers/clk/clk-en7523.c
@@ -314,7 +314,7 @@ static int en7523_clk_probe(struct platform_device *pdev)
 		return PTR_ERR(base);
 
 	np_base = devm_platform_ioremap_resource(pdev, 1);
-	if (IS_ERR(base))
+	if (IS_ERR(np_base))
 		return PTR_ERR(np_base);
 
 	clk_data = devm_kzalloc(&pdev->dev,
-- 
2.25.1

Re: [PATCH -next] clk: en7523: fix wrong pointer check in en7523_clk_probe()

[Felix Fietkau]

On 26.04.22 15:15, Yang Yingliang wrote:
> Check the real return value of devm_platform_ioremap_resource()
> in en7523_clk_probe().
> 
> Fixes: 1e6273179190 ("clk: en7523: Add clock driver for Airoha EN7523 SoC")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>

Acked-by: Felix Fietkau <nbd@nbd.name>

Re: [PATCH -next] clk: en7523: fix wrong pointer check in en7523_clk_probe()

[Stephen Boyd]

Quoting Yang Yingliang (2022-04-26 06:15:39)
> Check the real return value of devm_platform_ioremap_resource()
> in en7523_clk_probe().
> 
> Fixes: 1e6273179190 ("clk: en7523: Add clock driver for Airoha EN7523 SoC")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
> ---

Applied to clk-next