From: Dylan Hung <dylan_hung@aspeedtech.com> To: <robh+dt@kernel.org>, <joel@jms.id.au>, <andrew@aj.id.au>, <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>, <p.zabel@pengutronix.de>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>, <krzk+dt@kernel.org> Cc: <BMC-SW@aspeedtech.com>, Krzysztof Kozlowski <krzk@kernel.org> Subject: [PATCH net-next v6 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding Date: Wed, 27 Apr 2022 11:54:59 +0800 [thread overview] Message-ID: <20220427035501.17500-2-dylan_hung@aspeedtech.com> (raw) In-Reply-To: <20220427035501.17500-1-dylan_hung@aspeedtech.com> The AST2600 MDIO bus controller has a reset control bit and must be deasserted before manipulating the MDIO controller. By default, the hardware asserts the reset so the driver only need to deassert it. Regarding to the old DT blobs which don't have reset property in them, the reset deassertion is usually done by the bootloader so the reset property is optional to work with them. Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Andrew Jeffery <andrew@aj.id.au> --- .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml index 1c88820cbcdf..f81eda8cb0a5 100644 --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml @@ -20,10 +20,14 @@ allOf: properties: compatible: const: aspeed,ast2600-mdio + reg: maxItems: 1 description: The register range of the MDIO controller instance + resets: + maxItems: 1 + required: - compatible - reg @@ -34,11 +38,13 @@ unevaluatedProperties: false examples: - | + #include <dt-bindings/clock/ast2600-clock.h> mdio0: mdio@1e650000 { compatible = "aspeed,ast2600-mdio"; reg = <0x1e650000 0x8>; #address-cells = <1>; #size-cells = <0>; + resets = <&syscon ASPEED_RESET_MII>; ethphy0: ethernet-phy@0 { compatible = "ethernet-phy-ieee802.3-c22"; -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Dylan Hung <dylan_hung@aspeedtech.com> To: <robh+dt@kernel.org>, <joel@jms.id.au>, <andrew@aj.id.au>, <andrew@lunn.ch>, <hkallweit1@gmail.com>, <linux@armlinux.org.uk>, <davem@davemloft.net>, <kuba@kernel.org>, <pabeni@redhat.com>, <p.zabel@pengutronix.de>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-aspeed@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>, <krzk+dt@kernel.org> Cc: <BMC-SW@aspeedtech.com>, Krzysztof Kozlowski <krzk@kernel.org> Subject: [PATCH net-next v6 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding Date: Wed, 27 Apr 2022 11:54:59 +0800 [thread overview] Message-ID: <20220427035501.17500-2-dylan_hung@aspeedtech.com> (raw) In-Reply-To: <20220427035501.17500-1-dylan_hung@aspeedtech.com> The AST2600 MDIO bus controller has a reset control bit and must be deasserted before manipulating the MDIO controller. By default, the hardware asserts the reset so the driver only need to deassert it. Regarding to the old DT blobs which don't have reset property in them, the reset deassertion is usually done by the bootloader so the reset property is optional to work with them. Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com> Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org> Reviewed-by: Andrew Jeffery <andrew@aj.id.au> --- .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml index 1c88820cbcdf..f81eda8cb0a5 100644 --- a/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml +++ b/Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.yaml @@ -20,10 +20,14 @@ allOf: properties: compatible: const: aspeed,ast2600-mdio + reg: maxItems: 1 description: The register range of the MDIO controller instance + resets: + maxItems: 1 + required: - compatible - reg @@ -34,11 +38,13 @@ unevaluatedProperties: false examples: - | + #include <dt-bindings/clock/ast2600-clock.h> mdio0: mdio@1e650000 { compatible = "aspeed,ast2600-mdio"; reg = <0x1e650000 0x8>; #address-cells = <1>; #size-cells = <0>; + resets = <&syscon ASPEED_RESET_MII>; ethphy0: ethernet-phy@0 { compatible = "ethernet-phy-ieee802.3-c22"; -- 2.25.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-04-27 3:55 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-27 3:54 [PATCH net-next v6 0/3] Add reset deassertion for Aspeed MDIO Dylan Hung 2022-04-27 3:54 ` Dylan Hung 2022-04-27 3:54 ` Dylan Hung [this message] 2022-04-27 3:54 ` [PATCH net-next v6 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding Dylan Hung 2022-04-27 3:55 ` [PATCH net-next v6 2/3] net: mdio: add reset control for Aspeed MDIO Dylan Hung 2022-04-27 3:55 ` Dylan Hung 2022-04-27 3:55 ` [PATCH net-next v6 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes Dylan Hung 2022-04-27 3:55 ` Dylan Hung 2022-04-28 8:00 ` [PATCH net-next v6 0/3] Add reset deassertion for Aspeed MDIO patchwork-bot+netdevbpf 2022-04-28 8:00 ` patchwork-bot+netdevbpf
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220427035501.17500-2-dylan_hung@aspeedtech.com \ --to=dylan_hung@aspeedtech.com \ --cc=BMC-SW@aspeedtech.com \ --cc=andrew@aj.id.au \ --cc=andrew@lunn.ch \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=hkallweit1@gmail.com \ --cc=joel@jms.id.au \ --cc=krzk+dt@kernel.org \ --cc=krzk@kernel.org \ --cc=kuba@kernel.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-aspeed@lists.ozlabs.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux@armlinux.org.uk \ --cc=netdev@vger.kernel.org \ --cc=p.zabel@pengutronix.de \ --cc=pabeni@redhat.com \ --cc=robh+dt@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.