All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v5 0/4] leds: pca955x: Add HW blink support
@ 2022-04-27 18:54 Eddie James
  2022-04-27 18:54 ` [PATCH v5 1/4] leds: pca955x: Refactor with helper functions and renaming Eddie James
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Eddie James @ 2022-04-27 18:54 UTC (permalink / raw)
  To: pavel; +Cc: linux-leds, linux-kernel, andy.shevchenko, eajames, dan.carpenter

This series adds support for blinking using the PCA955x chip, falling
back to software blinking if another LED on the chip is already blinking
at a different rate, or if the requested rate isn't representable with
the PCA955x.
Also included are some minor clean up and optimization changes that make
the HW blinking a bit easier.

Changes since v4:
 - Set duty cycle to fifty percent for blinked LEDs in order to maintain
   the specified blink rate.

Changes since v3:
 - Initialize return value in the blink function
   Thanks Dan Carpenter and kernel test robot

Changes since v2:
 - Split the cleanup patch
 - Prettier dev_err calls
 - Include units for blink period and use defined unit translations
   rather than just a number.
 - Use positive conditionals.

Changes since v1:
 - Rework the blink function to fallback to software blinking if the
   period is out of range of the chip's capabilities or if another LED
   on the chip is already blinking at a different rate.
 - Add the cleanup patch

Eddie James (4):
  leds: pca955x: Refactor with helper functions and renaming
  leds: pca955x: Use pointers to driver data rather than I2C client
  leds: pca955x: Optimize probe led selection
  leds: pca955x: Add HW blink support

 drivers/leds/leds-pca955x.c | 348 ++++++++++++++++++++++++------------
 1 file changed, 237 insertions(+), 111 deletions(-)

-- 
2.27.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-04-27 19:05 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-27 18:54 [PATCH v5 0/4] leds: pca955x: Add HW blink support Eddie James
2022-04-27 18:54 ` [PATCH v5 1/4] leds: pca955x: Refactor with helper functions and renaming Eddie James
2022-04-27 18:54 ` [PATCH v5 2/4] leds: pca955x: Use pointers to driver data rather than I2C client Eddie James
2022-04-27 18:54 ` [PATCH v5 3/4] leds: pca955x: Optimize probe led selection Eddie James
2022-04-27 18:54 ` [PATCH v5 4/4] leds: pca955x: Add HW blink support Eddie James

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.