From: Peng Liu <liupeng256@huawei.com> To: <mike.kravetz@oracle.com>, <david@redhat.com>, <akpm@linux-foundation.org>, <yaozhenguo1@gmail.com>, <baolin.wang@linux.alibaba.com>, <songmuchun@bytedance.com>, <liuyuntao10@huawei.com>, <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>, <wangkefeng.wang@huawei.com>, <dave@stgolabs.net>, <liupeng256@huawei.com>, <wangborong@cdjrlc.com>, <linux-ia64@vger.kernel.org>, <adobriyan@gmail.com> Subject: [PATCH v4] mm: Using for_each_online_node and node_online instead of open coding Date: Fri, 29 Apr 2022 03:02:18 +0000 [thread overview] Message-ID: <20220429030218.644635-1-liupeng256@huawei.com> (raw) In-Reply-To: <20220413032915.251254-4-liupeng256@huawei.com> Use more generic functions to deal with issues related to online nodes. The changes will make the code simplified. Signed-off-by: Peng Liu <liupeng256@huawei.com> Suggested-by: Davidlohr Bueso <dave@stgolabs.net> Suggested-by: Andrew Morton <akpm@linux-foundation.org> --- v4: Clean up all the related issues in one patch as suggested by Andrew. arch/ia64/kernel/uncached.c | 2 +- mm/hugetlb.c | 4 ++-- mm/page_ext.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/ia64/kernel/uncached.c b/arch/ia64/kernel/uncached.c index 816803636a75..a0fec82c56b8 100644 --- a/arch/ia64/kernel/uncached.c +++ b/arch/ia64/kernel/uncached.c @@ -261,7 +261,7 @@ static int __init uncached_init(void) { int nid; - for_each_node_state(nid, N_ONLINE) { + for_each_online_node(nid) { uncached_pools[nid].pool = gen_pool_create(PAGE_SHIFT, nid); mutex_init(&uncached_pools[nid].add_chunk_mutex); } diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 30e1099fd99a..0e5a7764efaa 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6951,7 +6951,7 @@ void __init hugetlb_cma_reserve(int order) if (hugetlb_cma_size_in_node[nid] == 0) continue; - if (!node_state(nid, N_ONLINE)) { + if (!node_online(nid)) { pr_warn("hugetlb_cma: invalid node %d specified\n", nid); hugetlb_cma_size -= hugetlb_cma_size_in_node[nid]; hugetlb_cma_size_in_node[nid] = 0; @@ -6990,7 +6990,7 @@ void __init hugetlb_cma_reserve(int order) } reserved = 0; - for_each_node_state(nid, N_ONLINE) { + for_each_online_node(nid) { int res; char name[CMA_MAX_NAME]; diff --git a/mm/page_ext.c b/mm/page_ext.c index 2e66d934d63f..3dc715d7ac29 100644 --- a/mm/page_ext.c +++ b/mm/page_ext.c @@ -320,7 +320,7 @@ static int __meminit online_page_ext(unsigned long start_pfn, * online__pages(), and start_pfn should exist. */ nid = pfn_to_nid(start_pfn); - VM_BUG_ON(!node_state(nid, N_ONLINE)); + VM_BUG_ON(!node_online(nid)); } for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) -- 2.25.1
WARNING: multiple messages have this Message-ID (diff)
From: Peng Liu <liupeng256@huawei.com> To: mike.kravetz@oracle.com, david@redhat.com, akpm@linux-foundation.org, yaozhenguo1@gmail.com, baolin.wang@linux.alibaba.com, songmuchun@bytedance.com, liuyuntao10@huawei.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, wangkefeng.wang@huawei.com, dave@stgolabs.net, liupeng256@huawei.com, wangborong@cdjrlc.com, linux-ia64@vger.kernel.org, adobriyan@gmail.com Subject: [PATCH v4] mm: Using for_each_online_node and node_online instead of open coding Date: Fri, 29 Apr 2022 02:43:47 +0000 [thread overview] Message-ID: <20220429030218.644635-1-liupeng256@huawei.com> (raw) In-Reply-To: <20220413032915.251254-4-liupeng256@huawei.com> Use more generic functions to deal with issues related to online nodes. The changes will make the code simplified. Signed-off-by: Peng Liu <liupeng256@huawei.com> Suggested-by: Davidlohr Bueso <dave@stgolabs.net> Suggested-by: Andrew Morton <akpm@linux-foundation.org> --- v4: Clean up all the related issues in one patch as suggested by Andrew. arch/ia64/kernel/uncached.c | 2 +- mm/hugetlb.c | 4 ++-- mm/page_ext.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/arch/ia64/kernel/uncached.c b/arch/ia64/kernel/uncached.c index 816803636a75..a0fec82c56b8 100644 --- a/arch/ia64/kernel/uncached.c +++ b/arch/ia64/kernel/uncached.c @@ -261,7 +261,7 @@ static int __init uncached_init(void) { int nid; - for_each_node_state(nid, N_ONLINE) { + for_each_online_node(nid) { uncached_pools[nid].pool = gen_pool_create(PAGE_SHIFT, nid); mutex_init(&uncached_pools[nid].add_chunk_mutex); } diff --git a/mm/hugetlb.c b/mm/hugetlb.c index 30e1099fd99a..0e5a7764efaa 100644 --- a/mm/hugetlb.c +++ b/mm/hugetlb.c @@ -6951,7 +6951,7 @@ void __init hugetlb_cma_reserve(int order) if (hugetlb_cma_size_in_node[nid] = 0) continue; - if (!node_state(nid, N_ONLINE)) { + if (!node_online(nid)) { pr_warn("hugetlb_cma: invalid node %d specified\n", nid); hugetlb_cma_size -= hugetlb_cma_size_in_node[nid]; hugetlb_cma_size_in_node[nid] = 0; @@ -6990,7 +6990,7 @@ void __init hugetlb_cma_reserve(int order) } reserved = 0; - for_each_node_state(nid, N_ONLINE) { + for_each_online_node(nid) { int res; char name[CMA_MAX_NAME]; diff --git a/mm/page_ext.c b/mm/page_ext.c index 2e66d934d63f..3dc715d7ac29 100644 --- a/mm/page_ext.c +++ b/mm/page_ext.c @@ -320,7 +320,7 @@ static int __meminit online_page_ext(unsigned long start_pfn, * online__pages(), and start_pfn should exist. */ nid = pfn_to_nid(start_pfn); - VM_BUG_ON(!node_state(nid, N_ONLINE)); + VM_BUG_ON(!node_online(nid)); } for (pfn = start; !fail && pfn < end; pfn += PAGES_PER_SECTION) -- 2.25.1
next prev parent reply other threads:[~2022-04-29 2:44 UTC|newest] Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-04-13 3:29 [PATCH v3 0/4] hugetlb: Fix some incorrect behavior Peng Liu 2022-04-13 3:29 ` [PATCH v3 1/4] hugetlb: Fix wrong use of nr_online_nodes Peng Liu 2022-04-13 4:42 ` Andrew Morton 2022-04-13 6:27 ` liupeng (DM) 2022-04-13 22:04 ` Andrew Morton 2022-04-14 1:28 ` liupeng (DM) 2022-04-13 6:29 ` Baolin Wang 2022-04-14 23:36 ` Mike Kravetz 2022-04-15 2:09 ` Davidlohr Bueso 2022-04-15 5:41 ` Kefeng Wang 2022-04-15 7:01 ` liupeng (DM) 2022-04-16 1:21 ` Kefeng Wang 2022-04-19 4:40 ` Andrew Morton 2022-04-19 8:54 ` Kefeng Wang 2022-04-16 10:35 ` [PATCH v4] " Peng Liu 2022-04-18 5:53 ` Kefeng Wang 2022-04-19 4:03 ` Andrew Morton 2022-04-19 14:07 ` Kefeng Wang 2022-04-20 6:17 ` liupeng (DM) 2022-04-29 9:32 ` David Hildenbrand 2022-04-13 3:29 ` [PATCH v3 2/4] hugetlb: Fix hugepages_setup when deal with pernode Peng Liu 2022-04-14 23:50 ` Mike Kravetz 2022-04-29 9:30 ` David Hildenbrand 2022-04-13 3:29 ` [PATCH v3 3/4] hugetlb: Fix return value of __setup handlers Peng Liu 2022-04-13 6:39 ` Baolin Wang 2022-04-13 7:55 ` Muchun Song 2022-04-13 8:16 ` liupeng (DM) 2022-04-13 8:21 ` Muchun Song 2022-04-13 8:45 ` Kefeng Wang 2022-04-13 9:01 ` Muchun Song 2022-04-15 0:01 ` Mike Kravetz 2022-04-15 2:24 ` Davidlohr Bueso 2022-04-29 2:43 ` Peng Liu [this message] 2022-04-29 3:02 ` [PATCH v4] mm: Using for_each_online_node and node_online instead of open coding Peng Liu 2022-04-29 9:29 ` David Hildenbrand 2022-04-29 9:29 ` David Hildenbrand 2022-04-29 11:44 ` Muchun Song 2022-04-29 11:44 ` Muchun Song 2022-04-13 3:29 ` [PATCH v3 4/4] hugetlb: Clean up hugetlb_cma_reserve Peng Liu 2022-04-13 5:50 ` Muchun Song 2022-04-13 6:41 ` Baolin Wang 2022-04-15 0:03 ` Mike Kravetz 2022-04-15 2:15 ` Davidlohr Bueso 2022-04-15 7:03 ` liupeng (DM) 2022-04-29 9:28 ` David Hildenbrand
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220429030218.644635-1-liupeng256@huawei.com \ --to=liupeng256@huawei.com \ --cc=adobriyan@gmail.com \ --cc=akpm@linux-foundation.org \ --cc=baolin.wang@linux.alibaba.com \ --cc=dave@stgolabs.net \ --cc=david@redhat.com \ --cc=linux-ia64@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-mm@kvack.org \ --cc=liuyuntao10@huawei.com \ --cc=mike.kravetz@oracle.com \ --cc=songmuchun@bytedance.com \ --cc=wangborong@cdjrlc.com \ --cc=wangkefeng.wang@huawei.com \ --cc=yaozhenguo1@gmail.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.