* [PATCH 1/2] volatile-binds: Change DefaultDependencies from false to no
@ 2022-04-29 7:34 Portia
2022-04-29 7:34 ` [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used Portia
0 siblings, 1 reply; 5+ messages in thread
From: Portia @ 2022-04-29 7:34 UTC (permalink / raw)
To: openembedded-core; +Cc: Portia
The systemd-unit parameter DefaultDependencies changed from true/false
to yes/no. This changed in systemd in v242.
Signed-off-by: Portia Stephens <stephensportia@gmail.com>
---
.../recipes-core/volatile-binds/files/volatile-binds.service.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
index 6612d2aae0..8fe7d8d4f9 100644
--- a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
+++ b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
@@ -1,6 +1,6 @@
[Unit]
Description=Bind mount volatile @where@
-DefaultDependencies=false
+DefaultDependencies=no
Before=local-fs.target
RequiresMountsFor=@whatparent@ @whereparent@
ConditionPathIsReadWrite=@whatparent@
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used
2022-04-29 7:34 [PATCH 1/2] volatile-binds: Change DefaultDependencies from false to no Portia
@ 2022-04-29 7:34 ` Portia
2022-04-29 15:38 ` [OE-core] " Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Portia @ 2022-04-29 7:34 UTC (permalink / raw)
To: openembedded-core; +Cc: Portia
Remove setting TimeoutSec and allow the DefaultTimeSec to be set for the
volatile-binds services.
Signed-off-by: Portia Stephens <stephensportia@gmail.com>
---
meta/recipes-core/volatile-binds/files/volatile-binds.service.in | 1 -
1 file changed, 1 deletion(-)
diff --git a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
index 8fe7d8d4f9..52384c8264 100644
--- a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
+++ b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
@@ -10,7 +10,6 @@ ConditionPathIsReadWrite=!@where@
[Service]
Type=oneshot
RemainAfterExit=Yes
-TimeoutSec=0
Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@
ExecStart=/sbin/mount-copybind @what@ @where@
ExecStop=/bin/umount @where@
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used
2022-04-29 7:34 ` [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used Portia
@ 2022-04-29 15:38 ` Khem Raj
2022-04-29 22:17 ` Portia Stephens
0 siblings, 1 reply; 5+ messages in thread
From: Khem Raj @ 2022-04-29 15:38 UTC (permalink / raw)
To: Portia, openembedded-core
On 4/29/22 12:34 AM, Portia wrote:
> Remove setting TimeoutSec and allow the DefaultTimeSec to be set for the
> volatile-binds services.
>
Whats the default value? I hope it does not go into infinite loop in
case the service gets stuck
> Signed-off-by: Portia Stephens <stephensportia@gmail.com>
> ---
> meta/recipes-core/volatile-binds/files/volatile-binds.service.in | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> index 8fe7d8d4f9..52384c8264 100644
> --- a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> +++ b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> @@ -10,7 +10,6 @@ ConditionPathIsReadWrite=!@where@
> [Service]
> Type=oneshot
> RemainAfterExit=Yes
> -TimeoutSec=0
> Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@
> ExecStart=/sbin/mount-copybind @what@ @where@
> ExecStop=/bin/umount @where@
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#164998): https://lists.openembedded.org/g/openembedded-core/message/164998
> Mute This Topic: https://lists.openembedded.org/mt/90771601/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used
2022-04-29 15:38 ` [OE-core] " Khem Raj
@ 2022-04-29 22:17 ` Portia Stephens
2022-04-29 22:45 ` Khem Raj
0 siblings, 1 reply; 5+ messages in thread
From: Portia Stephens @ 2022-04-29 22:17 UTC (permalink / raw)
To: Khem Raj; +Cc: openembedded-core
On Sat, Apr 30, 2022 at 1:39 AM Khem Raj <raj.khem@gmail.com> wrote:
>
>
>
> On 4/29/22 12:34 AM, Portia wrote:
> > Remove setting TimeoutSec and allow the DefaultTimeSec to be set for the
> > volatile-binds services.
> >
>
> Whats the default value? I hope it does not go into infinite loop in
> case the service gets stuck
>
Timeout=0 sets the Timeout to infinity, so the current behavior is
that if the service gets stuck
it never gets killed. DefaultTimeout will depend on what is set in the
/etc/systemd/system.conf.
> > Signed-off-by: Portia Stephens <stephensportia@gmail.com>
> > ---
> > meta/recipes-core/volatile-binds/files/volatile-binds.service.in | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> > index 8fe7d8d4f9..52384c8264 100644
> > --- a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> > +++ b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> > @@ -10,7 +10,6 @@ ConditionPathIsReadWrite=!@where@
> > [Service]
> > Type=oneshot
> > RemainAfterExit=Yes
> > -TimeoutSec=0
> > Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@
> > ExecStart=/sbin/mount-copybind @what@ @where@
> > ExecStop=/bin/umount @where@
> >
> >
> >
> > -=-=-=-=-=-=-=-=-=-=-=-
> > Links: You receive all messages sent to this group.
> > View/Reply Online (#164998): https://lists.openembedded.org/g/openembedded-core/message/164998
> > Mute This Topic: https://lists.openembedded.org/mt/90771601/1997914
> > Group Owner: openembedded-core+owner@lists.openembedded.org
> > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> > -=-=-=-=-=-=-=-=-=-=-=-
> >
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [OE-core] [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used
2022-04-29 22:17 ` Portia Stephens
@ 2022-04-29 22:45 ` Khem Raj
0 siblings, 0 replies; 5+ messages in thread
From: Khem Raj @ 2022-04-29 22:45 UTC (permalink / raw)
To: Portia Stephens; +Cc: openembedded-core
[-- Attachment #1: Type: text/plain, Size: 2124 bytes --]
On Fri, Apr 29, 2022 at 3:17 PM Portia Stephens <stephensportia@gmail.com>
wrote:
> On Sat, Apr 30, 2022 at 1:39 AM Khem Raj <raj.khem@gmail.com> wrote:
> >
> >
> >
> > On 4/29/22 12:34 AM, Portia wrote:
> > > Remove setting TimeoutSec and allow the DefaultTimeSec to be set for
> the
> > > volatile-binds services.
> > >
> >
> > Whats the default value? I hope it does not go into infinite loop in
> > case the service gets stuck
> >
>
> Timeout=0 sets the Timeout to infinity, so the current behavior is
> that if the service gets stuck
> it never gets killed. DefaultTimeout will depend on what is set in the
> /etc/systemd/system.conf.
Right reading it from system default is fine I guess defaults are perhaps
around 90s which is enough for the service to load normally
>
> > > Signed-off-by: Portia Stephens <stephensportia@gmail.com>
> > > ---
> > > meta/recipes-core/volatile-binds/files/volatile-binds.service.in |
> 1 -
> > > 1 file changed, 1 deletion(-)
> > >
> > > diff --git a/meta/recipes-core/volatile-binds/files/
> volatile-binds.service.in b/meta/recipes-core/volatile-binds/files/
> volatile-binds.service.in
> > > index 8fe7d8d4f9..52384c8264 100644
> > > --- a/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> > > +++ b/meta/recipes-core/volatile-binds/files/volatile-binds.service.in
> > > @@ -10,7 +10,6 @@ ConditionPathIsReadWrite=!@where@
> > > [Service]
> > > Type=oneshot
> > > RemainAfterExit=Yes
> > > -TimeoutSec=0
> > > Environment=MOUNT_COPYBIND_AVOID_OVERLAYFS=@avoid_overlayfs@
> > > ExecStart=/sbin/mount-copybind @what@ @where@
> > > ExecStop=/bin/umount @where@
> > >
> > >
> > >
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > > Links: You receive all messages sent to this group.
> > > View/Reply Online (#164998):
> https://lists.openembedded.org/g/openembedded-core/message/164998
> > > Mute This Topic: https://lists.openembedded.org/mt/90771601/1997914
> > > Group Owner: openembedded-core+owner@lists.openembedded.org
> > > Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub
> [raj.khem@gmail.com]
> > > -=-=-=-=-=-=-=-=-=-=-=-
> > >
>
[-- Attachment #2: Type: text/html, Size: 3930 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-04-29 22:46 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 7:34 [PATCH 1/2] volatile-binds: Change DefaultDependencies from false to no Portia
2022-04-29 7:34 ` [PATCH 2/2] volatile-binds: Remove TimeoutSec and allow DefaultTimeoutSec to be used Portia
2022-04-29 15:38 ` [OE-core] " Khem Raj
2022-04-29 22:17 ` Portia Stephens
2022-04-29 22:45 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.