All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN
@ 2022-04-29  8:01 Peng Fan (OSS)
  2022-04-29  8:01 ` [PATCH 2/3] imx: imx8mq: default select CLK_IMX8MQ Peng Fan (OSS)
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Peng Fan (OSS) @ 2022-04-29  8:01 UTC (permalink / raw)
  To: sbabic, festevam; +Cc: uboot-imx, u-boot, trini, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

set SPL_SYS_MALLOC_F_LEN to 0x2000
set SYS_MALLOC_F_LEN to 0x10000

This is to prepare enable CLK_IMX8MQ for i.MX8MQ

Fixes: commit 4eb82c2e56a7c ("imx: power-domain: Get rid of SMCCC dependency")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/Kconfig b/Kconfig
index bdae59e06f4..4559b627707 100644
--- a/Kconfig
+++ b/Kconfig
@@ -257,7 +257,7 @@ config SYS_MALLOC_F_LEN
 	default 0x4000 if SANDBOX || RISCV || ARCH_APPLE || ROCKCHIP_RK3368 || \
 			  ROCKCHIP_RK3399
 	default 0x8000 if RCAR_GEN3
-	default 0x10000 if ARCH_IMX8 || (ARCH_IMX8M && !IMX8MQ) || \
+	default 0x10000 if ARCH_IMX8 || ARCH_IMX8M || \
 			   ARCH_LS1012A || ARCH_LS1021A || ARCH_LS1043A || \
 			   ARCH_LS1046A
 	default 0x2000
@@ -285,6 +285,7 @@ config SPL_SYS_MALLOC_F_LEN
 	depends on SYS_MALLOC_F && SPL
 	default 0 if !SPL_FRAMEWORK
 	default 0x2800 if RCAR_GEN3
+	default 0x2000 if IMX8MQ
 	default SYS_MALLOC_F_LEN
 	help
 	  In SPL memory is very limited on many platforms. Still,
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/3] imx: imx8mq: default select CLK_IMX8MQ
  2022-04-29  8:01 [PATCH 1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN Peng Fan (OSS)
@ 2022-04-29  8:01 ` Peng Fan (OSS)
  2022-04-30 13:49   ` Adam Ford
  2022-04-29  8:01 ` [PATCH 3/3] imx: imx8mq: select CONFIG_CMD_CLK Peng Fan (OSS)
  2022-06-10 18:13 ` [PATCH 1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN Heiko Thiery
  2 siblings, 1 reply; 6+ messages in thread
From: Peng Fan (OSS) @ 2022-04-29  8:01 UTC (permalink / raw)
  To: sbabic, festevam, NXP i.MX U-Boot Team; +Cc: u-boot, trini, Peng Fan

From: Peng Fan <peng.fan@nxp.com>

Since the power domain driver default select CONFIG_CLK, so we will
meet lots failures without CLK_IMX8MQ, so default select it.

Fixes: commit 4eb82c2e56a7c ("imx: power-domain: Get rid of SMCCC dependency")
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 arch/arm/mach-imx/imx8m/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
index 24299ae037f..7f23d687be3 100644
--- a/arch/arm/mach-imx/imx8m/Kconfig
+++ b/arch/arm/mach-imx/imx8m/Kconfig
@@ -8,6 +8,7 @@ config IMX8M
 config IMX8MQ
 	bool
 	select IMX8M
+	select CLK_IMX8MQ
 
 config IMX8MM
 	bool
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 3/3] imx: imx8mq: select CONFIG_CMD_CLK
  2022-04-29  8:01 [PATCH 1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN Peng Fan (OSS)
  2022-04-29  8:01 ` [PATCH 2/3] imx: imx8mq: default select CLK_IMX8MQ Peng Fan (OSS)
@ 2022-04-29  8:01 ` Peng Fan (OSS)
  2022-06-10 18:13 ` [PATCH 1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN Heiko Thiery
  2 siblings, 0 replies; 6+ messages in thread
From: Peng Fan (OSS) @ 2022-04-29  8:01 UTC (permalink / raw)
  To: sbabic, festevam, Peng Fan; +Cc: uboot-imx, u-boot, trini

From: Peng Fan <peng.fan@nxp.com>

select CONFIG_CMD_CLK to enable dump clk in uboot shell

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 configs/imx8mq_evk_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/imx8mq_evk_defconfig b/configs/imx8mq_evk_defconfig
index 780f93103c7..9f54a280d9b 100644
--- a/configs/imx8mq_evk_defconfig
+++ b/configs/imx8mq_evk_defconfig
@@ -40,6 +40,7 @@ CONFIG_SYS_PROMPT="u-boot=> "
 # CONFIG_CMD_EXPORTENV is not set
 # CONFIG_CMD_IMPORTENV is not set
 # CONFIG_CMD_CRC32 is not set
+CONFIG_CMD_CLK=y
 CONFIG_CMD_FUSE=y
 CONFIG_CMD_GPIO=y
 CONFIG_CMD_I2C=y
-- 
2.36.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/3] imx: imx8mq: default select CLK_IMX8MQ
  2022-04-29  8:01 ` [PATCH 2/3] imx: imx8mq: default select CLK_IMX8MQ Peng Fan (OSS)
@ 2022-04-30 13:49   ` Adam Ford
  2022-05-01  9:44     ` Peng Fan (OSS)
  0 siblings, 1 reply; 6+ messages in thread
From: Adam Ford @ 2022-04-30 13:49 UTC (permalink / raw)
  To: Peng Fan (OSS)
  Cc: Stefano Babic, Fabio Estevam, NXP i.MX U-Boot Team,
	U-Boot Mailing List, Tom Rini, Peng Fan

On Fri, Apr 29, 2022 at 2:20 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> Since the power domain driver default select CONFIG_CLK, so we will
> meet lots failures without CLK_IMX8MQ, so default select it.
>

There is a related patch [1] that I submitted for all imx8m SoC's t
select their respective CLK_IMX8M[MNPQ]

adam

[1] - https://patchwork.ozlabs.org/project/uboot/patch/20220417221647.2390750-1-aford173@gmail.com/

> Fixes: commit 4eb82c2e56a7c ("imx: power-domain: Get rid of SMCCC dependency")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  arch/arm/mach-imx/imx8m/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
> index 24299ae037f..7f23d687be3 100644
> --- a/arch/arm/mach-imx/imx8m/Kconfig
> +++ b/arch/arm/mach-imx/imx8m/Kconfig
> @@ -8,6 +8,7 @@ config IMX8M
>  config IMX8MQ
>         bool
>         select IMX8M
> +       select CLK_IMX8MQ
>
>  config IMX8MM
>         bool
> --
> 2.36.0
>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/3] imx: imx8mq: default select CLK_IMX8MQ
  2022-04-30 13:49   ` Adam Ford
@ 2022-05-01  9:44     ` Peng Fan (OSS)
  0 siblings, 0 replies; 6+ messages in thread
From: Peng Fan (OSS) @ 2022-05-01  9:44 UTC (permalink / raw)
  To: Adam Ford
  Cc: Stefano Babic, Fabio Estevam, dl-uboot-imx, U-Boot Mailing List,
	Tom Rini, Peng Fan



On 2022/4/30 21:49, Adam Ford wrote:
> On Fri, Apr 29, 2022 at 2:20 AM Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>>
>> From: Peng Fan <peng.fan@nxp.com>
>>
>> Since the power domain driver default select CONFIG_CLK, so we will
>> meet lots failures without CLK_IMX8MQ, so default select it.
>>
> 
> There is a related patch [1] that I submitted for all imx8m SoC's t
> select their respective CLK_IMX8M[MNPQ]

Actually default select CLK_IMX8MQ will not make i.MX8MQ bootable,
patch 1 in this patchset still needed. If possible, you could take
my patch 1 in your patchset and drop patch 2 in this patchset.

Thanks,
Peng.

> 
> adam
> 
> [1] - https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpatchwork.ozlabs.org%2Fproject%2Fuboot%2Fpatch%2F20220417221647.2390750-1-aford173%40gmail.com%2F&amp;data=05%7C01%7Cpeng.fan%40nxp.com%7C48339c3e1efe45476e6d08da2ab04211%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C637869233759129025%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=wZCdJR%2BVf%2BpeBkq%2BtGA%2FcXkxY5GUPUfU%2FeyPtrc%2Bpn0%3D&amp;reserved=0
> 
>> Fixes: commit 4eb82c2e56a7c ("imx: power-domain: Get rid of SMCCC dependency")
>> Signed-off-by: Peng Fan <peng.fan@nxp.com>
>> ---
>>   arch/arm/mach-imx/imx8m/Kconfig | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/mach-imx/imx8m/Kconfig b/arch/arm/mach-imx/imx8m/Kconfig
>> index 24299ae037f..7f23d687be3 100644
>> --- a/arch/arm/mach-imx/imx8m/Kconfig
>> +++ b/arch/arm/mach-imx/imx8m/Kconfig
>> @@ -8,6 +8,7 @@ config IMX8M
>>   config IMX8MQ
>>          bool
>>          select IMX8M
>> +       select CLK_IMX8MQ
>>
>>   config IMX8MM
>>          bool
>> --
>> 2.36.0
>>

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN
  2022-04-29  8:01 [PATCH 1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN Peng Fan (OSS)
  2022-04-29  8:01 ` [PATCH 2/3] imx: imx8mq: default select CLK_IMX8MQ Peng Fan (OSS)
  2022-04-29  8:01 ` [PATCH 3/3] imx: imx8mq: select CONFIG_CMD_CLK Peng Fan (OSS)
@ 2022-06-10 18:13 ` Heiko Thiery
  2 siblings, 0 replies; 6+ messages in thread
From: Heiko Thiery @ 2022-06-10 18:13 UTC (permalink / raw)
  To: Peng Fan (OSS); +Cc: sbabic, festevam, uboot-imx, u-boot, trini, Peng Fan

Hi Peng,

Am Fr., 29. Apr. 2022 um 09:20 Uhr schrieb Peng Fan (OSS)
<peng.fan@oss.nxp.com>:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> set SPL_SYS_MALLOC_F_LEN to 0x2000
> set SYS_MALLOC_F_LEN to 0x10000
>
> This is to prepare enable CLK_IMX8MQ for i.MX8MQ
>
> Fixes: commit 4eb82c2e56a7c ("imx: power-domain: Get rid of SMCCC dependency")
> Signed-off-by: Peng Fan <peng.fan@nxp.com>

The kontron pitx-imx8m board (imx8mq SoC) does not start properly in
since 4eb82c2e56a7c. This is still valid in the 2022.7-rcX. I see in
patchwork that this commit is superseded. Are there others available
that will fix your mentioned problem?

> ---
>  Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Kconfig b/Kconfig
> index bdae59e06f4..4559b627707 100644
> --- a/Kconfig
> +++ b/Kconfig
> @@ -257,7 +257,7 @@ config SYS_MALLOC_F_LEN
>         default 0x4000 if SANDBOX || RISCV || ARCH_APPLE || ROCKCHIP_RK3368 || \
>                           ROCKCHIP_RK3399
>         default 0x8000 if RCAR_GEN3
> -       default 0x10000 if ARCH_IMX8 || (ARCH_IMX8M && !IMX8MQ) || \
> +       default 0x10000 if ARCH_IMX8 || ARCH_IMX8M || \
>                            ARCH_LS1012A || ARCH_LS1021A || ARCH_LS1043A || \
>                            ARCH_LS1046A
>         default 0x2000
> @@ -285,6 +285,7 @@ config SPL_SYS_MALLOC_F_LEN
>         depends on SYS_MALLOC_F && SPL
>         default 0 if !SPL_FRAMEWORK
>         default 0x2800 if RCAR_GEN3
> +       default 0x2000 if IMX8MQ
>         default SYS_MALLOC_F_LEN
>         help
>           In SPL memory is very limited on many platforms. Still,
> --
> 2.36.0
>

Thanks
-- 
Heiko

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2022-06-10 18:14 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29  8:01 [PATCH 1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN Peng Fan (OSS)
2022-04-29  8:01 ` [PATCH 2/3] imx: imx8mq: default select CLK_IMX8MQ Peng Fan (OSS)
2022-04-30 13:49   ` Adam Ford
2022-05-01  9:44     ` Peng Fan (OSS)
2022-04-29  8:01 ` [PATCH 3/3] imx: imx8mq: select CONFIG_CMD_CLK Peng Fan (OSS)
2022-06-10 18:13 ` [PATCH 1/3] Kconfig: set i.MX8MQ SYS_MALLOC_F_LEN Heiko Thiery

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.