All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] EDAC/synopsys: Fix coding style issues
@ 2022-04-29 12:09 Shubhrajyoti Datta
  0 siblings, 0 replies; only message in thread
From: Shubhrajyoti Datta @ 2022-04-29 12:09 UTC (permalink / raw)
  To: linux-edac
  Cc: bp, mchehab, tony.luck, james.morse, michals, git, Shubhrajyoti Datta

Most of these stuff are reported by checkpatch.
The fixes are:
    - Additional ()
    - Newlines
    - alignment

Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xilinx.com>
---
 drivers/edac/synopsys_edac.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

diff --git a/drivers/edac/synopsys_edac.c b/drivers/edac/synopsys_edac.c
index f7d37c282819..5099a270d837 100644
--- a/drivers/edac/synopsys_edac.c
+++ b/drivers/edac/synopsys_edac.c
@@ -523,7 +523,6 @@ static void enable_intr(struct synps_edac_priv *priv)
 	else
 		writel(DDR_QOSUE_MASK | DDR_QOSCE_MASK,
 		       priv->baseaddr + DDR_QOS_IRQ_EN_OFST);
-
 }
 
 static void disable_intr(struct synps_edac_priv *priv)
@@ -692,7 +691,7 @@ static bool zynq_get_ecc_state(void __iomem *base)
 		return false;
 
 	ecctype = readl(base + SCRUB_OFST) & SCRUB_MODE_MASK;
-	if ((ecctype == SCRUB_MODE_SECDED) && (dt == DEV_X2))
+	if (ecctype == SCRUB_MODE_SECDED && dt == DEV_X2)
 		return true;
 
 	return false;
@@ -716,8 +715,8 @@ static bool zynqmp_get_ecc_state(void __iomem *base)
 		return false;
 
 	ecctype = readl(base + ECC_CFG0_OFST) & SCRUB_MODE_MASK;
-	if ((ecctype == SCRUB_MODE_SECDED) &&
-	    ((dt == DEV_X2) || (dt == DEV_X4) || (dt == DEV_X8)))
+	if (ecctype == SCRUB_MODE_SECDED &&
+	    (dt == DEV_X2 || dt == DEV_X4 || dt == DEV_X8))
 		return true;
 
 	return false;
@@ -919,7 +918,6 @@ static const struct synps_platform_data synopsys_edac_def = {
 			  ),
 };
 
-
 static const struct of_device_id synps_edac_match[] = {
 	{
 		.compatible = "xlnx,zynq-ddrc-a05",
@@ -1245,7 +1243,6 @@ static void setup_column_address_map(struct synps_edac_priv *priv, u32 *addrmap)
 			priv->col_shift[index - width] = 0;
 		}
 	}
-
 }
 
 static void setup_bank_address_map(struct synps_edac_priv *priv, u32 *addrmap)
@@ -1257,7 +1254,6 @@ static void setup_bank_address_map(struct synps_edac_priv *priv, u32 *addrmap)
 				BANK_MAX_VAL_MASK) == BANK_MAX_VAL_MASK) ? 0 :
 				(((addrmap[1] >> 16) & BANK_MAX_VAL_MASK) +
 				 BANK_B2_BASE);
-
 }
 
 static void setup_bg_address_map(struct synps_edac_priv *priv, u32 *addrmap)
@@ -1267,7 +1263,6 @@ static void setup_bg_address_map(struct synps_edac_priv *priv, u32 *addrmap)
 	priv->bankgrp_shift[1] = (((addrmap[8] >> 8) & BANKGRP_MAX_VAL_MASK) ==
 				BANKGRP_MAX_VAL_MASK) ? 0 : (((addrmap[8] >> 8)
 				& BANKGRP_MAX_VAL_MASK) + BANKGRP_B1_BASE);
-
 }
 
 static void setup_rank_address_map(struct synps_edac_priv *priv, u32 *addrmap)
@@ -1381,7 +1376,7 @@ static int mc_probe(struct platform_device *pdev)
 		rc = edac_create_sysfs_attributes(mci);
 		if (rc) {
 			edac_printk(KERN_ERR, EDAC_MC,
-					"Failed to create sysfs entries\n");
+				    "Failed to create sysfs entries\n");
 			goto free_edac_mc;
 		}
 	}
-- 
2.25.1


^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2022-04-29 12:09 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 12:09 [PATCH] EDAC/synopsys: Fix coding style issues Shubhrajyoti Datta

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.