* [PATCH] configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR
@ 2022-04-29 16:54 Tim Harvey
0 siblings, 0 replies; 3+ messages in thread
From: Tim Harvey @ 2022-04-29 16:54 UTC (permalink / raw)
To: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot; +Cc: Tim Harvey
The IMX8M based Venice boards all have device-tree fec nodes that
use proper dt with a phy-handle pointing to a phy with reg assigned
to the proper phy address.
There is no need to keep using the CONFIG_FEC_MXC_PHYADDR hack when
a proper dt is used - remove it.
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
include/configs/imx8mm_venice.h | 1 -
include/configs/imx8mn_venice.h | 1 -
2 files changed, 2 deletions(-)
diff --git a/include/configs/imx8mm_venice.h b/include/configs/imx8mm_venice.h
index 1b26e0280e1c..28417c55b9b6 100644
--- a/include/configs/imx8mm_venice.h
+++ b/include/configs/imx8mm_venice.h
@@ -112,7 +112,6 @@
sizeof(CONFIG_SYS_PROMPT) + 16)
/* FEC */
-#define CONFIG_FEC_MXC_PHYADDR 0
#define FEC_QUIRK_ENET_MAC
#endif
diff --git a/include/configs/imx8mn_venice.h b/include/configs/imx8mn_venice.h
index a4826779022a..0379c27f11a5 100644
--- a/include/configs/imx8mn_venice.h
+++ b/include/configs/imx8mn_venice.h
@@ -108,7 +108,6 @@
sizeof(CONFIG_SYS_PROMPT) + 16)
/* FEC */
-#define CONFIG_FEC_MXC_PHYADDR 0
#define FEC_QUIRK_ENET_MAC
#endif
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH] configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR
2022-11-04 15:50 Tim Harvey
@ 2022-11-08 16:37 ` sbabic
0 siblings, 0 replies; 3+ messages in thread
From: sbabic @ 2022-11-08 16:37 UTC (permalink / raw)
To: Tim Harvey, u-boot
> The IMX8M based Venice boards all have device-tree fec nodes that
> use proper dt with a phy-handle pointing to a phy with reg assigned
> to the proper phy address.
> There is no need to keep using the CONFIG_FEC_MXC_PHYADDR hack when
> a proper dt is used - remove it.
> This was previously done in commit 400eebf10d9b
> ("configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR")
> but got clobbered by commit 6889412ad5e7
> ("Convert CONFIG_SYS_BARGSIZE to Kconfig")
> Signed-off-by: Tim Harvey <tharvey@gateworks.com>
Applied to u-boot-imx, master, thanks !
Best regards,
Stefano Babic
--
=====================================================================
DENX Software Engineering GmbH, Managing Director: Wolfgang Denk
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-53 Fax: +49-8142-66989-80 Email: sbabic@denx.de
=====================================================================
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR
@ 2022-11-04 15:50 Tim Harvey
2022-11-08 16:37 ` sbabic
0 siblings, 1 reply; 3+ messages in thread
From: Tim Harvey @ 2022-11-04 15:50 UTC (permalink / raw)
To: Stefano Babic, Fabio Estevam, NXP i . MX U-Boot Team, u-boot; +Cc: Tim Harvey
The IMX8M based Venice boards all have device-tree fec nodes that
use proper dt with a phy-handle pointing to a phy with reg assigned
to the proper phy address.
There is no need to keep using the CONFIG_FEC_MXC_PHYADDR hack when
a proper dt is used - remove it.
This was previously done in commit 400eebf10d9b
("configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR")
but got clobbered by commit 6889412ad5e7
("Convert CONFIG_SYS_BARGSIZE to Kconfig")
Signed-off-by: Tim Harvey <tharvey@gateworks.com>
---
include/configs/imx8mm_venice.h | 4 ----
include/configs/imx8mn_venice.h | 4 ----
2 files changed, 8 deletions(-)
diff --git a/include/configs/imx8mm_venice.h b/include/configs/imx8mm_venice.h
index 44c6bc331dc7..6ecc3477f1b6 100644
--- a/include/configs/imx8mm_venice.h
+++ b/include/configs/imx8mm_venice.h
@@ -82,8 +82,4 @@
#define PHYS_SDRAM 0x40000000
#define PHYS_SDRAM_SIZE SZ_4G
-/* FEC */
-#define CONFIG_FEC_MXC_PHYADDR 0
-#define FEC_QUIRK_ENET_MAC
-
#endif
diff --git a/include/configs/imx8mn_venice.h b/include/configs/imx8mn_venice.h
index 6694820e76e5..4266eb076029 100644
--- a/include/configs/imx8mn_venice.h
+++ b/include/configs/imx8mn_venice.h
@@ -76,8 +76,4 @@
#define PHYS_SDRAM 0x40000000
#define PHYS_SDRAM_SIZE SZ_4G
-/* FEC */
-#define CONFIG_FEC_MXC_PHYADDR 0
-#define FEC_QUIRK_ENET_MAC
-
#endif
--
2.25.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-11-08 16:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-29 16:54 [PATCH] configs: imx8m{m, n}_venice: remove unneeded CONFIG_FEC_MXC_PHYADDR Tim Harvey
2022-11-04 15:50 Tim Harvey
2022-11-08 16:37 ` sbabic
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.