* [asahilinux:bits/110-smc 11/14] drivers/power/reset/macsmc-reboot.c:142:37: warning: declaration of 'struct power_off_data' will not be visible outside of this function
@ 2022-05-03 8:48 kernel test robot
0 siblings, 0 replies; only message in thread
From: kernel test robot @ 2022-05-03 8:48 UTC (permalink / raw)
To: Hector Martin; +Cc: llvm, kbuild-all, linux-kernel
tree: https://github.com/AsahiLinux/linux bits/110-smc
head: dc3db43287ff1d44b447fff8ed6386b28b339f1c
commit: c65d40d51ad43c1cb61a2e8658005340a622b826 [11/14] power: reset: macsmc-reboot: Add driver for rebooting via Apple SMC
config: arm64-randconfig-r034-20220501 (https://download.01.org/0day-ci/archive/20220503/202205031650.5NKbmyGx-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 363b3a645a1e30011cc8da624f13dac5fd915628)
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# install arm64 cross compiling tool for clang build
# apt-get install binutils-aarch64-linux-gnu
# https://github.com/AsahiLinux/linux/commit/c65d40d51ad43c1cb61a2e8658005340a622b826
git remote add asahilinux https://github.com/AsahiLinux/linux
git fetch --no-tags asahilinux bits/110-smc
git checkout c65d40d51ad43c1cb61a2e8658005340a622b826
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=arm64 SHELL=/bin/bash drivers/input/misc/ drivers/power/reset/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/power/reset/macsmc-reboot.c:54:25: error: field has incomplete type 'struct sys_off_handler'
struct sys_off_handler sys_off;
^
drivers/power/reset/macsmc-reboot.c:54:9: note: forward declaration of 'struct sys_off_handler'
struct sys_off_handler sys_off;
^
>> drivers/power/reset/macsmc-reboot.c:142:37: warning: declaration of 'struct power_off_data' will not be visible outside of this function [-Wvisibility]
static void macsmc_power_off(struct power_off_data *data)
^
drivers/power/reset/macsmc-reboot.c:144:37: error: incomplete definition of type 'struct power_off_data'
struct macsmc_reboot *reboot = data->cb_data;
~~~~^
drivers/power/reset/macsmc-reboot.c:142:37: note: forward declaration of 'struct power_off_data'
static void macsmc_power_off(struct power_off_data *data)
^
>> drivers/power/reset/macsmc-reboot.c:156:35: warning: declaration of 'struct restart_data' will not be visible outside of this function [-Wvisibility]
static void macsmc_restart(struct restart_data *data)
^
drivers/power/reset/macsmc-reboot.c:158:37: error: incomplete definition of type 'struct restart_data'
struct macsmc_reboot *reboot = data->cb_data;
~~~~^
drivers/power/reset/macsmc-reboot.c:156:35: note: forward declaration of 'struct restart_data'
static void macsmc_restart(struct restart_data *data)
^
>> drivers/power/reset/macsmc-reboot.c:170:42: warning: declaration of 'struct reboot_prep_data' will not be visible outside of this function [-Wvisibility]
static void macsmc_reboot_prepare(struct reboot_prep_data *data)
^
drivers/power/reset/macsmc-reboot.c:172:37: error: incomplete definition of type 'struct reboot_prep_data'
struct macsmc_reboot *reboot = data->cb_data;
~~~~^
drivers/power/reset/macsmc-reboot.c:170:42: note: forward declaration of 'struct reboot_prep_data'
static void macsmc_reboot_prepare(struct reboot_prep_data *data)
^
drivers/power/reset/macsmc-reboot.c:176:14: error: incomplete definition of type 'struct reboot_prep_data'
switch (data->mode) {
~~~~^
drivers/power/reset/macsmc-reboot.c:170:42: note: forward declaration of 'struct reboot_prep_data'
static void macsmc_reboot_prepare(struct reboot_prep_data *data)
^
drivers/power/reset/macsmc-reboot.c:289:37: error: use of undeclared identifier 'RESTART_PRIO_HIGH'
reboot->sys_off.restart_priority = RESTART_PRIO_HIGH;
^
drivers/power/reset/macsmc-reboot.c:292:8: error: call to undeclared function 'devm_register_sys_off_handler'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
ret = devm_register_sys_off_handler(&pdev->dev, &reboot->sys_off);
^
3 warnings and 7 errors generated.
vim +142 drivers/power/reset/macsmc-reboot.c
50
51 struct macsmc_reboot {
52 struct device *dev;
53 struct apple_smc *smc;
> 54 struct sys_off_handler sys_off;
55
56 union {
57 struct macsmc_reboot_nvmem nvm;
58 struct nvmem_cell *nvm_cells[ARRAY_SIZE(nvmem_names)];
59 };
60 };
61
62 /* Helpers to read/write a u8 given a struct nvmem_cell */
63 static int nvmem_cell_get_u8(struct nvmem_cell *cell)
64 {
65 size_t len;
66 u8 val;
67 void *ret = nvmem_cell_read(cell, &len);
68
69 if (IS_ERR(ret))
70 return PTR_ERR(ret);
71
72 if (len < 1) {
73 kfree(ret);
74 return -EINVAL;
75 }
76
77 val = *(u8 *)ret;
78 kfree(ret);
79 return val;
80 }
81
82 static int nvmem_cell_set_u8(struct nvmem_cell *cell, u8 val)
83 {
84 return nvmem_cell_write(cell, &val, sizeof(val));
85 }
86
87 static ssize_t macsmc_ac_power_mode_store(struct device *dev, struct device_attribute *attr,
88 const char *buf, size_t n)
89 {
90 struct macsmc_reboot *reboot = dev_get_drvdata(dev);
91 int mode;
92 int ret;
93
94 mode = sysfs_match_string(ac_power_modes, buf);
95 if (mode < 0)
96 return mode;
97
98 ret = nvmem_cell_set_u8(reboot->nvm.pm_setting, ac_power_mode_map[mode]);
99 if (ret < 0)
100 return ret;
101
102 return n;
103 }
104
105 static ssize_t macsmc_ac_power_mode_show(struct device *dev,
106 struct device_attribute *attr, char *buf)
107 {
108 struct macsmc_reboot *reboot = dev_get_drvdata(dev);
109 int len = 0;
110 int i;
111 int mode = nvmem_cell_get_u8(reboot->nvm.pm_setting);
112
113 if (mode < 0)
114 return mode;
115
116 for (i = 0; i < ARRAY_SIZE(ac_power_mode_map); i++)
117 if (mode == ac_power_mode_map[i])
118 len += scnprintf(buf+len, PAGE_SIZE-len,
119 "[%s] ", ac_power_modes[i]);
120 else
121 len += scnprintf(buf+len, PAGE_SIZE-len,
122 "%s ", ac_power_modes[i]);
123 buf[len-1] = '\n';
124 return len;
125 }
126 static DEVICE_ATTR(ac_power_mode, 0644, macsmc_ac_power_mode_show,
127 macsmc_ac_power_mode_store);
128
129 /*
130 * SMC 'MBSE' key actions:
131 *
132 * 'offw' - shutdown warning
133 * 'slpw' - sleep warning
134 * 'rest' - restart warning
135 * 'off1' - shutdown (needs PMU bit set to stay on)
136 * 'susp' - suspend
137 * 'phra' - restart ("PE Halt Restart Action"?)
138 * 'panb' - panic beginning
139 * 'pane' - panic end
140 */
141
> 142 static void macsmc_power_off(struct power_off_data *data)
143 {
144 struct macsmc_reboot *reboot = data->cb_data;
145
146 dev_info(reboot->dev, "Issuing power off (off1)\n");
147
148 if (apple_smc_write_u32_atomic(reboot->smc, SMC_KEY(MBSE), SMC_KEY(off1)) < 0) {
149 dev_err(reboot->dev, "Failed to issue MBSE = off1 (power_off)\n");
150 } else {
151 mdelay(100);
152 WARN_ON(1);
153 }
154 }
155
> 156 static void macsmc_restart(struct restart_data *data)
157 {
158 struct macsmc_reboot *reboot = data->cb_data;
159
160 dev_info(reboot->dev, "Issuing restart (phra)\n");
161
162 if (apple_smc_write_u32_atomic(reboot->smc, SMC_KEY(MBSE), SMC_KEY(phra)) < 0) {
163 dev_err(reboot->dev, "Failed to issue MBSE = phra (restart)\n");
164 } else {
165 mdelay(100);
166 WARN_ON(1);
167 }
168 }
169
> 170 static void macsmc_reboot_prepare(struct reboot_prep_data *data)
171 {
172 struct macsmc_reboot *reboot = data->cb_data;
173 u32 val;
174 u8 shutdown_flag;
175
176 switch (data->mode) {
177 case SYS_RESTART:
178 val = SMC_KEY(rest);
179 shutdown_flag = 0;
180 break;
181 case SYS_POWER_OFF:
182 val = SMC_KEY(offw);
183 shutdown_flag = 1;
184 break;
185 default:
186 return;
187 }
188
189 dev_info(reboot->dev, "Preparing for reboot (%p4ch)\n", &val);
190
191 /* On the Mac Mini, this will turn off the LED for power off */
192 if (apple_smc_write_u32(reboot->smc, SMC_KEY(MBSE), val) < 0)
193 dev_err(reboot->dev, "Failed to issue MBSE = %p4ch (reboot_prepare)\n", &val);
194
195 /* Set the boot_stage to 0, which means we're doing a clean shutdown/reboot. */
196 if (reboot->nvm.boot_stage &&
197 nvmem_cell_set_u8(reboot->nvm.boot_stage, BOOT_STAGE_SHUTDOWN) < 0)
198 dev_err(reboot->dev, "Failed to write boot_stage\n");
199
200 /*
201 * Set the PMU flag to actually reboot into the off state.
202 * Without this, the device will just reboot. We make it optional in case it is no longer
203 * necessary on newer hardware.
204 */
205 if (reboot->nvm.shutdown_flag &&
206 nvmem_cell_set_u8(reboot->nvm.shutdown_flag, shutdown_flag) < 0)
207 dev_err(reboot->dev, "Failed to write shutdown_flag\n");
208
--
0-DAY CI Kernel Test Service
https://01.org/lkp
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-05-03 8:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-03 8:48 [asahilinux:bits/110-smc 11/14] drivers/power/reset/macsmc-reboot.c:142:37: warning: declaration of 'struct power_off_data' will not be visible outside of this function kernel test robot
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.