All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jagan Teki <jagan@amarulasolutions.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Inki Dae <inki.dae@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Fancy Fang <chen.fang@nxp.com>,
	Tim Harvey <tharvey@gateworks.com>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Adam Ford <aford173@gmail.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Cc: Matteo Lisi <matteo.lisi@engicam.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v2 05/12] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable()
Date: Wed,  4 May 2022 17:10:14 +0530	[thread overview]
Message-ID: <20220504114021.33265-6-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20220504114021.33265-1-jagan@amarulasolutions.com>

Host transfer() in DSI master will invoke only when the DSI commands
are sent from DSI devices like DSI Panel or DSI bridges and this
host transfer wouldn't invoke for I2C-based-DSI bridge drivers.

Handling DSI host initialization in transfer calls misses the
controller setup for I2C configured DSI bridges.

This patch adds the DSI initialization from transfer to bridge
pre_enable as the bridge pre_enable API is invoked by core as
it is common across all classes of DSI device drivers.

v2:
* check initialized state in samsung_dsim_init

v1:
* keep DSI init in host transfer

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 60dc863113a0..b9361af5ef2d 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1259,6 +1259,9 @@ static int samsung_dsim_init(struct samsung_dsim *dsi)
 {
 	const struct samsung_dsim_driver_data *driver_data = dsi->driver_data;
 
+	if (dsi->state & DSIM_STATE_INITIALIZED)
+		return 0;
+
 	samsung_dsim_reset(dsi);
 	samsung_dsim_enable_irq(dsi);
 
@@ -1271,6 +1274,8 @@ static int samsung_dsim_init(struct samsung_dsim *dsi)
 	samsung_dsim_set_phy_ctrl(dsi);
 	samsung_dsim_init_link(dsi);
 
+	dsi->state |= DSIM_STATE_INITIALIZED;
+
 	return 0;
 }
 
@@ -1290,6 +1295,10 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge,
 	}
 
 	dsi->state |= DSIM_STATE_ENABLED;
+
+	ret = samsung_dsim_init(dsi);
+	if (ret)
+		return;
 }
 
 static void samsung_dsim_atomic_enable(struct drm_bridge *bridge,
@@ -1464,12 +1473,9 @@ static ssize_t samsung_dsim_host_transfer(struct mipi_dsi_host *host,
 	if (!(dsi->state & DSIM_STATE_ENABLED))
 		return -EINVAL;
 
-	if (!(dsi->state & DSIM_STATE_INITIALIZED)) {
-		ret = samsung_dsim_init(dsi);
-		if (ret)
-			return ret;
-		dsi->state |= DSIM_STATE_INITIALIZED;
-	}
+	ret = samsung_dsim_init(dsi);
+	if (ret)
+		return ret;
 
 	ret = mipi_dsi_create_packet(&xfer.packet, msg);
 	if (ret < 0)
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Inki Dae <inki.dae@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Fancy Fang <chen.fang@nxp.com>,
	Tim Harvey <tharvey@gateworks.com>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Adam Ford <aford173@gmail.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Cc: linux-samsung-soc@vger.kernel.org,
	Matteo Lisi <matteo.lisi@engicam.com>,
	dri-devel@lists.freedesktop.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	linux-arm-kernel@lists.infradead.org,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v2 05/12] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable()
Date: Wed,  4 May 2022 17:10:14 +0530	[thread overview]
Message-ID: <20220504114021.33265-6-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20220504114021.33265-1-jagan@amarulasolutions.com>

Host transfer() in DSI master will invoke only when the DSI commands
are sent from DSI devices like DSI Panel or DSI bridges and this
host transfer wouldn't invoke for I2C-based-DSI bridge drivers.

Handling DSI host initialization in transfer calls misses the
controller setup for I2C configured DSI bridges.

This patch adds the DSI initialization from transfer to bridge
pre_enable as the bridge pre_enable API is invoked by core as
it is common across all classes of DSI device drivers.

v2:
* check initialized state in samsung_dsim_init

v1:
* keep DSI init in host transfer

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 60dc863113a0..b9361af5ef2d 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1259,6 +1259,9 @@ static int samsung_dsim_init(struct samsung_dsim *dsi)
 {
 	const struct samsung_dsim_driver_data *driver_data = dsi->driver_data;
 
+	if (dsi->state & DSIM_STATE_INITIALIZED)
+		return 0;
+
 	samsung_dsim_reset(dsi);
 	samsung_dsim_enable_irq(dsi);
 
@@ -1271,6 +1274,8 @@ static int samsung_dsim_init(struct samsung_dsim *dsi)
 	samsung_dsim_set_phy_ctrl(dsi);
 	samsung_dsim_init_link(dsi);
 
+	dsi->state |= DSIM_STATE_INITIALIZED;
+
 	return 0;
 }
 
@@ -1290,6 +1295,10 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge,
 	}
 
 	dsi->state |= DSIM_STATE_ENABLED;
+
+	ret = samsung_dsim_init(dsi);
+	if (ret)
+		return;
 }
 
 static void samsung_dsim_atomic_enable(struct drm_bridge *bridge,
@@ -1464,12 +1473,9 @@ static ssize_t samsung_dsim_host_transfer(struct mipi_dsi_host *host,
 	if (!(dsi->state & DSIM_STATE_ENABLED))
 		return -EINVAL;
 
-	if (!(dsi->state & DSIM_STATE_INITIALIZED)) {
-		ret = samsung_dsim_init(dsi);
-		if (ret)
-			return ret;
-		dsi->state |= DSIM_STATE_INITIALIZED;
-	}
+	ret = samsung_dsim_init(dsi);
+	if (ret)
+		return ret;
 
 	ret = mipi_dsi_create_packet(&xfer.packet, msg);
 	if (ret < 0)
-- 
2.25.1


WARNING: multiple messages have this Message-ID (diff)
From: Jagan Teki <jagan@amarulasolutions.com>
To: Andrzej Hajda <andrzej.hajda@intel.com>,
	Inki Dae <inki.dae@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Joonyoung Shim <jy0922.shim@samsung.com>,
	Seung-Woo Kim <sw0312.kim@samsung.com>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Fancy Fang <chen.fang@nxp.com>,
	Tim Harvey <tharvey@gateworks.com>,
	Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
	Adam Ford <aford173@gmail.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <Laurent.pinchart@ideasonboard.com>,
	Tommaso Merciai <tommaso.merciai@amarulasolutions.com>
Cc: Matteo Lisi <matteo.lisi@engicam.com>,
	dri-devel@lists.freedesktop.org,
	linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	NXP Linux Team <linux-imx@nxp.com>,
	linux-amarula <linux-amarula@amarulasolutions.com>,
	Jagan Teki <jagan@amarulasolutions.com>
Subject: [PATCH v2 05/12] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable()
Date: Wed,  4 May 2022 17:10:14 +0530	[thread overview]
Message-ID: <20220504114021.33265-6-jagan@amarulasolutions.com> (raw)
In-Reply-To: <20220504114021.33265-1-jagan@amarulasolutions.com>

Host transfer() in DSI master will invoke only when the DSI commands
are sent from DSI devices like DSI Panel or DSI bridges and this
host transfer wouldn't invoke for I2C-based-DSI bridge drivers.

Handling DSI host initialization in transfer calls misses the
controller setup for I2C configured DSI bridges.

This patch adds the DSI initialization from transfer to bridge
pre_enable as the bridge pre_enable API is invoked by core as
it is common across all classes of DSI device drivers.

v2:
* check initialized state in samsung_dsim_init

v1:
* keep DSI init in host transfer

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/gpu/drm/bridge/samsung-dsim.c | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/drivers/gpu/drm/bridge/samsung-dsim.c b/drivers/gpu/drm/bridge/samsung-dsim.c
index 60dc863113a0..b9361af5ef2d 100644
--- a/drivers/gpu/drm/bridge/samsung-dsim.c
+++ b/drivers/gpu/drm/bridge/samsung-dsim.c
@@ -1259,6 +1259,9 @@ static int samsung_dsim_init(struct samsung_dsim *dsi)
 {
 	const struct samsung_dsim_driver_data *driver_data = dsi->driver_data;
 
+	if (dsi->state & DSIM_STATE_INITIALIZED)
+		return 0;
+
 	samsung_dsim_reset(dsi);
 	samsung_dsim_enable_irq(dsi);
 
@@ -1271,6 +1274,8 @@ static int samsung_dsim_init(struct samsung_dsim *dsi)
 	samsung_dsim_set_phy_ctrl(dsi);
 	samsung_dsim_init_link(dsi);
 
+	dsi->state |= DSIM_STATE_INITIALIZED;
+
 	return 0;
 }
 
@@ -1290,6 +1295,10 @@ static void samsung_dsim_atomic_pre_enable(struct drm_bridge *bridge,
 	}
 
 	dsi->state |= DSIM_STATE_ENABLED;
+
+	ret = samsung_dsim_init(dsi);
+	if (ret)
+		return;
 }
 
 static void samsung_dsim_atomic_enable(struct drm_bridge *bridge,
@@ -1464,12 +1473,9 @@ static ssize_t samsung_dsim_host_transfer(struct mipi_dsi_host *host,
 	if (!(dsi->state & DSIM_STATE_ENABLED))
 		return -EINVAL;
 
-	if (!(dsi->state & DSIM_STATE_INITIALIZED)) {
-		ret = samsung_dsim_init(dsi);
-		if (ret)
-			return ret;
-		dsi->state |= DSIM_STATE_INITIALIZED;
-	}
+	ret = samsung_dsim_init(dsi);
+	if (ret)
+		return ret;
 
 	ret = mipi_dsi_create_packet(&xfer.packet, msg);
 	if (ret < 0)
-- 
2.25.1


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-05-04 11:41 UTC|newest]

Thread overview: 103+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-04 11:40 [PATCH v2 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Jagan Teki
2022-05-04 11:40 ` Jagan Teki
2022-05-04 11:40 ` Jagan Teki
2022-05-04 11:40 ` [PATCH v2 01/12] drm: bridge: Add Samsung DSIM bridge driver Jagan Teki
2022-05-09 12:44   ` Marek Szyprowski
2022-05-09 12:44     ` Marek Szyprowski
2022-05-09 12:44     ` Marek Szyprowski
2022-05-11 12:21   ` Marek Szyprowski
2022-05-11 12:21     ` Marek Szyprowski
2022-05-11 12:21     ` Marek Szyprowski
2022-05-04 11:40 ` [PATCH v2 02/12] drm: bridge: samsung-dsim: Lookup OF-graph or Child node devices Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40 ` [PATCH v2 03/12] drm: bridge: samsung-dsim: Handle platform init via driver_data Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40 ` [PATCH v2 04/12] drm: bridge: samsung-dsim: Mark PHY as optional Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40 ` Jagan Teki [this message]
2022-05-04 11:40   ` [PATCH v2 05/12] drm: bridge: samsung-dsim: Add DSI init in bridge pre_enable() Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-11 15:02   ` Marek Szyprowski
2022-05-11 15:02     ` Marek Szyprowski
2022-05-11 15:02     ` Marek Szyprowski
2022-05-18 14:15     ` Marek Szyprowski
2022-05-18 14:15       ` Marek Szyprowski
2022-05-18 14:15       ` Marek Szyprowski
2022-05-04 11:40 ` [PATCH v2 06/12] drm: bridge: samsung-dsim: Fix PLL_P (PMS_P) offset Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40 ` [PATCH v2 07/12] drm: bridge: samsung-dsim: Add module init, exit Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-09 12:05   ` Marek Szyprowski
2022-05-09 12:05     ` Marek Szyprowski
2022-05-09 12:05     ` Marek Szyprowski
2022-07-19 12:11     ` Jagan Teki
2022-07-19 12:11       ` Jagan Teki
2022-07-19 12:11       ` Jagan Teki
2022-05-04 11:40 ` [PATCH v2 08/12] drm: bridge: samsung-dsim: Add atomic_check Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-10 21:41   ` Marek Szyprowski
2022-05-10 21:41     ` Marek Szyprowski
2022-05-10 21:41     ` Marek Szyprowski
2022-05-11 10:31   ` Andrzej Hajda
2022-05-11 10:31     ` Andrzej Hajda
2022-05-11 10:31     ` Andrzej Hajda
2022-06-13 11:17     ` Jagan Teki
2022-06-13 11:17       ` Jagan Teki
2022-06-13 11:17       ` Jagan Teki
2022-06-13 11:32       ` Marek Szyprowski
2022-06-13 11:32         ` Marek Szyprowski
2022-06-13 11:32         ` Marek Szyprowski
2022-06-13 11:34         ` Jagan Teki
2022-06-13 11:34           ` Jagan Teki
2022-06-13 11:34           ` Jagan Teki
2022-06-13 11:36           ` Marek Szyprowski
2022-06-13 11:36             ` Marek Szyprowski
2022-06-13 11:36             ` Marek Szyprowski
2022-06-13 12:15             ` Lucas Stach
2022-06-13 12:15               ` Lucas Stach
2022-06-13 12:15               ` Lucas Stach
2022-05-04 11:40 ` [PATCH v2 09/12] drm: bridge: samsung-dsim: Add atomic_get_input_bus_fmts Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40 ` [PATCH v2 10/12] drm: bridge: samsung-dsim: Add input_bus_flags Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40 ` [PATCH v2 11/12] dt-bindings: display: exynos: dsim: Add NXP i.MX8MM support Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-16 22:56   ` Rob Herring
2022-05-16 22:56     ` Rob Herring
2022-05-16 22:56     ` Rob Herring
2022-05-04 11:40 ` [PATCH v2 12/12] drm: bridge: samsung-dsim: Add " Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-04 11:40   ` Jagan Teki
2022-05-05  7:26 ` (EXT) [PATCH v2 00/12] drm: bridge: Add Samsung MIPI DSIM bridge Alexander Stein
2022-05-05  7:26   ` Alexander Stein
2022-05-05  7:26   ` Alexander Stein
2022-05-05  7:38   ` Jagan Teki
2022-05-05  7:38     ` Jagan Teki
2022-05-05  7:38     ` Jagan Teki
2022-05-05  7:48     ` (EXT) " Alexander Stein
2022-05-05  7:48       ` Alexander Stein
2022-05-05  7:48       ` Alexander Stein
2022-05-05 11:55     ` Alexander Stein
2022-05-05 11:55       ` Alexander Stein
2022-05-05 11:55       ` Alexander Stein
2022-05-06  8:57       ` Marek Szyprowski
2022-05-06  8:57         ` Marek Szyprowski
2022-05-06  8:57         ` Marek Szyprowski
2022-05-06 10:38         ` Alexander Stein
2022-05-06 10:38           ` Alexander Stein
2022-05-06 10:38           ` Alexander Stein
2022-05-06 10:50         ` Dave Stevenson
2022-05-06 10:50           ` Dave Stevenson
2022-05-06 10:50           ` Dave Stevenson
2022-05-09  9:00           ` Marek Szyprowski
2022-05-09  9:00             ` Marek Szyprowski
2022-05-09  9:00             ` Marek Szyprowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220504114021.33265-6-jagan@amarulasolutions.com \
    --to=jagan@amarulasolutions.com \
    --cc=Laurent.pinchart@ideasonboard.com \
    --cc=aford173@gmail.com \
    --cc=andrzej.hajda@intel.com \
    --cc=chen.fang@nxp.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=frieder.schrempf@kontron.de \
    --cc=inki.dae@samsung.com \
    --cc=jy0922.shim@samsung.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-amarula@amarulasolutions.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=matteo.lisi@engicam.com \
    --cc=michael@amarulasolutions.com \
    --cc=narmstrong@baylibre.com \
    --cc=robert.foss@linaro.org \
    --cc=sw0312.kim@samsung.com \
    --cc=tharvey@gateworks.com \
    --cc=tommaso.merciai@amarulasolutions.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.