* [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses
@ 2022-05-05 15:47 Krzysztof Kozlowski
2022-05-05 15:47 ` [PATCH 2/2] arm64: dts: qcom: correct SPMI WLED register range encoding Krzysztof Kozlowski
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-05 15:47 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
Kiran Gunda, dri-devel, linux-leds, devicetree, linux-kernel,
linux-arm-msm
Cc: Krzysztof Kozlowski
On PM660L, PMI8994 and PMI8998, the WLED has two address spaces. This
also fixes dtbs_check warnings like:
arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: [[55296], [55552]] is too long
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
.../devicetree/bindings/leds/backlight/qcom-wled.yaml | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
index 5d66c3e4def5..4c15693f7a01 100644
--- a/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
+++ b/Documentation/devicetree/bindings/leds/backlight/qcom-wled.yaml
@@ -26,7 +26,8 @@ properties:
- qcom,pm8150l-wled
reg:
- maxItems: 1
+ minItems: 1
+ maxItems: 2
default-brightness:
description: |
@@ -171,6 +172,9 @@ allOf:
then:
properties:
+ reg:
+ maxItems: 1
+
qcom,current-boost-limit:
enum: [ 105, 385, 525, 805, 980, 1260, 1400, 1680 ]
default: 805
@@ -189,6 +193,9 @@ allOf:
else:
properties:
+ reg:
+ minItems: 2
+
qcom,current-boost-limit:
enum: [ 105, 280, 450, 620, 970, 1150, 1300, 1500 ]
default: 970
--
2.32.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* [PATCH 2/2] arm64: dts: qcom: correct SPMI WLED register range encoding
2022-05-05 15:47 [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses Krzysztof Kozlowski
@ 2022-05-05 15:47 ` Krzysztof Kozlowski
2022-06-22 8:35 ` (subset) " Krzysztof Kozlowski
2022-07-03 3:56 ` Bjorn Andersson
2022-05-17 0:11 ` Rob Herring
2022-06-20 19:41 ` (subset) " Krzysztof Kozlowski
2 siblings, 2 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-05-05 15:47 UTC (permalink / raw)
To: Lee Jones, Daniel Thompson, Jingoo Han, Pavel Machek,
Rob Herring, Krzysztof Kozlowski, Andy Gross, Bjorn Andersson,
Kiran Gunda, dri-devel, linux-leds, devicetree, linux-kernel,
linux-arm-msm
Cc: Krzysztof Kozlowski
On PM660L, PMI8994 and PMI8998, the WLED has two address spaces and with
size-cells=0, they should be encoded as two separate items.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/qcom/pm660l.dtsi | 2 +-
arch/arm64/boot/dts/qcom/pmi8994.dtsi | 2 +-
arch/arm64/boot/dts/qcom/pmi8998.dtsi | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/pm660l.dtsi b/arch/arm64/boot/dts/qcom/pm660l.dtsi
index cfef42353611..cf26432bb7ce 100644
--- a/arch/arm64/boot/dts/qcom/pm660l.dtsi
+++ b/arch/arm64/boot/dts/qcom/pm660l.dtsi
@@ -67,7 +67,7 @@ pmic@3 {
pm660l_wled: leds@d800 {
compatible = "qcom,pm660l-wled";
- reg = <0xd800 0xd900>;
+ reg = <0xd800>, <0xd900>;
interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>;
interrupt-names = "ovp";
label = "backlight";
diff --git a/arch/arm64/boot/dts/qcom/pmi8994.dtsi b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
index 6e7c252568e6..81899fe17f2b 100644
--- a/arch/arm64/boot/dts/qcom/pmi8994.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8994.dtsi
@@ -35,7 +35,7 @@ pmi8994_spmi_regulators: regulators {
pmi8994_wled: wled@d800 {
compatible = "qcom,pmi8994-wled";
- reg = <0xd800 0xd900>;
+ reg = <0xd800>, <0xd900>;
interrupts = <3 0xd8 0x02 IRQ_TYPE_EDGE_RISING>;
interrupt-names = "short";
qcom,cabc;
diff --git a/arch/arm64/boot/dts/qcom/pmi8998.dtsi b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
index 0fef5f113f05..ef29e80c442c 100644
--- a/arch/arm64/boot/dts/qcom/pmi8998.dtsi
+++ b/arch/arm64/boot/dts/qcom/pmi8998.dtsi
@@ -44,7 +44,7 @@ lab: lab {
pmi8998_wled: leds@d800 {
compatible = "qcom,pmi8998-wled";
- reg = <0xd800 0xd900>;
+ reg = <0xd800>, <0xd900>;
interrupts = <0x3 0xd8 0x1 IRQ_TYPE_EDGE_RISING>,
<0x3 0xd8 0x2 IRQ_TYPE_EDGE_RISING>;
interrupt-names = "ovp", "short";
--
2.32.0
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: (subset) [PATCH 2/2] arm64: dts: qcom: correct SPMI WLED register range encoding
2022-05-05 15:47 ` [PATCH 2/2] arm64: dts: qcom: correct SPMI WLED register range encoding Krzysztof Kozlowski
@ 2022-06-22 8:35 ` Krzysztof Kozlowski
2022-07-03 3:56 ` Bjorn Andersson
1 sibling, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-22 8:35 UTC (permalink / raw)
To: kgunda, devicetree, robh+dt, linux-arm-msm, pavel, dri-devel,
daniel.thompson, krzysztof.kozlowski+dt, lee.jones, linux-kernel,
agross, bjorn.andersson, krzysztof.kozlowski, jingoohan1,
linux-leds
On Thu, 5 May 2022 17:47:02 +0200, Krzysztof Kozlowski wrote:
> On PM660L, PMI8994 and PMI8998, the WLED has two address spaces and with
> size-cells=0, they should be encoded as two separate items.
>
>
Applied, thanks!
[2/2] arm64: dts: qcom: correct SPMI WLED register range encoding
https://git.kernel.org/krzk/linux/c/2559f68b5991be168785a16a53f582862cf0063c
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread* Re: (subset) [PATCH 2/2] arm64: dts: qcom: correct SPMI WLED register range encoding
2022-05-05 15:47 ` [PATCH 2/2] arm64: dts: qcom: correct SPMI WLED register range encoding Krzysztof Kozlowski
2022-06-22 8:35 ` (subset) " Krzysztof Kozlowski
@ 2022-07-03 3:56 ` Bjorn Andersson
1 sibling, 0 replies; 7+ messages in thread
From: Bjorn Andersson @ 2022-07-03 3:56 UTC (permalink / raw)
To: Rob Herring, Andy Gross, Krzysztof Kozlowski, linux-kernel,
linux-arm-msm, devicetree, dri-devel, Krzysztof Kozlowski,
Kiran Gunda, Daniel Thompson, linux-leds, Jingoo Han,
Pavel Machek, Lee Jones
On Thu, 5 May 2022 17:47:02 +0200, Krzysztof Kozlowski wrote:
> On PM660L, PMI8994 and PMI8998, the WLED has two address spaces and with
> size-cells=0, they should be encoded as two separate items.
>
>
Applied, thanks!
[2/2] arm64: dts: qcom: correct SPMI WLED register range encoding
commit: d66b1d2e4afc0c8a9eb267740825240b67f6b1d1
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses
2022-05-05 15:47 [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses Krzysztof Kozlowski
@ 2022-05-17 0:11 ` Rob Herring
2022-05-17 0:11 ` Rob Herring
2022-06-20 19:41 ` (subset) " Krzysztof Kozlowski
2 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-05-17 0:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: linux-kernel, dri-devel, linux-leds, Daniel Thompson,
Krzysztof Kozlowski, Jingoo Han, Rob Herring, Andy Gross,
linux-arm-msm, Lee Jones, Bjorn Andersson, devicetree,
Pavel Machek, Kiran Gunda
On Thu, 05 May 2022 17:47:01 +0200, Krzysztof Kozlowski wrote:
> On PM660L, PMI8994 and PMI8998, the WLED has two address spaces. This
> also fixes dtbs_check warnings like:
>
> arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: [[55296], [55552]] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/leds/backlight/qcom-wled.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses
@ 2022-05-17 0:11 ` Rob Herring
0 siblings, 0 replies; 7+ messages in thread
From: Rob Herring @ 2022-05-17 0:11 UTC (permalink / raw)
To: Krzysztof Kozlowski
Cc: devicetree, Daniel Thompson, Kiran Gunda, Pavel Machek,
Jingoo Han, linux-kernel, dri-devel, Bjorn Andersson,
Rob Herring, Andy Gross, Krzysztof Kozlowski, linux-arm-msm,
Lee Jones, linux-leds
On Thu, 05 May 2022 17:47:01 +0200, Krzysztof Kozlowski wrote:
> On PM660L, PMI8994 and PMI8998, the WLED has two address spaces. This
> also fixes dtbs_check warnings like:
>
> arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: [[55296], [55552]] is too long
>
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> ---
> .../devicetree/bindings/leds/backlight/qcom-wled.yaml | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: (subset) [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses
2022-05-05 15:47 [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses Krzysztof Kozlowski
2022-05-05 15:47 ` [PATCH 2/2] arm64: dts: qcom: correct SPMI WLED register range encoding Krzysztof Kozlowski
2022-05-17 0:11 ` Rob Herring
@ 2022-06-20 19:41 ` Krzysztof Kozlowski
2 siblings, 0 replies; 7+ messages in thread
From: Krzysztof Kozlowski @ 2022-06-20 19:41 UTC (permalink / raw)
To: daniel.thompson, linux-kernel, lee.jones, jingoohan1,
bjorn.andersson, agross, linux-arm-msm, devicetree, linux-leds,
kgunda, pavel, robh+dt, krzysztof.kozlowski+dt, dri-devel,
krzysztof.kozlowski
On Thu, 5 May 2022 17:47:01 +0200, Krzysztof Kozlowski wrote:
> On PM660L, PMI8994 and PMI8998, the WLED has two address spaces. This
> also fixes dtbs_check warnings like:
>
> arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dtb: leds@d800: reg: [[55296], [55552]] is too long
>
>
Applied, thanks!
[1/2] dt-bindings: leds: qcom-wled: fix number of addresses
https://git.kernel.org/krzk/linux-dt/c/ba52039325826b3f2bddd00972f3f61fbe7d9f0e
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2022-07-03 3:58 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-05 15:47 [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses Krzysztof Kozlowski
2022-05-05 15:47 ` [PATCH 2/2] arm64: dts: qcom: correct SPMI WLED register range encoding Krzysztof Kozlowski
2022-06-22 8:35 ` (subset) " Krzysztof Kozlowski
2022-07-03 3:56 ` Bjorn Andersson
2022-05-17 0:11 ` [PATCH 1/2] dt-bindings: leds: qcom-wled: fix number of addresses Rob Herring
2022-05-17 0:11 ` Rob Herring
2022-06-20 19:41 ` (subset) " Krzysztof Kozlowski
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.