[PATCH] xfs: remove unreachable code

[PATCH] xfs: remove unreachable code

[Jiapeng Chong]

Clean up the following smatch warning:

fs/xfs/xfs_icache.c:1768 xfs_icwalk() warn: ignoring unreachable code.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
---
 fs/xfs/xfs_icache.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
index 5269354b1b69..5af272c20934 100644
--- a/fs/xfs/xfs_icache.c
+++ b/fs/xfs/xfs_icache.c
@@ -1765,7 +1765,6 @@ xfs_icwalk(
 		}
 	}
 	return last_error;
-	BUILD_BUG_ON(XFS_ICWALK_PRIVATE_FLAGS & XFS_ICWALK_FLAGS_VALID);
 }
 
 #ifdef DEBUG
-- 
2.20.1.7.g153144c

Re: [PATCH] xfs: remove unreachable code

[Darrick J. Wong]

On Fri, May 06, 2022 at 04:26:15PM +0800, Jiapeng Chong wrote:
> Clean up the following smatch warning:
> 
> fs/xfs/xfs_icache.c:1768 xfs_icwalk() warn: ignoring unreachable code.
> 
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>
> ---
>  fs/xfs/xfs_icache.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_icache.c b/fs/xfs/xfs_icache.c
> index 5269354b1b69..5af272c20934 100644
> --- a/fs/xfs/xfs_icache.c
> +++ b/fs/xfs/xfs_icache.c
> @@ -1765,7 +1765,6 @@ xfs_icwalk(
>  		}
>  	}
>  	return last_error;
> -	BUILD_BUG_ON(XFS_ICWALK_PRIVATE_FLAGS & XFS_ICWALK_FLAGS_VALID);

<cough> Do you know what you're removing?

--D

>  }
>  
>  #ifdef DEBUG
> -- 
> 2.20.1.7.g153144c
> 

Re: [PATCH] xfs: remove unreachable code

[Christoph Hellwig]

On Fri, May 06, 2022 at 09:04:02AM -0700, Darrick J. Wong wrote:
> > @@ -1765,7 +1765,6 @@ xfs_icwalk(
> >  		}
> >  	}
> >  	return last_error;
> > -	BUILD_BUG_ON(XFS_ICWALK_PRIVATE_FLAGS & XFS_ICWALK_FLAGS_VALID);
> 
> <cough> Do you know what you're removing?

That being said hiding this behind the return is rather odd.  The
normal placement in most of the kernel is at the beginning of a
function.