* [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol
@ 2022-05-06 12:04 Jani Nikula
2022-05-06 13:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 6+ messages in thread
From: Jani Nikula @ 2022-05-06 12:04 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula
Fix:
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:61:6: warning: symbol
'intel_pxp_debugfs_register' was not declared. Should it be static?
Sort and remove the redundant pxp prefixes from the includes while at
it.
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
index c9da1015eb42..e888b5124a07 100644
--- a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
+++ b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
@@ -9,9 +9,10 @@
#include <drm/drm_print.h>
#include "gt/intel_gt_debugfs.h"
-#include "pxp/intel_pxp.h"
-#include "pxp/intel_pxp_irq.h"
#include "i915_drv.h"
+#include "intel_pxp.h"
+#include "intel_pxp_debugfs.h"
+#include "intel_pxp_irq.h"
static int pxp_info_show(struct seq_file *m, void *data)
{
--
2.30.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/pxp: fix sparse warning for not declared symbol
2022-05-06 12:04 [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol Jani Nikula
@ 2022-05-06 13:57 ` Patchwork
2022-05-06 14:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-05-06 13:57 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/pxp: fix sparse warning for not declared symbol
URL : https://patchwork.freedesktop.org/series/103673/
State : warning
== Summary ==
Error: dim checkpatch failed
151a8d341bdd drm/i915/pxp: fix sparse warning for not declared symbol
-:4: WARNING:EMAIL_SUBJECT: A patch subject line should describe the change not the tool that found it
#4:
Subject: [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol
total: 0 errors, 1 warnings, 0 checks, 12 lines checked
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pxp: fix sparse warning for not declared symbol
2022-05-06 12:04 [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol Jani Nikula
2022-05-06 13:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2022-05-06 14:04 ` Patchwork
2022-05-06 16:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-06-08 8:06 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-05-06 14:04 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 2753 bytes --]
== Series Details ==
Series: drm/i915/pxp: fix sparse warning for not declared symbol
URL : https://patchwork.freedesktop.org/series/103673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11617 -> Patchwork_103673v1
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/index.html
Participating hosts (45 -> 34)
------------------------------
Additional (1): fi-snb-2520m
Missing (12): bat-adls-5 bat-dg1-6 bat-dg2-8 fi-skl-guc bat-adlm-1 bat-dg2-9 fi-bsw-cyan bat-adlp-6 bat-adln-1 bat-rpls-2 bat-jsl-2 bat-jsl-1
Known issues
------------
Here are the changes found in Patchwork_103673v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_lmem_swapping@basic:
- fi-snb-2520m: NOTRUN -> [SKIP][1] ([fdo#109271]) +24 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/fi-snb-2520m/igt@gem_lmem_swapping@basic.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-snb-2600: NOTRUN -> [SKIP][2] ([fdo#109271] / [fdo#111827])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/fi-snb-2600/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-snb-2520m: NOTRUN -> [SKIP][3] ([fdo#109271] / [fdo#111827]) +8 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/fi-snb-2520m/igt@kms_chamelium@hdmi-hpd-fast.html
#### Possible fixes ####
* igt@i915_selftest@live@hangcheck:
- fi-snb-2600: [INCOMPLETE][4] ([i915#3921]) -> [PASS][5]
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/fi-snb-2600/igt@i915_selftest@live@hangcheck.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
Build changes
-------------
* Linux: CI_DRM_11617 -> Patchwork_103673v1
CI-20190529: 20190529
CI_DRM_11617: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103673v1: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
5ddacc70a7f9 drm/i915/pxp: fix sparse warning for not declared symbol
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/index.html
[-- Attachment #2: Type: text/html, Size: 3637 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pxp: fix sparse warning for not declared symbol
2022-05-06 12:04 [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol Jani Nikula
2022-05-06 13:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-05-06 14:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
@ 2022-05-06 16:49 ` Patchwork
2022-06-08 8:06 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
3 siblings, 0 replies; 6+ messages in thread
From: Patchwork @ 2022-05-06 16:49 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 2180 bytes --]
== Series Details ==
Series: drm/i915/pxp: fix sparse warning for not declared symbol
URL : https://patchwork.freedesktop.org/series/103673/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_11617_full -> Patchwork_103673v1_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/index.html
Participating hosts (11 -> 7)
------------------------------
Missing (4): pig-skl-6260u pig-kbl-iris shard-tglu pig-glk-j5005
Known issues
------------
Here are the changes found in Patchwork_103673v1_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@kms_big_fb@linear-64bpp-rotate-0:
- shard-snb: [PASS][1] -> [SKIP][2] ([fdo#109271]) +5 similar issues
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/shard-snb4/igt@kms_big_fb@linear-64bpp-rotate-0.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/shard-snb7/igt@kms_big_fb@linear-64bpp-rotate-0.html
#### Possible fixes ####
* igt@gem_mmap_gtt@coherency:
- shard-snb: [SKIP][3] ([fdo#109271]) -> [PASS][4] +1 similar issue
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/shard-snb6/igt@gem_mmap_gtt@coherency.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/shard-snb4/igt@gem_mmap_gtt@coherency.html
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
Build changes
-------------
* Linux: CI_DRM_11617 -> Patchwork_103673v1
* Piglit: piglit_4509 -> None
CI-20190529: 20190529
CI_DRM_11617: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103673v1: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103673v1/index.html
[-- Attachment #2: Type: text/html, Size: 2872 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol
2022-05-06 12:04 [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol Jani Nikula
` (2 preceding siblings ...)
2022-05-06 16:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
@ 2022-06-08 8:06 ` Tvrtko Ursulin
2022-06-08 8:46 ` Jani Nikula
3 siblings, 1 reply; 6+ messages in thread
From: Tvrtko Ursulin @ 2022-06-08 8:06 UTC (permalink / raw)
To: Jani Nikula, intel-gfx
On 06/05/2022 13:04, Jani Nikula wrote:
> Fix:
>
> drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:61:6: warning: symbol
> 'intel_pxp_debugfs_register' was not declared. Should it be static?
>
> Sort and remove the redundant pxp prefixes from the includes while at
> it.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
> index c9da1015eb42..e888b5124a07 100644
> --- a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
> @@ -9,9 +9,10 @@
> #include <drm/drm_print.h>
>
> #include "gt/intel_gt_debugfs.h"
> -#include "pxp/intel_pxp.h"
> -#include "pxp/intel_pxp_irq.h"
> #include "i915_drv.h"
> +#include "intel_pxp.h"
> +#include "intel_pxp_debugfs.h"
> +#include "intel_pxp_irq.h"
>
> static int pxp_info_show(struct seq_file *m, void *data)
> {
Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Lets try to copy domain owners when doing cleanups to lessen the
maintainer load, since it appears people are not really scanning the
upstream mailing list these days. :(
Regards,
Tvrtko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol
2022-06-08 8:06 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
@ 2022-06-08 8:46 ` Jani Nikula
0 siblings, 0 replies; 6+ messages in thread
From: Jani Nikula @ 2022-06-08 8:46 UTC (permalink / raw)
To: Tvrtko Ursulin, intel-gfx
On Wed, 08 Jun 2022, Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> wrote:
> On 06/05/2022 13:04, Jani Nikula wrote:
>> Fix:
>>
>> drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c:61:6: warning: symbol
>> 'intel_pxp_debugfs_register' was not declared. Should it be static?
>>
>> Sort and remove the redundant pxp prefixes from the includes while at
>> it.
>>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>> ---
>> drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c | 5 +++--
>> 1 file changed, 3 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
>> index c9da1015eb42..e888b5124a07 100644
>> --- a/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
>> +++ b/drivers/gpu/drm/i915/pxp/intel_pxp_debugfs.c
>> @@ -9,9 +9,10 @@
>> #include <drm/drm_print.h>
>>
>> #include "gt/intel_gt_debugfs.h"
>> -#include "pxp/intel_pxp.h"
>> -#include "pxp/intel_pxp_irq.h"
>> #include "i915_drv.h"
>> +#include "intel_pxp.h"
>> +#include "intel_pxp_debugfs.h"
>> +#include "intel_pxp_irq.h"
>>
>> static int pxp_info_show(struct seq_file *m, void *data)
>> {
>
> Reviewed-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Thanks, pushed to din.
BR,
Jani.
>
> Lets try to copy domain owners when doing cleanups to lessen the
> maintainer load, since it appears people are not really scanning the
> upstream mailing list these days. :(
>
> Regards,
>
> Tvrtko
--
Jani Nikula, Intel Open Source Graphics Center
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-06-08 8:46 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-06 12:04 [Intel-gfx] [PATCH] drm/i915/pxp: fix sparse warning for not declared symbol Jani Nikula
2022-05-06 13:57 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2022-05-06 14:04 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2022-05-06 16:49 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork
2022-06-08 8:06 ` [Intel-gfx] [PATCH] " Tvrtko Ursulin
2022-06-08 8:46 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.