All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: sam9g20_wm8731: Use dev_err_probe() for snd_soc_register_card()
@ 2022-05-06 13:03 Mark Brown
  2022-05-09  8:14 ` Codrin.Ciubotariu
  2022-05-09 18:47 ` Mark Brown
  0 siblings, 2 replies; 3+ messages in thread
From: Mark Brown @ 2022-05-06 13:03 UTC (permalink / raw)
  To: Codrin Ciubotariu, Liam Girdwood; +Cc: alsa-devel, Mark Brown

Log the error code when snd_soc_regster_card() fails, but fold in the
silencing of deferred probe errors.

Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/atmel/sam9g20_wm8731.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/sound/soc/atmel/sam9g20_wm8731.c b/sound/soc/atmel/sam9g20_wm8731.c
index 0365b583ba70..4d25fb61c652 100644
--- a/sound/soc/atmel/sam9g20_wm8731.c
+++ b/sound/soc/atmel/sam9g20_wm8731.c
@@ -171,7 +171,8 @@ static int at91sam9g20ek_audio_probe(struct platform_device *pdev)
 
 	ret = snd_soc_register_card(card);
 	if (ret) {
-		dev_err(&pdev->dev, "snd_soc_register_card() failed\n");
+		dev_err_probe(&pdev->dev, ret,
+			      "snd_soc_register_card() failed: %d\n", ret);
 		goto err;
 	}
 
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: sam9g20_wm8731: Use dev_err_probe() for snd_soc_register_card()
  2022-05-06 13:03 [PATCH] ASoC: sam9g20_wm8731: Use dev_err_probe() for snd_soc_register_card() Mark Brown
@ 2022-05-09  8:14 ` Codrin.Ciubotariu
  2022-05-09 18:47 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Codrin.Ciubotariu @ 2022-05-09  8:14 UTC (permalink / raw)
  To: broonie, lgirdwood; +Cc: alsa-devel

On 06.05.2022 16:03, Mark Brown wrote:
> Log the error code when snd_soc_regster_card() fails, but fold in the
> silencing of deferred probe errors.
> 
> Signed-off-by: Mark Brown <broonie@kernel.org>

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thank you!

> ---
>   sound/soc/atmel/sam9g20_wm8731.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] ASoC: sam9g20_wm8731: Use dev_err_probe() for snd_soc_register_card()
  2022-05-06 13:03 [PATCH] ASoC: sam9g20_wm8731: Use dev_err_probe() for snd_soc_register_card() Mark Brown
  2022-05-09  8:14 ` Codrin.Ciubotariu
@ 2022-05-09 18:47 ` Mark Brown
  1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2022-05-09 18:47 UTC (permalink / raw)
  To: codrin.ciubotariu, broonie, Liam Girdwood; +Cc: alsa-devel

On Fri, 6 May 2022 14:03:49 +0100, Mark Brown wrote:
> Log the error code when snd_soc_regster_card() fails, but fold in the
> silencing of deferred probe errors.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: sam9g20_wm8731: Use dev_err_probe() for snd_soc_register_card()
      commit: 29f4078f777fed4cb47695b284938fbfd80f990e

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2022-05-09 18:48 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-06 13:03 [PATCH] ASoC: sam9g20_wm8731: Use dev_err_probe() for snd_soc_register_card() Mark Brown
2022-05-09  8:14 ` Codrin.Ciubotariu
2022-05-09 18:47 ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.