* [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-06 13:22 ` Javier Martinez Canillas
0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2022-05-06 13:22 UTC (permalink / raw)
To: linux-kernel
Cc: Andrzej Hajda, Ville Syrjälä,
intel-gfx, Javier Martinez Canillas, Daniel Vetter, Helge Deller,
Peter Jones, Thomas Zimmermann, dri-devel, linux-fbdev
Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
than .remove") attempted to fix a use-after-free error due driver freeing
the fb_info in the .remove handler instead of doing it in .fb_destroy.
But ironically that change introduced yet another use-after-free since the
fb_info was still used after the free.
This should fix for good by freeing the fb_info at the end of the handler.
Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/video/fbdev/efifb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index cfa3dc0b4eee..b3d5f884c544 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
memunmap(info->screen_base);
}
- framebuffer_release(info);
-
if (request_mem_succeeded)
release_mem_region(info->apertures->ranges[0].base,
info->apertures->ranges[0].size);
fb_dealloc_cmap(&info->cmap);
+
+ framebuffer_release(info);
}
static const struct fb_ops efifb_ops = {
--
2.35.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-06 13:22 ` Javier Martinez Canillas
0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2022-05-06 13:22 UTC (permalink / raw)
To: linux-kernel
Cc: linux-fbdev, Thomas Zimmermann, Daniel Vetter, intel-gfx,
Javier Martinez Canillas, dri-devel, Peter Jones, Andrzej Hajda,
Helge Deller
Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
than .remove") attempted to fix a use-after-free error due driver freeing
the fb_info in the .remove handler instead of doing it in .fb_destroy.
But ironically that change introduced yet another use-after-free since the
fb_info was still used after the free.
This should fix for good by freeing the fb_info at the end of the handler.
Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/video/fbdev/efifb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index cfa3dc0b4eee..b3d5f884c544 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
memunmap(info->screen_base);
}
- framebuffer_release(info);
-
if (request_mem_succeeded)
release_mem_region(info->apertures->ranges[0].base,
info->apertures->ranges[0].size);
fb_dealloc_cmap(&info->cmap);
+
+ framebuffer_release(info);
}
static const struct fb_ops efifb_ops = {
--
2.35.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-06 13:22 ` Javier Martinez Canillas
0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2022-05-06 13:22 UTC (permalink / raw)
To: linux-kernel
Cc: linux-fbdev, Thomas Zimmermann, Daniel Vetter, intel-gfx,
Javier Martinez Canillas, dri-devel, Peter Jones, Andrzej Hajda,
Helge Deller
Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
than .remove") attempted to fix a use-after-free error due driver freeing
the fb_info in the .remove handler instead of doing it in .fb_destroy.
But ironically that change introduced yet another use-after-free since the
fb_info was still used after the free.
This should fix for good by freeing the fb_info at the end of the handler.
Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
---
drivers/video/fbdev/efifb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
index cfa3dc0b4eee..b3d5f884c544 100644
--- a/drivers/video/fbdev/efifb.c
+++ b/drivers/video/fbdev/efifb.c
@@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
memunmap(info->screen_base);
}
- framebuffer_release(info);
-
if (request_mem_succeeded)
release_mem_region(info->apertures->ranges[0].base,
info->apertures->ranges[0].size);
fb_dealloc_cmap(&info->cmap);
+
+ framebuffer_release(info);
}
static const struct fb_ops efifb_ops = {
--
2.35.1
^ permalink raw reply related [flat|nested] 18+ messages in thread
* Re: [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
2022-05-06 13:22 ` Javier Martinez Canillas
(?)
@ 2022-05-06 13:39 ` Thomas Zimmermann
-1 siblings, 0 replies; 18+ messages in thread
From: Thomas Zimmermann @ 2022-05-06 13:39 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Andrzej Hajda, Ville Syrjälä,
intel-gfx, Daniel Vetter, Helge Deller, Peter Jones, dri-devel,
linux-fbdev
[-- Attachment #1.1: Type: text/plain, Size: 1751 bytes --]
Am 06.05.22 um 15:22 schrieb Javier Martinez Canillas:
> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
> than .remove") attempted to fix a use-after-free error due driver freeing
> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
> But ironically that change introduced yet another use-after-free since the
> fb_info was still used after the free.
>
> This should fix for good by freeing the fb_info at the end of the handler.
>
> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimemrmann@suse.de>
> ---
>
> drivers/video/fbdev/efifb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index cfa3dc0b4eee..b3d5f884c544 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
> memunmap(info->screen_base);
> }
>
> - framebuffer_release(info);
> -
> if (request_mem_succeeded)
> release_mem_region(info->apertures->ranges[0].base,
> info->apertures->ranges[0].size);
> fb_dealloc_cmap(&info->cmap);
> +
> + framebuffer_release(info);
> }
>
> static const struct fb_ops efifb_ops = {
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-06 13:39 ` Thomas Zimmermann
0 siblings, 0 replies; 18+ messages in thread
From: Thomas Zimmermann @ 2022-05-06 13:39 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-fbdev, Daniel Vetter, intel-gfx, dri-devel, Peter Jones,
Andrzej Hajda, Helge Deller
[-- Attachment #1.1: Type: text/plain, Size: 1751 bytes --]
Am 06.05.22 um 15:22 schrieb Javier Martinez Canillas:
> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
> than .remove") attempted to fix a use-after-free error due driver freeing
> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
> But ironically that change introduced yet another use-after-free since the
> fb_info was still used after the free.
>
> This should fix for good by freeing the fb_info at the end of the handler.
>
> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimemrmann@suse.de>
> ---
>
> drivers/video/fbdev/efifb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index cfa3dc0b4eee..b3d5f884c544 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
> memunmap(info->screen_base);
> }
>
> - framebuffer_release(info);
> -
> if (request_mem_succeeded)
> release_mem_region(info->apertures->ranges[0].base,
> info->apertures->ranges[0].size);
> fb_dealloc_cmap(&info->cmap);
> +
> + framebuffer_release(info);
> }
>
> static const struct fb_ops efifb_ops = {
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-06 13:39 ` Thomas Zimmermann
0 siblings, 0 replies; 18+ messages in thread
From: Thomas Zimmermann @ 2022-05-06 13:39 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-fbdev, Daniel Vetter, intel-gfx, dri-devel, Peter Jones,
Andrzej Hajda, Helge Deller
[-- Attachment #1.1: Type: text/plain, Size: 1751 bytes --]
Am 06.05.22 um 15:22 schrieb Javier Martinez Canillas:
> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
> than .remove") attempted to fix a use-after-free error due driver freeing
> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
> But ironically that change introduced yet another use-after-free since the
> fb_info was still used after the free.
>
> This should fix for good by freeing the fb_info at the end of the handler.
>
> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimemrmann@suse.de>
> ---
>
> drivers/video/fbdev/efifb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index cfa3dc0b4eee..b3d5f884c544 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
> memunmap(info->screen_base);
> }
>
> - framebuffer_release(info);
> -
> if (request_mem_succeeded)
> release_mem_region(info->apertures->ranges[0].base,
> info->apertures->ranges[0].size);
> fb_dealloc_cmap(&info->cmap);
> +
> + framebuffer_release(info);
> }
>
> static const struct fb_ops efifb_ops = {
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for fbdev: efifb: Fix a use-after-free due early fb_info cleanup
2022-05-06 13:22 ` Javier Martinez Canillas
` (2 preceding siblings ...)
(?)
@ 2022-05-06 14:56 ` Patchwork
-1 siblings, 0 replies; 18+ messages in thread
From: Patchwork @ 2022-05-06 14:56 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: intel-gfx
[-- Attachment #1: Type: text/plain, Size: 28040 bytes --]
== Series Details ==
Series: fbdev: efifb: Fix a use-after-free due early fb_info cleanup
URL : https://patchwork.freedesktop.org/series/103680/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_11617 -> Patchwork_103680v1
====================================================
Summary
-------
**FAILURE**
Serious unknown changes coming with Patchwork_103680v1 absolutely need to be
verified manually.
If you think the reported changes have nothing to do with the changes
introduced in Patchwork_103680v1, please notify your bug team to allow them
to document this new failure mode, which will reduce false positives in CI.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/index.html
Participating hosts (45 -> 33)
------------------------------
Additional (1): fi-snb-2520m
Missing (13): fi-rkl-11600 bat-adls-5 bat-dg1-6 bat-dg2-8 bat-adlm-1 bat-dg2-9 fi-bsw-cyan bat-adlp-6 fi-cfl-guc bat-adln-1 bat-rpls-2 bat-jsl-2 bat-jsl-1
Possible new issues
-------------------
Here are the unknown changes that may have been introduced in Patchwork_103680v1:
### IGT changes ###
#### Possible regressions ####
* igt@gem_tiled_pread_basic:
- fi-icl-u2: NOTRUN -> [DMESG-WARN][1]
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-icl-u2/igt@gem_tiled_pread_basic.html
Known issues
------------
Here are the changes found in Patchwork_103680v1 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@debugfs_test@read_all_entries:
- fi-apl-guc: NOTRUN -> [DMESG-WARN][2] ([i915#5595])
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-apl-guc/igt@debugfs_test@read_all_entries.html
* igt@gem_exec_fence@basic-busy@bcs0:
- fi-kbl-guc: NOTRUN -> [SKIP][3] ([fdo#109271]) +18 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-guc/igt@gem_exec_fence@basic-busy@bcs0.html
- fi-kbl-soraka: NOTRUN -> [SKIP][4] ([fdo#109271]) +9 similar issues
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-soraka/igt@gem_exec_fence@basic-busy@bcs0.html
* igt@gem_exec_suspend@basic-s0@smem:
- fi-tgl-1115g4: NOTRUN -> [DMESG-WARN][5] ([i915#5122])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@gem_exec_suspend@basic-s0@smem.html
* igt@gem_huc_copy@huc-copy:
- fi-hsw-4770: NOTRUN -> [SKIP][6] ([fdo#109271]) +9 similar issues
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-4770/igt@gem_huc_copy@huc-copy.html
- fi-skl-6700k2: NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-skl-6700k2/igt@gem_huc_copy@huc-copy.html
- fi-kbl-soraka: NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#2190])
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
- fi-kbl-7500u: NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#2190])
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-7500u/igt@gem_huc_copy@huc-copy.html
- fi-kbl-8809g: NOTRUN -> [SKIP][10] ([fdo#109271] / [i915#2190])
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-8809g/igt@gem_huc_copy@huc-copy.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][11] ([i915#2190])
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
- fi-glk-j4005: NOTRUN -> [SKIP][12] ([fdo#109271] / [i915#2190])
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-glk-j4005/igt@gem_huc_copy@huc-copy.html
- fi-cfl-8109u: NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#2190])
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8109u/igt@gem_huc_copy@huc-copy.html
- fi-bxt-dsi: NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#2190])
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bxt-dsi/igt@gem_huc_copy@huc-copy.html
- fi-cfl-8700k: NOTRUN -> [SKIP][15] ([fdo#109271] / [i915#2190])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8700k/igt@gem_huc_copy@huc-copy.html
- fi-icl-u2: NOTRUN -> [SKIP][16] ([i915#2190])
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-icl-u2/igt@gem_huc_copy@huc-copy.html
* igt@gem_lmem_swapping@basic:
- fi-skl-guc: NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#4613]) +3 similar issues
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-skl-guc/igt@gem_lmem_swapping@basic.html
- fi-glk-j4005: NOTRUN -> [SKIP][18] ([fdo#109271] / [i915#4613]) +3 similar issues
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-glk-j4005/igt@gem_lmem_swapping@basic.html
- fi-snb-2520m: NOTRUN -> [SKIP][19] ([fdo#109271]) +24 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-snb-2520m/igt@gem_lmem_swapping@basic.html
- fi-kbl-7500u: NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +3 similar issues
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-7500u/igt@gem_lmem_swapping@basic.html
- fi-kbl-soraka: NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +3 similar issues
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
* igt@gem_lmem_swapping@parallel-random-engines:
- fi-cfl-8700k: NOTRUN -> [SKIP][22] ([fdo#109271] / [i915#4613]) +3 similar issues
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8700k/igt@gem_lmem_swapping@parallel-random-engines.html
* igt@gem_lmem_swapping@random-engines:
- fi-ivb-3770: NOTRUN -> [SKIP][23] ([fdo#109271]) +18 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-ivb-3770/igt@gem_lmem_swapping@random-engines.html
- fi-skl-6700k2: NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613]) +3 similar issues
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-skl-6700k2/igt@gem_lmem_swapping@random-engines.html
- fi-kbl-8809g: NOTRUN -> [SKIP][25] ([fdo#109271] / [i915#4613]) +3 similar issues
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-8809g/igt@gem_lmem_swapping@random-engines.html
- fi-cfl-8109u: NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +3 similar issues
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8109u/igt@gem_lmem_swapping@random-engines.html
* igt@gem_lmem_swapping@verify-random:
- fi-bxt-dsi: NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#4613]) +3 similar issues
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bxt-dsi/igt@gem_lmem_swapping@verify-random.html
- fi-rkl-guc: NOTRUN -> [SKIP][28] ([i915#4613]) +3 similar issues
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@gem_lmem_swapping@verify-random.html
- fi-adl-ddr5: NOTRUN -> [SKIP][29] ([i915#4613]) +3 similar issues
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@gem_lmem_swapping@verify-random.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][30] ([i915#4613]) +3 similar issues
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@gem_lmem_swapping@verify-random.html
* igt@gem_tiled_pread_basic:
- fi-adl-ddr5: NOTRUN -> [SKIP][31] ([i915#3282])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@gem_tiled_pread_basic.html
- fi-rkl-guc: NOTRUN -> [SKIP][32] ([i915#3282])
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@gem_tiled_pread_basic.html
* igt@i915_pm_backlight@basic-brightness:
- fi-hsw-4770: NOTRUN -> [SKIP][33] ([fdo#109271] / [i915#3012])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-4770/igt@i915_pm_backlight@basic-brightness.html
- fi-adl-ddr5: NOTRUN -> [SKIP][34] ([i915#1155])
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@i915_pm_backlight@basic-brightness.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][35] ([i915#1155])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@i915_pm_backlight@basic-brightness.html
- fi-hsw-g3258: NOTRUN -> [SKIP][36] ([fdo#109271] / [i915#3012])
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-g3258/igt@i915_pm_backlight@basic-brightness.html
- fi-rkl-guc: NOTRUN -> [SKIP][37] ([i915#3012])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@i915_pm_backlight@basic-brightness.html
* igt@i915_selftest@live@gt_pm:
- fi-kbl-soraka: NOTRUN -> [DMESG-FAIL][38] ([i915#1886])
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
* igt@i915_selftest@live@hangcheck:
- fi-bdw-5557u: NOTRUN -> [INCOMPLETE][39] ([i915#3921])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bdw-5557u/igt@i915_selftest@live@hangcheck.html
* igt@i915_selftest@live@requests:
- fi-pnv-d510: [PASS][40] -> [DMESG-FAIL][41] ([i915#4528])
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/fi-pnv-d510/igt@i915_selftest@live@requests.html
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-pnv-d510/igt@i915_selftest@live@requests.html
* igt@kms_busy@basic:
- fi-kbl-guc: NOTRUN -> [SKIP][42] ([fdo#109271] / [i915#1845])
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-guc/igt@kms_busy@basic.html
* igt@kms_chamelium@common-hpd-after-suspend:
- fi-bxt-dsi: NOTRUN -> [SKIP][43] ([fdo#109271] / [fdo#111827]) +8 similar issues
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bxt-dsi/igt@kms_chamelium@common-hpd-after-suspend.html
- fi-hsw-4770: NOTRUN -> [SKIP][44] ([fdo#109271] / [fdo#111827]) +8 similar issues
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-4770/igt@kms_chamelium@common-hpd-after-suspend.html
* igt@kms_chamelium@dp-crc-fast:
- fi-kbl-7500u: NOTRUN -> [SKIP][45] ([fdo#109271] / [fdo#111827]) +8 similar issues
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-7500u/igt@kms_chamelium@dp-crc-fast.html
- fi-skl-guc: NOTRUN -> [SKIP][46] ([fdo#109271] / [fdo#111827]) +8 similar issues
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-skl-guc/igt@kms_chamelium@dp-crc-fast.html
- fi-bdw-5557u: NOTRUN -> [SKIP][47] ([fdo#109271] / [fdo#111827]) +7 similar issues
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bdw-5557u/igt@kms_chamelium@dp-crc-fast.html
* igt@kms_chamelium@dp-edid-read:
- fi-kbl-soraka: NOTRUN -> [SKIP][48] ([fdo#109271] / [fdo#111827]) +7 similar issues
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-soraka/igt@kms_chamelium@dp-edid-read.html
- fi-rkl-guc: NOTRUN -> [SKIP][49] ([fdo#111827]) +8 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@kms_chamelium@dp-edid-read.html
* igt@kms_chamelium@dp-hpd-fast:
- fi-ivb-3770: NOTRUN -> [SKIP][50] ([fdo#109271] / [fdo#111827]) +8 similar issues
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-ivb-3770/igt@kms_chamelium@dp-hpd-fast.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][51] ([fdo#111827]) +7 similar issues
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@kms_chamelium@dp-hpd-fast.html
* igt@kms_chamelium@hdmi-crc-fast:
- fi-skl-6700k2: NOTRUN -> [SKIP][52] ([fdo#109271] / [fdo#111827]) +8 similar issues
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-skl-6700k2/igt@kms_chamelium@hdmi-crc-fast.html
- fi-bsw-n3050: NOTRUN -> [SKIP][53] ([fdo#109271] / [fdo#111827]) +8 similar issues
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bsw-n3050/igt@kms_chamelium@hdmi-crc-fast.html
- fi-adl-ddr5: NOTRUN -> [SKIP][54] ([fdo#111827]) +8 similar issues
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@kms_chamelium@hdmi-crc-fast.html
* igt@kms_chamelium@hdmi-edid-read:
- fi-kbl-8809g: NOTRUN -> [SKIP][55] ([fdo#109271] / [fdo#111827]) +8 similar issues
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-8809g/igt@kms_chamelium@hdmi-edid-read.html
- fi-bsw-kefka: NOTRUN -> [SKIP][56] ([fdo#109271] / [fdo#111827]) +8 similar issues
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bsw-kefka/igt@kms_chamelium@hdmi-edid-read.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-glk-j4005: NOTRUN -> [SKIP][57] ([fdo#109271] / [fdo#111827]) +8 similar issues
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-glk-j4005/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-snb-2520m: NOTRUN -> [SKIP][58] ([fdo#109271] / [fdo#111827]) +8 similar issues
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-snb-2520m/igt@kms_chamelium@hdmi-hpd-fast.html
- fi-cfl-8109u: NOTRUN -> [SKIP][59] ([fdo#109271] / [fdo#111827]) +8 similar issues
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8109u/igt@kms_chamelium@hdmi-hpd-fast.html
* igt@kms_chamelium@vga-edid-read:
- fi-cfl-8700k: NOTRUN -> [SKIP][60] ([fdo#109271] / [fdo#111827]) +8 similar issues
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8700k/igt@kms_chamelium@vga-edid-read.html
- fi-hsw-g3258: NOTRUN -> [SKIP][61] ([fdo#109271] / [fdo#111827]) +8 similar issues
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-g3258/igt@kms_chamelium@vga-edid-read.html
* igt@kms_chamelium@vga-hpd-fast:
- fi-kbl-guc: NOTRUN -> [SKIP][62] ([fdo#109271] / [fdo#111827]) +7 similar issues
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-guc/igt@kms_chamelium@vga-hpd-fast.html
* igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
- fi-skl-guc: NOTRUN -> [SKIP][63] ([fdo#109271]) +11 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-skl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-rkl-guc: NOTRUN -> [SKIP][64] ([i915#4070] / [i915#4103]) +1 similar issue
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-adl-ddr5: NOTRUN -> [SKIP][65] ([i915#4103]) +1 similar issue
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][66] ([i915#4103]) +1 similar issue
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
* igt@kms_force_connector_basic@force-load-detect:
- fi-bxt-dsi: NOTRUN -> [SKIP][67] ([fdo#109271]) +13 similar issues
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bxt-dsi/igt@kms_force_connector_basic@force-load-detect.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][68] ([fdo#109285])
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
- fi-rkl-guc: NOTRUN -> [SKIP][69] ([fdo#109285])
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@kms_force_connector_basic@force-load-detect.html
- fi-adl-ddr5: NOTRUN -> [SKIP][70] ([fdo#109285])
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@kms_force_connector_basic@force-load-detect.html
* igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d:
- fi-hsw-g3258: NOTRUN -> [SKIP][71] ([fdo#109271] / [i915#533])
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-g3258/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-hsw-4770: NOTRUN -> [SKIP][72] ([fdo#109271] / [i915#533])
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-7500u: NOTRUN -> [SKIP][73] ([fdo#109271] / [i915#533])
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-7500u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-cfl-8700k: NOTRUN -> [SKIP][74] ([fdo#109271] / [i915#533])
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8700k/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-bxt-dsi: NOTRUN -> [SKIP][75] ([fdo#109271] / [i915#533])
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bxt-dsi/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-soraka: NOTRUN -> [SKIP][76] ([fdo#109271] / [i915#533])
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-soraka/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-skl-6700k2: NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#533])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-skl-6700k2/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-rkl-guc: NOTRUN -> [SKIP][78] ([i915#4070] / [i915#533])
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-cfl-8109u: NOTRUN -> [SKIP][79] ([fdo#109271] / [i915#533])
[79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8109u/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-kbl-8809g: NOTRUN -> [SKIP][80] ([fdo#109271] / [i915#533])
[80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-8809g/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-glk-j4005: NOTRUN -> [SKIP][81] ([fdo#109271] / [i915#533])
[81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-glk-j4005/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
- fi-skl-guc: NOTRUN -> [SKIP][82] ([fdo#109271] / [i915#533])
[82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-skl-guc/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-pipe-d.html
* igt@kms_pipe_crc_basic@hang-read-crc-pipe-a:
- fi-bsw-n3050: NOTRUN -> [SKIP][83] ([fdo#109271]) +29 similar issues
[83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bsw-n3050/igt@kms_pipe_crc_basic@hang-read-crc-pipe-a.html
* igt@kms_psr@cursor_plane_move:
- fi-kbl-8809g: NOTRUN -> [SKIP][84] ([fdo#109271]) +37 similar issues
[84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-8809g/igt@kms_psr@cursor_plane_move.html
- fi-bsw-kefka: NOTRUN -> [SKIP][85] ([fdo#109271]) +19 similar issues
[85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bsw-kefka/igt@kms_psr@cursor_plane_move.html
- fi-glk-j4005: NOTRUN -> [SKIP][86] ([fdo#109271]) +11 similar issues
[86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-glk-j4005/igt@kms_psr@cursor_plane_move.html
* igt@kms_psr@primary_mmap_gtt:
- fi-hsw-g3258: NOTRUN -> [SKIP][87] ([fdo#109271] / [i915#1072]) +3 similar issues
[87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-g3258/igt@kms_psr@primary_mmap_gtt.html
- fi-cfl-8109u: NOTRUN -> [SKIP][88] ([fdo#109271]) +11 similar issues
[88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8109u/igt@kms_psr@primary_mmap_gtt.html
- fi-kbl-7500u: NOTRUN -> [SKIP][89] ([fdo#109271]) +11 similar issues
[89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-kbl-7500u/igt@kms_psr@primary_mmap_gtt.html
- fi-adl-ddr5: NOTRUN -> [SKIP][90] ([i915#1072]) +3 similar issues
[90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@kms_psr@primary_mmap_gtt.html
- fi-hsw-4770: NOTRUN -> [SKIP][91] ([fdo#109271] / [i915#1072]) +3 similar issues
[91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-4770/igt@kms_psr@primary_mmap_gtt.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][92] ([fdo#110189]) +3 similar issues
[92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@kms_psr@primary_mmap_gtt.html
* igt@kms_psr@sprite_plane_onoff:
- fi-rkl-guc: NOTRUN -> [SKIP][93] ([i915#1072]) +3 similar issues
[93]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@kms_psr@sprite_plane_onoff.html
* igt@kms_setmode@basic-clone-single-crtc:
- fi-skl-6700k2: NOTRUN -> [SKIP][94] ([fdo#109271]) +11 similar issues
[94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-skl-6700k2/igt@kms_setmode@basic-clone-single-crtc.html
- fi-hsw-g3258: NOTRUN -> [SKIP][95] ([fdo#109271]) +9 similar issues
[95]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-hsw-g3258/igt@kms_setmode@basic-clone-single-crtc.html
- fi-bdw-5557u: NOTRUN -> [SKIP][96] ([fdo#109271]) +14 similar issues
[96]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-bdw-5557u/igt@kms_setmode@basic-clone-single-crtc.html
- fi-rkl-guc: NOTRUN -> [SKIP][97] ([i915#3555] / [i915#4098])
[97]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@kms_setmode@basic-clone-single-crtc.html
- fi-adl-ddr5: NOTRUN -> [SKIP][98] ([i915#3555])
[98]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@kms_setmode@basic-clone-single-crtc.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][99] ([i915#3555])
[99]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html
* igt@prime_vgem@basic-userptr:
- fi-cfl-8700k: NOTRUN -> [SKIP][100] ([fdo#109271]) +11 similar issues
[100]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-cfl-8700k/igt@prime_vgem@basic-userptr.html
- fi-tgl-1115g4: NOTRUN -> [SKIP][101] ([i915#3301])
[101]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@prime_vgem@basic-userptr.html
- fi-rkl-guc: NOTRUN -> [SKIP][102] ([i915#3301] / [i915#3708])
[102]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@prime_vgem@basic-userptr.html
- fi-adl-ddr5: NOTRUN -> [SKIP][103] ([i915#3301])
[103]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@prime_vgem@basic-userptr.html
* igt@prime_vgem@basic-write:
- fi-adl-ddr5: NOTRUN -> [SKIP][104] ([i915#3291]) +2 similar issues
[104]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-adl-ddr5/igt@prime_vgem@basic-write.html
- fi-rkl-guc: NOTRUN -> [SKIP][105] ([i915#3291] / [i915#3708]) +2 similar issues
[105]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-rkl-guc/igt@prime_vgem@basic-write.html
* igt@runner@aborted:
- fi-pnv-d510: NOTRUN -> [FAIL][106] ([fdo#109271] / [i915#2403] / [i915#4312])
[106]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-pnv-d510/igt@runner@aborted.html
#### Warnings ####
* igt@runner@aborted:
- fi-icl-u2: [FAIL][107] ([i915#3690]) -> [FAIL][108] ([i915#3690] / [i915#4312])
[107]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/fi-icl-u2/igt@runner@aborted.html
[108]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-icl-u2/igt@runner@aborted.html
- fi-apl-guc: [FAIL][109] ([i915#5917]) -> [FAIL][110] ([i915#4312])
[109]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/fi-apl-guc/igt@runner@aborted.html
[110]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-apl-guc/igt@runner@aborted.html
- fi-tgl-1115g4: [FAIL][111] ([i915#3690]) -> [FAIL][112] ([i915#4312] / [i915#5257])
[111]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_11617/fi-tgl-1115g4/igt@runner@aborted.html
[112]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/fi-tgl-1115g4/igt@runner@aborted.html
{name}: This element is suppressed. This means it is ignored when computing
the status of the difference (SUCCESS, WARNING, or FAILURE).
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109278]: https://bugs.freedesktop.org/show_bug.cgi?id=109278
[fdo#109284]: https://bugs.freedesktop.org/show_bug.cgi?id=109284
[fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
[fdo#110189]: https://bugs.freedesktop.org/show_bug.cgi?id=110189
[fdo#111827]: https://bugs.freedesktop.org/show_bug.cgi?id=111827
[i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
[i915#1155]: https://gitlab.freedesktop.org/drm/intel/issues/1155
[i915#1759]: https://gitlab.freedesktop.org/drm/intel/issues/1759
[i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
[i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
[i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
[i915#2373]: https://gitlab.freedesktop.org/drm/intel/issues/2373
[i915#2403]: https://gitlab.freedesktop.org/drm/intel/issues/2403
[i915#3012]: https://gitlab.freedesktop.org/drm/intel/issues/3012
[i915#3282]: https://gitlab.freedesktop.org/drm/intel/issues/3282
[i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
[i915#3301]: https://gitlab.freedesktop.org/drm/intel/issues/3301
[i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
[i915#3690]: https://gitlab.freedesktop.org/drm/intel/issues/3690
[i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
[i915#3921]: https://gitlab.freedesktop.org/drm/intel/issues/3921
[i915#4070]: https://gitlab.freedesktop.org/drm/intel/issues/4070
[i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
[i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
[i915#4312]: https://gitlab.freedesktop.org/drm/intel/issues/4312
[i915#4528]: https://gitlab.freedesktop.org/drm/intel/issues/4528
[i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
[i915#5122]: https://gitlab.freedesktop.org/drm/intel/issues/5122
[i915#5257]: https://gitlab.freedesktop.org/drm/intel/issues/5257
[i915#533]: https://gitlab.freedesktop.org/drm/intel/issues/533
[i915#5595]: https://gitlab.freedesktop.org/drm/intel/issues/5595
[i915#5917]: https://gitlab.freedesktop.org/drm/intel/issues/5917
Build changes
-------------
* Linux: CI_DRM_11617 -> Patchwork_103680v1
CI-20190529: 20190529
CI_DRM_11617: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_6468: cffa5fffe9acddf49565b4caeeb5e3355ff2ea44 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
Patchwork_103680v1: d96cea3d7ffb524248fcc8db433c579cf262eaea @ git://anongit.freedesktop.org/gfx-ci/linux
### Linux commits
fa17a8f7c3c9 fbdev: efifb: Fix a use-after-free due early fb_info cleanup
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_103680v1/index.html
[-- Attachment #2: Type: text/html, Size: 39541 bytes --]
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
2022-05-06 13:22 ` Javier Martinez Canillas
@ 2022-05-06 15:44 ` Andi Shyti
-1 siblings, 0 replies; 18+ messages in thread
From: Andi Shyti @ 2022-05-06 15:44 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, linux-fbdev, Thomas Zimmermann, Daniel Vetter,
intel-gfx, dri-devel, Peter Jones, Andrzej Hajda, Helge Deller
Hi Javier,
On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote:
> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
> than .remove") attempted to fix a use-after-free error due driver freeing
> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
> But ironically that change introduced yet another use-after-free since the
> fb_info was still used after the free.
>
> This should fix for good by freeing the fb_info at the end of the handler.
>
> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-06 15:44 ` Andi Shyti
0 siblings, 0 replies; 18+ messages in thread
From: Andi Shyti @ 2022-05-06 15:44 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-fbdev, Andrzej Hajda, Daniel Vetter, intel-gfx,
linux-kernel, dri-devel, Peter Jones, Thomas Zimmermann,
Helge Deller
Hi Javier,
On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote:
> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
> than .remove") attempted to fix a use-after-free error due driver freeing
> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
> But ironically that change introduced yet another use-after-free since the
> fb_info was still used after the free.
>
> This should fix for good by freeing the fb_info at the end of the handler.
>
> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Andi
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
2022-05-06 13:22 ` Javier Martinez Canillas
(?)
@ 2022-05-06 16:50 ` Andrzej Hajda
-1 siblings, 0 replies; 18+ messages in thread
From: Andrzej Hajda @ 2022-05-06 16:50 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: Ville Syrjälä,
intel-gfx, Daniel Vetter, Helge Deller, Peter Jones,
Thomas Zimmermann, dri-devel, linux-fbdev
On 06.05.2022 15:22, Javier Martinez Canillas wrote:
> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
> than .remove") attempted to fix a use-after-free error due driver freeing
> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
> But ironically that change introduced yet another use-after-free since the
> fb_info was still used after the free.
>
> This should fix for good by freeing the fb_info at the end of the handler.
>
> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
>
> drivers/video/fbdev/efifb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index cfa3dc0b4eee..b3d5f884c544 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
> memunmap(info->screen_base);
> }
>
> - framebuffer_release(info);
> -
> if (request_mem_succeeded)
> release_mem_region(info->apertures->ranges[0].base,
> info->apertures->ranges[0].size);
> fb_dealloc_cmap(&info->cmap);
> +
> + framebuffer_release(info);
> }
>
> static const struct fb_ops efifb_ops = {
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-06 16:50 ` Andrzej Hajda
0 siblings, 0 replies; 18+ messages in thread
From: Andrzej Hajda @ 2022-05-06 16:50 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-fbdev, Daniel Vetter, intel-gfx, dri-devel, Peter Jones,
Thomas Zimmermann, Helge Deller
On 06.05.2022 15:22, Javier Martinez Canillas wrote:
> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
> than .remove") attempted to fix a use-after-free error due driver freeing
> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
> But ironically that change introduced yet another use-after-free since the
> fb_info was still used after the free.
>
> This should fix for good by freeing the fb_info at the end of the handler.
>
> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
>
> drivers/video/fbdev/efifb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index cfa3dc0b4eee..b3d5f884c544 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
> memunmap(info->screen_base);
> }
>
> - framebuffer_release(info);
> -
> if (request_mem_succeeded)
> release_mem_region(info->apertures->ranges[0].base,
> info->apertures->ranges[0].size);
> fb_dealloc_cmap(&info->cmap);
> +
> + framebuffer_release(info);
> }
>
> static const struct fb_ops efifb_ops = {
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-06 16:50 ` Andrzej Hajda
0 siblings, 0 replies; 18+ messages in thread
From: Andrzej Hajda @ 2022-05-06 16:50 UTC (permalink / raw)
To: Javier Martinez Canillas, linux-kernel
Cc: linux-fbdev, Daniel Vetter, intel-gfx, dri-devel, Peter Jones,
Thomas Zimmermann, Helge Deller
On 06.05.2022 15:22, Javier Martinez Canillas wrote:
> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
> than .remove") attempted to fix a use-after-free error due driver freeing
> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
> But ironically that change introduced yet another use-after-free since the
> fb_info was still used after the free.
>
> This should fix for good by freeing the fb_info at the end of the handler.
>
> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
> Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
> Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
> ---
Reviewed-by: Andrzej Hajda <andrzej.hajda@intel.com>
Regards
Andrzej
>
> drivers/video/fbdev/efifb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
> index cfa3dc0b4eee..b3d5f884c544 100644
> --- a/drivers/video/fbdev/efifb.c
> +++ b/drivers/video/fbdev/efifb.c
> @@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
> memunmap(info->screen_base);
> }
>
> - framebuffer_release(info);
> -
> if (request_mem_succeeded)
> release_mem_region(info->apertures->ranges[0].base,
> info->apertures->ranges[0].size);
> fb_dealloc_cmap(&info->cmap);
> +
> + framebuffer_release(info);
> }
>
> static const struct fb_ops efifb_ops = {
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
2022-05-06 13:22 ` Javier Martinez Canillas
(?)
@ 2022-05-07 16:20 ` Lucas De Marchi
-1 siblings, 0 replies; 18+ messages in thread
From: Lucas De Marchi @ 2022-05-07 16:20 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-kernel, linux-fbdev, Thomas Zimmermann, Daniel Vetter,
intel-gfx, dri-devel, Peter Jones, Andrzej Hajda, Helge Deller
On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote:
>Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
>than .remove") attempted to fix a use-after-free error due driver freeing
>the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
>But ironically that change introduced yet another use-after-free since the
>fb_info was still used after the free.
>
>This should fix for good by freeing the fb_info at the end of the handler.
>
>Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
are these patches going through any CI before being applied? Maybe would
be a good idea to cc intel-gfx mailing list on these fixes to have Intel
CI to pick them up for some tests?
pushed to drm-misc-fixes where the previous patch was applied.
thanks
LUcas De Marchi
>Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
>Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>---
>
> drivers/video/fbdev/efifb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
>index cfa3dc0b4eee..b3d5f884c544 100644
>--- a/drivers/video/fbdev/efifb.c
>+++ b/drivers/video/fbdev/efifb.c
>@@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
> memunmap(info->screen_base);
> }
>
>- framebuffer_release(info);
>-
> if (request_mem_succeeded)
> release_mem_region(info->apertures->ranges[0].base,
> info->apertures->ranges[0].size);
> fb_dealloc_cmap(&info->cmap);
>+
>+ framebuffer_release(info);
> }
>
> static const struct fb_ops efifb_ops = {
>--
>2.35.1
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-07 16:20 ` Lucas De Marchi
0 siblings, 0 replies; 18+ messages in thread
From: Lucas De Marchi @ 2022-05-07 16:20 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-fbdev, Andrzej Hajda, Daniel Vetter, intel-gfx,
linux-kernel, dri-devel, Peter Jones, Thomas Zimmermann,
Helge Deller
On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote:
>Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
>than .remove") attempted to fix a use-after-free error due driver freeing
>the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
>But ironically that change introduced yet another use-after-free since the
>fb_info was still used after the free.
>
>This should fix for good by freeing the fb_info at the end of the handler.
>
>Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
are these patches going through any CI before being applied? Maybe would
be a good idea to cc intel-gfx mailing list on these fixes to have Intel
CI to pick them up for some tests?
pushed to drm-misc-fixes where the previous patch was applied.
thanks
LUcas De Marchi
>Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
>Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>---
>
> drivers/video/fbdev/efifb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
>index cfa3dc0b4eee..b3d5f884c544 100644
>--- a/drivers/video/fbdev/efifb.c
>+++ b/drivers/video/fbdev/efifb.c
>@@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
> memunmap(info->screen_base);
> }
>
>- framebuffer_release(info);
>-
> if (request_mem_succeeded)
> release_mem_region(info->apertures->ranges[0].base,
> info->apertures->ranges[0].size);
> fb_dealloc_cmap(&info->cmap);
>+
>+ framebuffer_release(info);
> }
>
> static const struct fb_ops efifb_ops = {
>--
>2.35.1
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-07 16:20 ` Lucas De Marchi
0 siblings, 0 replies; 18+ messages in thread
From: Lucas De Marchi @ 2022-05-07 16:20 UTC (permalink / raw)
To: Javier Martinez Canillas
Cc: linux-fbdev, Andrzej Hajda, Daniel Vetter, intel-gfx,
linux-kernel, dri-devel, Peter Jones, Thomas Zimmermann,
Helge Deller
On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote:
>Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
>than .remove") attempted to fix a use-after-free error due driver freeing
>the fb_info in the .remove handler instead of doing it in .fb_destroy.
>
>But ironically that change introduced yet another use-after-free since the
>fb_info was still used after the free.
>
>This should fix for good by freeing the fb_info at the end of the handler.
>
>Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
are these patches going through any CI before being applied? Maybe would
be a good idea to cc intel-gfx mailing list on these fixes to have Intel
CI to pick them up for some tests?
pushed to drm-misc-fixes where the previous patch was applied.
thanks
LUcas De Marchi
>Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
>Reported-by: Andrzej Hajda <andrzej.hajda@intel.com>
>Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
>---
>
> drivers/video/fbdev/efifb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers/video/fbdev/efifb.c b/drivers/video/fbdev/efifb.c
>index cfa3dc0b4eee..b3d5f884c544 100644
>--- a/drivers/video/fbdev/efifb.c
>+++ b/drivers/video/fbdev/efifb.c
>@@ -259,12 +259,12 @@ static void efifb_destroy(struct fb_info *info)
> memunmap(info->screen_base);
> }
>
>- framebuffer_release(info);
>-
> if (request_mem_succeeded)
> release_mem_region(info->apertures->ranges[0].base,
> info->apertures->ranges[0].size);
> fb_dealloc_cmap(&info->cmap);
>+
>+ framebuffer_release(info);
> }
>
> static const struct fb_ops efifb_ops = {
>--
>2.35.1
>
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
2022-05-07 16:20 ` Lucas De Marchi
(?)
@ 2022-05-07 16:40 ` Javier Martinez Canillas
-1 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2022-05-07 16:40 UTC (permalink / raw)
To: Lucas De Marchi
Cc: linux-fbdev, Andrzej Hajda, Daniel Vetter, intel-gfx,
linux-kernel, dri-devel, Peter Jones, Thomas Zimmermann,
Helge Deller
Hello Lucas,
On 5/7/22 18:20, Lucas De Marchi wrote:
> On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote:
>> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
>> than .remove") attempted to fix a use-after-free error due driver freeing
>> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>>
>> But ironically that change introduced yet another use-after-free since the
>> fb_info was still used after the free.
>>
>> This should fix for good by freeing the fb_info at the end of the handler.
>>
>> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
>
> are these patches going through any CI before being applied? Maybe would
> be a good idea to cc intel-gfx mailing list on these fixes to have Intel
> CI to pick them up for some tests?
>
I Cc'ed intel-gfx for this particular patch. I should had done it for the
previous patches too, but I wasn't aware that Cc'ing that list would make
it run on your CI.
I tested locally the offending patch on an EFI platform before applying it
and I don't know why it didn't fail there. Sorry all for the inconvenience.
> pushed to drm-misc-fixes where the previous patch was applied.
>
Thanks.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-07 16:40 ` Javier Martinez Canillas
0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2022-05-07 16:40 UTC (permalink / raw)
To: Lucas De Marchi
Cc: linux-fbdev, Thomas Zimmermann, Daniel Vetter, intel-gfx,
linux-kernel, dri-devel, Peter Jones, Andrzej Hajda,
Helge Deller
Hello Lucas,
On 5/7/22 18:20, Lucas De Marchi wrote:
> On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote:
>> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
>> than .remove") attempted to fix a use-after-free error due driver freeing
>> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>>
>> But ironically that change introduced yet another use-after-free since the
>> fb_info was still used after the free.
>>
>> This should fix for good by freeing the fb_info at the end of the handler.
>>
>> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
>
> are these patches going through any CI before being applied? Maybe would
> be a good idea to cc intel-gfx mailing list on these fixes to have Intel
> CI to pick them up for some tests?
>
I Cc'ed intel-gfx for this particular patch. I should had done it for the
previous patches too, but I wasn't aware that Cc'ing that list would make
it run on your CI.
I tested locally the offending patch on an EFI platform before applying it
and I don't know why it didn't fail there. Sorry all for the inconvenience.
> pushed to drm-misc-fixes where the previous patch was applied.
>
Thanks.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [Intel-gfx] [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup
@ 2022-05-07 16:40 ` Javier Martinez Canillas
0 siblings, 0 replies; 18+ messages in thread
From: Javier Martinez Canillas @ 2022-05-07 16:40 UTC (permalink / raw)
To: Lucas De Marchi
Cc: linux-fbdev, Thomas Zimmermann, Daniel Vetter, intel-gfx,
linux-kernel, dri-devel, Peter Jones, Andrzej Hajda,
Helge Deller
Hello Lucas,
On 5/7/22 18:20, Lucas De Marchi wrote:
> On Fri, May 06, 2022 at 03:22:25PM +0200, Javier Martinez Canillas wrote:
>> Commit d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather
>> than .remove") attempted to fix a use-after-free error due driver freeing
>> the fb_info in the .remove handler instead of doing it in .fb_destroy.
>>
>> But ironically that change introduced yet another use-after-free since the
>> fb_info was still used after the free.
>>
>> This should fix for good by freeing the fb_info at the end of the handler.
>>
>> Fixes: d258d00fb9c7 ("fbdev: efifb: Cleanup fb_info in .fb_destroy rather than .remove")
>
> are these patches going through any CI before being applied? Maybe would
> be a good idea to cc intel-gfx mailing list on these fixes to have Intel
> CI to pick them up for some tests?
>
I Cc'ed intel-gfx for this particular patch. I should had done it for the
previous patches too, but I wasn't aware that Cc'ing that list would make
it run on your CI.
I tested locally the offending patch on an EFI platform before applying it
and I don't know why it didn't fail there. Sorry all for the inconvenience.
> pushed to drm-misc-fixes where the previous patch was applied.
>
Thanks.
--
Best regards,
Javier Martinez Canillas
Linux Engineering
Red Hat
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2022-05-07 16:40 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-06 13:22 [PATCH] fbdev: efifb: Fix a use-after-free due early fb_info cleanup Javier Martinez Canillas
2022-05-06 13:22 ` [Intel-gfx] " Javier Martinez Canillas
2022-05-06 13:22 ` Javier Martinez Canillas
2022-05-06 13:39 ` Thomas Zimmermann
2022-05-06 13:39 ` [Intel-gfx] " Thomas Zimmermann
2022-05-06 13:39 ` Thomas Zimmermann
2022-05-06 14:56 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
2022-05-06 15:44 ` [Intel-gfx] [PATCH] " Andi Shyti
2022-05-06 15:44 ` Andi Shyti
2022-05-06 16:50 ` Andrzej Hajda
2022-05-06 16:50 ` [Intel-gfx] " Andrzej Hajda
2022-05-06 16:50 ` Andrzej Hajda
2022-05-07 16:20 ` Lucas De Marchi
2022-05-07 16:20 ` [Intel-gfx] " Lucas De Marchi
2022-05-07 16:20 ` Lucas De Marchi
2022-05-07 16:40 ` Javier Martinez Canillas
2022-05-07 16:40 ` [Intel-gfx] " Javier Martinez Canillas
2022-05-07 16:40 ` Javier Martinez Canillas
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.