[PATCH] docs: Add small intro to idmap examples

[PATCH] docs: Add small intro to idmap examples

[Rodrigo Campos]

When reading the documentation, I didn't understand why this list
examples of things that fail without using the mount idmap feature.
It seems pretty pointless and I doubted if I was missing something,
until I finished the examples, the next section and saw the examples
revisited.  After that, it all made sense.

Let's add one small sentence before, so the reader knows where this is
going and why examples that don't might seem relevant are used.

Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
---
 Documentation/filesystems/idmappings.rst | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/filesystems/idmappings.rst b/Documentation/filesystems/idmappings.rst
index 7a879ec3b6bf..c1db8748389c 100644
--- a/Documentation/filesystems/idmappings.rst
+++ b/Documentation/filesystems/idmappings.rst
@@ -369,6 +369,11 @@ kernel maps the caller's userspace id down into a kernel id according to the
 caller's idmapping and then maps that kernel id up according to the
 filesystem's idmapping.
 
+Let's see some examples with caller/filesystem idmapping but without mount
+idmappings. This will exhibit some problems we can hit. After that we will
+revisit/reconsider these examples, this time using mount idmappings, to see how
+they can solve the problems we observed before.
+
 Example 1
 ~~~~~~~~~
 
-- 
2.35.1

Re: [PATCH] docs: Add small intro to idmap examples

[Christian Brauner]

On Fri, Apr 29, 2022 at 03:57:48PM +0200, Rodrigo Campos wrote:
> When reading the documentation, I didn't understand why this list
> examples of things that fail without using the mount idmap feature.
> It seems pretty pointless and I doubted if I was missing something,
> until I finished the examples, the next section and saw the examples
> revisited.  After that, it all made sense.
> 
> Let's add one small sentence before, so the reader knows where this is
> going and why examples that don't might seem relevant are used.
> 
> Signed-off-by: Rodrigo Campos <rodrigo@sdfg.com.ar>
> ---

Good idea. Thank you!
(Will pick up next week. Just back from LSFMM.)
Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>

Re: [PATCH] docs: Add small intro to idmap examples

[Rodrigo Campos]

On 5/7/22 14:04, Christian Brauner wrote:
> 
> Good idea. Thank you!

Thanks!

> (Will pick up next week. Just back from LSFMM.)
> Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>


Friendly ping? :)

Re: [PATCH] docs: Add small intro to idmap examples

[Christian Brauner]

On Fri, May 13, 2022 at 11:43:13AM +0200, Rodrigo Campos wrote:
> On 5/7/22 14:04, Christian Brauner wrote:
> > 
> > Good idea. Thank you!
> 
> Thanks!
> 
> > (Will pick up next week. Just back from LSFMM.)
> > Reviewed-by: Christian Brauner (Microsoft) <brauner@kernel.org>
> 
> 
> Friendly ping? :)

Oh, sorry. Already applied and in for-next. :)