From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: Hector Martin <marcan@marcan.st>, "Rafael J. Wysocki" <rafael@kernel.org>, Sven Peter <sven@svenpeter.dev>, Alyssa Rosenzweig <alyssa@rosenzweig.io>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Marc Zyngier <maz@kernel.org>, Mark Kettenis <mark.kettenis@xs4all.nl>, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] Apple SoC cpufreq driver Date: Sun, 8 May 2022 12:46:56 +0530 [thread overview] Message-ID: <20220508071656.GA42059@thinkpad> (raw) In-Reply-To: <20220504160019.GB3507@thinkpad> On Wed, May 04, 2022 at 09:30:26PM +0530, Manivannan Sadhasivam wrote: > Hi Viresh, > > On Wed, May 04, 2022 at 03:57:45PM +0530, Viresh Kumar wrote: > > On 04-05-22, 16:51, Hector Martin wrote: > > > Hi folks, > > > > > > Here's a second take on the cpufreq driver for Apple SoCs. This is a > > > complete rewrite using a stand-alone cpufreq driver instead of using the > > > cpufreq-dt infrastructure. > > > > > > Since v1 we ran some experiments on the memory controller performance > > > switching and it turns out it doesn't make a huge difference, so it > > > makes sense to punt that feature to the future (perhaps once a proper > > > memory controller driver exists for other reasons, e.g. for error > > > handling). > > > > > > One advantage of having a standalone cpufreq driver is that we can > > > support fast switching. This also means any future interaction with > > > the memory controller will probably use some bespoke mechanism instead > > > of the genpd infrastructure, so we can keep the fast path without > > > allowing sleeps/etc. > > > > > > The driver is based on scpi-cpufreq.c, with some bits (e.g. the > > > apple,freq-domain stuff) inspired by how cpufreq-qcom-hw does it. > > > I'm not sure if that particular property should be described > > > in a binding, since it goes in the cpu nodes (qcom doesn't have it > > > anywhere...). > > > > Hi Mani, > > > > I can see that Rob asked you to add this somewhere, maybe in arm/cpu > > stuff, but I don't think you ever sent a patch with that. What > > happened ? > > > > https://lore.kernel.org/lkml/20201013171800.GA3716411@bogus/ > > > > Oops. Looks like that one slipped through the cracks. I did add it to my todo > list for qcom-cpufreq but missed it completely. > > I will look into it. > So I did send a patch for adding the qcom specific property [1], but Rob asked for a common one and that's where it got lost. But in the last revision [2], you've asked for converting the qcom cpufreq driver to support the generic performance domains instead. For maintaining compatibility with the old dts files, we need to support the qcom specific property as well. I will send a series for that. Thanks, Mani [1] https://patchwork.kernel.org/project/linux-pm/patch/20201020153944.18047-1-manivannan.sadhasivam@linaro.org/#23718065 [2] https://patchwork.kernel.org/project/linux-pm/patch/20210701105730.322718-4-angelogioacchino.delregno@somainline.org/ > Thanks, > Mani > > > -- > > viresh -- மணிவண்ணன் சதாசிவம்
WARNING: multiple messages have this Message-ID (diff)
From: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> To: Viresh Kumar <viresh.kumar@linaro.org> Cc: Hector Martin <marcan@marcan.st>, "Rafael J. Wysocki" <rafael@kernel.org>, Sven Peter <sven@svenpeter.dev>, Alyssa Rosenzweig <alyssa@rosenzweig.io>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Stephen Boyd <sboyd@kernel.org>, Ulf Hansson <ulf.hansson@linaro.org>, Marc Zyngier <maz@kernel.org>, Mark Kettenis <mark.kettenis@xs4all.nl>, linux-arm-kernel@lists.infradead.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/4] Apple SoC cpufreq driver Date: Sun, 8 May 2022 12:46:56 +0530 [thread overview] Message-ID: <20220508071656.GA42059@thinkpad> (raw) In-Reply-To: <20220504160019.GB3507@thinkpad> On Wed, May 04, 2022 at 09:30:26PM +0530, Manivannan Sadhasivam wrote: > Hi Viresh, > > On Wed, May 04, 2022 at 03:57:45PM +0530, Viresh Kumar wrote: > > On 04-05-22, 16:51, Hector Martin wrote: > > > Hi folks, > > > > > > Here's a second take on the cpufreq driver for Apple SoCs. This is a > > > complete rewrite using a stand-alone cpufreq driver instead of using the > > > cpufreq-dt infrastructure. > > > > > > Since v1 we ran some experiments on the memory controller performance > > > switching and it turns out it doesn't make a huge difference, so it > > > makes sense to punt that feature to the future (perhaps once a proper > > > memory controller driver exists for other reasons, e.g. for error > > > handling). > > > > > > One advantage of having a standalone cpufreq driver is that we can > > > support fast switching. This also means any future interaction with > > > the memory controller will probably use some bespoke mechanism instead > > > of the genpd infrastructure, so we can keep the fast path without > > > allowing sleeps/etc. > > > > > > The driver is based on scpi-cpufreq.c, with some bits (e.g. the > > > apple,freq-domain stuff) inspired by how cpufreq-qcom-hw does it. > > > I'm not sure if that particular property should be described > > > in a binding, since it goes in the cpu nodes (qcom doesn't have it > > > anywhere...). > > > > Hi Mani, > > > > I can see that Rob asked you to add this somewhere, maybe in arm/cpu > > stuff, but I don't think you ever sent a patch with that. What > > happened ? > > > > https://lore.kernel.org/lkml/20201013171800.GA3716411@bogus/ > > > > Oops. Looks like that one slipped through the cracks. I did add it to my todo > list for qcom-cpufreq but missed it completely. > > I will look into it. > So I did send a patch for adding the qcom specific property [1], but Rob asked for a common one and that's where it got lost. But in the last revision [2], you've asked for converting the qcom cpufreq driver to support the generic performance domains instead. For maintaining compatibility with the old dts files, we need to support the qcom specific property as well. I will send a series for that. Thanks, Mani [1] https://patchwork.kernel.org/project/linux-pm/patch/20201020153944.18047-1-manivannan.sadhasivam@linaro.org/#23718065 [2] https://patchwork.kernel.org/project/linux-pm/patch/20210701105730.322718-4-angelogioacchino.delregno@somainline.org/ > Thanks, > Mani > > > -- > > viresh -- மணிவண்ணன் சதாசிவம் _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-05-08 7:17 UTC|newest] Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-05-04 7:51 [PATCH v2 0/4] Apple SoC cpufreq driver Hector Martin 2022-05-04 7:51 ` Hector Martin 2022-05-04 7:51 ` [PATCH v2 1/4] MAINTAINERS: Add entries for " Hector Martin 2022-05-04 7:51 ` Hector Martin 2022-05-04 10:17 ` Viresh Kumar 2022-05-04 10:17 ` Viresh Kumar 2022-05-04 14:52 ` Hector Martin 2022-05-04 14:52 ` Hector Martin 2022-05-05 8:42 ` Krzysztof Kozlowski 2022-05-05 8:42 ` Krzysztof Kozlowski 2022-05-05 8:44 ` Viresh Kumar 2022-05-05 8:44 ` Viresh Kumar 2022-05-04 7:51 ` [PATCH v2 2/4] dt-bindings: cpufreq: apple,soc-cpufreq: Add binding for Apple SoC cpufreq Hector Martin 2022-05-04 7:51 ` [PATCH v2 2/4] dt-bindings: cpufreq: apple, soc-cpufreq: " Hector Martin 2022-05-05 8:43 ` [PATCH v2 2/4] dt-bindings: cpufreq: apple,soc-cpufreq: " Krzysztof Kozlowski 2022-05-05 8:43 ` Krzysztof Kozlowski 2022-05-05 11:06 ` Hector Martin 2022-05-05 11:06 ` Hector Martin 2022-05-16 22:49 ` Rob Herring 2022-05-16 22:49 ` Rob Herring 2022-05-04 7:51 ` [PATCH v2 3/4] cpufreq: apple-soc: Add new driver to control Apple SoC CPU P-states Hector Martin 2022-05-04 7:51 ` Hector Martin 2022-05-04 7:51 ` [PATCH v2 4/4] arm64: dts: apple: Add CPU topology & cpufreq nodes for t8103 Hector Martin 2022-05-04 7:51 ` Hector Martin 2022-05-04 10:27 ` [PATCH v2 0/4] Apple SoC cpufreq driver Viresh Kumar 2022-05-04 10:27 ` Viresh Kumar 2022-05-04 16:00 ` Manivannan Sadhasivam 2022-05-04 16:00 ` Manivannan Sadhasivam 2022-05-08 7:16 ` Manivannan Sadhasivam [this message] 2022-05-08 7:16 ` Manivannan Sadhasivam
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20220508071656.GA42059@thinkpad \ --to=manivannan.sadhasivam@linaro.org \ --cc=alyssa@rosenzweig.io \ --cc=devicetree@vger.kernel.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-pm@vger.kernel.org \ --cc=marcan@marcan.st \ --cc=mark.kettenis@xs4all.nl \ --cc=maz@kernel.org \ --cc=rafael@kernel.org \ --cc=robh+dt@kernel.org \ --cc=sboyd@kernel.org \ --cc=sven@svenpeter.dev \ --cc=ulf.hansson@linaro.org \ --cc=viresh.kumar@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.