* [PATCH 0/2] pull request for net-next: batman-adv 2022-05-08
@ 2022-05-08 13:26 ` Simon Wunderlich
0 siblings, 0 replies; 9+ messages in thread
From: Simon Wunderlich @ 2022-05-08 13:26 UTC (permalink / raw)
To: kuba, davem; +Cc: netdev, b.a.t.m.a.n, Simon Wunderlich
Hi Jakub, hi David,
here is a very little cleanup pull request of batman-adv to go into net-next.
Please pull or let me know of any problem!
Thank you,
Simon
The following changes since commit 3123109284176b1532874591f7c81f3837bbdc17:
Linux 5.18-rc1 (2022-04-03 14:08:21 -0700)
are available in the Git repository at:
git://git.open-mesh.org/linux-merge.git tags/batadv-next-pullrequest-20220508
for you to fetch changes up to 8864d2fcf04385cabb8c8bb159f1f2ba5790cf71:
batman-adv: remove unnecessary type castings (2022-04-22 11:23:46 +0200)
----------------------------------------------------------------
This cleanup patchset includes the following patches:
- bump version strings, by Simon Wunderlich
- remove unnecessary type castings, by Yu Zhe
----------------------------------------------------------------
Simon Wunderlich (1):
batman-adv: Start new development cycle
Yu Zhe (1):
batman-adv: remove unnecessary type castings
net/batman-adv/bridge_loop_avoidance.c | 4 ++--
net/batman-adv/main.h | 2 +-
net/batman-adv/translation-table.c | 12 ++++++------
3 files changed, 9 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 0/2] pull request for net-next: batman-adv 2022-05-08
@ 2022-05-08 13:26 ` Simon Wunderlich
0 siblings, 0 replies; 9+ messages in thread
From: Simon Wunderlich @ 2022-05-08 13:26 UTC (permalink / raw)
To: kuba, davem; +Cc: netdev, b.a.t.m.a.n
Hi Jakub, hi David,
here is a very little cleanup pull request of batman-adv to go into net-next.
Please pull or let me know of any problem!
Thank you,
Simon
The following changes since commit 3123109284176b1532874591f7c81f3837bbdc17:
Linux 5.18-rc1 (2022-04-03 14:08:21 -0700)
are available in the Git repository at:
git://git.open-mesh.org/linux-merge.git tags/batadv-next-pullrequest-20220508
for you to fetch changes up to 8864d2fcf04385cabb8c8bb159f1f2ba5790cf71:
batman-adv: remove unnecessary type castings (2022-04-22 11:23:46 +0200)
----------------------------------------------------------------
This cleanup patchset includes the following patches:
- bump version strings, by Simon Wunderlich
- remove unnecessary type castings, by Yu Zhe
----------------------------------------------------------------
Simon Wunderlich (1):
batman-adv: Start new development cycle
Yu Zhe (1):
batman-adv: remove unnecessary type castings
net/batman-adv/bridge_loop_avoidance.c | 4 ++--
net/batman-adv/main.h | 2 +-
net/batman-adv/translation-table.c | 12 ++++++------
3 files changed, 9 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/2] batman-adv: Start new development cycle
2022-05-08 13:26 ` Simon Wunderlich
@ 2022-05-08 13:26 ` Simon Wunderlich
-1 siblings, 0 replies; 9+ messages in thread
From: Simon Wunderlich @ 2022-05-08 13:26 UTC (permalink / raw)
To: kuba, davem; +Cc: netdev, b.a.t.m.a.n, Simon Wunderlich
This version will contain all the (major or even only minor) changes for
Linux 5.19.
The version number isn't a semantic version number with major and minor
information. It is just encoding the year of the expected publishing as
Linux -rc1 and the number of published versions this year (starting at 0).
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
net/batman-adv/main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index f3be82999f1f..23f3d53f4b51 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -13,7 +13,7 @@
#define BATADV_DRIVER_DEVICE "batman-adv"
#ifndef BATADV_SOURCE_VERSION
-#define BATADV_SOURCE_VERSION "2022.1"
+#define BATADV_SOURCE_VERSION "2022.2"
#endif
/* B.A.T.M.A.N. parameters */
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 1/2] batman-adv: Start new development cycle
@ 2022-05-08 13:26 ` Simon Wunderlich
0 siblings, 0 replies; 9+ messages in thread
From: Simon Wunderlich @ 2022-05-08 13:26 UTC (permalink / raw)
To: kuba, davem; +Cc: netdev, b.a.t.m.a.n
This version will contain all the (major or even only minor) changes for
Linux 5.19.
The version number isn't a semantic version number with major and minor
information. It is just encoding the year of the expected publishing as
Linux -rc1 and the number of published versions this year (starting at 0).
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
net/batman-adv/main.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
index f3be82999f1f..23f3d53f4b51 100644
--- a/net/batman-adv/main.h
+++ b/net/batman-adv/main.h
@@ -13,7 +13,7 @@
#define BATADV_DRIVER_DEVICE "batman-adv"
#ifndef BATADV_SOURCE_VERSION
-#define BATADV_SOURCE_VERSION "2022.1"
+#define BATADV_SOURCE_VERSION "2022.2"
#endif
/* B.A.T.M.A.N. parameters */
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] batman-adv: remove unnecessary type castings
2022-05-08 13:26 ` Simon Wunderlich
(?)
(?)
@ 2022-05-08 13:26 ` Simon Wunderlich
-1 siblings, 0 replies; 9+ messages in thread
From: Simon Wunderlich @ 2022-05-08 13:26 UTC (permalink / raw)
To: kuba, davem; +Cc: netdev, b.a.t.m.a.n, Yu Zhe, Sven Eckelmann, Simon Wunderlich
From: Yu Zhe <yuzhe@nfschina.com>
remove unnecessary void* type castings.
Signed-off-by: Yu Zhe <yuzhe@nfschina.com>
[sven@narfation.org: Fix missing const in batadv_choose* functions]
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
---
net/batman-adv/bridge_loop_avoidance.c | 4 ++--
net/batman-adv/translation-table.c | 12 ++++++------
2 files changed, 8 insertions(+), 8 deletions(-)
diff --git a/net/batman-adv/bridge_loop_avoidance.c b/net/batman-adv/bridge_loop_avoidance.c
index 7f8a14d99cdb..37ce6cfb3520 100644
--- a/net/batman-adv/bridge_loop_avoidance.c
+++ b/net/batman-adv/bridge_loop_avoidance.c
@@ -65,7 +65,7 @@ batadv_bla_send_announce(struct batadv_priv *bat_priv,
*/
static inline u32 batadv_choose_claim(const void *data, u32 size)
{
- struct batadv_bla_claim *claim = (struct batadv_bla_claim *)data;
+ const struct batadv_bla_claim *claim = data;
u32 hash = 0;
hash = jhash(&claim->addr, sizeof(claim->addr), hash);
@@ -86,7 +86,7 @@ static inline u32 batadv_choose_backbone_gw(const void *data, u32 size)
const struct batadv_bla_backbone_gw *gw;
u32 hash = 0;
- gw = (struct batadv_bla_backbone_gw *)data;
+ gw = data;
hash = jhash(&gw->orig, sizeof(gw->orig), hash);
hash = jhash(&gw->vid, sizeof(gw->vid), hash);
diff --git a/net/batman-adv/translation-table.c b/net/batman-adv/translation-table.c
index 8478034d3abf..01d30c1e412c 100644
--- a/net/batman-adv/translation-table.c
+++ b/net/batman-adv/translation-table.c
@@ -103,10 +103,10 @@ static bool batadv_compare_tt(const struct hlist_node *node, const void *data2)
*/
static inline u32 batadv_choose_tt(const void *data, u32 size)
{
- struct batadv_tt_common_entry *tt;
+ const struct batadv_tt_common_entry *tt;
u32 hash = 0;
- tt = (struct batadv_tt_common_entry *)data;
+ tt = data;
hash = jhash(&tt->addr, ETH_ALEN, hash);
hash = jhash(&tt->vid, sizeof(tt->vid), hash);
@@ -2766,7 +2766,7 @@ static void batadv_tt_tvlv_generate(struct batadv_priv *bat_priv,
u32 i;
tt_tot = batadv_tt_entries(tt_len);
- tt_change = (struct batadv_tvlv_tt_change *)tvlv_buff;
+ tt_change = tvlv_buff;
if (!valid_cb)
return;
@@ -3994,7 +3994,7 @@ static void batadv_tt_tvlv_ogm_handler_v1(struct batadv_priv *bat_priv,
if (tvlv_value_len < sizeof(*tt_data))
return;
- tt_data = (struct batadv_tvlv_tt_data *)tvlv_value;
+ tt_data = tvlv_value;
tvlv_value_len -= sizeof(*tt_data);
num_vlan = ntohs(tt_data->num_vlan);
@@ -4037,7 +4037,7 @@ static int batadv_tt_tvlv_unicast_handler_v1(struct batadv_priv *bat_priv,
if (tvlv_value_len < sizeof(*tt_data))
return NET_RX_SUCCESS;
- tt_data = (struct batadv_tvlv_tt_data *)tvlv_value;
+ tt_data = tvlv_value;
tvlv_value_len -= sizeof(*tt_data);
tt_vlan_len = sizeof(struct batadv_tvlv_tt_vlan_data);
@@ -4129,7 +4129,7 @@ static int batadv_roam_tvlv_unicast_handler_v1(struct batadv_priv *bat_priv,
goto out;
batadv_inc_counter(bat_priv, BATADV_CNT_TT_ROAM_ADV_RX);
- roaming_adv = (struct batadv_tvlv_roam_adv *)tvlv_value;
+ roaming_adv = tvlv_value;
batadv_dbg(BATADV_DBG_TT, bat_priv,
"Received ROAMING_ADV from %pM (client %pM)\n",
--
2.30.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] batman-adv: Start new development cycle
2022-05-08 13:26 ` Simon Wunderlich
(?)
@ 2022-05-08 15:37 ` Leon Romanovsky
-1 siblings, 0 replies; 9+ messages in thread
From: Leon Romanovsky @ 2022-05-08 15:37 UTC (permalink / raw)
To: Simon Wunderlich, kuba, davem; +Cc: netdev, b.a.t.m.a.n
On Sun, May 08, 2022 at 03:26:15PM +0200, Simon Wunderlich wrote:
> This version will contain all the (major or even only minor) changes for
> Linux 5.19.
>
> The version number isn't a semantic version number with major and minor
> information. It is just encoding the year of the expected publishing as
> Linux -rc1 and the number of published versions this year (starting at 0).
>
> Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
> ---
> net/batman-adv/main.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/batman-adv/main.h b/net/batman-adv/main.h
> index f3be82999f1f..23f3d53f4b51 100644
> --- a/net/batman-adv/main.h
> +++ b/net/batman-adv/main.h
> @@ -13,7 +13,7 @@
> #define BATADV_DRIVER_DEVICE "batman-adv"
>
> #ifndef BATADV_SOURCE_VERSION
> -#define BATADV_SOURCE_VERSION "2022.1"
> +#define BATADV_SOURCE_VERSION "2022.2"
It is so not kernel-style. I recommend to drop this patch.
Thanks
> #endif
>
> /* B.A.T.M.A.N. parameters */
> --
> 2.30.2
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] pull request for net-next: batman-adv 2022-05-08
2022-05-08 13:26 ` Simon Wunderlich
` (2 preceding siblings ...)
(?)
@ 2022-05-08 16:09 ` David Miller
2022-05-08 16:10 ` David Miller
-1 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2022-05-08 16:09 UTC (permalink / raw)
To: sw; +Cc: kuba, netdev, b.a.t.m.a.n
Patch #2 is a cleanup and therefore not appropriate for 'net'.
Thank you.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/2] pull request for net-next: batman-adv 2022-05-08
2022-05-08 16:09 ` [PATCH 0/2] pull request for net-next: batman-adv 2022-05-08 David Miller
@ 2022-05-08 16:10 ` David Miller
0 siblings, 0 replies; 9+ messages in thread
From: David Miller @ 2022-05-08 16:10 UTC (permalink / raw)
To: sw; +Cc: kuba, netdev, b.a.t.m.a.n
From: David Miller <davem@davemloft.net>
Date: Sun, 08 May 2022 17:09:08 +0100 (BST)
>
> Patch #2 is a cleanup and therefore not appropriate for 'net'.
Sorry I'm mixing up the two pull requests you sent, all is fine.
Thanks.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] batman-adv: Start new development cycle
2022-05-08 13:26 ` Simon Wunderlich
(?)
(?)
@ 2022-05-08 16:20 ` patchwork-bot+netdevbpf
-1 siblings, 0 replies; 9+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-05-08 16:20 UTC (permalink / raw)
To: Simon Wunderlich; +Cc: kuba, davem, netdev, b.a.t.m.a.n
Hello:
This series was applied to netdev/net-next.git (master)
by Simon Wunderlich <sw@simonwunderlich.de>:
On Sun, 8 May 2022 15:26:15 +0200 you wrote:
> This version will contain all the (major or even only minor) changes for
> Linux 5.19.
>
> The version number isn't a semantic version number with major and minor
> information. It is just encoding the year of the expected publishing as
> Linux -rc1 and the number of published versions this year (starting at 0).
>
> [...]
Here is the summary with links:
- [1/2] batman-adv: Start new development cycle
https://git.kernel.org/netdev/net-next/c/cfa4e7b1bcf8
- [2/2] batman-adv: remove unnecessary type castings
https://git.kernel.org/netdev/net-next/c/8864d2fcf043
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2022-05-08 16:20 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-08 13:26 [PATCH 0/2] pull request for net-next: batman-adv 2022-05-08 Simon Wunderlich
2022-05-08 13:26 ` Simon Wunderlich
2022-05-08 13:26 ` [PATCH 1/2] batman-adv: Start new development cycle Simon Wunderlich
2022-05-08 13:26 ` Simon Wunderlich
2022-05-08 15:37 ` Leon Romanovsky
2022-05-08 16:20 ` patchwork-bot+netdevbpf
2022-05-08 13:26 ` [PATCH 2/2] batman-adv: remove unnecessary type castings Simon Wunderlich
2022-05-08 16:09 ` [PATCH 0/2] pull request for net-next: batman-adv 2022-05-08 David Miller
2022-05-08 16:10 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.