[PATCH] can: ctucanfd: Let users select instead of depend on CAN_CTUCANFD

[PATCH] can: ctucanfd: Let users select instead of depend on CAN_CTUCANFD

[Geert Uytterhoeven]

The CTU CAN-FD IP core is only useful when used with one of the
corresponding PCI/PCIe or platform (FPGA, SoC) drivers, which depend on
PCI resp. OF.

Hence make the users select the core driver code, instead of letting
then depend on it.  Keep the core code config option visible when
compile-testing, to maintain compile-coverage.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 drivers/net/can/ctucanfd/Kconfig | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/can/ctucanfd/Kconfig b/drivers/net/can/ctucanfd/Kconfig
index 48963efc7f19955f..3c383612eb1764e2 100644
--- a/drivers/net/can/ctucanfd/Kconfig
+++ b/drivers/net/can/ctucanfd/Kconfig
@@ -1,5 +1,5 @@
 config CAN_CTUCANFD
-	tristate "CTU CAN-FD IP core"
+	tristate "CTU CAN-FD IP core" if COMPILE_TEST
 	help
 	  This driver adds support for the CTU CAN FD open-source IP core.
 	  More documentation and core sources at project page
@@ -13,8 +13,8 @@ config CAN_CTUCANFD
 
 config CAN_CTUCANFD_PCI
 	tristate "CTU CAN-FD IP core PCI/PCIe driver"
-	depends on CAN_CTUCANFD
 	depends on PCI
+	select CAN_CTUCANFD
 	help
 	  This driver adds PCI/PCIe support for CTU CAN-FD IP core.
 	  The project providing FPGA design for Intel EP4CGX15 based DB4CGX15
@@ -23,8 +23,8 @@ config CAN_CTUCANFD_PCI
 
 config CAN_CTUCANFD_PLATFORM
 	tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver"
-	depends on CAN_CTUCANFD
 	depends on OF || COMPILE_TEST
+	select CAN_CTUCANFD
 	help
 	  The core has been tested together with OpenCores SJA1000
 	  modified to be CAN FD frames tolerant on MicroZed Zynq based
-- 
2.25.1

Re: [PATCH] can: ctucanfd: Let users select instead of depend on CAN_CTUCANFD

[Pavel Pisa]

Hello Geert,

On Monday 09 of May 2022 16:02:59 Geert Uytterhoeven wrote:
> The CTU CAN-FD IP core is only useful when used with one of the
> corresponding PCI/PCIe or platform (FPGA, SoC) drivers, which depend on
> PCI resp. OF.
>
> Hence make the users select the core driver code, instead of letting
> then depend on it.  Keep the core code config option visible when
> compile-testing, to maintain compile-coverage.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Acked-by: Pavel Pisa <pisa@cmp.felk.cvut.cz>

Thanks for suggestion, I have no strong opinion/experience there
but I agree that proposed behavior seems more friendly to users. 

>  drivers/net/can/ctucanfd/Kconfig | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/can/ctucanfd/Kconfig
> b/drivers/net/can/ctucanfd/Kconfig index 48963efc7f19955f..3c383612eb1764e2
> 100644
> --- a/drivers/net/can/ctucanfd/Kconfig
> +++ b/drivers/net/can/ctucanfd/Kconfig
> @@ -1,5 +1,5 @@
>  config CAN_CTUCANFD
> -	tristate "CTU CAN-FD IP core"
> +	tristate "CTU CAN-FD IP core" if COMPILE_TEST
>  	help
>  	  This driver adds support for the CTU CAN FD open-source IP core.
>  	  More documentation and core sources at project page
> @@ -13,8 +13,8 @@ config CAN_CTUCANFD
>
>  config CAN_CTUCANFD_PCI
>  	tristate "CTU CAN-FD IP core PCI/PCIe driver"
> -	depends on CAN_CTUCANFD
>  	depends on PCI
> +	select CAN_CTUCANFD
>  	help
>  	  This driver adds PCI/PCIe support for CTU CAN-FD IP core.
>  	  The project providing FPGA design for Intel EP4CGX15 based DB4CGX15
> @@ -23,8 +23,8 @@ config CAN_CTUCANFD_PCI
>
>  config CAN_CTUCANFD_PLATFORM
>  	tristate "CTU CAN-FD IP core platform (FPGA, SoC) driver"
> -	depends on CAN_CTUCANFD
>  	depends on OF || COMPILE_TEST
> +	select CAN_CTUCANFD
>  	help
>  	  The core has been tested together with OpenCores SJA1000
>  	  modified to be CAN FD frames tolerant on MicroZed Zynq based

Re: [PATCH] can: ctucanfd: Let users select instead of depend on CAN_CTUCANFD

[Marc Kleine-Budde]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

On 09.05.2022 16:02:59, Geert Uytterhoeven wrote:
> The CTU CAN-FD IP core is only useful when used with one of the
> corresponding PCI/PCIe or platform (FPGA, SoC) drivers, which depend on
> PCI resp. OF.
> 
> Hence make the users select the core driver code, instead of letting
> then depend on it.  Keep the core code config option visible when
> compile-testing, to maintain compile-coverage.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Makes sense! Applied to linux-can-next/testing.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde           |
Embedded Linux                   | https://www.pengutronix.de  |
Vertretung West/Dortmund         | Phone: +49-231-2826-924     |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-5555 |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]